- wine-gitlab - winehq.org

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 04 Nov '24

04 Nov '24

On Sat Nov 2 19:49:00 2024 +0000, Alanas wrote: > > With this change, unhandled notifications are all forwarded to > hwndNotify and I worry that it might not be the case. > Yes, windows does have more handled notifications. > There are notifications that don't get forwarded. > There are notifications that `nmhdr->code` overwritten and get forwarded. > Not all notifications have `nmhdr->code` that is equal to a macro in > mingw-w64's > [commctrl.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82… > and [prsht.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82693…. > See https://bugs.winehq.org/attachment.cgi?id=77351&action=edit and https://bugs.winehq.org/attachment.cgi?id=77352&action=edit. I think we can probably return 0 for the range used by common controls and then forward the rest to hwndNotify. The range doesn't have to be exact. For example, the smallest notification code is LVN_FIRST (0U-100U) and the largest is TRBN_LAST (0u-1519u). So we can probably return 0 for LVN_FIRST ~ TRBN_LAST. The more exact range can be found using a loop. In your winehq test, 0xffff0000u seems like a special value. So maybe exclude 0xffff0000u~0xffffffffu also works? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86499

1 0

[PATCH 0/1] MR6765: winegcc: Skip --no-default-config in find_libgcc.
by Jacek Caban (＠jacek) 04 Nov '24

04 Nov '24

The default config provides a valid way of defining the default compiler’s libgcc (or its equivalent). Future llvm-mingw will use it instead of shell wrappers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6765

2 1

[PATCH 0/1] MR6764: kernelbase: Add undocumented EXTENDED_FLAGS to process attribute list.
by eric pouech (＠epo) 04 Nov '24

04 Nov '24

Let the sub-process be created, without implementing any additional behavior from these flags. Native cmd.exe uses this flag when spawning itself again for handling builtin commands inside a pipe. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6764

2 1

[PATCH 0/3] MR6763: dplayx fixes
by Alistair Leslie-Hughes (＠alesliehughes) 04 Nov '24

04 Nov '24

This patchset does includes a patch from another patchset, which I'll rebase once this one is accepted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6763

3 4

[PATCH 0/4] MR6733: Mfplat HTTP byte stream implementation
by Torge Matthies (＠tmatthies) 03 Nov '24

03 Nov '24

This has been tested with VRChat in Proton, and with one change to `IMFMediaEngine` and some small changes to winegstreamer it is able to play YouTube videos in Unity video player based players. The AVPro based players have many more issues, because that API uses YouTube's HLS files instead of the direct MP4 links, and new media source would need many fixes to be able to play HLS correctly. Which it isn't supposed to do anyway since that's the `IMFMediaEngine`'s job. There are some things that I did not implement: - `IMFByteStreamBuffering::SetBufferingParams`, the parameters don't have any obvious effect on the functionality of the byte stream or the HTTP requests it makes. It's probably not used by anything anyway. - How much data has to be pre-buffered before it considers buffering to be complete and sends `MEBufferingStopped`. I didn't put much time into this and just chose 64 KiB. - Persistent caching of downloaded data; Native seems to be able to omit redownloading data it has previously downloaded before by using the `If-Modified-Since` header. This seems like more work and unnecessary complexity than it's worth. - Mapping of all the WinHTTP errors to HRESULTs; HTTP status codes are handled, as well as the most common `ERROR_WINHTTP_*` values, but anything else just goes through `HRESULT_FROM_WIN32`. I don't even know how to trigger most of the WinHTTP errors; It's probably fine, the most important info is just that there has been an error anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6733

4 39

Re: [PATCH v3 0/2] MR6584: wintab32: Improve wow64 support
by John Chadwick (＠jchw) 02 Nov '24

02 Nov '24

FWIW, as far as I'm concerned, this or a similar patch should probably still be merged, to fix the wow64 stub. It basically just comes down to the approach to fix it. If anyone gets a chance to look at this let me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6584#note_86467

1 0

[PATCH v4 0/1] MR6285: shell32: Allow FindExecutables to find unix files.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Nov '24

02 Nov '24

This fixes one of the regression with ShellExecute when using a full patch and an executable without an extension. -- v4: shell32: Allow FindExecutables to find unix files. https://gitlab.winehq.org/wine/wine/-/merge_requests/6285

2 1

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 02 Nov '24

02 Nov '24

On Sat Nov 2 08:52:23 2024 +0000, Zhiyi Zhang wrote: > This `else` branch should never get executed because only the > test_WM_NOTIFY() test sends a WM_NOTIFY with TEST_WM_NOTIFY_CODE. So you > can delete this branch. `else` branch will be executed if WM_NOTIFY message gets forwarded twice by buggy non-test code -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86464

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 02 Nov '24

02 Nov '24

> With this change, unhandled notifications are all forwarded to hwndNotify and I worry that it might not be the case. Yes, windows does have more handled notifications. There are notifications that don't get forwarded. There are notifications that `nmhdr->code` overwritten and get forwarded. Not all notifications have `nmhdr->code` that is equal to a macro in mingw-w64's [commctrl.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82… and [prsht.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82693…. See https://bugs.winehq.org/attachment.cgi?id=77351&action=edit and https://bugs.winehq.org/attachment.cgi?id=77352&action=edit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86463

1 0

[PATCH 0/2] MR6759: kernelbase: Make trailing slashes in CreateFileW set ERROR_PATH_NOT_FOUND
by Fabian Maurer (＠DarkShadow44) 02 Nov '24

02 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57376 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6759

4 4

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/toolbar.c: > return 0; > > default: With this change, unhandled notifications are all forwarded to hwndNotify and I worry that it might not be the case. Please add tests for [pager notification codes](https://learn.microsoft.com/en-us/windows/win32/controls/bumper-page… and [tooltips notification codes](https://learn.microsoft.com/en-us/windows/win32/controls/bumper-tool…. Also add a TRACE() when forwarding notifications to hwndNotify. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86461

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > } > } > > return TRUE; Please add a dot at the end of the commit subject. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86460

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > return 0; > } > + case TEST_WM_NOTIFY_CODE: > + if (expecting_test_WM_NOTIFY) > + { > + ok(hdr == &test_WM_NOTIFY_nmhdr, "Got unexpected header.\n"); > + ok(wParam == TEST_WM_NOTIFY_IDFROM, "Got unexpected wParam 0x%Ix.\n", wParam); > + } > + else This `else` branch should never get executed because only the test_WM_NOTIFY() test sends a WM_NOTIFY with TEST_WM_NOTIFY_CODE. So you can delete this branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86459

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 02 Nov '24

02 Nov '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define TEST_WM_NOTIFY_IDFROM 0xabcd0002 > +#define TEST_WM_NOTIFY_CODE 0xabcd0003 > +#define TEST_WM_NOTIFY_RETURN 0xabcd0004 > +static BOOL expecting_test_WM_NOTIFY; > +static const NMHDR test_WM_NOTIFY_nmhdr = > +{ > + /* .hwndFrom should not be accessed */ > + .hwndFrom = (HWND)0xabcd0001, Let's add a TEST_WM_NOTIFY_HWND as well for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86458

1 0

[PATCH 0/4] MR6663: Draft: Placed-allocation-callback solution for wow64 GL memory mappings
by Derek Lesho (＠dlesho) 02 Nov '24

02 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6663

6 9

[PATCH 0/4] MR6751: dplayx: Misc fixes and CREATEPLAYER handling.
by Anton Baskanov (＠baskanov) 01 Nov '24

01 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6751

4 6

[PATCH 0/6] MR6758: d3dx9: PNG/JPG file handling changes.
by Connor McAdams (＠cmcadams) 01 Nov '24

01 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6758

3 7

[PATCH v10 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) 01 Nov '24

01 Nov '24

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v10: server: Implement more FSCTLs on \Device\NamedPipe and \Device\NamedPipe\. server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

2 3

[PATCH 0/1] MR6757: include: Annotate PFN_CMSG_ALLOC with __WINE_ALLOC_SIZE.
by Alex Henrie (＠alexhenrie) 01 Nov '24

01 Nov '24

To match [PFN_CRYPT_ALLOC](https://gitlab.winehq.org/alexhenrie/wine/-/blob/3a736901c… and get better warnings when compiling with `-fanalyzer`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6757

2 1

Re: [PATCH v3 0/2] MR6581: win32u: Implement drawing transformed arcs.
by Haoyang Chen (＠chenhaoyang) 01 Nov '24

01 Nov '24

Hi, if ellipse_width/ellipse_height is less than 2, it will assert at solid_pen_lines( dlls/win32u/dibdrv/objects.c +812). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6581#note_86430

1 0

[PATCH 0/1] MR6755: Draft: wined3d: Metal renderer
by Isaac Marovitz (＠IsaacMarovitz) 31 Oct '24

31 Oct '24

Mostly just boilerplate while I figure out how to best approach the Objective-C <-> C mess this will require. It likely won't go anywhere but I figured I would share. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6755

3 2

Re: [PATCH v3 0/4] MR6746: d3dx9: Introduce d3dx_pixel_format_id enumeration. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6746

1 0

Re: [PATCH v2 0/2] MR6749: Stubs for the FTDI USB D2XX drivers. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6749

1 0

Re: [PATCH v2 0/7] MR6753: dataexchange: Make core_dragdrop_manager_add_TargetRequested() return S_OK. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6753

1 0

Re: [PATCH v4 0/4] MR6722: win32u: Yet more arc fixes. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6722

1 0

2025

2024

2023

2022

wine-gitlab