- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR6749: Stubs for the FTDI USB D2XX drivers. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6749

1 0

Re: [PATCH v2 0/7] MR6753: dataexchange: Make core_dragdrop_manager_add_TargetRequested() return S_OK. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6753

1 0

Re: [PATCH v4 0/4] MR6722: win32u: Yet more arc fixes. - approved
by Alexandre Julliard (＠julliard) 31 Oct '24

31 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6722

1 0

Re: [PATCH v31 0/5] MR6621: winebth.sys part 1: Introduce Bluetooth driver. - approved
by Elizabeth Figura (＠zfigura) 31 Oct '24

31 Oct '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6621

1 0

[PATCH v2 0/4] MR6746: d3dx9: Introduce d3dx_pixel_format_id enumeration.
by Connor McAdams (＠cmcadams) 31 Oct '24

31 Oct '24

This MR contains a set of patches that move away from using `D3DFORMAT` inside of `struct d3dx_image`. This will allow us to support formats that do not have a direct mapping to `D3DFORMAT`, and eventually once we share code with d3dx10/d3dx11 formats that do not have a direct mapping to `DXGI_FORMAT`. I've pushed a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/UPSTREAM/d3dx9-new-fmt… containing patches that actually use this new internal format system in practice. I would've included those in this MR, but that seemed like it'd make for a rather large MR. Hopefully splitting it this way makes it easier to review. :) -- v2: d3dx9: Use the d3dx_pixel_format_id enumeration inside of the WIC pixel format lookup structure. d3dx9: Use the d3dx_pixel_format_id enumeration inside of the DDS pixel format lookup structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/6746

3 6

[PATCH 0/4] MR6746: d3dx9: Introduce d3dx_pixel_format_id enumeration.
by Connor McAdams (＠cmcadams) 31 Oct '24

31 Oct '24

This MR contains a set of patches that move away from using `D3DFORMAT` inside of `struct d3dx_image`. This will allow us to support formats that do not have a direct mapping to `D3DFORMAT`, and eventually once we share code with d3dx10/d3dx11 formats that do not have a direct mapping to `DXGI_FORMAT`. I've pushed a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/UPSTREAM/d3dx9-new-fmt… containing patches that actually use this new internal format system in practice. I would've included those in this MR, but that seemed like it'd make for a rather large MR. Hopefully splitting it this way makes it easier to review. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6746

3 9

[PATCH v6 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 31 Oct '24

31 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v6: comctl32/toolbar: forward unhandled WM_NOTIFY comctl32/tests: Test WM_NOTIFY forwarding for toolbars. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

2 7

[PATCH v3 0/2] MR6734: wbemprox: Add property "ExecutablePath" to Win32_Process
by Fabian Maurer (＠DarkShadow44) 31 Oct '24

31 Oct '24

I added a new test method, please tell me if I should merge that into an existing one, but as far as I understood, there is no tests for the querying yet. -- v3: wbemprox: Add property "ExecutablePath" to Win32_Process wbemprox/tests: Add test for Win32_Process querying "ExecutablePath" propery https://gitlab.winehq.org/wine/wine/-/merge_requests/6734

4 10

[PATCH 0/7] MR6752: include: More fixes to build libc++.
by Rémi Bernon (＠rbernon) 31 Oct '24

31 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6752

3 10

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

On Thu Oct 31 10:21:42 2024 +0000, Alanas wrote: > do `ok`s in > ```c > case forward_test_code: > if (forward_test) > { > ok(hdr == &forward_test_nmhdr, "Got unexpected header.\n"); > ok(wParam == forward_test_idFrom, "Got unexpected wParam > 0x%Ix.\n", wParam); > } > else > { > ok(FALSE, "Got unexpected WM_NOTIFY.\n"); > } > forward_test = FALSE; > return forward_test_return; > ``` > need to be replaced with `todo_wine ok`? > they get passed 1 in first argument in windows and never run in wine > without editing `dlls/comctl32/toolbar.c` If these ok() in parent_wnd_notify() don't have failures before your fix, then you don't need to add todo_wines in parent_wnd_notify(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86364

1 0

[PATCH v3 0/4] MR6722: win32u: Yet more arc fixes.
by Elizabeth Figura (＠zfigura) 31 Oct '24

31 Oct '24

-- v3: win32u: Forward to Rectangle() if the ellipse width or height is zero. https://gitlab.winehq.org/wine/wine/-/merge_requests/6722

3 6

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 31 Oct '24

31 Oct '24

On Thu Oct 31 09:39:11 2024 +0000, Zhiyi Zhang wrote: > Put the todo_wine before each ok() statement in test_WM_NOTIFY() instead. do `ok`s in ```c case forward_test_code: if (forward_test) { ok(hdr == &forward_test_nmhdr, "Got unexpected header.\n"); ok(wParam == forward_test_idFrom, "Got unexpected wParam 0x%Ix.\n", wParam); } else { ok(FALSE, "Got unexpected WM_NOTIFY.\n"); } forward_test = FALSE; return forward_test_return; ``` need to be replaced with `todo_wine ok`? they get passed 1 in first argument in windows and never run in wine without editing `dlls/comctl32/toolbar.c` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86362

1 0

[PATCH v2 0/5] MR6743: win32u: Use MDT_RAW_DPI in the drivers 1/2.
by Rémi Bernon (＠rbernon) 31 Oct '24

31 Oct '24

This starts using MDT_RAW_DPI in the drivers, and provides the necessary raw/virt monitor information to wineserver. For now, this should not change much, as MDT_RAW_DPI is still the same as MDT_DEFAULT_DPI, but later it will return the DPI of the physical mode while MDT_DEFAULT_DPI will return a DPI for the possibly virtualized current display mode. -- v2: server: Use the monitor infos to compute the virtual screen rect. win32u: Inform wineserver about the winstation monitors. win32u: Move some monitor info getter code around. win32u: Use MDT_RAW_DPI monitor DPI type in the drivers. win32u: Implement get_win_monitor_dpi. https://gitlab.winehq.org/wine/wine/-/merge_requests/6743

3 7

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > test_drawtext_flags(); > test_imagelist(); > test_BTNS_SEP(); > + todo_wine test_WM_NOTIFY(); Put the todo_wine before each ok() statement in test_WM_NOTIFY() instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86359

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > DestroyWindow(hwnd); > } > > +static void test_WM_NOTIFY(void) > +{ > + HWND toolbar = NULL; > + LRESULT ret; Let's put a new line after variable declarations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86358

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; > +static const NMHDR forward_test_nmhdr = { Rename forward_test_nmhdr to test_WM_NOTIFY_forwarding_nmhdr. And put the `{` on a newline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86357

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; We usually use the win32 BOOL instead of _Bool. And let's rename the variable to test_WM_NOTIFY_forwarding. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86356

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 Let's use capitals for these definitions. For example, WM_NOTIFY_FORWARD_ID, WM_NOTIFY_FORWARD_HWND, WM_NOTIFY_FORWARD_CODE, and WM_NOTIFY_FORWARD_RETURN. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86355

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > Let's rename the patch subject to "comctl32/tests: Test WM_NOTIFY forwarding for toolbars." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86354

1 0

[PATCH 0/7] MR6753: dataexchange: Make core_dragdrop_manager_add_TargetRequested() return S_OK.
by Zhiyi Zhang (＠zhiyi) 31 Oct '24

31 Oct '24

React Native applications checks the return value from core_dragdrop_manager_add_TargetRequested(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6753

2 7

[PATCH 0/2] MR6750: user32/edit: multiple edits control also can set passwords.
by Haoyang Chen (＠chenhaoyang) 31 Oct '24

31 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6750

2 2

Re: [PATCH v2 0/1] MR6748: include: Move ISAXXMLFilter interface to after base ISAXXMLReader - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6748

1 0

Re: [PATCH v2 0/3] MR6747: include: Add windows.applicationmodel.datatransfer.dragdrop.idl. - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6747

1 0

Re: [PATCH v35 0/2] MR4661: gdiplus: Implement Gdiplus GetParameterSize - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

1 0

Re: [PATCH v2 0/7] MR6745: include: More fixes to build libc++. - approved
by Alexandre Julliard (＠julliard) 30 Oct '24

30 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6745

1 0

2025

2024

2023

2022

wine-gitlab