- wine-gitlab - winehq.org

[PATCH v6 0/45] MR6569: Draft: winex11: Refactor window state/config tracker to fix race conditions.
by Rémi Bernon (＠rbernon) 22 Oct '24

22 Oct '24

This completely refactors the winex11 window state tracking, keeping track of the desired/pending/current window state and config in a fully asynchronous way, and avoiding duplicate requests. I believe this mitigates various race conditions that we're suffering from, solving most spurious event feedback loops when the X11 state is being applied while some win32 state change is being requested, and fixing the spurious d3d/ddraw/user32 test failures. -- v6: d3d9/tests: Remove now unnecesary d3d9ex todo_wine / flaky. winex11: Try updating client window config on (_NET_)_WM_STATE updates. winex11: Try updating client window state on ConfigureNotify. winex11: Request only one _NET_WM_STATE bit change at a time. winex11: Remove now unnecessary (net_)wm_state window members. winex11: Get rid of the now unnecessary unmap_window helper. winex11: Request window state updates asynchronously. winex11: Try updating the client window state in net_wm_state_notify. winex11: Request window config updates asynchronously. winex11: Introduce a new window_update_client_config helper. winex11: Simplify the control flow in ConfigureNotify handlers. winex11: Introduce a new window_update_client_state helper. winex11: Simplify the control flow in WM_STATE handlers. winex11: Avoid updating _NET_WM_STATE on iconic windows. winex11: Tweak the WM_TAKE_FOCUS event time to workaround a FVWM bug. winex11: Ignore focus changes during WM_STATE updates. winex11: Get rid of the now unnecessary mapped window data flag. winex11: Use desired_state wm_state to decide of the mapped flag. winex11: Call window_set_wm_state when unmapping embedded windows. winex11: Get rid of the unnecessary net_wm_state window data member. winex11: Get rid of the now unnecessary iconic window data flag. winex11: Use pending_state wm_state to decide whether a window is currently iconic. winex11: Use pending_state to decide whether to set fullscreen monitor property. winex11: Use pending_state wm_state to decide if requests can be made directly. winex11: Compute WM_STATE notify updates in term of style changes. winex11: Compute ConfigureNotify updates in term of style changes. winex11: Compute WindowPosChanged updates in term of style changes. winex11: Avoid requesting unnecessary window config changes. winex11: Avoid requesting unnecessary _NET_WM_STATE changes. winex11: Track window config requests and updates. winex11: Introduce a new window_set_config helper. winex11: Track _NET_WM_STATE window property requests and updates. winex11: Introduce a new window_set_net_wm_state helper. winex11: Introduce a new window_set_wm_state helper. winex11: Track _XEMBED_INFO window property changes. winex11: Introduce a new window state tracker. winex11: Move embedded check in update_net_wm_states / sync_window_style. winex11: Move ConfigureNotify checks after computing visible rect. winex11: Rename read_net_wm_state to get_window_net_wm_state. winex11: Set configure_serial when resizing on display mode change. winex11: Avoid processing RRNotify events in xrandr14_get_id. d3d9/tests: Use static class for the dummy window. d3d9/tests: Avoid creating visible windows concurrently. wined3d: Check that format_id is >= 0 before assuming it's an index. DEBUG: gitlab: Only build the last commit. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6569

1 1

[PATCH 0/1] MR6714: winecrt0: Use version 2 of CHPE metadata.
by Jacek Caban (＠jacek) 22 Oct '24

22 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6714

3 2

[PATCH v5 0/44] MR6569: Draft: winex11: Keep a list of pending window config requests.
by Rémi Bernon (＠rbernon) 22 Oct '24

22 Oct '24

Instead of a single configure serial, which is simply not enough to mitigate event feedback loops. This should (hopefully) address the recent d3d8:device / d3d9:device test failures on the Gitlab CI, without having to add more `flush_events` calls to the tests. I believe it should also provide a more general fix to this race condition than the configure_serial mechanism. -- v5: d3d9/tests: Remove now unnecesary d3d9ex todo_wine / flaky. winex11: Try updating client window config on (_NET_)_WM_STATE updates. winex11: Try updating client window state on ConfigureNotify. winex11: Request only one _NET_WM_STATE bit change at a time. winex11: Remove now unnecessary (net_)wm_state window members. winex11: Get rid of the now unnecessary unmap_window helper. winex11: Request window state updates asynchronously. winex11: Try updating the client window state in net_wm_state_notify. winex11: Request window config updates asynchronously. winex11: Introduce a new window_update_client_config helper. winex11: Simplify the control flow in ConfigureNotify handlers. winex11: Introduce a new window_update_client_state helper. winex11: Simplify the control flow in WM_STATE handlers. winex11: Avoid updating _NET_WM_STATE on iconic windows. winex11: Tweak the WM_TAKE_FOCUS event time to workaround a FVWM bug. winex11: Ignore focus changes during WM_STATE updates. winex11: Get rid of the now unnecessary mapped window data flag. winex11: Use desired_state wm_state to decide of the mapped flag. winex11: Call window_set_wm_state when unmapping embedded windows. winex11: Get rid of the unnecessary net_wm_state window data member. winex11: Get rid of the now unnecessary iconic window data flag. winex11: Use pending_state wm_state to decide whether a window is currently iconic. winex11: Use pending_state to decide whether to set fullscreen monitor property. winex11: Use pending_state wm_state to decide if requests can be made directly. winex11: Compute WM_STATE notify updates in term of style changes. winex11: Compute ConfigureNotify updates in term of style changes. winex11: Compute WindowPosChanged updates in term of style changes. winex11: Avoid requesting unnecessary window config changes. winex11: Avoid requesting unnecessary _NET_WM_STATE changes. winex11: Track window config requests and updates. winex11: Introduce a new window_set_config helper. winex11: Track _NET_WM_STATE window property requests and updates. winex11: Introduce a new window_set_net_wm_state helper. winex11: Introduce a new window_set_wm_state helper. winex11: Track _XEMBED_INFO window property changes. winex11: Introduce a new window state tracker. winex11: Move embedded check in update_net_wm_states / sync_window_style. winex11: Move ConfigureNotify checks after computing visible rect. winex11: Rename read_net_wm_state to get_window_net_wm_state. winex11: Set configure_serial when resizing on display mode change. winex11: Avoid processing RRNotify events in xrandr14_get_id. d3d9/tests: Use static class for the dummy window. d3d9/tests: Avoid creating visible windows concurrently. wined3d: Check that format_id is >= 0 before assuming it's an index. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6569

1 1

[PATCH 0/8] MR6709: Code refactor reduced variable inner scope
by Herman Semenov (＠GermanAizek) 22 Oct '24

22 Oct '24

Micro-optimization works only in Debug build, therefore, it is more correct to name this code refactoring, in my GCC with -O2 flag it does not affect count and decrease cost per CPU clock cycle instructions generated in any way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6709

4 12

[PATCH 0/3] MR6704: d3dx9: Some changes to pixel format handling on the WIC image decode path.
by Connor McAdams (＠cmcadams) 22 Oct '24

22 Oct '24

This adds support for converting to different WIC formats, in one case to more closely match native d3dx9, and in the other to convert to a format that can actually be represented by d3d9. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6704

3 5

[PATCH v4 0/7] MR6640: propsys: Support converting to BSTR for PropVariantToVariant.
by Ziqing Hui (＠zhui) 22 Oct '24

22 Oct '24

This is based on top of !6526, will mark ready after !6526 is merged. -- v4: DEBUG the gitlab CI test failure. propsys: Support converting to BSTR for PropVariantToVariant. propsys: Use debugstr_variant for the trace in VariantToPropVariant. propsys: Implement PropVariantToBSTR. propsys/tests: Test truncating for PropVariantToString. propsys/tests: Test PropVariantToBSTR. propsys: Add PropVariantToBSTR stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6640

4 12

[PATCH 0/9] MR6712: wintypes: Add IPropertyValueStatics and IPropertyValue.
by Zhiyi Zhang (＠zhiyi) 22 Oct '24

22 Oct '24

React Native apps require these. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6712

2 9

[PATCH 0/1] MR6708: win32u: Sync cursor position on window position change.
by Paul Gofman (＠gofman) 22 Oct '24

22 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6708

3 3

[PATCH v5 0/7] MR6158: Replaced on simpler functions with char, wchar_t parameter if possible
by Herman Semenov (＠GermanAizek) 22 Oct '24

22 Oct '24

Example my assembly with gcc -02 flag Before: ![screen_before](/uploads/f2bf5f4c793c159c31ac42b635c46d5a/screen_before.jpg) After: ![screen_after](/uploads/051315ad1e3c064046446782d36e1a29/screen_after.jpg) -- v5: d3dcompiler_43: micro-optimization using strstr -> strchr implementation if possible wusa: micro-optimization using strstr -> strchr implementation if possible oledb32: micro-optimization using strstr -> strchr implementation if possible wbemprox: micro-optimization using strstr -> strchr implementation if possible oledb32: micro-optimization using strstr -> strchr implementation if possible wusa: micro-optimization using strstr -> strchr implementation if possible msidb: micro-optimization using strstr -> strchr implementation if possible https://gitlab.winehq.org/wine/wine/-/merge_requests/6158

2 8

Re: [PATCH v6 0/7] MR6703: msvcrt: Improve DBCS support for _strnicmp_l(). - approved
by Alexandre Julliard (＠julliard) 21 Oct '24

21 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6703

1 0

Re: [PATCH v2 0/3] MR6706: windows.gaming.input: Invoke event handlers outside of the critical section. - approved
by Alexandre Julliard (＠julliard) 21 Oct '24

21 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6706

1 0

Re: [PATCH v10 0/8] MR6649: winex11: Replace foreign windows with a driver-only host window tracking. - approved
by Alexandre Julliard (＠julliard) 21 Oct '24

21 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

1 0

Re: [PATCH v2 0/1] MR6705: win32u: Do not adjust old valid rect when moving child window bits. - approved
by Alexandre Julliard (＠julliard) 21 Oct '24

21 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6705

1 0

Re: [PATCH v2 0/1] MR6702: include: Add new property keys in propkey.h. - approved
by Alexandre Julliard (＠julliard) 21 Oct '24

21 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6702

1 0

Re: [PATCH v3 0/2] MR6696: mciseq: Don't seek to the end of the root chunk in RMID files. - approved
by Alexandre Julliard (＠julliard) 21 Oct '24

21 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6696

1 0

Re: [PATCH v2 0/5] MR6681: dplayx, dpwsockx: CreatePlayer() part 2. - approved
by Alexandre Julliard (＠julliard) 21 Oct '24

21 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6681

1 0

[PATCH v3 0/1] MR6666: ntdll: Implement NtWow64QueryInformationProcess64.
by Alex Henrie (＠alexhenrie) 21 Oct '24

21 Oct '24

Needed for GOG Galaxy. -- v3: ntdll: Implement NtWow64QueryInformationProcess64. https://gitlab.winehq.org/wine/wine/-/merge_requests/6666

4 4

[PATCH v2 0/1] MR6666: ntdll: Implement NtWow64QueryInformationProcess64.
by Alex Henrie (＠alexhenrie) 21 Oct '24

21 Oct '24

Needed for GOG Galaxy. -- v2: ntdll: Implement NtWow64QueryInformationProcess64. https://gitlab.winehq.org/wine/wine/-/merge_requests/6666

4 6

[PATCH v4 0/2] MR6158: Replaced on simpler functions with char, wchar_t parameter if possible
by Herman Semenov (＠GermanAizek) 21 Oct '24

21 Oct '24

Example my assembly with gcc -02 flag Before: ![screen_before](/uploads/f2bf5f4c793c159c31ac42b635c46d5a/screen_before.jpg) After: ![screen_after](/uploads/051315ad1e3c064046446782d36e1a29/screen_after.jpg) -- v4: d3dcompiler: replaced to char, wchar_t parameter if possible wcmdmain: replaced to char, wchar_t parameter if possible https://gitlab.winehq.org/wine/wine/-/merge_requests/6158

4 10

[PATCH v5 0/7] MR6703: msvcrt: Improve DBCS support for _strnicmp_l().
by Jactry Zeng (＠jactry) 21 Oct '24

21 Oct '24

-- v5: msvcrt/tests: Add tests of _strnicmp_l(). include: Add _strnicmp_l() declaration. msvcrt/tests: Test _stricmp() with multiple bytes characters. msvcrt: Correct the result of non-ASCII characters for _strnicmp_l(). msvcrt/tests: Test _tolower_l() with DBCS. msvcrt: Improve DBCS support for _tolower_l(). msvcrt/tests: Test tolower() with DBCS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6703

3 8

[PATCH v2 0/2] MR6707: Fix compilation for gcc 4.7
by Fabian Maurer (＠DarkShadow44) 21 Oct '24

21 Oct '24

-- v2: mf/tests: Fix compilation for gcc 4.7 https://gitlab.winehq.org/wine/wine/-/merge_requests/6707

2 4

[PATCH v2 0/1] MR6169: comctl32: fixed first we check index then array access by index is safe
by Herman Semenov (＠GermanAizek) 21 Oct '24

21 Oct '24

I think this PR changes will protect against situation if out-of-bounds access array. -- v2: comctl32: fixed first we check index then array access by index is safe https://gitlab.winehq.org/wine/wine/-/merge_requests/6169

6 8

[PATCH v8 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) 21 Oct '24

21 Oct '24

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v8: server: Implement more FSCTLs on \Device\NamedPipe and \Device\NamedPipe\. server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

3 4

[PATCH v4 0/7] MR6703: msvcrt: Improve DBCS support for _strnicmp_l().
by Jactry Zeng (＠jactry) 21 Oct '24

21 Oct '24

-- v4: msvcrt/tests: Add tests of _strnicmp_l(). include: Add _strnicmp_l() declaration. msvcrt/tests: Test _stricmp() with multiple bytes characters. msvcrt: Correct the result of non-ASCII characters for _strnicmp_l(). msvcrt/tests: Test _tolower_l() with DBCS. msvcrt: Improve DBCS support for _tolower_l(). msvcrt/tests: Test tolower() with DBCS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6703

3 9

[PATCH 0/2] MR6707: Fix compilation for gcc 4.7
by Fabian Maurer (＠DarkShadow44) 21 Oct '24

21 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6707

4 4

2025

2024

2023

2022

wine-gitlab