- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR6684: win32u: Avoid crashing when creating a new layered window surface. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6684

1 0

Re: [PATCH v2 0/1] MR6683: win32u: Use parent-relative coordinates for old window rectangles. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6683

1 0

Re: [PATCH v4 0/1] MR6648: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors(). - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6648

1 0

Re: [PATCH v3 0/6] MR6682: winex11: More drag'n'drop PE side code cleanup. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6682

1 0

Re: [PATCH v2 0/1] MR6669: windowscodecs: Implement 48bppRGB -> 64bppRGBA conversion. - approved
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6669

1 0

[PATCH 0/1] MR6238: comdlg32: Add `const' qualifier
by Ruslan Garipov (＠ruslangaripov) 16 Oct '24

16 Oct '24

No functional changes intended. Please, review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6238

4 5

[PATCH v2 0/4] MR6602: win32u: Always launch explorer for the desktop with a default token.
by Tim Clem (＠tclem) 16 Oct '24

16 Oct '24

Testing on Windows shows that the owner of GetDesktopWindow() always has a default admin token with `TokenElevationTypeDefault`, no matter the token of the process/thread that is responsible for creating it. We've had issues in this area in the past - 99e2fad1 was a case where it was important that explorer not inherit the token of the *process* spawning it, but instead the token of the *thread*. This patch keeps that app working, since now explorer will get a default token regardless. In addition to the privilege issues from 99e2fad1, it is a relatively common pattern to duplicate the token of the owner of GetDesktopWindow to acquire a default token. -- v2: services: Apply a default admin token to the process. ntdll: Count default-elevation admin tokens as elevated from NtQueryInformationToken(TokenElevation). Revert "win32u: Create explorer with the thread effective access token." explorer: Apply a default admin token when running for the desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/6602

3 6

[PATCH v2 0/3] MR6673: d3dx9: Move targa decoding into d3dx9, part 1.
by Connor McAdams (＠cmcadams) 16 Oct '24

16 Oct '24

This is the first set of patches to move targa decoding out of WIC and into d3dx9. The eventual goal is to add support for saving targa files. I've pushed a branch with the rest of the patches for decoding the image [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/d3dx9-targa-decode… if extra context would help. I split this into two parts to make review a little less overwhelming. :) -- v2: d3dx9: Use d3dx9 to get image information for targa files. d3dx9/tests: Add TGA header image info tests. d3dx9: Do not use WIC to detect image file format. https://gitlab.winehq.org/wine/wine/-/merge_requests/6673

4 9

[PATCH 0/1] MR6674: xml2: Import upstream release 2.12.8.
by Alexandre Julliard (＠julliard) 16 Oct '24

16 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6674

4 10

[PATCH 0/3] MR6673: d3dx9: Move targa decoding into d3dx9, part 1.
by Connor McAdams (＠cmcadams) 16 Oct '24

16 Oct '24

This is the first set of patches to move targa decoding out of WIC and into d3dx9. The eventual goal is to add support for saving targa files. I've pushed a branch with the rest of the patches for decoding the image [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/d3dx9-targa-decode… if extra context would help. I split this into two parts to make review a little less overwhelming. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6673

3 15

[PATCH 0/1] MR6684: win32u: Avoid crashing when creating a new layered window surface.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57311 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6684

2 1

[PATCH v2 0/7] MR6672: winetest: Implement JUnit report output mode.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

For Gitlab to detect and report the failing tests directly on the MR front page. This has the disadvantage of making the test job output more silent, but the results are still available as artifacts (in JUnit XML format), which hopefully should be enough if we need to have a better look at it. The tests standard output is included in the reports too. I believe it would also show some failure statistics that could help deciding on whether a test is regularly failing or not, but I wasn't able to really test that it does. In order to help it doing it, it also implements hashing of test sources to generate test IDs that are more stable than `source:line`, although it could be done later. All the succeeding (and todo) tests are grouped together and reported as once, as they would otherwise be split into individual success lines in the Gitlab UI, which would make it unnecessary large. Only failures and skipped tests are reported as individual entries. -- v2: gitlab: Use winetest JUnit output mode. winetest: Implement JUnit report output mode. winetest: Introduce some test report helpers. winetest: Pass output file handle to xprintf. winetest: Always use a temporary file for test output. winetest: Add printf attributes to xprintf. winetest: Add printf attributes to strmake. https://gitlab.winehq.org/wine/wine/-/merge_requests/6672

2 8

[PATCH 0/3] MR6680: msvcp140: Use current locale to convert path in _Fiopen.
by Daniel Lehman (＠dlehman25) 16 Oct '24

16 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6680

4 5

[PATCH v2 0/1] MR6620: comctl32: Implement WM_GETOBJECT for buttons.
by Esme Povirk (＠madewokherd) 16 Oct '24

16 Oct '24

-- v2: comctl32: Implement WM_GETOBJECT for buttons. https://gitlab.winehq.org/wine/wine/-/merge_requests/6620

5 5

[PATCH 0/1] MR6683: win32u: Use parent-relative coordinates for old window rectangles.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

Since 4e06b87633ec7e04822ad4f4854df7ae43f0d7e0, we are moving the window rects, which is in screen coordinates for the old rects, because invalidate_dce expects it, but in parent coordinates for the new rects. This makes the old and new rectangles to be consistently using parent-relative coordinates, fixing some broken window bits copy with child windows. Fixes 4e06b87633ec7e04822ad4f4854df7ae43f0d7e0 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6683

2 1

Re: [PATCH v2 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's.
by Alistair Leslie-Hughes (＠alesliehughes) 16 Oct '24

16 Oct '24

Since the DLLs are now real windows dll, the attribute not is required. This attribute stopped these private functions from being exposed in the Unix libraries. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4332#note_85119

1 0

[PATCH v3 0/1] MR6648: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors().
by Aida Jonikienė (＠DodoGTA) 16 Oct '24

16 Oct '24

This prevents a "Failed to get xinerama fullscreen monitor indices." error when minimizing a fullscreen window. -- v3: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6648

3 3

Re: [PATCH v2 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's.
by David Kahurani (＠ReDress) 16 Oct '24

16 Oct '24

When you bring up issues on MRs that already gotten merged, that really isn't very nice -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4332#note_85116

1 0

Re: [PATCH v2 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's.
by Ruslan Garipov (＠ruslangaripov) 16 Oct '24

16 Oct '24

@alesliehughes Sorry for bothering, but could you please explain a motivation behind this and next similar patches/requests removing the `DECLSPEC_HIDDEN` attribute from functions? I just can't understand why they exist. And no Wine-related mailing list gave me an answer... Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4332#note_85109

1 0

[PATCH v2 0/1] MR6648: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors().
by Aida Jonikienė (＠DodoGTA) 16 Oct '24

16 Oct '24

This prevents a "Failed to get xinerama fullscreen monitor indices." error when minimizing a fullscreen window. -- v2: winex11: Properly handle minimized windows in update_net_wm_fullscreen_monitors(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6648

3 3

[PATCH v2 0/6] MR6682: winex11: More drag'n'drop PE side code cleanup.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

-- v2: winex11: Get rid of X11DRV_XDND_HasHDROP helper. winex11: Use a custom IEnumFORMATETC interface implementation. winex11: Clear the XDND data object on drop event. winex11: Get rid of X11DRV_XDND_SendDropFiles helper. winex11: Assume that PostMessageW WM_DROPFILES succeeds. winex11: Only enter the CS to get a reference on the data object. https://gitlab.winehq.org/wine/wine/-/merge_requests/6682

2 6

[PATCH 0/6] MR6682: winex11: More drag'n'drop PE side code cleanup.
by Rémi Bernon (＠rbernon) 16 Oct '24

16 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6682

2 6

[PATCH 0/1] MR6669: windowscodecs: Implement 48bppRGB -> 64bppRGBA conversion.
by Paul Gofman (＠gofman) 15 Oct '24

15 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6669

3 3

Re: [PATCH v3 0/1] MR6676: conhost: Start input thread in IOCTL_CONDRV_GET_INPUT_INFO ioctl. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6676

1 0

Re: [PATCH v2 0/1] MR6677: advapi32: Don't trace password in CreateProcessWithLogonW stub. - approved
by Alexandre Julliard (＠julliard) 15 Oct '24

15 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6677

1 0

2025

2024

2023

2022

wine-gitlab