- wine-gitlab - winehq.org

Re: [PATCH v2 0/4] MR8143: amstream: Improve DDSURFACEDESC to AM_MEDIA_TYPE conversion, part 1/2. - approved
by Alexandre Julliard (＠julliard) 26 May '25

26 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8143

1 0

Re: [PATCH v2 0/3] MR8142: dmime: Cut down on the fixmes for unsupported MIDI meta events - approved
by Alexandre Julliard (＠julliard) 26 May '25

26 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8142

1 0

Re: [PATCH v2 0/1] MR8138: gdiplus: Unify region rasterization in GdipFillRegion. - approved
by Alexandre Julliard (＠julliard) 26 May '25

26 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8138

1 0

Re: [PATCH v2 0/3] MR8136: Fix interaction between FreeConsole() and CRT std streams. - approved
by Alexandre Julliard (＠julliard) 26 May '25

26 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8136

1 0

Re: [PATCH v2 0/1] MR8131: comctl32/tests: Fix childid in trackbar statechange event. - approved
by Alexandre Julliard (＠julliard) 26 May '25

26 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8131

1 0

Re: [PATCH v2 0/1] MR8124: dmusic: Only extract name in EnumInstrument when the valid flag is set. - approved
by Alexandre Julliard (＠julliard) 26 May '25

26 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8124

1 0

[PATCH 0/1] MR8151: ntdll: Avoid excessive committed range scan in NtProtectVirtualMemory().
by Paul Gofman (＠gofman) 26 May '25

26 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8151

2 1

[PATCH 0/1] MR8144: winegstreamer: Add basic support for GST_VIDEO_FORMAT_I420_10LE.
by Brendan McGrath (＠redmcg) 26 May '25

26 May '25

Windows doesn't support I420 10LE, but uses P010 instead, thus GST_VIDEO_FORMAT_I420_10LE is ultimately converted to GST_VIDEO_FORMAT_P010_10LE. This fixes playback of videos in VRChat that use i420 10le as the raw video color format. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8144

4 3

Re: [PATCH v2 0/1] MR8096: ntdll: Pass exception code to exception handlers in __C_specific_handler.
by Jacek Caban (＠jacek) 26 May '25

26 May '25

On Mon May 26 16:15:35 2025 +0000, Alexandre Julliard wrote: > This is crashing on the testbot for most Windows version, could you > please have a look? Sorry about that, !8149 should fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8096#note_104584

1 0

[PATCH 0/1] MR8149: ntdll/tests: Register runtime function in test___C_specific_handler.
by Jacek Caban (＠jacek) 26 May '25

26 May '25

On some Windows versions, `__C_specific_handler` requires unwind information for the tested function, even though it's not actually needed, since unwinding should stop at this point. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8149

2 1

[PATCH v4 0/1] MR8116: kerberos: Add support for SECBUFFER_STREAM to SpUnsealMessage().
by Dmitry Timoshkov (＠dmitry) 26 May '25

26 May '25

This is an alternative approach to https://gitlab.winehq.org/wine/wine/-/merge_requests/8114. Once this is accepted SECBUFFER_STREAM could be used for for Kerberos/DecryptMessage() in libs/ldap. -- v4: kerberos: Add support for SECBUFFER_STREAM to SpUnsealMessage(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8116

3 6

[PATCH v6 0/6] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 26 May '25

26 May '25

-- v6: winex11: Serialize window config requests with some other requests. winex11: Serialize managed window config change requests. winex11: Keep track of the last config above flag used. winex11: Track window pending config position / size independently. winex11: Serialize individual _NET_WM_STATE bit changes. winex11: Continue requesting desired window state on no-op event. https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

3 10

[PATCH v2 0/1] MR8130: winex11: Keep track of xinerama fullscreen monitors generation.
by Rémi Bernon (＠rbernon) 26 May '25

26 May '25

Fixes: 065d637e3eebbd0600b48f84447c5249cbea4752 -- v2: winex11: Keep track of xinerama fullscreen monitors generation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8130

3 3

Re: [PATCH v2 0/1] MR8096: ntdll: Pass exception code to exception handlers in __C_specific_handler.
by Alexandre Julliard (＠julliard) 26 May '25

26 May '25

This is crashing on the testbot for most Windows version, could you please have a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8096#note_104565

1 0

[PATCH v5 0/6] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 26 May '25

26 May '25

-- v5: winex11: Serialize window config requests with some other requests. winex11: Serialize managed window config change requests. winex11: Keep track of the last config above flag used. winex11: Track window pending config position / size independently. winex11: Serialize individual _NET_WM_STATE bit changes. winex11: Continue requesting desired window state on no-op event. https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

3 8

[PATCH v3 0/1] MR8116: kerberos: Add support for SECBUFFER_STREAM to SpUnsealMessage().
by Dmitry Timoshkov (＠dmitry) 26 May '25

26 May '25

This is an alternative approach to https://gitlab.winehq.org/wine/wine/-/merge_requests/8114. Once this is accepted SECBUFFER_STREAM could be used for for Kerberos/DecryptMessage() in libs/ldap. -- v3: kerberos: Add support for SECBUFFER_STREAM to SpUnsealMessage(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8116

3 3

[PATCH 0/1] MR8130: winex11: Keep track of xinerama fullscreen monitors generation.
by Rémi Bernon (＠rbernon) 26 May '25

26 May '25

Fixes: 065d637e3eebbd0600b48f84447c5249cbea4752 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8130

3 2

[PATCH v2 0/6] MR8148: opengl32: Implement wglShareLists directly.
by Rémi Bernon (＠rbernon) 26 May '25

26 May '25

-- v2: win32u: Drop now unnecessary wglShareList implementation. opengl32: Implement wglShareLists directly. opengl32: Cache context creation attributes. opengl32: Share wgl_context struct definition with win32u. opengl32: Simplify wglMake(Context)Current control flow. opengl32: Move glFlush/glFinish hooking from win32u. https://gitlab.winehq.org/wine/wine/-/merge_requests/8148

2 6

[PATCH 0/7] MR8146: Implement IReference<T>
by Zhiyi Zhang (＠zhiyi) 26 May '25

26 May '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8146

2 7

[PATCH v6 0/1] MR8137: kernel32: Implement ReadConsoleInputEx
by Jayson Reis (＠jaysonsantos) 26 May '25

26 May '25

This implements the method only with empty flags, nowait (0x2) and all flags on noremove(0x1) | nowait(0x2) -- v6: kernel32: Implement ReadConsoleInputEx https://gitlab.winehq.org/wine/wine/-/merge_requests/8137

4 5

[PATCH v51 0/2] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 May '25

26 May '25

Over the past several weeks I've been working on and off on this. I didn't track the hours but I'm sure that I've spent 80+ hours on the feature. I've tested and retested all known scenarios and it seems to be working as expected. -- v51: cmd: Implement tab completion for command line entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/7843

2 3

[PATCH v3 0/1] MR7747: ntdll: Detect the optical disc type on Linux using a SCSI command.
by Alex Henrie (＠alexhenrie) 26 May '25

26 May '25

SCSI command 0xAD (GPCMD_READ_DVD_STRUCTURE) with the eighth byte of the command set to 0x00 (DVD_STRUCT_PHYSICAL) returns physical disc information for DVDs and blu-rays. On success, the command returns status 0, and for ordinary CDs, the command returns the error status 0x02 (SAM_STAT_CHECK_CONDITION). The format of the data returned is different for blu-rays than for DVDs, and the second byte of the command indicates whether to return DVD information or blu-ray information. (My LG WH16NS40 drive actually ignores the second byte when there is a DVD in the drive, but it returns SAM_STAT_CHECK_CONDITION when there is a blu-ray in the drive and the second byte is not 0x01.) Windows does not distinguish between DVDs and blu-rays in IOCTL_DISK_GET_MEDIA_TYPES, so if the SCSI command succeeds for either disc type, report FILE_DEVICE_DVD. More specific media information is still not implemented. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57790 -- v3: ntdll: Detect the optical disc type on Linux using a SCSI command. https://gitlab.winehq.org/wine/wine/-/merge_requests/7747

2 2

[PATCH 0/1] MR8141: gdiplus: Add check of type parameter to be positive (ASan).
by Bernhard Übelacker (＠bernhardu) 26 May '25

26 May '25

Function GdipGetImageAttributesAdjustedPalette gets [called with type = -1](https://gitlab.winehq.org/wine/wine/-/blob/22af42ac22279e6c0c671f033661f95c1761b4bb/dlls/gdiplus/tests/image.c?page=6#L5649) and therefore accesses several arrays at index -1. This patch adds a helper which additionally checks for `type >= ColorAdjustTypeDefault`. <details> <summary>ASan output</summary> ``` ================================================================= ==gdiplus_test.exe==308==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f21342c57f8 at pc 0x6ffffadfd25b bp 0x7ffffe1ff750 sp 0x7ffffe1ff798 READ of size 4 at 0x7f21342c57f8 thread T0 #0 0x6ffffadfd25a in apply_image_attributes .../dlls/gdiplus/graphics.c:929:41 #1 0x6ffffae5c2f2 in GdipGetImageAttributesAdjustedPalette .../dlls/gdiplus/imageattributes.c:123:5 #2 0x000140084b59 in test_getadjustedpalette .../dlls/gdiplus/tests/image.c:5649:12 #3 0x000140062be6 in func_image .../dlls/gdiplus/tests/image.c:6719:5 #4 0x0001400c9132 in run_test .../include/wine/test.h:765:5 #5 0x0001400c8b50 in main .../include/wine/test.h:884:12 #6 0x0001400cad3a in mainCRTStartup .../dlls/msvcrt/crt_main.c:60:11 #7 0x6fffffc45aa0 in BaseThreadInitThunk .../dlls/kernel32/thread.c:61:24 #8 0x6fffffdcc776 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004c776) 0x7f21342c57f8 is located 144 bytes after 1256-byte region [0x7f21342c5280,0x7f21342c5768) freed by thread T0 here: #0 0x6ffffe88aab1 in free C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan\asan_malloc_win.cpp:71:3 #1 0x6ffffae5c21d in GdipDisposeImageAttributes .../dlls/gdiplus/imageattributes.c:109:5 #2 0x000140083598 in test_colorkey .../dlls/gdiplus/tests/image.c:3709:5 #3 0x000140062bd7 in func_image .../dlls/gdiplus/tests/image.c:6716:5 #4 0x0001400c9132 in run_test .../include/wine/test.h:765:5 #5 0x0001400c8b50 in main .../include/wine/test.h:884:12 #6 0x0001400cad3a in mainCRTStartup .../dlls/msvcrt/crt_main.c:60:11 #7 0x6fffffc45aa0 in BaseThreadInitThunk .../dlls/kernel32/thread.c:61:24 #8 0x6fffffdcc776 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004c776) previously allocated by thread T0 here: #0 0x6ffffe88ace6 in calloc C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan\asan_malloc_win.cpp:91:3 #1 0x6ffffae5c0fc in GdipCreateImageAttributes .../dlls/gdiplus/imageattributes.c:87:18 #2 0x000140082bf9 in test_colorkey .../dlls/gdiplus/tests/image.c:3629:12 #3 0x000140062bd7 in func_image .../dlls/gdiplus/tests/image.c:6716:5 #4 0x0001400c9132 in run_test .../include/wine/test.h:765:5 #5 0x0001400c8b50 in main .../include/wine/test.h:884:12 #6 0x0001400cad3a in mainCRTStartup .../dlls/msvcrt/crt_main.c:60:11 #7 0x6fffffc45aa0 in BaseThreadInitThunk .../dlls/kernel32/thread.c:61:24 #8 0x6fffffdcc776 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004c776) SUMMARY: AddressSanitizer: heap-buffer-overflow .../dlls/gdiplus/graphics.c:929:41 in apply_image_attributes Shadow bytes around the buggy address: 0x7f21342c5500: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5580: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5600: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5680: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f21342c5700: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa =>0x7f21342c5780: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa[fa] 0x7f21342c5800: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x7f21342c5880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f21342c5900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f21342c5980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f21342c5a00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==gdiplus_test.exe==308==ABORTING ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8141

3 2

[PATCH 0/4] MR8143: amstream: Improve DDSURFACEDESC to AM_MEDIA_TYPE conversion, part 1/2.
by Elizabeth Figura (＠zfigura) 26 May '25

26 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8143

2 4

[PATCH v4 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) 25 May '25

25 May '25

Fix out-of-bound access by wcslen. Found by ASan. -- v4: mscoree: Add missing NUL terminator. https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

4 6

2025

2024

2023

2022

wine-gitlab