- wine-gitlab - winehq.org

[PATCH 0/1] MR6617: comctl32: Use correct clipping region when handling themed WM_NCPAINT in listview.
by Dmitry Timoshkov (＠dmitry) 08 Oct '24

08 Oct '24

Same calculation is used in the DefWindowProc() handler. This also fixes handling of region == 1: GetDCEx(hwnd, 1, DCX_INTERSECTRGN) won't work. Probably same fix is needed for other comctl32 themed controls. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6617

4 18

[PATCH v7 0/47] MR6623: Draft: include/winnt.h: Add support for thread safety annotation attributes.
by Vibhav Pant (＠vibhavp) 08 Oct '24

08 Oct '24

This MR introduces support for [thread safety annotations,](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditi… currently supported by Clang. The feature is similar to `__WINE_MALLOC` attributes, allowing functions, data members and global variables to be optionally annotated with synchronization details. As a proof of concept, I have annotated `RTL_CRITICAL_SECTION` and `dlls/ntdll`. Because the feature was designed as a C++ extension first, a bit of stubbing is required to annotate struct fields about what lock they are guarded by. The macros `WINE_DECLARE_LOCK_FIELD_STUB` and `WINE_DEFINE_LOCK_FIELD_STUB` take care of that. For instance, in `dlls/ntdll/threadpool.c`: ```c WINE_DECLARE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); struct threadpool_group { LONG refcount; BOOL shutdown; CRITICAL_SECTION cs; /* list of group members, locked via .cs */ struct list members __WINE_FIELD_GUARDED_BY(threadpool_group, cs); }; WINE_DEFINE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); ``` Clang will therefore warn if `members` is accessed without holding `cs`. Note that the analyzer does not support conditional locking. For that reason, functions that hold and release a lock conditionally have been marked with `__WINE_NO_THREAD_SAFETY_ANALYSIS` to pre-empt false positives from Clang. -- v7: dlls/ntoskrnl.exe: Add thread safety annotations. dlls/combase: Add thread safety annotations. dlls/imm32: Add GUARDED_BY attribute to the struct ime's refcount field. dlls/crypt32: Annotate CRYPT_CollectionAdvanceEnum indicating that the caller should hold the collection store's lock. dlls/amstream/tests: Disable thread safety analysis for testfilter_wait_state. dlls/winhttp: Add thread safety annotations. dlls/mmdevapi: Add thread safety annotations for session_lock and sessions_unlock. dlls/mfplat: Add thread safety annotations. dlls/msi: Add thread safety annotations for msiobj_lock and msiobj_unlock. dlls/xaudio2_7: Add thread safety annotations. dlls/wmvcore: Add thread safety annotations for async_reader_wait_pts, async_reader_deliver_sample, and callback_thread_run. dlls/wininet: Disable thread safety annotations for HTTPREQ_ReadFile and HTTPREQ_QueryDataAvailable. dlls/winegstreamer: Add thread safety annotation for GST_Seeking_SetPositions. dlls/dwrite: Add thread safety annotations for factory_lock and factory_unlock. dlls/wined3d: Add thread safety annotations. lib/vkd3d: Build with WINE_NO_THREAD_SAFETY_ANALYSIS defined. dlls/d2d1: Add thread safety annotations. dlls/xaudio2_7: Disable thread safety analysis for IXAudio2Impl_CreateSourceVoice. dlls/xinput1_3: Add thread safety annotations for controller_lock and controller_unlock. dlls/ucrtbase/tests: Only release &fp.iobuf->_crit if the previous lock was successful (Clang). dlls/netio.sys: Add thread safety annotations for lock_sock and unlock_socket. dlls/msvcirt/tests: Release &sb.lock only if the previous lock was successful (Clang). dlls/wbemprox: Add thread safety annotations. libs/strmbase: Annotate BaseRenderer_Receive to indicate the caller needs to hold the underlying filter lock. dlls/rpcrt4: Add thread safety annotations for AllocateContextHandle, FindContextHandle, ReleaseContextHandle. dlls/wined3d: Add thread safety annotations for allocator locking helpers. dlls/mfreadwrite: Indicate calling source_reader_read_sample requires holding &reader->cs. dlls/mapi32: Add thread safety annotations for GetValue, AddValue, Lock, Unlock. dlls/kernel32/tests: Add thread safety annotations. dlls/combase: Add thread safety annotations programs/services: Add thread safety annotations. dlls/winmm: Add thread safety annotations. dlls/vcomp: Add thread safety annotations. dlls/user32: Add thread safety annotations. dlls/odbc32: Add thread safety annotations. dlls/krnl386.exe16: Add thread safety annotations. dlls/msvcirt: Add thread safety annotations. dlls/msvcp90: Add thread safety annotations. dlls/msvcrt: Add thread safety annotations. dlls/kernelbase: Add thread safety annotations. include/wine/winbase16: Add thread safety annotations for _Enter/LeaveSysLevel dlls/kernelbase: Release console_section in case of an allocation failure in alloc_console. include/winbase.h: Add thread safety annotations for Enter/LeaveCriticalSection, SleepConditionVariableCS and TryEnterCriticalSection. dlls/ntdll: Add thread safety annotations. configure: Enable -Wthread-safety-analysis, -Wthread-safety-attributes warnings. include/winternl.h: Add thread safety annotations to several NT synchronization primitives. include/winnt.h: Add macros for thread safety annotations. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6623

1 0

[PATCH v2 0/4] MR6564: d3d: Do not apply the stateblock when clearing.
by Elizabeth Figura (＠zfigura) 08 Oct '24

08 Oct '24

-- v2: d3d9: Do not apply the stateblock when clearing. d3d8: Do not apply the stateblock when clearing. ddraw: Do not apply the entire stateblock when clearing. wined3d: Move rasterizer state invalidation to wined3d_stateblock_set_render_state(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6564

4 6

[PATCH v2 0/3] MR6603: win32u: Support QDC_VIRTUAL_MODE_AWARE QueryDisplayConfig flag.
by Paul Gofman (＠gofman) 08 Oct '24

08 Oct '24

-- v2: win32u: Support QDC_VIRTUAL_MODE_AWARE in NtUserQueryDisplayConfig(). win32u: Support QDC_VIRTUAL_MODE_AWARE in NtUserGetDisplayConfigBufferSizes(). user32/tests: Add tests for QueryDisplayConfig( QDC_VIRTUAL_MODE_AWARE ). https://gitlab.winehq.org/wine/wine/-/merge_requests/6603

4 6

[PATCH 0/1] MR6628: mmdevapi: Fix buffer overflow in pulse_set_sample_rate.
by Santino Mazza (＠tati1454) 08 Oct '24

08 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6628

3 2

[PATCH 0/1] MR6634: win32u: Use an internal message for XIM IME notifications.
by Rémi Bernon (＠rbernon) 08 Oct '24

08 Oct '24

Fixes IME not working anymore in Diablo IV. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6634

2 1

[PATCH v4 0/3] MR6608: riched20: Only run editor_ensure_visible and ME_SendRequestResize when control is in-place active.
by Charlotte Pabst (＠CharlottePabst) 08 Oct '24

08 Oct '24

According to microsoft documentation, GetClientRect, ScrollWindowEx, SetScrollPos and SetScrollRange (among others) may only be called while the control is in-place active. This fixes a segmentation fault in Anytone CPS. -- v4: riched20/tests: Test that ScrollWindowEx and GetClientRect are only called when control is in-place active. riched20: Only call ME_SendRequestResize when control is in-place active. riched20: Exit from editor_ensure_visible when control is not in-place active. https://gitlab.winehq.org/wine/wine/-/merge_requests/6608

4 5

[PATCH v2 0/1] MR6633: win32u: Add winevulkan/driver entry points to sync surfaces with the host.
by Rémi Bernon (＠rbernon) 08 Oct '24

08 Oct '24

Fixes: 278ca7f68d727639b3389b78c363134fa2bd32a8 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57233 -- v2: win32u: Add winevulkan/driver entry points to sync surfaces with the host. https://gitlab.winehq.org/wine/wine/-/merge_requests/6633

2 1

[PATCH 0/1] MR6633: win32u: Add winevulkan/driver entry points to sync surfaces with the host.
by Rémi Bernon (＠rbernon) 08 Oct '24

08 Oct '24

Fixes: 278ca7f68d727639b3389b78c363134fa2bd32a8 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57233 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6633

2 1

[PATCH v2 0/5] MR6613: win32u: Introduce a new NtUserSetRawWindowPos call for the drivers.
by Rémi Bernon (＠rbernon) 08 Oct '24

08 Oct '24

-- v2: win32u: Introduce a new NtUserSetRawWindowPos call for the drivers. winex11: Use XTranslateCoordinates to compute relative coordinates. winex11: Use NtUserSetWindowPos when DPI awareness is unnecessary. winemac: Use NtUserSetWindowPos when DPI awareness is unnecessary. winemac: Stop mapping toplevel window rects to parent window. https://gitlab.winehq.org/wine/wine/-/merge_requests/6613

2 6

[PATCH v3 0/6] MR6632: dplayx: Open() part 8.
by Anton Baskanov (＠baskanov) 08 Oct '24

08 Oct '24

-- v3: dplayx/tests: Test receiving ADDFORWARDREPLY. https://gitlab.winehq.org/wine/wine/-/merge_requests/6632

3 8

Re: [PATCH v4 0/6] MR6632: dplayx: Open() part 8.
by Anton Baskanov (＠baskanov) 08 Oct '24

08 Oct '24

v4: - Fix the `may be used uninitialized` warning (this time in the correct commit). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6632#note_84297

1 0

[PATCH v2 0/6] MR6632: dplayx: Open() part 8.
by Anton Baskanov (＠baskanov) 08 Oct '24

08 Oct '24

-- v2: dplayx/tests: Test receiving ADDFORWARDREPLY. dplayx: Handle ADDFORWARDREPLY and return error. dplayx/tests: Test receiving REQUESTPLAYERREPLY with error result. dplayx: Check reply result in DP_MSG_SendRequestPlayerId(). dplayx: Use the documented reply layout in DP_MSG_SendRequestPlayerId(). dplayx: Free message header on error path in DP_MSG_SendRequestPlayerId(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6632

3 8

[PATCH 0/5] MR6632: dplayx: Open() part 8.
by Anton Baskanov (＠baskanov) 08 Oct '24

08 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6632

3 6

[PATCH 0/1] MR6631: include: Fix base class of ICompositorInterop interface
by Biswapriyo Nath (＠Biswa96) 08 Oct '24

08 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6631

3 2

[PATCH 0/1] MR6627: gdiplus: Add support for EmfPlusRecordTypeSetRenderingOrigin record playback.
by Dmitry Timoshkov (＠dmitry) 07 Oct '24

07 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6627

3 2

Re: [PATCH v2 0/1] MR6626: include: Add windows.security.authorization.appcapabilityaccess.idl. - approved
by Alexandre Julliard (＠julliard) 07 Oct '24

07 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6626

1 0

Re: [PATCH v2 0/1] MR6625: include: Add windows.data.xml.dom.idl. - approved
by Alexandre Julliard (＠julliard) 07 Oct '24

07 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6625

1 0

Re: [PATCH v3 0/1] MR6597: gdiplus: Assign box height when bounding height is higher. - approved
by Alexandre Julliard (＠julliard) 07 Oct '24

07 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6597

1 0

Re: [PATCH v3 0/8] MR6568: d3dx9: Pixel format handling changes, part 2. - approved
by Alexandre Julliard (＠julliard) 07 Oct '24

07 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6568

1 0

Re: [PATCH v2 0/1] MR6624: msiexec: Remove quotes from all filenames. - approved
by Alexandre Julliard (＠julliard) 07 Oct '24

07 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6624

1 0

Re: [PATCH v2 0/5] MR6619: dplayx: Open() part 7. - approved
by Alexandre Julliard (＠julliard) 07 Oct '24

07 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6619

1 0

[PATCH v6 0/43] MR6623: Draft: include/winnt.h: Add support for thread safety annotation attributes.
by Vibhav Pant (＠vibhavp) 07 Oct '24

07 Oct '24

This MR introduces support for [thread safety annotations,](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditi… currently supported by Clang. The feature is similar to `__WINE_MALLOC` attributes, allowing functions, data members and global variables to be optionally annotated with synchronization details. As a proof of concept, I have annotated `RTL_CRITICAL_SECTION` and `dlls/ntdll`. Because the feature was designed as a C++ extension first, a bit of stubbing is required to annotate struct fields about what lock they are guarded by. The macros `WINE_DECLARE_LOCK_FIELD_STUB` and `WINE_DEFINE_LOCK_FIELD_STUB` take care of that. For instance, in `dlls/ntdll/threadpool.c`: ```c WINE_DECLARE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); struct threadpool_group { LONG refcount; BOOL shutdown; CRITICAL_SECTION cs; /* list of group members, locked via .cs */ struct list members __WINE_FIELD_GUARDED_BY(threadpool_group, cs); }; WINE_DEFINE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); ``` Clang will therefore warn if `members` is accessed without holding `cs`. Note that the analyzer does not support conditional locking. For that reason, functions that hold and release a lock conditionally have been marked with `__WINE_NO_THREAD_SAFETY_ANALYSIS` to pre-empt false positives from Clang. -- v6: dlls/amstream/tests: Disable thread safety analysis for testfilter_wait_state. dlls/winhttp: Add thread safety annotations. dlls/mmdevapi: Add thread safety annotations for session_lock and sessions_unlock. dlls/mfplat: Add thread safety annotations. dlls/msi: Add thread safety annotations for msiobj_lock and msiobj_unlock. dlls/xaudio2_7: Add thread safety annotations. dlls/wmvcore: Add thread safety annotations for async_reader_wait_pts, async_reader_deliver_sample, and callback_thread_run. dlls/wininet: Disable thread safety annotations for HTTPREQ_ReadFile and HTTPREQ_QueryDataAvailable. dlls/winegstreamer: Add thread safety annotation for GST_Seeking_SetPositions. dlls/dwrite: Add thread safety annotations for factory_lock and factory_unlock. dlls/wined3d: Add thread safety annotations. lib/vkd3d: Build with WINE_NO_THREAD_SAFETY_ANALYSIS defined. dlls/d2d1: Add thread safety annotations. dlls/xaudio2_7: Disable thread safety analysis for IXAudio2Impl_CreateSourceVoice. dlls/xinput1_3: Add thread safety annotations for controller_lock and controller_unlock. dlls/ucrtbase/tests: Only release &fp.iobuf->_crit if the previous lock was successful (Clang). dlls/netio.sys: Add thread safety annotations for lock_sock and unlock_socket. dlls/msvcirt/tests: Release &sb.lock only if the previous lock was successful (Clang). dlls/wbemprox: Add thread safety annotations. libs/strmbase: Annotate BaseRenderer_Receive to indicate the caller needs to hold the underlying filter lock. dlls/rpcrt4: Add thread safety annotations for AllocateContextHandle, FindContextHandle, ReleaseContextHandle. dlls/wined3d: Add thread safety annotations for allocator locking helpers. dlls/mfreadwrite: Indicate calling source_reader_read_sample requires holding &reader->cs. dlls/mapi32: Add thread safety annotations for GetValue, AddValue, Lock, Unlock. dlls/kernel32/tests: Add thread safety annotations. dlls/combase: Add thread safety annotations programs/services: Add thread safety annotations. dlls/winmm: Add thread safety annotations. dlls/vcomp: Add thread safety annotations. dlls/user32: Add thread safety annotations. dlls/odbc32: Add thread safety annotations. dlls/krnl386.exe16: Add thread safety annotations. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6623

1 0

[PATCH v5 0/43] MR6623: Draft: include/winnt.h: Add support for thread safety annotation attributes.
by Vibhav Pant (＠vibhavp) 07 Oct '24

07 Oct '24

This MR introduces support for [thread safety annotations,](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditi… currently supported by Clang. The feature is similar to `__WINE_MALLOC` attributes, allowing functions, data members and global variables to be optionally annotated with synchronization details. As a proof of concept, I have annotated `RTL_CRITICAL_SECTION` and `dlls/ntdll`. Because the feature was designed as a C++ extension first, a bit of stubbing is required to annotate struct fields about what lock they are guarded by. The macros `WINE_DECLARE_LOCK_FIELD_STUB` and `WINE_DEFINE_LOCK_FIELD_STUB` take care of that. For instance, in `dlls/ntdll/threadpool.c`: ```c WINE_DECLARE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); struct threadpool_group { LONG refcount; BOOL shutdown; CRITICAL_SECTION cs; /* list of group members, locked via .cs */ struct list members __WINE_FIELD_GUARDED_BY(threadpool_group, cs); }; WINE_DEFINE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); ``` Clang will therefore warn if `members` is accessed without holding `cs`. Note that the analyzer does not support conditional locking. For that reason, functions that hold and release a lock conditionally have been marked with `__WINE_NO_THREAD_SAFETY_ANALYSIS` to pre-empt false positives from Clang. -- v5: dlls/amstream/tests: Disable thread safety analysis for testfilter_wait_state. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6623

1 0

[PATCH 0/5] MR6613: win32u: Introduce a new NtUserSetRawWindowPos call for the drivers.
by Rémi Bernon (＠rbernon) 07 Oct '24

07 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6613

3 7

2025

2024

2023

2022

wine-gitlab