On Sat Sep 21 20:51:46 2024 +0000, Philipp Knechtges wrote:
> TBH, I do not really know what to make of this assessment. Looking at
> the d2d1 tests it feels like, correctness is at best achieved
> approximately, and then the question arises what is the metric in which
> "correctness" is assessed? Unarguably, the tests as a metric are a
> moving target, depending on when which tests are added, thus making it a
> subjective choice at times.
> In my book, the patch at hand makes the rendering more correct in many
> cases. To be precise in all cases in which the individual geometries in
> the geometry group do not intersect, and thus the fill mode does not
> matter. Would you consider the patch sufficient, if it would
> (approximately) check for intersections and only copy if there are none,
> and falling back to old behavior (rendering just nothing) in case there
> are any (potentially false-positive) intersections?
It wouldn't consider it sufficient, it's clear that there is more to it than copying data from individual geometries. So the question is the same - what needs to be done to make it work properly, once it's understood, we could implement it partially if it's too hard to do properly.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_83622
--
v3: propsys: Initially implement PropVariantToVariant.
propsys: Support converting clsid to string for PropVariant.
propsys/tests: Test converting clsid to string.
propsys/tests: Add tests for PropVariantToVariant.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6526
This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for
* WlanEnumInterfaces
* WlanGetAvailableNetworkList
* WlanGetAvailableNetworkList
* WlanGetNetworkBssList
* WlanScan
--
v11: wlanapi: Add NetworkManager backed implementation for WlanGetProfileList.
wlanapi/tests: Add unit tests for WlanGetProfileList.
wlanapi: Add stub for WlanGetProfileList.
wlanapi: Add NetworkManager backed implementation for WlanScan.
wlanapi/tests: Add unit tests for WlanScan.
wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList.
wlanapi/tests: Add unit test for test_WlanGetNetworkBssList.
wlanapi: Add stub for WlanGetNetworkBssList.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6505
--
v4: server: Eliminate async_alerted() helper function.
server: Eliminate async_unknown_status() helper function.
server: Remove "unknown_status" field from struct async.
server: Remove "alerted" field from struct async.
server: Remove "terminated" field from struct async.
server: Remove "signaled" field from struct async.
server: Remove "direct_result" field from struct async.
server: Signal async unconditionally in async_set_result().
server: Introduce a new async state enum.
server: Introduce async_unknown_status() helper to compute the 'unknown_status' flag.
server: Introduce async_alerted() helper to compute the 'alerted' flag.
server: Introduce async_terminated() helper to compute the 'terminated' flag.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6369
This is part XXVI of cmd engine rewrite.
It mainly tackles which variable name (single letter) are supported as FOR
loop variables.
We recently extended the scope of letters (a-z, A-Z) with digits (0-9).
A couple of bug reports show that more are supported.
More manual testing show that all 7bit ASCII characters are supported
(except the ones handled by lexer like CR, LR, \0, <SPACE>, <TAB>,
ctrl-Z...).
This serie:
- add a couple of new tests for FOR loop variables (also testing limits
on tokens= options for setting at once several contiguous variables)
- fix all exhibited bugs
- rewrite parsing and handling of tokens= option (simplicity, correctness).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6577