- wine-gitlab - winehq.org

[PATCH v3 0/2] MR6548: nsiproxy: Only set the connection count from tcp_conns_enumerate_all/udp_endpoint_enumerate_all when appropriate.
by Tim Clem (＠tclem) 23 Sep '24

23 Sep '24

Fixes heap corruption downstream in NsiEnumerateObjectsAllParametersEx. Fixes regressions from 9085bc7b87f and a3f737f6143. --- I missed this piece of logic in MR !6399. The original line that implemented it is this: https://gitlab.winehq.org/wine/wine/-/blob/1d05064e747f9998fd705345659030e6… -- v3: nsiproxy: Only set the endpoint count from udp_endpoint_enumerate_all when appropriate. nsiproxy: Only set the connection count from tcp_conns_enumerate_all when appropriate. https://gitlab.winehq.org/wine/wine/-/merge_requests/6548

4 4

[PATCH v2 0/2] MR6548: nsiproxy: Only set the connection count from tcp_conns_enumerate_all/udp_endpoint_enumerate_all when appropriate.
by Tim Clem (＠tclem) 23 Sep '24

23 Sep '24

Fixes heap corruption downstream in NsiEnumerateObjectsAllParametersEx. Fixes regressions from 9085bc7b87f and a3f737f6143. --- I missed this piece of logic in MR !6399. The original line that implemented it is this: https://gitlab.winehq.org/wine/wine/-/blob/1d05064e747f9998fd705345659030e6… -- v2: nsiproxy: Only set the connection count from udp_endpoint_enumerate_all when appropriate. https://gitlab.winehq.org/wine/wine/-/merge_requests/6548

3 3

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

On Mon Sep 23 16:17:10 2024 +0000, Zephyr Lykos wrote: > Thanks! Thanks for letting me know and bisecting! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83050

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Zephyr Lykos (＠self) 23 Sep '24

23 Sep '24

On Mon Sep 23 16:13:24 2024 +0000, Paul Gofman wrote: > I sent a fix: https://gitlab.winehq.org/wine/wine/-/merge_requests/6547 Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83049

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

On Mon Sep 23 15:39:41 2024 +0000, Paul Gofman wrote: > Nevermind, I think I reproduced it (downloaded the theme from somewhere > and it looks like it is not supposed to be pink). I'll take a look. I sent a fix: https://gitlab.winehq.org/wine/wine/-/merge_requests/6547 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83046

1 0

[PATCH v6 0/9] MR6323: winewayland: Support GL/VK rendering in child windows (alt).
by Rémi Bernon (＠rbernon) 23 Sep '24

23 Sep '24

-- v6: winewayland: Let the render threads commit changes to client surfaces. winewayland: Attach client client surfaces to their toplevel surface. winewayland: Pass the client surface rect to wayland_surface_reconfigure_client. winewayland: Split wayland_win_data_update_wayland_surface helper. winewayland: Update the client separately from the window surface updates. winewayland: Keep the toplevel hwnd on the wayland_client_surface. winewayland: Call ensure_window_surface_contents with the toplevel window. winewayland: Use window DPI for the OpenGL client surface size. win32u: Notify drivers of the child surfaces state when their ancestor moves. https://gitlab.winehq.org/wine/wine/-/merge_requests/6323

3 13

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

On Mon Sep 23 15:19:03 2024 +0000, Paul Gofman wrote: > > This breaks `Luna.msstyles`: > Could you please give the full details how can I reproduce the issue: > - Wine doesn't have Luna mssstyle, how do you get and install it exactly? > - What is the exact problem, it is not apparent to me from the screenshot? Nevermind, I think I reproduced it (downloaded the theme from somewhere and it looks like it is not supposed to be pink). I'll take a look. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83038

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

> This breaks `Luna.msstyles`: Could you please give the full details how can I reproduce the issue: - Wine doesn't have Luna mssstyle, how do you get and install it exactly? - What is the exact problem, it is not apparent to me from the screenshot? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83035

1 0

[PATCH v10 0/11] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v10: wlanapi/tests: Add unit tests for WlanGetProfileList. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 12

[PATCH v9 0/11] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v9: wlanapi/tests: Add unit tests for WlanGetProfileList. wlanapi: Add stub for WlanGetProfileList. wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. wlanapi: Add stub for WlanGetNetworkBssList. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 12

[PATCH v8 0/9] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v8: wlanapi: Add stub for WlanGetProfileList. wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 10

[PATCH 0/4] MR6545: mfsrcsnk: Improve EOS handling and expose unknown streams.
by Rémi Bernon (＠rbernon) 23 Sep '24

23 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6545

2 4

[PATCH v2 0/2] MR6536: mfplat: Fill user data when converting VIDEOINFOHEADER formats.
by Rémi Bernon (＠rbernon) 23 Sep '24

23 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56975 -- v2: mfplat: Fill user data when converting VIDEOINFOHEADER formats. mfplat/tests: Add tests for VIDEOINFOHEADER(2) user data conversion. https://gitlab.winehq.org/wine/wine/-/merge_requests/6536

3 4

[PATCH v24 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v24: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

3 14

[PATCH v3 0/1] MR6542: winedump: Dump CLR metadata.
by Hans Leidekker (＠hans) 23 Sep '24

23 Sep '24

-- v3: winedump: Dump CLR metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/6542

2 1

[PATCH v2 0/1] MR6542: winedump: Dump CLR metadata.
by Hans Leidekker (＠hans) 23 Sep '24

23 Sep '24

-- v2: winedump: Dump CLR metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/6542

2 1

[PATCH 0/1] MR6542: winedump: Dump CLR metadata.
by Hans Leidekker (＠hans) 23 Sep '24

23 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6542

2 1

[PATCH v3 0/12] MR6369: Draft: Refactor the async state flags
by Jinoh Kang (＠iamahuman) 22 Sep '24

22 Sep '24

-- v3: server: Eliminate async_alerted() helper function. server: Eliminate async_unknown_status() helper function. server: Remove "unknown_status" field from struct async. server: Remove "alerted" field from struct async. server: Remove "terminated" field from struct async. server: Remove "signaled" field from struct async. server: Remove "direct_result" field from struct async. server: Signal async unconditionally in async_set_result(). server: Introduce a new async state enum. https://gitlab.winehq.org/wine/wine/-/merge_requests/6369

2 12

[PATCH v6 0/8] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 22 Sep '24

22 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v6: wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. wlanapi: Add NetworkManager backed implementation for WlanGetAvailableNetworkList. wlanapi/tests: Add unit test for WlanGetAvailableNetworkList. wlanapi: Add NetworkManager backed implementation for WlanEnumInterfaces. wlanapi: Add a basic unixlib implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 9

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Zephyr Lykos (＠self) 22 Sep '24

22 Sep '24

cc @gofman - any thoughts for a fix that does not affect performance too much? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_82962

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Zephyr Lykos (＠mochaaP) 22 Sep '24

22 Sep '24

This breaks `Luna.msstyles`: ![luna.msstyles broken on 9.18](/uploads/83a195c4a2dc65cdd1c80754b7bbc86a/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_82961

1 0

[PATCH v23 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v23: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 13

[PATCH v22 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v22: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 12

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Philipp Knechtges (＠d1saster) 21 Sep '24

21 Sep '24

On Wed Sep 18 15:58:22 2024 +0000, Nikolay Sivov wrote: > I think it is, because it will produce incorrect rendering. First > priority is to have it working correctly, then we can deal with possible duplication. TBH, I do not really know what to make of this assessment. Looking at the d2d1 tests it feels like, correctness is at best achieved approximately, and then the question arises what is the metric in which "correctness" is assessed? Unarguably, the tests as a metric are a moving target, depending on when which tests are added, thus making it a subjective choice at times. In my book, the patch at hand makes the rendering more correct in many cases. To be precise in all cases in which the individual geometries in the geometry group do not intersect, and thus the fill mode does not matter. Would you consider the patch sufficient, if it would (approximately) check for intersections and only copy if there are none, and falling back to old behavior (rendering just nothing) in case there are any (potentially false-positive) intersections? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_82945

1 0

[PATCH v21 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v21: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 17

2025

2024

2023

2022

wine-gitlab