- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR6528: netapi32: Add a stub NetFreeAadJoinInformation function.
by Louis Lenders (＠xe) 20 Sep '24

20 Sep '24

>It gracefully handles our ERROR_CALL_NOT_IMPLEMENTED from NetGetAadJoinInformation. Why is does it return ERROR_CALL_NOT_IMPLEMENTED when this is a HRESULT? Shouldn't it return E_NOTIMPL? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6528#note_82773

1 0

[PATCH v5 0/4] MR4443: Do not release media session topologies until the media session is shutdown.
by Santino Mazza (＠tati1454) 20 Sep '24

20 Sep '24

-- v5: mf: Shutdown all used topologies by media session. mf/tests: Test how session releases not queued topologies. mf: Only shutdown current topology when session is shutdown. mf/tests: Test for topology reuse after session ends. https://gitlab.winehq.org/wine/wine/-/merge_requests/4443

3 6

[PATCH 0/6] MR6537: Cmd engine rewrite (part XXV)
by eric pouech (＠epo) 20 Sep '24

20 Sep '24

This is part XXV of command engine rewrite. This MR tackles three items: - fixing some corner cases in variable expansion. Note, there's still todo_wine in the non regression tests, but I don't feel like fixing them for now (like an un-paired ! within double quotes when delayed expansion is enabled - which behaves differently then not within double quotes) - breaking out of FOR loops with 'EXIT /B'. I'm damn sure I dealt with this earlier on, it likely fails into the cracks during some rebase. - somme builtin commands behave differently when run from .BAT or .CMD files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6537

3 7

[PATCH 0/1] MR6536: mfplat: Fill user data when converting VIDEOINFOHEADER formats.
by Rémi Bernon (＠rbernon) 20 Sep '24

20 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56975 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6536

3 2

[PATCH v2 0/6] MR6534: dplayx: EnumSessions() part 4
by Anton Baskanov (＠baskanov) 20 Sep '24

20 Sep '24

-- v2: dplayx: Check ENUMSESSIONSREPLY size before access. dplayx: Check the message size before access. dplayx/tests: Correctly compute session enumeration reply size. dplayx: Send password in session enumeration request. dplayx: Reduce nesting of the async enumeration code. https://gitlab.winehq.org/wine/wine/-/merge_requests/6534

4 10

Re: [PATCH v3 0/7] MR6517: mfsrcsnk: Read samples from the media source demuxer.
by Derek Lesho (＠dlesho) 20 Sep '24

20 Sep '24

On Wed Sep 18 13:32:52 2024 +0000, Rémi Bernon wrote: > Maybe, but I don't think it matters so much here. It's just reading > compressed samples here, so copy size stays relatively small. Do you intend on also enabling protonvideoconvert through winedmo? If so, wouldn't we have to do it in the demuxer (doesn't mp4 demuxer also require steam://unlockh264), at which point this might be relavant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6517#note_82731

1 0

[PATCH 0/6] MR6534: dplayx: EnumSessions() part 4
by Anton Baskanov (＠baskanov) 20 Sep '24

20 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6534

3 7

[PATCH 0/2] MR6533: winegstreamer: Tweak h264 caps conversion.
by Rémi Bernon (＠rbernon) 20 Sep '24

20 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6533

4 4

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Rémi Bernon (＠rbernon) 19 Sep '24

19 Sep '24

Virtualizing the swapchain is the better and more general plan and something we'd need to do for Wayland cross-process rendering anyway. Implementing composition on the win32u level will take care of it in a generic way, though we probably want to keep the direct rendering path as a default and best option. This current approach is a best effort with what we have right now, it unlocks various applications which required VK child window rendering, and is cheap enough and doesn't introduce much problems as it simply does the same as GL. Both GL and VK would then be addressed the same way for composition, through dma-buf export (or the equivalent macOS primitive) and shared resources. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82704

1 0

[PATCH 0/1] MR6527: dinput8: Prefer the native DLL.
by Aida Jonikienė (＠DodoGTA) 19 Sep '24

19 Sep '24

Many mod/ASI loaders hijack this DLL to do their work so accommodate this fairly common case by preferring their library. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6527

9 15

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Elizabeth Figura (＠zfigura) 19 Sep '24

19 Sep '24

> > VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. > > That's unfortunate, I was thinking VK_KHR_present_wait will solve these problems (which are real WRT games too in some cases) until we have a "direct composition" implementation. Are you sure that this is supposed and actual behaviour? It's the spec behaviour, actually. I didn't test whether it works in practice, and it's not unlikely that it does work in practice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82702

1 0

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Paul Gofman (＠gofman) 19 Sep '24

19 Sep '24

> VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. That's unfortunate, I was thinking VK_KHR_present_wait will solve these problems (which are real WRT games too in some cases) until we have a "direct composition" implementation. Are you sure that this is supposed and actual behaviour? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82701

1 0

[PATCH 0/1] MR6531: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 19 Sep '24

19 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6531

2 1

Re: [PATCH v3 0/5] MR6524: tools: Replace sprintf with snprintf to avoid deprecation warnings on macOS. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6524

1 0

Re: [PATCH v2 0/10] MR6529: desk.cpl: Introduce new control panel applet. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6529

1 0

Re: [PATCH v4 0/1] MR6372: winewayland: Make the pointer protocols optional. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6372

1 0

Re: [PATCH v2 0/1] MR6530: ntdll: Ensure Unix path strings are wrapped with debugstr_a in traces. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6530

1 0

Re: [PATCH v2 0/1] MR6528: netapi32: Add a stub NetFreeAadJoinInformation function. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6528

1 0

Re: [PATCH v4 0/7] MR6519: win32u: Get rid of NtUserIsWindowRectFullScreen calls. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6519

1 0

Re: [PATCH v2 0/2] MR6525: Remove some pre-macOS 10.12 workarounds (clock_gettime and mach_continuous_time) - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6525

1 0

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Elizabeth Figura (＠zfigura) 19 Sep '24

19 Sep '24

I don't think this architecture is going to work. It probably isn't evident from games testing, but there is a synchronization problem here. We can't simply do vkQueuePresent() and then copy from the corresponding X11 drawable, because vkQueuePresent() won't guarantee that the bits have reached the X11 drawable yet. For GLX this approach is fine, assuming we have GLX_OML_sync_control. In that case waiting for SBC is exactly what we need. Vulkan doesn't have an equivalent extension. VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. This means we probably need to virtualize the whole swapchain, unfortunately, and either create a Vulkan swapchain on the relevant top-level window, or use DRI3 to interop between Vulkan and X11 without a swapchain. In this case vkQueuePresent() would of course not present directly. We could also try to invent an extension that lets us do what GLX_OML_sync_control does, but I fear that Mesa and/or Khronos will push back on this, and basically tell us to fix it on our end, by virtualizing the swapchain... There may be reasons we can't virtualize the swapchain that I'm not thinking of. I also have zero knowledge of Wayland and don't know how to fit that into anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82685

1 0

[PATCH v2 0/5] MR6524: tools: Replace sprintf with snprintf to avoid deprecation warnings on macOS.
by Brendan Shanks (＠bshanks) 19 Sep '24

19 Sep '24

Excluding winedump for now, since it has a lot of tricky sprintf calls to replace -- v2: wrc: Replace sprintf with snprintf to avoid deprecation warnings on macOS. wmc: Replace sprintf with snprintf to avoid deprecation warnings on macOS. winebuild: Replace sprintf with snprintf to avoid deprecation warnings on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6524

4 8

[PATCH 0/1] MR6447: winegstreamer/wm_reader: Use codec format only for compressed types.
by Ziqing Hui (＠zhui) 19 Sep '24

19 Sep '24

The intention of wg_parser_stream_get_codec_format is to return the codec for compressed stream. We shouldn't use it for uncompressed result. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6447

4 17

[PATCH 0/2] MR6521: win32u: Implement a ForceDpiAwareness registry option.
by Rémi Bernon (＠rbernon) 19 Sep '24

19 Sep '24

Under the HKCU\Software\Wine\X11 Driver global or application-specific HKCU\Software\Wine\AppDefaults\app.exe\X11 Driver registry keys. This option can be used to restore the old behavior with DPI awareness forced on every application, which some of them handled well enough even if not DPI aware otherwise. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57175 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6521

4 6

[PATCH v3 0/1] MR6372: winewayland: Some init changes.
by Aida Jonikienė (＠DodoGTA) 19 Sep '24

19 Sep '24

-- v3: winewayland: Make the pointer protocols optional. https://gitlab.winehq.org/wine/wine/-/merge_requests/6372

4 7

2025

2024

2023

2022

wine-gitlab