On Mon Sep 9 23:07:07 2024 +0000, Jacek Caban wrote:
> It looks like you pushed a version that has 0 commits compared to upstream.
I tried to push the changes again. The new commit is now visible (at least for me).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81716
[Documentation for EnumSystemLocalesA/W](https://learn.microsoft.com/en-us/windows/win32/api/w… says "If [`LCID_ALTERNATE_SORTS`] is used with either `LCID_INSTALLED` or `LCID_SUPPORTED`, the installed or supported locales are retrieved, **as well as** the alternate sort locale identifiers." (emphasis mine).
Until now, Wine *only* returned alternate sorts in this case, which apparently breaks some versions of NexusDB.
This MR fixes the issue and adds some basic tests to ensure the issue isn't accidentally re-introduced at a later time.
--
v6: kernel32/tests: Add basic tests for EnumSystemLocalesA/W
https://gitlab.winehq.org/wine/wine/-/merge_requests/6455
[Documentation for EnumSystemLocalesA/W](https://learn.microsoft.com/en-us/windows/win32/api/w… says "If [`LCID_ALTERNATE_SORTS`] is used with either `LCID_INSTALLED` or `LCID_SUPPORTED`, the installed or supported locales are retrieved, **as well as** the alternate sort locale identifiers." (emphasis mine).
Until now, Wine *only* returned alternate sorts in this case, which apparently breaks some versions of NexusDB.
This MR fixes the issue and adds some basic tests to ensure the issue isn't accidentally re-introduced at a later time.
--
v5: kernel32: Add basic tests for EnumSystemLocalesA/W
kernelbase: Fix EnumSystemLocalesA/W filtering of default/alternate sort orders.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6455
This introduces a new alternative FFmpeg-based implementation for the
MF byte stream handlers, while keeping the current GStreamer-based as
default.
The new implementation can be enabled by setting the DWORD value:
DisableGstByteStreamHandler = 1
in the HKCU\Software\Wine\MediaFoundation registry key.
--
v2: mfsrcsnk: Stub byte stream handlers if demuxing is supported.
winedmo: Export a new winedmo_demuxer_check function.
winedmo: Link and initialize FFmpeg on load.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6442
[Documentation for EnumSystemLocalesA/W](https://learn.microsoft.com/en-us/windows/win32/api/w… says "If [`LCID_ALTERNATE_SORTS`] is used with either `LCID_INSTALLED` or `LCID_SUPPORTED`, the installed or supported locales are retrieved, **as well as** the alternate sort locale identifiers." (emphasis mine).
Until now, Wine *only* returned alternate sorts in this case, which apparently breaks some versions of NexusDB.
This MR fixes the issue and adds some basic tests to ensure the issue isn't accidentally re-introduced at a later time.
--
v3: Add basic tests for EnumSystemLocalesA/W
Fix EnumSystemLocalesA/W filtering of default/alternate sort orders.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6455
This fixes a bug in EastMoney, which calls SetFileTypes() with a COMDLG_FILTERSPEC structure in which pszSpec = L"" followed by SetFileName(L"*.fml"). In windows, this matches all *.fml files. In wine, this matched no files. Before this patch, wine did not use filters from the file name field (marked as a FIXME) and a file type entry with an empty spec would match no files (as opposed to leaving the current filter unmodified).
The exact rules worked out by testing in a Windows 10 VM seem to be:
Current filter is initially empty and can be set by typing a filter
into the file name field (or SetFileName) or selecting an entry from the file type menu (or SetFileTypeIndex).
Selecting a file type entry with an empty spec leaves the current filter unchanged.
Selecting a file type entry with a non-empty spec clears the file name field if it currently contains a filter.
This was tested using https://github.com/microsoft/Windows-classic-samples/blob/main/Samples/Win7… (MIT Licensed). There is a c_rgSaveTypes variable at the top which can be modified to various configurations (especially ones that include a COMDLG_FILTERSPEC with an empty pszSpec)
--
v3: comdlg32: add tests for itemdlg file name field filters
comdlg32: allow entering a filter in the itemdlg file name field
https://gitlab.winehq.org/wine/wine/-/merge_requests/6443
The tests should go along with the existing ones in dlls/kernel32/tests/locale.c.
Also please write a more specific commit message, "behave according to documentation" can apply to just about anything.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6455#note_81668
Previously, map_font() could return a font that does not directly
support the requested codepage but has a child font that does. By
enumerating fonts for the specific charset, as well as checking each
candidate font's signature, the returned font now directly supports the
codepage.
--
v2: mlang: Use EnumFontFamiliesEx() in map_font().
https://gitlab.winehq.org/wine/wine/-/merge_requests/6450
This fixes a bug in EastMoney, which calls SetFileTypes() with a COMDLG_FILTERSPEC structure in which pszSpec = L"" followed by SetFileName(L"*.fml"). In windows, this matches all *.fml files. In wine, this matched no files. Before this patch, wine did not use filters from the file name field (marked as a FIXME) and a file type entry with an empty spec would match no files (as opposed to leaving the current filter unmodified).
The exact rules worked out by testing in a Windows 10 VM seem to be:
Current filter is initially empty and can be set by typing a filter
into the file name field (or SetFileName) or selecting an entry from the file type menu (or SetFileTypeIndex).
Selecting a file type entry with an empty spec leaves the current filter unchanged.
Selecting a file type entry with a non-empty spec clears the file name field if it currently contains a filter.
This was tested using https://github.com/microsoft/Windows-classic-samples/blob/main/Samples/Win7… (MIT Licensed). There is a c_rgSaveTypes variable at the top which can be modified to various configurations (especially ones that include a COMDLG_FILTERSPEC with an empty pszSpec)
--
v2: comdlg32: allow entering a filter in the itemdlg file name field
https://gitlab.winehq.org/wine/wine/-/merge_requests/6443