- wine-gitlab - winehq.org

[PATCH 0/2] MR7938: Draft: winemac: Use IOSurface to update native window layers instead of CGImage.
by Marc-Aurel Zent (＠mzent) 22 May '25

22 May '25

This consolidates the two separate `CGImage`s (`colorImage` and `shapeImage`) previously used in `WineContentView` into a single `IOSurface` that also holds the window mask information in its alpha channel now. The alpha channel is now being updated in `macdrv_surface_flush`, whenever the shape changes (and stores that change for the next update, to also keep the front buffer in sync). This reduces the delay from setting a `CGImage` to a layer from 50ms to about 1.5ms in the `IOSurface` case (also accounting for `vImageSelectChannels_ARGB8888` operation). Based on a patch by @bshanks. I am already putting it out for feedback, but I will so some more testing to see how the performance impact of this is and do more exhaustive testing with shaped windows. Ideally the double buffer solution can be avoided as well... Also the `HBITMAP` for the windows is currently backed by a `CGDataProviderRef` and could also become an `IOSurface` I believe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7938

3 11

Re: [PATCH v6 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) 22 May '25

22 May '25

On Thu May 22 22:07:54 2025 +0000, Alexander Shaikhulin wrote: > (32-bit FreeBSD apps on amd64 don't run into this issue because they use > int 0x80 / iret.) This is the most concise explanation that I found: https://github.com/torvalds/linux/blob/a11a72229881d8ac1d52ea727101bc9c7441…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8073#note_104276

1 0

[PATCH v3 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) 22 May '25

22 May '25

Fix out-of-bound access by wcslen. Found by ASan. -- v3: mscoree: Add missing NUL terminator. https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

2 2

[PATCH 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) 22 May '25

22 May '25

Fix out-of-bound access by wcslen. Found by ASan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

2 1

Re: [PATCH v6 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) 22 May '25

22 May '25

On Thu May 22 21:42:35 2025 +0000, Alexandre Julliard wrote: > Please keep the Linux and FreeBSD case separate, unless they are truly identical. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8073#note_104269

1 0

[PATCH v5 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) 22 May '25

22 May '25

1. For %fs/fsbase the patch follows the macOS logic with LDT descriptor registration and Linux with switching. One notable difference is that on 32->64 transition we set %fs to GSEL(GUFS32_SEL, SEL_UPL) before restoring fsbase, otherwise FreeBSD will just revert it by reloading the selector [at the first opportunity](https://github.com/freebsd/freebsd-src/blob/5673462af5330df207…. GSEL(GUFS32_SEL, SEL_UPL) is the default %fs value on FreeBSD and is special-cased to save/restore actual fsbase value to/from PCB. 2. I was told we could get rid of fsbase glitches in signal handlers by blocking signals with [sigfastblock(2)](https://man.freebsd.org/cgi/man.cgi?query=sigfastblock) between %fs reset to the default value and fsbase reset to pthread_teb. This is currently a part of internal API for libthr, which could be exposed as pthread_signal_block_np for Wine. I'm on the fence whether it's worth it. 3. I fully admit I have no idea what registers are worth preserving around fallback sysarch(AMD64_SET_FSBASE) syscalls and whether it's appropriate to push those registers to stack. ("Kernel" stack should be fine, I assume?) Syscalls definitely clobber r8-r11. 4. For %ss see https://lkml.org/lkml/2015/4/24/216. FreeBSD doesn't have a similar workaround in the kernel, so it goes into Wine. -- v5: ntdll: Unbreak new wow64 mode on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/8073

2 1

[PATCH v4 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) 22 May '25

22 May '25

1. For %fs/fsbase the patch follows the macOS logic with LDT descriptor registration and Linux with switching. One notable difference is that on 32->64 transition we set %fs to GSEL(GUFS32_SEL, SEL_UPL) before restoring fsbase, otherwise FreeBSD will just revert it by reloading the selector [at the first opportunity](https://github.com/freebsd/freebsd-src/blob/5673462af5330df207…. GSEL(GUFS32_SEL, SEL_UPL) is the default %fs value on FreeBSD and is special-cased to save/restore actual fsbase value to/from PCB. 2. I was told we could get rid of fsbase glitches in signal handlers by blocking signals with [sigfastblock(2)](https://man.freebsd.org/cgi/man.cgi?query=sigfastblock) between %fs reset to the default value and fsbase reset to pthread_teb. This is currently a part of internal API for libthr, which could be exposed as pthread_signal_block_np for Wine. I'm on the fence whether it's worth it. 3. I fully admit I have no idea what registers are worth preserving around fallback sysarch(AMD64_SET_FSBASE) syscalls and whether it's appropriate to push those registers to stack. ("Kernel" stack should be fine, I assume?) Syscalls definitely clobber r8-r11. 4. For %ss see https://lkml.org/lkml/2015/4/24/216. FreeBSD doesn't have a similar workaround in the kernel, so it goes into Wine. -- v4: ntdll: Unbreak new wow64 mode on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/8073

3 8

Re: [PATCH v2 0/5] MR8123: winex11: Track _MOTIF_WM_HINTS property in the window state. - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8123

1 0

Re: [PATCH v2 0/1] MR8119: odbc32: Destroy child objects automatically on successful SQLDisconnect(). - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8119

1 0

Re: [PATCH v2 0/2] MR8118: masdo15: Add connection_OpenSchema implementation. - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8118

1 0

Re: [PATCH v2 0/1] MR8113: libs/ldap: Save server attributes also on 2nd authentication step. - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8113

1 0

Re: [PATCH v2 0/1] MR8117: Revert "winex11: Focus the desktop window when _NET_ACTIVE_WINDOW is None." - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8117

1 0

Re: [PATCH v3 0/3] MR8112: Enable compiler exceptions on Clang for 64-bit MSVC targets. - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8112

1 0

Re: [PATCH v2 0/1] MR8082: windowscodecs/tiff: Fix source buffer size for 16bpp format (ASan). - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8082

1 0

Re: [PATCH v2 0/2] MR8083: windowscodecs/tiff: Remove remaining endianess compiler checks. - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8083

1 0

Re: [PATCH v5 0/5] MR8037: widl: Initial support for generating Windows Runtime metadata. - approved
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8037

1 0

[PATCH v2 0/2] MR8122: Draft: taskschd: Implements IRegisteredTaskCollection get_Item().
by Jacob Czekalla (＠JacobCzekalla) 22 May '25

22 May '25

Implements IRegisteredTaskCollection get_Item(). -- v2: taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8122

2 2

Re: [PATCH v2 0/1] MR7747: ntdll: Guess optical disc type based on data size.
by Alexandre Julliard (＠julliard) 22 May '25

22 May '25

> There is probably some tiny DVD somewhere in the world that will still be misdetected, but I'm not sure that issuing SCSI commands to the drive to try to determine the disc type would be any more reliable. To support an app that is most likely going to issue DVD ioctls, checking by using a DVD ioctl seems preferable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7747#note_104243

1 0

[PATCH v2 0/7] MR8115: win32u: Open EGL display and configs on behalf of the drivers.
by Rémi Bernon (＠rbernon) 22 May '25

22 May '25

-- v2: wineandroid: Use win32u for EGL display and pixel formats. winewayland: Use win32u for EGL display and pixel formats. win32u: Implement OpenGL pixel formats over EGL configs. win32u: Introduce an EGL opengl_driver_function table. winewayland: Use the EGL display opened from win32u. wineandroid: Use the EGL display opened from win32u. win32u: Open and initialize an EGL platform display. https://gitlab.winehq.org/wine/wine/-/merge_requests/8115

3 9

[PATCH 0/5] MR8123: winex11: Track _MOTIF_WM_HINTS property in the window state.
by Rémi Bernon (＠rbernon) 22 May '25

22 May '25

And a couple of other minor and (hopefully) harmless changes, in preparation for !8079 as it would otherwise grow large. The main thing here is the introduction of _MOTIF_WM_HINTS into the state tracker, changing the property can trigger unexpected ConfigureNotify events and we will need to serialize its updates with other _NET_WM_STATE and window config requests in order to avoid getting surprised and confused. It will also later be useful to be able to track further consequences of _MOTIF_WM_HINTS changes on Mutter-based window managers, such as a ReparentNotify > UnmapNotify > FocusOut > MapNotify > FocusIn > ConfigureNotify event sequence, to eventually ignore the transient focus loss and avoid changing Win32 foreground window during it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8123

2 5

[PATCH 0/1] MR8119: odbc32: Destroy child objects automatically on successful SQLDisconnect().
by Nikolay Sivov (＠nsivov) 22 May '25

22 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8119

3 2

[PATCH v2 0/1] MR8111: win32u: Implement NtGdiDdDDIOpenAdapterFromDeviceName().
by Paul Gofman (＠gofman) 22 May '25

22 May '25

-- v2: win32u: Implement NtGdiDdDDIOpenAdapterFromDeviceName(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8111

2 2

[PATCH 0/2] MR8122: taskschd: Implements IRegisteredTaskCollection get_Item().
by Jacob Czekalla (＠JacobCzekalla) 22 May '25

22 May '25

Implements IRegisteredTaskCollection get_Item(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8122

2 2

[PATCH 0/2] MR8120: wow64: Convert SCSI_PASS_THROUGH and SCSI_PASS_THROUGH_DIRECT structures in wow64_NtDeviceIoControlFile.
by Akihiro Sagawa (＠sgwaki) 22 May '25

22 May '25

Otherwise, NtDeviceIoControlFile fails because of a structure size mismatch. This happens since SCSI_PASS_THROUGH_DIRECT and SCSI_PASS_THROUGH structures contain a pointer-type member, which is 4 bytes in a 32-bit system and 8 bytes in a 64-bit system. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58257 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8120

3 3

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) 22 May '25

22 May '25

On Thu May 22 14:53:16 2025 +0000, Dmitry Timoshkov wrote: > Shouldn't also work {NULL,0} as a SECBUFFER_STREAM output? Maybe, this doesn't appear to be documented. I guess we need tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104217

1 0

2025

2024

2023

2022

wine-gitlab