- wine-gitlab - winehq.org

[PATCH 0/1] MR6356: mfplat: Fix pointer dereference when caching buffer data.
by Rémi Bernon (＠rbernon) 26 Aug '24

26 Aug '24

Fixes: 035012be26aa59675ca3209f428e597f8efa7015 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6356

3 2

[PATCH 0/1] MR6355: mfmediaengine: Remove duplicate classes IDL.
by Rémi Bernon (＠rbernon) 26 Aug '24

26 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6355

3 2

[PATCH 0/1] MR6349: widl: Remove unused variable.
by Huw Davies (＠huw) 26 Aug '24

26 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6349

4 5

[PATCH 0/3] MR6359: arm64: Add support for more IsProcessorFeaturePresent flags
by Martin Storsjö (＠mstorsjo) 26 Aug '24

26 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6359

3 4

[PATCH v2 0/4] MR6330: H264enc
by Ziqing Hui (＠zhui) 26 Aug '24

26 Aug '24

-- v2: winegstreamer/video_encoder: Initially implement ProcessOutput. winegstreamer/video_encoder: Add ICodecAPI stubs. mf/tests: Test codecapi for h264 encoder. mf/tests: Test h264 encoder sample processing. https://gitlab.winehq.org/wine/wine/-/merge_requests/6330

4 6

[PATCH 0/1] MR6352: winegstreamer: Support IYUV alias for I420
by CreeperFace (＠dy-tea) 26 Aug '24

26 Aug '24

Credits to [mkrysm1](mailto:mkrsym1@gmail.com) for the patch. This patch fixes a video regression when mfplat is being used in conjunction with Unity in a certain piece of closed-source commercial software. See [fourcc](https://fourcc.org/pixel-format/yuv-i420/) for more information. Signed-off-by: Dylan Donnell <dylan.donnell(a)student.griffith.ie> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6352

4 3

[PATCH v2 0/10] MR6354: winex11, winemac: Route remaining user callbacks through user32.
by Rémi Bernon (＠rbernon) 26 Aug '24

26 Aug '24

And fix the regressions from part1. -- v2: user32: Remove NtUserDriverCallback* kernel callbacks. winemac: Route kernel callbacks through user32. winex11: Route kernel callbacks through user32. winex11: Use a UINT64 for the foreign_window_proc parameter. winex11: Wrap x11drv_dnd_post_drop params in a struct. winex11: Wrap x11drv_dnd_enter_event params in a struct. winex11: Wrap x11drv_dnd_drop_event params in a struct. opengl32: Remove unnecessary function addresses. opengl32: Add missing WOW64 process_attach unixlib entry. win32u: Add missing thunk lock parameters callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/6354

4 11

[PATCH v4 0/5] MR6331: win32u: Implement DPI scaled window surface.
by Rémi Bernon (＠rbernon) 26 Aug '24

26 Aug '24

Right now this should not do anything because all windows are per-monitor DPI aware. When this is changed this will automatically fall back to window surface scaling through `NtGdiStretchBlt` in win32u. This has the disadvantage that `NtGdiStretchBlt` is doing an absolutely terrible job at upscaling. This then adds a way for drivers to opt-in and do their own surface scaling before falling back to win32u. Alternatively and perhaps better, we could pull libcairo and use it to scale the surface contents with high quality filtering instead of using GDI. -- v4: win32u: Implement DPI scaled window surface. win32u: Move window_surface creation helper to dce.c. win32u: Map window rects DPI before calling into the drivers. win32u: Map window region DPI before calling into the drivers. win32u: Only allow a custom visible rect for toplevel windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6331

2 6

[PATCH 0/1] MR6357: win32u: Only allow a custom visible rect for toplevel windows.
by Rémi Bernon (＠rbernon) 26 Aug '24

26 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57102 Fixes: cb1c03b926ca01619be02f835f382c1dd7d4a478 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6357

2 1

[PATCH v5 0/2] MR6294: mlang: Fix bug when multibyte string truncation in ConvertINetMultiByteToUnicode
by Yeshun Ye (＠yeyeshun) 26 Aug '24

26 Aug '24

mlang/tests: Add test for multibyte string truncation mlang: Fix bug when multibyte string truncation in ConvertINetMultiByteToUnicode Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- v5: mlang: Fix bad characters in MBCS of ConvertINetMultiByteToUnicode mlang/tests: Add test for bad characters of MBCS https://gitlab.winehq.org/wine/wine/-/merge_requests/6294

3 3

[PATCH 0/10] MR6354: winex11, winemac: Route remaining user callbacks through user32.
by Rémi Bernon (＠rbernon) 26 Aug '24

26 Aug '24

And fix the regressions from part1. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6354

4 12

Re: [PATCH v2 0/5] MR6353: cmd: Run files with ShellExecute() if CreateProcess() fails. - approved
by Elizabeth Figura (＠zfigura) 26 Aug '24

26 Aug '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6353

1 0

[PATCH 0/5] MR6353: cmd: Run files with ShellExecute() if CreateProcess() fails.
by Elizabeth Figura (＠zfigura) 26 Aug '24

26 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6353

3 5

[PATCH v4 0/1] MR6347: advpack: DelNode support the ADN_DEL_IF_EMPTY flag
by Anders Kjersem (＠anders) 25 Aug '24

25 Aug '24

Fixes a bug where `rundll32.exe advpack.dll,DelNodeRunDLL32 "c:\test",1` is only supposed to delete "test" if the directory is empty. Also causes the [DelDirs Inf section](https://www.mdgx.com/INF_web/deldirs.htm) to work correctly. Notes: - I changed the code so it ignores the result of `SetFileAttributesW` because the user might not have FILE_WRITE_ATTRIBUTES even if they have DELETE rights. This seems to match Windows (XP NTFS). -- v4: advpack: DelNode support ADN_DEL_IF_EMPTY flag https://gitlab.winehq.org/wine/wine/-/merge_requests/6347

3 2

[PATCH v3 0/1] MR6347: advpack: DelNode support the ADN_DEL_IF_EMPTY flag
by Anders Kjersem (＠anders) 25 Aug '24

25 Aug '24

Fixes a bug where `rundll32.exe advpack.dll,DelNodeRunDLL32 "c:\test",1` is only supposed to delete "test" if the directory is empty. Also causes the [DelDirs Inf section](https://www.mdgx.com/INF_web/deldirs.htm) to work correctly. Notes: - I changed the code so it ignores the result of `SetFileAttributesW` because the user might not have FILE_WRITE_ATTRIBUTES even if they have DELETE rights. This seems to match Windows (XP NTFS). -- v3: advpack: DelNode support ADN_DEL_IF_EMPTY flag https://gitlab.winehq.org/wine/wine/-/merge_requests/6347

5 11

[PATCH 0/1] MR6351: win32u: Use unsigned bitfields.
by Huw Davies (＠huw) 25 Aug '24

25 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6351

2 1

[PATCH 0/1] MR6350: nsiproxy: Add linux guards for the IPv6 forward info.
by Huw Davies (＠huw) 25 Aug '24

25 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6350

3 2

Re: [PATCH v2 0/1] MR4483: nsiproxy.sys: Reduce scope of a variable in process_monitor_event - closed
by Huw Davies (＠huw) 25 Aug '24

25 Aug '24

This merge request was closed by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4483

1 0

Re: [PATCH v2 0/1] MR4483: nsiproxy.sys: Reduce scope of a variable in process_monitor_event
by Huw Davies (＠huw) 25 Aug '24

25 Aug '24

Superseded by !6350 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4483#note_79928

1 0

[PATCH 0/1] MR6306: msxml3: Fix compilation errors with Clang 18.
by Grigory Vasilyev (＠h0tc0d3) 24 Aug '24

24 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6306

4 7

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 24 Aug '24

24 Aug '24

On Sat Aug 24 19:23:49 2024 +0000, Vibhav Pant wrote: > Hm, the `BroadcastSystemMessage` calls wouldn't work since the > \`DBT_BROADCAST_DEVICEINTERFACE\` struct needs to be first constructed. > That being said, I have tried to added code that does that to 1/4. 1/4 > also shouldn't have any `DBT_DEVTYP_HANDLE` related code anymore, let me > know if that works. 1/4 also merges the old 1/4 commit, and has been split into 2 commits - for introducing `new_event` and friends. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79915

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 24 Aug '24

24 Aug '24

On Sat Aug 24 19:22:08 2024 +0000, Elizabeth Figura wrote: > Patch 1/4 still needs to be merged into 2/4. > The BroadcastSystemMessage() calls seem to have been inadvertently > removed in 2/4, and the split isn't quite complete—it still introduces > DBT_DEVTYP_HANDLE support in plugplay_send_event(). Ideally separating > the new_event() helper would also be a separate commit, so that you're > not moving code and changing it at the same time. Hm, the `BroadcastSystemMessage` calls wouldn't work since the \`DBT_BROADCAST_DEVICEINTERFACE\` struct needs to be first constructed. That being said, I have tried to added code that does that to 1/4. 1/4 also shouldn't have any `DBT_DEVTYP_HANDLE` related code anymore, let me know if that works. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79913

1 0

[PATCH v2 0/2] MR5234: win32u: Add registry keys for changing media center/tablet status.
by Aida Jonikienė (＠DodoGTA) 24 Aug '24

24 Aug '24

This is a heavily simplified version of Michael Müller's staging patch (the staging version got broken by the PE/Unix split) I rebased that staging patch but I thought it was too big for what it does (so I did this instead) As for automatically changing the status, SM_MEDIACENTER would require Windows version checks (which are never used in Wine) and SM_TABLETPC would likely require touchscreen/tablet detection (rbernon is working on some touch stuff so that could be useful) -- v2: win32u: Enable the media center metric by default. win32u: Add registry key for changing tablet status. https://gitlab.winehq.org/wine/wine/-/merge_requests/5234

2 3

[PATCH v30 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 24 Aug '24

24 Aug '24

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- v30: plugplay: Add support for DBT_DEVTYP_HANDLE device notifications. plugplay: Broadcast PnP events on a dedicated thread. plugplay: Separate deep-copying the received event into new_event. plugplay: Separate device broadcast event types into their own structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

3 5

[PATCH v31 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 24 Aug '24

24 Aug '24

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- v31: plugplay: Add support for DBT_DEVTYP_HANDLE device notifications. plugplay: Broadcast PnP events on a dedicated thread. plugplay: Separate deep-copying the received event into new_event. plugplay: Separate device broadcast event types into their own structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

2 4

2025

2024

2023

2022

wine-gitlab