- wine-gitlab - winehq.org

[PATCH 0/2] MR8122: taskschd: Implements IRegisteredTaskCollection get_Item().
by Jacob Czekalla (＠JacobCzekalla) 22 May '25

22 May '25

Implements IRegisteredTaskCollection get_Item(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8122

2 2

[PATCH 0/2] MR8120: wow64: Convert SCSI_PASS_THROUGH and SCSI_PASS_THROUGH_DIRECT structures in wow64_NtDeviceIoControlFile.
by Akihiro Sagawa (＠sgwaki) 22 May '25

22 May '25

Otherwise, NtDeviceIoControlFile fails because of a structure size mismatch. This happens since SCSI_PASS_THROUGH_DIRECT and SCSI_PASS_THROUGH structures contain a pointer-type member, which is 4 bytes in a 32-bit system and 8 bytes in a 64-bit system. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58257 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8120

3 3

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) 22 May '25

22 May '25

On Thu May 22 14:53:16 2025 +0000, Dmitry Timoshkov wrote: > Shouldn't also work {NULL,0} as a SECBUFFER_STREAM output? Maybe, this doesn't appear to be documented. I guess we need tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104217

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) 22 May '25

22 May '25

On Thu May 22 12:47:26 2025 +0000, Hans Leidekker wrote: > That was my first guess too :) Perhaps I'm missing something but this > appears to encrypt in-place. It seems to me that you would need to pass > a separate SECBUFFER_STREAM buffer that is large enough to hold data + token. Shouldn't also work {NULL,0} as a SECBUFFER_STREAM output? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104216

1 0

[PATCH 0/2] MR8118: masdo15: Add connection_OpenSchema implementation.
by Piotr Caban (＠piotr) 22 May '25

22 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8118

2 2

[PATCH v2 0/3] MR8034: winegstreamer: Call wg_format_get_max_size() to get the video decoder output sample size.
by Conor McCarthy (＠cmccarthy) 22 May '25

22 May '25

Windows uses a smaller alignment than gstreamer for some formats, for example NV12. This means we cannot use MFCalculateImageSize() to get the output sample size. Commit 7b79e3a87b1e switched to calling it instead of GetOutputStreamInfo() to fix some game bugs. -- v2: mfplat/tests: Add NV12 650 x 850 to image_size_tests. mf/tests: Add a video processor NV12 test with a width alignment of 2. https://gitlab.winehq.org/wine/wine/-/merge_requests/8034

3 6

[PATCH 0/1] MR8113: libs/ldap: Save server attributes also on 2nd authentication step.
by Dmitry Timoshkov (＠dmitry) 22 May '25

22 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8113

3 2

[PATCH 0/1] MR8117: Revert "winex11: Focus the desktop window when _NET_ACTIVE_WINDOW is None."
by Rémi Bernon (＠rbernon) 22 May '25

22 May '25

This reverts commit b1f74bc20d75592217add533f4630e163ec76075. Although this was thoroughly tested on Mutter and Kwin with Proton, @alesliehughes reported some issues with it breaking Steam for Windows under some setup, and test results from tonight seem to indicate that it also triggers undesired focus changes, when foreground is only transient and about to change to another window, with Openbox and Fvwm: https://test.winehq.org/data/8f91df4c4e4fb8b32c737bb02e82dcddfb71a114/linux… https://test.winehq.org/data/8f91df4c4e4fb8b32c737bb02e82dcddfb71a114/linux… The problem is that Openbox is not developed anymore, so it is hopeless to imagine changing anything there. And the Fvwm version used in the testbot is `fvwm2`, in a similar development state, although we might decide to switch to a more recent fvwm3 later on it has its own issues as the `linux_rbernon-x11-trixie` test VMs show. Under XWayland, the only indication that a Wayland window is being focused is `_NET_ACTIVE_WINDOW = None`/FocusOut event, which are indistinguishable from these transient focus changes. I'm now trying to make some changes on XWayland WM side, by focusing the root window instead so we can tell the difference, but it's not clear whether this will be well received or not for the moment: * https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1761 * https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/5076 * https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4447 * https://invent.kde.org/plasma/kwin/-/merge_requests/7664 In the meantime we should probably revert this in order to fix the regression and avoid introducing spurious failures again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8117

2 1

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) 22 May '25

22 May '25

On Thu May 22 12:41:19 2025 +0000, Dmitry Timoshkov wrote: > I was mentioning the part about using SECBUFFER_STREAM in > DecryptMessage(). It was my guess that EncryptMessage() is supposed to > support the mirroring logic of using SECBUFFER_DATA as input and > SECBUFFER_STREAM as output buffers. That was my first guess too :) Perhaps I'm missing something but this appears to encrypt in-place. It seems to me that you would need to pass a separate SECBUFFER_STREAM buffer that is large enough to hold data + token. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104208

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) 22 May '25

22 May '25

On Thu May 22 12:32:42 2025 +0000, Hans Leidekker wrote: > They don't pass a SECBUFFER_STREAM buffer in that sample. I was mentioning the part about using SECBUFFER_STREAM in DecryptMessage(). It was my guess that EncryptMessage() is supposed to support the mirroring logic of using SECBUFFER_DATA as input and SECBUFFER_STREAM as output buffers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104207

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) 22 May '25

22 May '25

On Thu May 22 11:10:27 2025 +0000, Dmitry Timoshkov wrote: > Why not? EncryptMessage() would get SECBUFFER_DATA as input and > SECBUFFER_STREAM as output buffers. They don't pass a SECBUFFER_STREAM buffer in that sample. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104206

1 0

[PATCH v5 0/3] MR8078: windows.ui: Fix a double free.
by Zhiyi Zhang (＠zhiyi) 22 May '25

22 May '25

The object reference is actually held by ref_weak. -- v5: geolocation: Use helpers to implement IWeakReference. windows.ui: Use helpers to implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078

4 5

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) 22 May '25

22 May '25

On Thu May 22 11:10:27 2025 +0000, Hans Leidekker wrote: > Yes, I had seen that. Note that it wouldn't make the issue of buffer > layout > differences between NTLM and Kerberos go away for EncryptMessage(). Why not? EncryptMessage() would get SECBUFFER_DATA as input and SECBUFFER_STREAM as output buffers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104199

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) 22 May '25

22 May '25

Yes, I had seen that. Note that it wouldn't make the issue of buffer layout differences between NTLM and Kerberos go away for EncryptMessage(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104198

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) 22 May '25

22 May '25

Just in case this could be useful during further improvements: https://learn.microsoft.com/en-us/windows/win32/secauthn/sspi-kerberos-inte… suggests that continuous buffer encrypted by gss_wrap() could be decrypted by passing buffer with type SECBUFFER_STREAM to DecryptMessage(). Since neither dlls/msv1_0 (NTLM) nor dlls/kerberos support SECBUFFER_STREAM current approach with detecting security package and manually constructing data/token buffers is a working solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104197

1 0

[PATCH v2 0/6] MR7932: mf: Restart transforms and sinks on seek.
by Brendan McGrath (＠redmcg) 22 May '25

22 May '25

This MR fixes seek in VRChat by copying the sequence of flushes/stop/starts that Windows does. The order on Windows is: 1. Stop sources; 2. Flush MFTs; 3. Start sources; 4. Request output down the chain of sink inputs; 6. Flush sinks; and 7. Start the clock This takes place whether we pause before we seek or seek without pause. Changes in version 2: 1. Add test to see when SAR requests new samples; 2. Add test to examine when step 4 from above takes place; 3. Adjust the seek implementation in `mf/session.c` to match findings from the new tests 4. Adjust `mfmediaengine` to reflect findings from the new tests -- v2: mfmediaengine: Request sample if we are seeking. mfmediaengine: Don't perform implicit flush on state change. mf: Don't send MFT_MESSAGE_NOTIFY_START_OF_STREAM when seeking. mf: Restart transforms and sinks on seek. mf/tests: Test sequence of calls during a Pause and Seek. mf/tests: Test when SAR requests a new sample. https://gitlab.winehq.org/wine/wine/-/merge_requests/7932

3 10

[PATCH v8 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 22 May '25

22 May '25

In CopyFileEx, and DeleteFile functions, by default, the file name and path are limited to MAX_PATH characters. To extend this limit to 32,767 wide characters, need prepend "\\\\?\\" to the path. -- v8: kernelbase: Limit the maximum path length for DeleteFile. kernelbase: Fix DeleteFileA doesn't support long path. kernelbase: Limit the maximum path length for filesystem. ntdll: Check if long path aware is enabled. kernel32/tests: Add tests for maximum path length limitation. https://gitlab.winehq.org/wine/wine/-/merge_requests/7540

3 6

[PATCH v4 0/3] MR8078: windows.ui: Fix a double free.
by Zhiyi Zhang (＠zhiyi) 22 May '25

22 May '25

The object reference is actually held by ref_weak. -- v4: geolocation: Use helpers to implement IWeakReference. windows.ui: Use helpers to implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078

3 4

[PATCH v22 0/4] MR6737: comctl32/toolbar: forward WM_NOTIFY CBEN_ENDEDITW
by Alanas Tebuev (＠BZZZZ) 22 May '25

22 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v22: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW and CBEN_ENDEDITA. comctl32: Move WM_NOTIFY unicode to ansi conversion code from pager.c to commctrl.c. comctl32: Rewrite COMCTL32_WCHAR_array_reserve (was PAGER_AdjustBuffer). https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

3 7

Re: [PATCH v2 0/1] MR8108: winex11: Focus the desktop window when _NET_ACTIVE_WINDOW is None.
by Rémi Bernon (＠rbernon) 22 May '25

22 May '25

On Thu May 22 09:05:46 2025 +0000, Rémi Bernon wrote: > Looks like I broke focus again with this in some cases, some WMs use > _NET_ACTIVE_WINDOW = None more often than others (and FVWM would fall in > that category as spurious test failures seem to suggest) and it causes > spurious focus loss. > I don't have a good solution here, either revert this entirely and > consider this as an XWayland problem, and that it should probably focus > the root window instead when losing foreground to a Wayland window, or > check ourselves for XWayland presence and enable this conditionally. I'm saying XWayland but it's not clear where this effect is coming from, might be more complicated than that and perhaps it's not something that can be fixed in one place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8108#note_104179

1 0

Re: [PATCH v2 0/1] MR8108: winex11: Focus the desktop window when _NET_ACTIVE_WINDOW is None.
by Rémi Bernon (＠rbernon) 22 May '25

22 May '25

Looks like I broke focus again with this in some cases, some WMs use _NET_ACTIVE_WINDOW = None more often than others (and FVWM would fall in that category as spurious test failures seem to suggest) and it causes spurious focus loss. I don't have a good solution here, either revert this entirely and consider this as an XWayland problem, and that it should probably focus the root window instead when losing foreground to a Wayland window, or check ourselves for XWayland presence and enable this conditionally. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8108#note_104178

1 0

[PATCH 0/7] MR8115: win32u: Open EGL display and configs on behalf of the drivers.
by Rémi Bernon (＠rbernon) 22 May '25

22 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8115

2 7

[PATCH v4 0/5] MR8037: widl: Initial support for generating Windows Runtime metadata.
by Hans Leidekker (＠hans) 22 May '25

22 May '25

-- v4: widl: Write the guid stream. widl: Write the blob stream. widl: Write the user string stream. widl: Write the string stream. widl: Initial support for generating Windows Runtime metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/8037

2 6

[PATCH v3 0/3] MR8078: windows.ui: Fix a double free.
by Zhiyi Zhang (＠zhiyi) 22 May '25

22 May '25

The object reference is actually held by ref_weak. -- v3: geolocation: Use DEFINE_WEAKREF to implement IWeakReference. windows.ui: Use DEFINE_WEAKREF to implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078

3 4

[PATCH 0/1] MR8111: win32u: Implement NtGdiDdDDIOpenAdapterFromDeviceName().
by Paul Gofman (＠gofman) 22 May '25

22 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8111

3 4

2025

2024

2023

2022

wine-gitlab