- wine-gitlab - winehq.org

Re: [PATCH v4 0/3] MR5117: rpcrt4/tests: Allocate stub buffers with NdrOleAllocate. - approved
by Alexandre Julliard (＠julliard) 15 Aug '24

15 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5117

1 0

Re: [PATCH v3 0/1] MR6244: configure: Don't use CPPFLAGS for PE cross targets. - approved
by Alexandre Julliard (＠julliard) 15 Aug '24

15 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6244

1 0

Re: [PATCH v2 0/1] MR6279: mlang: Use larger destination buffer with WideCharToMultiByte(). - approved
by Alexandre Julliard (＠julliard) 15 Aug '24

15 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6279

1 0

Re: [PATCH v2 0/1] MR6281: odbc32: Support {}'s in Driver connection string - approved
by Alexandre Julliard (＠julliard) 15 Aug '24

15 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6281

1 0

Re: [PATCH v2 0/1] MR6284: odbc32: Connection string keywords are case insensitive. - approved
by Alexandre Julliard (＠julliard) 15 Aug '24

15 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6284

1 0

[PATCH v12 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 15 Aug '24

15 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v12: comctl32/treeview: Allow treeview parent to deny treeview expansion. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

3 6

[PATCH 0/1] MR6288: wintypes: Partially implement RoResolveNamespace and add 'Windows.winmd'
by Aaron Hill (＠Aaron1011) 15 Aug '24

15 Aug '24

The Visual Studio 2022 installer needs to be able to lookup a valid WinMD file for the 'Windows.Networking.Connectivity' namespace in order for the installation to start. A normal Windows installation contains lots of individual '.winmd' files (e.g. 'Windows.Networking.winmd'), which we cannot redistribute. Fortunately, Microsoft provides an open-source project called 'windows-rs', which contains a combined 'Windows.winmd' file that is explicitly MIT-licensed: https://github.com/microsoft/windows-rs/blob/master/crates/libs/bindgen/def… Make RoResolveNamespace resolve anything starting with 'Windows' by just pointing to this giant file. A full implementation will require us to actually walk the 'WinMetadata' directory (if the caller provides a custom path) and parse the matched '.winmd' file. However, this implementation is good enough for Visual Studio 2022 To actually run the vs2022 installer, a patch for the SHELL_execute trailing-space bug https://bugs.winehq.org/show_bug.cgi?id=56940 is needed: https://gitlab.winehq.org/wine/wine/-/merge_requests/6079 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6288

3 2

[PATCH v4 0/1] MR6251: wineoss.drv: Fix work with synth devices
by Ivan Rozhuk (＠Ivan_83) 15 Aug '24

15 Aug '24

Same code used for synth and for MIDI devices, but it try to count Synth or MIDI device id from wine driver ID. After this change device id is stored in struct and always correct. -- v4: wineoss: Store the OSS device in midi_dest. https://gitlab.winehq.org/wine/wine/-/merge_requests/6251

4 4

[PATCH v17 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Ilia Docin (＠IDocin) 15 Aug '24

15 Aug '24

-- v17: comctl32/listview: Do not return items count on getting next item for last one. comctl32/tests: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

3 6

[PATCH v11 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 15 Aug '24

15 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v11: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

5 5

Re: [PATCH v3 0/1] MR6251: wineoss.drv: Fix work with synth devices
by Ivan Rozhuk (＠Ivan_83) 15 Aug '24

15 Aug '24

On Thu Aug 15 10:21:21 2024 +0000, Huw Davies wrote: > ```suggestion:-0+0 > int dev; /* OSS device */ > ``` > Also, please change the commit message to something like: > ``` > wineoss: Store the OSS device in midi_dest. > This avoids having to calculate the OSS device from the Windows dev_id. > ``` Is is `int` only on query synth/midi info, and it is always `uint8_t` in synth/midi message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6251#note_78852

1 0

[PATCH v12 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 15 Aug '24

15 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v12: comctl32/tests: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 2

[PATCH v10 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 15 Aug '24

15 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v10: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

4 11

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 15 Aug '24

15 Aug '24

On Thu Aug 15 10:05:31 2024 +0000, Zhiyi Zhang wrote: > You can use SetRect(). Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78837

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 15 Aug '24

15 Aug '24

On Thu Aug 15 10:05:31 2024 +0000, Zhiyi Zhang wrote: > Is REBAR_POST_CHILD needed? Even if you do, it shouldn't be an enum. Yes, sure. It's involved in child rect calculation just before showing or hiding chevron. The desicion depends on comparing child rect width and cxIdeal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78836

1 0

Re: [PATCH v3 0/3] MR5117: rpcrt4/tests: Allocate stub buffers with NdrOleAllocate. - approved
by Huw Davies (＠huw) 15 Aug '24

15 Aug '24

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5117

1 0

Re: [PATCH v3 0/3] MR5117: rpcrt4/tests: Allocate stub buffers with NdrOleAllocate.
by Huw Davies (＠huw) 15 Aug '24

15 Aug '24

Looks like Windows' `NdrInterfacePointerBufferSize()` was buggy. Sure, let's live with this workaround. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5117#note_78832

1 0

[PATCH 0/5] MR6287: mshtml: Add support for remaining node prototype objects.
by Jacek Caban (＠jacek) 15 Aug '24

15 Aug '24

This gets prototype/constructor hierarchy right, but there is more work needed to get it fully right (the same is true for some other objects as well, to lesser extend). Comment and document fragment nodes should not expose element/document properties, attribute nodes should be actual nodes and legacy unknown elements seem to be some parser quirk (so `use_generic` is not exactly right even in legacy modes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6287

3 6

[PATCH 0/2] MR6225: ntdll: Populate the ARM64 processor ID register registry keys.
by Billy Laws (＠bylaws) 15 Aug '24

15 Aug '24

Takes advantage of linux's ID register emulation. The msr instruction is manually assembled to support older compilers and those that disallow reading e.g. SVE ID registers if unsupported by the target, even though they RAZ if unsupported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6225

5 17

Re: [PATCH v3 0/1] MR6251: wineoss.drv: Fix work with synth devices
by Huw Davies (＠huw) 15 Aug '24

15 Aug '24

Huw Davies (@huw) commented about dlls/wineoss.drv/ossmidi.c: > BOOL bEnabled; > MIDIOPENDESC midiDesc; > BYTE runningStatus; > + BYTE dev; /* OSS dev id. */ ```suggestion:-0+0 int dev; /* OSS device */ ``` Also, please change the commit message to something like: ``` wineoss: Store the OSS device in midi_dest. This avoids having to calculate the OSS device from the Windows dev_id. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6251#note_78829

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) 15 Aug '24

15 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } Please rename the patch subject to " comctl32/tests: Add LVM_GETNEXTITEM test." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78828

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) 15 Aug '24

15 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } > > +static void test_LVM_GETNEXTITEM(void) > +{ > + /* LVM_GETNEXTITEM */ > + > + HWND hwnd; > + DWORD r; > + UINT uFlagsAbove = MAKELPARAM(LVNI_ABOVE, 0); > + UINT uFlagsBelow = MAKELPARAM(LVNI_BELOW, 0); > + > + hwnd = create_listview_control(LVS_REPORT); > + insert_item(hwnd, 0); > + insert_item(hwnd, 1); I don't think you need three items. Try one or two. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78827

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) 15 Aug '24

15 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } > > +static void test_LVM_GETNEXTITEM(void) > +{ > + /* LVM_GETNEXTITEM */ Let's remove this comment. The test function name already indicates that it's for LVM_GETNEXTITEM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78826

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Zhiyi Zhang (＠zhiyi) 15 Aug '24

15 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c: > #undef X > } > > +static void test_chevron(void) > +{ > + HWND hRebar; > + REBARBANDINFOA rbi; > + /* the gap between the child and the next band */ > + enum { REBAR_POST_CHILD = 4 }; > + > + hRebar = create_rebar_control(0); > + rbi.cbSize = REBARBANDINFOA_V6_SIZE; > + rbi.fMask = RBBIM_CHILD | RBBIM_CHILDSIZE | RBBIM_IDEALSIZE | RBBIM_SIZE | RBBIM_STYLE; > + rbi.cxIdeal = 128; > + rbi.cx = rbi.cxIdeal + REBAR_POST_CHILD - 1; Is REBAR_POST_CHILD needed? Even if you do, it shouldn't be an enum. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78824

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Zhiyi Zhang (＠zhiyi) 15 Aug '24

15 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c: > + rbi.cyMinChild = rbi.cxMinChild; > + rbi.hwndChild = build_toolbar(1, hRebar); > + rbi.fStyle = RBBS_USECHEVRON | RBBS_NOGRIPPER; > + SendMessageA(hRebar, RB_INSERTBANDA, 0, (LPARAM)&rbi); > + SendMessageA(hRebar, RB_INSERTBANDA, 1, (LPARAM)&rbi); > + > + SetRectEmpty(&g_chevron_rect); > + SendMessageA(hRebar, RB_PUSHCHEVRON, 0, 0); > + ok(!IsRectEmpty(&g_chevron_rect), "Unexpected empty chevron rect\n"); > + > + /* increase band width to make it more then ideal value to hide chevron */ > + rbi.fMask = RBBIM_SIZE; > + rbi.cx = rbi.cx + 1; > + SendMessageA(hRebar, RB_SETBANDINFOA, 0, (LPARAM)&rbi); > + > + g_chevron_rect.left = g_chevron_rect.right = g_chevron_rect.top = g_chevron_rect.bottom = 1; You can use SetRect(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78825

1 0

2025

2024

2023

2022

wine-gitlab