- wine-gitlab - winehq.org

[PATCH v2 0/1] MR6264: gdiplus: Add a couple of missing gdi_dc_release().
by Dmitry Timoshkov (＠dmitry) 14 Aug '24

14 Aug '24

-- v2: gdiplus: Add a couple of missing gdi_dc_release(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6264

3 2

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) 14 Aug '24

14 Aug '24

On Wed Aug 14 17:21:18 2024 +0000, Alfred Agrell wrote: > - Simply implement EnumerableObjectCollection and IEnumObjects > - Add IObjectCollection > - Add remoting support (and run into that WIDL bug while we're at it) > - Move it to windows.storage.dll (Wine doesn't have that DLL yet > (closest match is windows.storage.applicationdata.dll), so that's yet > another pile of copypasted scaffolding) > The amount of scope creep in this MR is somewhere between concerning and > hilarious. I vote keep it in shell32 until and unless something cares. I don't think the last two are scope creep. Committing this without proper remoting support is simply broken, and putting the DLL in the right place is also a matter of correctness. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78717

1 0

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) 14 Aug '24

14 Aug '24

On Wed Aug 14 17:21:18 2024 +0000, Alfred Agrell wrote: > I can't see anything obviously wrong in v8 3/3(*). Do you want 3/3 > merged into 1/3? > And yeah, that looks strange. Not exactly wrong - S_OK means it fetched > as many items as it asked for, so that'll just write the value that's > already there (unless the Next impl is buggy or something) - but > certainly strange. Yeah, better remove it until and unless proven necessary. > (*) actually 3/4, but that last one's a merge commit so let's pretend it > doesn't exist. Rebase and remove it. Oh, right, I misremember, S_FALSE is returned if the count isn't equal. So this isn't really that important to fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78716

1 0

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Alfred Agrell (＠Alcaro) 14 Aug '24

14 Aug '24

On Wed Aug 14 17:21:18 2024 +0000, Elizabeth Figura wrote: > 3/3 still needs to be fixed up to 1/3 where the class is introduced, > including the actxprxy parts. > There's also a whitespace error introduced in 2/3. > Also, I'm just now noticing... > > ``` > > +HRESULT __RPC_STUB IEnumObjects_Next_Stub(IEnumObjects *This, ULONG > celt, REFIID riid, void **rgelt, ULONG *pceltFetched) > > +{ > > + HRESULT hr; > > + TRACE("(%p)->(%ld, %p, %p, %p)\n", This, celt, > debugstr_guid(riid), rgelt, pceltFetched); > > + *pceltFetched = 0; > > + hr = IEnumObjects_Next(This, celt, riid, rgelt, pceltFetched); > > + if (hr == S_OK) *pceltFetched = celt; > > + return hr; > > +} > > ``` > The "*pceltFetched = celt" line looks very wrong, and I don't think that > line should be necessary at all. It was copied from IEnumShellItems, but > that also looks wrong. I can't see anything obviously wrong in v8 3/3(*). Do you want 3/3 merged into 1/3? And yeah, that looks strange. Not exactly wrong - S_OK means it fetched as many items as it asked for, so that'll just write the value that's already there (unless the Next impl is buggy or something) - but certainly strange. Yeah, better remove it until and unless proven necessary. (*) actually 3/4, but that last one's a merge commit so let's pretend it doesn't exist. Rebase and remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78711

1 0

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Alfred Agrell (＠Alcaro) 14 Aug '24

14 Aug '24

On Wed Aug 14 17:21:18 2024 +0000, Elizabeth Figura wrote: > > Also, what version of Windows are you seeing vend this class from > shell32? My Windows 10 vends it from windows.storage.dll. > FWIW, I do see this vended from shell32 in Windows 7. It's probably > better to match more recent Windows here, though I'm not sure if it's > worth caring. - Simply implement EnumerableObjectCollection and IEnumObjects - Add IObjectCollection - Add remoting support (and run into that WIDL bug while we're at it) - Move it to windows.storage.dll (Wine doesn't have that DLL yet (closest match is windows.storage.applicationdata.dll), so that's yet another pile of copypasted scaffolding) The amount of scope creep in this MR is somewhere between concerning and hilarious. I vote keep it in shell32 until and unless something cares. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78712

1 0

[PATCH v4 0/5] MR6260: mshtml: Misc improvements and fixes.
by Gabriel Ivăncescu (＠insn) 14 Aug '24

14 Aug '24

-- v4: mshtml/tests: Accept rare return value from ReportResult on native. mshtml: Don't process tasks in message loop during parse complete mshtml: Implement EmulateIE* modes for X-UA-Compatible. mshtml: Don't return default ports from location.host in IE10+ modes. mshtml: Avoid calling remove_target_tasks needlessly. https://gitlab.winehq.org/wine/wine/-/merge_requests/6260

3 8

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) 14 Aug '24

14 Aug '24

On Wed Aug 14 16:29:53 2024 +0000, Kevin Martinez wrote: > Ok, was just following the example of other entries. Yeah, it's unfortunately one of those things that's been cargo-culted, but I think it's better to avoid it going forward. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78697

1 0

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) 14 Aug '24

14 Aug '24

> Also, what version of Windows are you seeing vend this class from shell32? My Windows 10 vends it from windows.storage.dll. FWIW, I do see this vended from shell32 in Windows 7. It's probably better to match more recent Windows here, though I'm not sure if it's worth caring. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78695

1 0

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) 14 Aug '24

14 Aug '24

3/3 still needs to be fixed up to 1/3 where the class is introduced, including the actxprxy parts. There's also a whitespace error introduced in 2/3. Also, I'm just now noticing... > ``` > +HRESULT __RPC_STUB IEnumObjects_Next_Stub(IEnumObjects *This, ULONG celt, REFIID riid, void **rgelt, ULONG *pceltFetched) > +{ > + HRESULT hr; > + TRACE("(%p)->(%ld, %p, %p, %p)\n", This, celt, debugstr_guid(riid), rgelt, pceltFetched); > + *pceltFetched = 0; > + hr = IEnumObjects_Next(This, celt, riid, rgelt, pceltFetched); > + if (hr == S_OK) *pceltFetched = celt; > + return hr; > +} > ``` The "*pceltFetched = celt" line looks very wrong, and I don't think that line should be necessary at all. It was copied from IEnumShellItems, but that also looks wrong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78694

1 0

[PATCH v2 0/3] MR6276: winebus.sys: Improve udev device information parsing.
by Rémi Bernon (＠rbernon) 14 Aug '24

14 Aug '24

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6268. -- v2: winebus.sys: Read vendor/product/serial strings from the usb subsystem. winebus.sys: Always parse uevent PRODUCT= line on input subsystem. winebus.sys: Add devtype parameter to get_device_subsystem_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6276

4 4

[PATCH 0/3] MR6276: winebus.sys: Improve udev device information parsing.
by Rémi Bernon (＠rbernon) 14 Aug '24

14 Aug '24

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6268. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6276

5 10

[PATCH v7 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) 14 Aug '24

14 Aug '24

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v7: actxprxy: Added IEnumObjects_Next_Proxy shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

2 7

[PATCH 0/1] MR6272: riched20: Release IME input context when done using it.
by Zhiyi Zhang (＠zhiyi) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6272

3 2

[PATCH v2 0/10] MR6273: win32u: Use window rects structs in more functions.
by Rémi Bernon (＠rbernon) 14 Aug '24

14 Aug '24

-- v2: win32u: Keep a window_rects struct in the WND structure. win32u: Pass a window_rects struct to calc_ncsize helper. win32u: Pass a window_rects struct from get_window_rects helper. win32u: Introduce new get_(client|window)_rect_rel helpers. win32u: Pass a window_rects struct to MoveWindowBits driver entry. win32u: Pass a window_rects struct to WindowPosChanging driver entry. win32u: Pass a window_rects struct to WindowPosChanged driver entry. win32u: Pass window_rects structs to create_window_surface. win32u: Use window_rects structs in apply_window_pos. win32u: Split driver side window bits move to a separate entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/6273

3 12

[PATCH 0/1] MR6244: configure: Use separate CPPFLAGS for PE cross targets.
by Billy Laws (＠bylaws) 14 Aug '24

14 Aug '24

Host CPPFLAGS may contain architecture or target specific flags that don't apply to a PE cross compiler, to pass CPPFLAGS in such a case CROSSCPPFLAGS can now be used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6244

3 5

[PATCH 0/2] MR6277: mfplat, mf: Fix some MFCreateMediaBufferFromMediaType tests.
by Rémi Bernon (＠rbernon) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6277

2 2

[PATCH 0/10] MR6273: win32u: Use window rects structs in more functions.
by Rémi Bernon (＠rbernon) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6273

3 13

[PATCH 0/3] MR6274: odbc32: Parse incoming connection string in SQLBrowse/DriverConnct().
by Hans Leidekker (＠hans) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6274

3 4

[PATCH 0/1] MR6252: wined3d: Fix return for WINED3D_SHADER_RESOURCE_TEXTURE_2DMSARRAY.
by Andrey Gusev (＠agusev) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6252

5 4

[PATCH 0/8] MR6275: mshtml: Add support for more prototype objects.
by Jacek Caban (＠jacek) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6275

2 8

[PATCH 0/1] MR6267: winebus.sys: Pass each input report regardless of report ID to the pending read IRQ.
by Ivo Ivanov (＠logos128) 14 Aug '24

14 Aug '24

This reverts commit b9d6b79fbc23fee93150445dd8f8f8954e524aa0. With 13a4486, the hidclass.sys FDO itself distributes the input reports by CollectionNumber (report ID) to the corresponding child PDOs. So the lower level driver (winebus.sys) must deliver all input reports regardless of their report IDs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6267

4 3

[PATCH 0/1] MR6270: winemac.drv: Better detect whether to unminimize a window when the app becomes active.
by Tim Clem (＠tclem) 13 Aug '24

13 Aug '24

The existing check would not unminimize a window if the only on-screen windows had a zero dimension or were otherwise invisible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6270

2 1

Re: [PATCH v2 0/2] MR6261: windowscodecs/metadata: Reset the handler on LoadEx(NULL). - approved
by Alexandre Julliard (＠julliard) 13 Aug '24

13 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6261

1 0

Re: [PATCH v2 0/10] MR6265: mshtml: Add support for more navigator prototype objects. - approved
by Alexandre Julliard (＠julliard) 13 Aug '24

13 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6265

1 0

Re: [PATCH v2 0/1] MR6246: ntdll: Call the exception preparation callback on ARM64EC. - approved
by Alexandre Julliard (＠julliard) 13 Aug '24

13 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6246

1 0

2025

2024

2023

2022

wine-gitlab