- wine-gitlab - winehq.org

Re: [PATCH v2 0/11] MR6239: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 5). - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6239

1 0

Re: [PATCH v2 0/10] MR6236: mshtml: Add support for style objects prototypes. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6236

1 0

Re: [PATCH v2 0/5] MR6235: include: Add codecapi defines. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6235

1 0

[PATCH v4 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v4: comctl32/test: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 6

[PATCH v3 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v3: comctl32/rebar: Add chevron test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 2

[PATCH v11 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

-- v11: comctl32/listview: Do not return items count on getting next item for last one. comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 3

[PATCH v10 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

-- v10: comctl32/listview: Do not return items count on getting next item for last one. comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 4

[PATCH 0/1] MR6246: ntdll: Call the exception preparation callback on ARM64EC.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6246

3 2

[PATCH 0/1] MR6198: gdi32: Bounds check EMF handle tables.
by Esme Povirk (＠madewokherd) 09 Aug '24

09 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45106 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6198

4 4

[PATCH 0/1] MR6245: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETCHECK.
by Esme Povirk (＠madewokherd) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6245

2 1

[PATCH v41 0/8] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 09 Aug '24

09 Aug '24

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v41: win32u: Handle dbus notification balloons from system_tray_call win32u: Handle notification balloons through org.freedesktop.Notifications dbus interface win32u: Add a ShowBalloon driver interface win32u: Handle StatusNotifierItem management from system_tray_call win32u: Handle StatusNotifierWatcher owner changing and registering objects to a new watcher win32u: Add SNI driver for systray handling win32u: Add DBus event loop for SNI handling win32u: Add a SystrayRunLoop driver interface https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

5 19

[PATCH 0/1] MR6229: winegstreamer/quartz_parser: Handle 0 size in read_thread.
by Ziqing Hui (＠zhui) 09 Aug '24

09 Aug '24

Calling IAsyncReader_SyncRead() with 0 size may fails, but we should not return error with 0 size, so we handle it earlier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6229

3 2

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Thanks for the patch! Other than a couple of style nitpicks it looks good. > I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). I think it'd still be preferable, though. 100 ms isn't a lot, but those kinds of sleeps can build up, and we do want our tests to be as quick as possible. Perhaps more concerningly, if the timing is particularly bad, and 100 ms isn't enough, we'll get intermittent failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78212

1 0

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Elizabeth Figura (@zfigura) commented about dlls/http.sys/http.c: > { > if (send(conn->socket, response->buffer, response->len, 0) >= 0) > { > - if (conn->content_len) > - { > - /* Discard whatever entity body is left. */ > - memmove(conn->buffer, conn->buffer + conn->content_len, conn->len - conn->content_len); > - conn->len -= conn->content_len; > + /* Clean up the connection if we are not sending more response data. */ > + if (response->response_flags != HTTP_SEND_RESPONSE_FLAG_MORE_DATA) { Brace on a new line, please, to match the existing style. There's another instance in 4/4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78211

1 0

[PATCH v5 0/1] MR6191: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux
by Haoran Wang (＠Low-power) 09 Aug '24

09 Aug '24

Tested using C&C Red Alert 2; selection of interface and network communication worked as expected. IPX traffic correctly sent to the selected interface only, as confirmed by **tcpdump(8)**. ![ra2-on-linux-with-multiple-ipx-interfaces](/uploads/7755db6a7b82a21050623d3ccd9ec37e/ra2-on-linux-with-multiple-ipx-interfaces.png) -- v5: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/6191

4 4

[PATCH 0/1] MR6242: include: Move arm64ec_shared_info to winternl and point to it in the PEB.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

From phnt headers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6242

3 2

[PATCH 0/1] MR6241: ntdll: Initialize dll search paths before WOW64 init.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

GetModuleHandle succeeds when called from WOW64 module callbacks on Windows but without this it would crash on wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6241

2 1

[PATCH v14 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v14: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 4

[PATCH 0/2] MR6240: dinput: Implement DIPROP_SCANCODE.
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6223. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6240

3 4

[PATCH v13 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v13: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

3 3

[PATCH v6 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v6: comctl32/treeview: Allow treeview parent to deny treeview expansion. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

4 4

Re: [PATCH v2 0/2] MR6223: dinput: Implement DIPROP_SCANCODE. - closed
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6223

1 0

Re: [PATCH v2 0/2] MR6223: dinput: Implement DIPROP_SCANCODE.
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

Thanks, I've made a couple of adjustments and opened https://gitlab.winehq.org/wine/wine/-/merge_requests/6240 instead. The mapping looks completely straightforward, regardless of the keyboard layout, and I changed it to simplify the changes. This is the case at least for standard keyboard types. We have supposedly some support of JP106 keyboard types but I don't think this is working enough to worry about it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6223#note_78188

1 0

[PATCH v8 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v8: comctl32/progress: Add states for progress bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

3 3

[PATCH 0/11] MR6239: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 5).
by Hans Leidekker (＠hans) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6239

2 11

2025

2024

2023

2022

wine-gitlab