- wine-gitlab - winehq.org

[PATCH 0/5] MR6237: win32u: Remove now unnecessary WindowPosChanging checks and UpdateLayeredWindow params.
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6237

2 5

Re: [PATCH v3 0/10] MR6230: mshtml: Support more node prototype objects.
by Jacek Caban (＠jacek) 09 Aug '24

09 Aug '24

On Fri Aug 9 00:00:38 2024 +0000, Nicholas Ansell wrote: > ```suggestion:-0+0 > .name = "CharacterData", > ``` Good catch, thanks. I sent a patch in !6236 that allows skipping the name for objects that have IDs, which should prevent such typos in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6230#note_78155

1 0

[PATCH 0/10] MR6236: mshtml: Add support for style objects prototypes.
by Jacek Caban (＠jacek) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6236

2 10

[PATCH 0/5] MR6235: include: Add codecapi defines.
by Ziqing Hui (＠zhui) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6235

3 8

[PATCH v12 0/1] MR5957: win32u: fix random crash without libfreetype
by Fan WenJie (＠fanwenjie) 09 Aug '24

09 Aug '24

without freetype, some calling return failed, so some value may not be initialized (it initialize by some failed calling and pass argument by point of it), it would cause random crash! Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v12: win32u: fix random crash without libfreetype https://gitlab.winehq.org/wine/wine/-/merge_requests/5957

2 1

Re: [PATCH v3 0/10] MR6230: mshtml: Support more node prototype objects.
by Nicholas Ansell (＠roadrunnerto) 09 Aug '24

09 Aug '24

Nicholas Ansell (@roadrunnerto) commented about dlls/mshtml/htmltextnode.c: > .clone = HTMLDOMTextNode_clone > }; > > -static const dispex_static_data_vtbl_t HTMLDOMTextNode_dispex_vtbl = { > +dispex_static_data_t CharacterData_dispex = { > + .name = "CharactedData", ```suggestion:-0+0 .name = "CharacterData", ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6230#note_78148

1 0

Re: [PATCH v2 0/2] MR6228: win32u: Always enumerate the primary source first. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6228

1 0

Re: [PATCH v2 0/1] MR6234: win32u: Always use the dummy surface if a surface isn't needed. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6234

1 0

Re: [PATCH v3 0/10] MR6230: mshtml: Support more node prototype objects. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6230

1 0

Re: [PATCH v2 0/1] MR6232: ntdll: Use the module debug channel in virtual_map_builtin_module(). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6232

1 0

Re: [PATCH v2 0/1] MR6205: d3dx9/effect: Return creator string from GetDesc(). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6205

1 0

Re: [PATCH v4 0/9] MR6157: d3dx9: More miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

1 0

Re: [PATCH v2 0/7] MR6231: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 4). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6231

1 0

Re: [PATCH v2 0/2] MR6226: mmdevapi: Implement control_GetSessionIdentifier / control_GetSessionInstanceIdentifier. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6226

1 0

Re: [PATCH v2 0/1] MR6224: mmdevapi: Unlock session in create_session_enumerator(). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6224

1 0

[PATCH v2 0/1] MR2657: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth..
by Aleksey Komarov (＠q4a) 08 Aug '24

08 Aug '24

General idea of this test is to show that a lot of factors influence the fog when transformed and untransformed vertex format was used: - Directly changing z and w (which is not equal in the corners). - Changing projection matrix that change z and w. - Using different programmable/ff vs/ps shader. - Using different depth bias. - Chaging depth in pixel shader (oDepth) may or may not affect to colors depending on the vendor implementation. - And various combinations of above. This gives `succ` in all cases on this configs: - Windows 10 with Radeon HD 8400 or Ivy Bridge GT1 (Intel HD Graphics). - Windows 7 with Radeon HD 6450. - Windows XP with GeForce Go 7300. -- v2: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth.. https://gitlab.winehq.org/wine/wine/-/merge_requests/2657

8 17

[PATCH 0/1] MR6234: win32u: Always use the dummy surface if a surface isn't needed.
by Rémi Bernon (＠rbernon) 08 Aug '24

08 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57033 We don't need a surface when the drawing rect is empty, and it can even FPE if we use one. Release any previously created surface in this case and use the dummy surface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6234

2 1

[PATCH 0/5] MR6233: winex11: Fix systray docked icons display.
by Rémi Bernon (＠rbernon) 08 Aug '24

08 Aug '24

And avoid triggering X11 errors with foreign windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6233

2 5

[PATCH 0/1] MR6232: ntdll: Use the module debug channel in virtual_map_builtin_module().
by Sven Baars (＠sbaars) 08 Aug '24

08 Aug '24

Not sure if this is useful for anyone else, but this is the second time this warn would have saved me at least an hour. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6232

3 2

[PATCH 0/1] MR6205: d3dx9/effect: Return creator string from GetDesc().
by Nikolay Sivov (＠nsivov) 08 Aug '24

08 Aug '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6205

4 3

[PATCH v3 0/9] MR6157: d3dx9: More miscellaneous fixes.
by Connor McAdams (＠cmcadams) 08 Aug '24

08 Aug '24

-- v3: d3dx9: Validate filter argument in texture from file functions. d3dx9: Validate filter argument in D3DXLoadSurfaceFrom{Surface,FileInMemory,Memory}(). d3dx9: Validate filter argument in D3DXLoadVolumeFrom{Volume,FileInMemory,Memory}(). d3dx9: Further validate filter argument passed to D3DXFilterTexture(). d3dx9: Introduce helper function for retrieving the mip filter value in texture from file functions. d3dx9/tests: Add d3dx filter argument value tests. d3dx9: Return failure from D3DXLoadSurfaceFromMemory() if d3dx_load_pixels_from_pixels() fails. d3dx9: Return success in D3DXLoadSurfaceFromMemory() for multisampled destination surfaces. d3dx9/tests: Add tests for D3DXLoadSurfaceFromMemory() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

4 16

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > !(item->state & TVIS_EXPANDEDONCE)); > if (sendsNotifications) > { > - if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > - { > - TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > - return FALSE; > - } > + if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > + { > + TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > + return TRUE; This is the only changed line. Please avoid whitespace changes for other lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78097

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > !(item->state & TVIS_EXPANDEDONCE)); > if (sendsNotifications) > { > - if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > - { > - TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > - return FALSE; > - } > + if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) Let's change TREEVIEW_SendExpanding to return the return value from TREEVIEW_SendTreeviewNotify() so we don't to need negate the return value twice and it's more intuitive this way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78098

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/treeview.c: > > DestroyWindow(hTree); > > + /* check that expansion can be denied by parent */ > + hTree = create_treeview_control(0); > + fill_tree(hTree); > + > + tvn_itemexpanding_ret = 1; > + memset(&item, 0, sizeof(item)); > + item.mask = TVIF_STATE; > + item.hItem = hRoot; > + *((HTREEITEM*)&rc) = item.hItem; Add a space between HTREEITEM and *. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78095

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > return FALSE; > > if (bUser) > - TREEVIEW_SendExpanding(infoPtr, item, action); > + { > + if(!TREEVIEW_SendExpanding(infoPtr, item, action)) > + return TRUE; Let's use if (bUser && !TREEVIEW_SendExpanding(infoPtr, item, action)) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78096

1 0

2025

2024

2023

2022

wine-gitlab