- wine-gitlab - winehq.org

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/treeview.c: > } > case TVN_ITEMEXPANDINGA: > { > - UINT newmask = pTreeView->itemNew.mask & ~TVIF_CHILDREN; > + UINT newmask; Let's add a new line after the variable declaration. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78094

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/treeview.c: > } > case TVN_ITEMEXPANDINGA: > { > - UINT newmask = pTreeView->itemNew.mask & ~TVIF_CHILDREN; > + UINT newmask; > + if (tvn_itemexpanding_ret) > + { > + tvn_itemexpanding_ret = 0; Let's use a similar naming convention like other global variables, for example, g_reject_tvn_itemexpanding. And let parent_wnd_proc always return TRUE when g_reject_tvn_itemexpanding is TRUE and then reset the variable to zero in test_expandnotify() after your tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78093

1 0

[PATCH v7 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 08 Aug '24

08 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v7: comctl32/progress: Add states for progress bar. comctl32/tests: Add tests for progress bar states. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

4 4

[PATCH v2 0/10] MR6230: mshtml: Support more node prototype objects.
by Jacek Caban (＠jacek) 08 Aug '24

08 Aug '24

-- v2: mshtml: Add support for text node prototype objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/6230

2 10

[PATCH v12 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 08 Aug '24

08 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v12: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 6

[PATCH 0/10] MR6230: mshtml: Support more node prototype objects.
by Jacek Caban (＠jacek) 08 Aug '24

08 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6230

3 11

[PATCH 0/7] MR6231: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 4).
by Hans Leidekker (＠hans) 08 Aug '24

08 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6231

2 7

[PATCH 0/2] MR6226: mmdevapi: Implement control_GetSessionIdentifier / control_GetSessionInstanceIdentifier.
by Paul Gofman (＠gofman) 08 Aug '24

08 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6226

4 4

[PATCH 0/1] MR6224: mmdevapi: Unlock session in create_session_enumerator().
by Paul Gofman (＠gofman) 08 Aug '24

08 Aug '24

Fixes a regression introduced by 2efb00bc850f69ebd994d715bdd510d7ced41b12. Sorry for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6224

4 3

[PATCH v15 0/6] MR6166: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 08 Aug '24

08 Aug '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v15: ntdll: main_envp has been replaced by environ ntdll: remove is_dynamic_env_var(...) because it is not needed anymore ntdll: remove unused vars ntdll: remove dead code ntdll: conversion from HOSTENV to WINENV is now using whitelisting instead of blacklisting of envvars currently only envvars "WINE"<special_var> (as defined in is_special_env_var() ) are whitelisted. ntdll: separate env for windows applications (WINENV) from env for wine processes (NIXENV) WINENV is typically limited to 32767 WCHAR, the host environment where wine processes are running can be much larger. Keeping the two envs separate enables a more granula handling of envvars. (see also MR!5231, MR!6140, bug #56941) https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

4 7

[PATCH 0/2] MR6228: win32u: Always enumerate the primary source first.
by Rémi Bernon (＠rbernon) 08 Aug '24

08 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56811 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56989 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6228

2 2

[PATCH v3 0/7] MR6220: mfplat: Implement MFCreateMediaBufferFromMediaType for video formats and test video processor with 2D buffers.
by Rémi Bernon (＠rbernon) 08 Aug '24

08 Aug '24

Superseding https://gitlab.winehq.org/wine/wine/-/merge_requests/6188 -- v3: mf/tests: Test 2D buffers can override stride. mf/tests: Test differing height attributes. mf/tests: Test 1D/2D output on 2D buffers. mf/tests: Test video processor with 2D buffers. mf/tests: Cleanup the video processor test list. mfplat: Implement MFCreateMediaBufferFromMediaType for video formats. mfplat/tests: Add more tests for MFCreateMediaBufferFromMediaType. https://gitlab.winehq.org/wine/wine/-/merge_requests/6220

5 11

[PATCH v14 0/50] MR6166: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 08 Aug '24

08 Aug '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v14: dnsapi/tests: Update tests for winehq.org DNS changes. mshtml: Add support for script element prototype objects. mshtml: Add support for object and embed element prototype objects. mshtml: Add support for link element prototype objects. mshtml: Add support for input elements prototype objects. mshtml: Add support for head elements prototype objects. mshtml: Add support for frame elements prototype objects. mshtml: Add support for form element prototype objects. mshtml: Add support for area element prototype objects. mshtml: Add support for anchor element prototype objects. mshtml/tests: Use winetest.js helpers in xhr.js. rsaenh: Don't crash when decrypting empty strings. d3d9/tests: Add comprehensive fog tests. wined3d: Use 1.0 for position W when using the FFP. d3d9/tests: Test position attribute W when using the FFP. wined3d: Feed point scale constants through a push constant buffer. wined3d: Hardcode 1.0 point size for shader model >= 4. wined3d: Store the normal matrix as a struct wined3d_matrix. wined3d: Feed the precomputed normal matrix through a push constant buffer. wined3d: Pass d3d_info and stream_info pointers to wined3d_ffp_get_[vf]s_settings(). ntdll: Try to use page size from host_page_size() for macOS. include: Add DECLSPEC_CHPE_PATCHABLE definition. user32: Implement EVENT_OBJECT_STATECHANGE for BST_PUSHED. ntdll: Raise exception on failed CS wait. hidclass: Start the HID device thread with the FDO. hidclass: Pass HIDP_DEVICE_DESC to find_report_with_type_and_id. hidclass: Use a single lock for PDO queues and removed flag. hidclass: Read reports with the largest input report size over TLCs. hidclass: Use poll_interval == 0 for non-polled devices. mshtml: Add support for MutationObserver consturctor and prototype objects. mshtml: Use host object script bindings for Option constructor object. mshtml: Add support for option element prototype objects. mshtml: Use host constructor script bindings for XMLHttpRequest constructor object. mshtml: Use host constructor script bindings for Image constructor object. jscript: Introduce HostConstructor function type. mshtml: Add support for image element prototype objects. configure: Test PE compilers after setting their target argument. shell32: Make SHGetStockIconInfo() attempt to set icon. kernelbase: Implement GetTempPath2A() and GetTempPath2W(). win32u: Force updating the display cache when virtual desktop state changes. ntdll: Implement NtQuerySystemInformationEx( SystemProcessorIdleCycleTimeInformation ) on Linux. kernel32: Implement QueryIdleProcessorCycleTime[Ex](). ntdll: Stub NtQuerySystemInformation[Ex]( SystemProcessorIdleCycleTimeInformation ). include: Always declare _setjmp in setjmp.h on i386 targets. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

1 0

[PATCH 0/4] MR6188: mf/tests: Test 2D buffers can override stride.
by Brendan McGrath (＠redmcg) 07 Aug '24

07 Aug '24

The existing video_processor tests were modified to also test 2D buffers (in addition to the existing 1D buffer tests). Because 2D buffers offer both a 1D view and 2D view of the buffer data, additional checks were also added to test the 2D view of the data. 2D buffers can also include their own stride value. So additional tests were added to ensure that a 2D buffer can override the stride settings of the input/output media attributes of a transform. And finally, tests for transforming from a buffer with a smaller input height to a greater output height were also added. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6188

3 7

Re: [PATCH v2 0/10] MR6222: mshtml: Add support for more element prototype object. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6222

1 0

Re: [PATCH v4 0/1] MR6221: rsaenh: Don't crash when decrypting empty strings - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6221

1 0

Re: [PATCH v3 0/3] MR6209: d3d9/tests: Add comprehensive fog tests. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6209

1 0

Re: [PATCH v2 0/5] MR6202: wined3d: Feed FFP shader constants through push constant buffers, part 6. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6202

1 0

Re: [PATCH v2 0/1] MR6215: ntdll: Try to use page size from host_page_size() for macOS. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6215

1 0

Re: [PATCH v2 0/1] MR6217: include: Add DECLSPEC_CHPE_PATCHABLE definition. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6217

1 0

Re: [PATCH v2 0/1] MR6219: user32: Implement EVENT_OBJECT_STATECHANGE for BST_PUSHED. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6219

1 0

Re: [PATCH v5 0/1] MR6175: ntdll: Raise exception on failed CS wait. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6175

1 0

Re: [PATCH v2 0/5] MR6214: hidclass: Use a single device reading thread instead of one for each TLC. - approved
by Alexandre Julliard (＠julliard) 07 Aug '24

07 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6214

1 0

[PATCH v9 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Giovanni Mascellani (＠giomasce) 07 Aug '24

07 Aug '24

-- v9: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

5 8

[PATCH v3 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 07 Aug '24

07 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v3: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

3 3

2025

2024

2023

2022

wine-gitlab