- wine-gitlab - winehq.org

[PATCH 0/1] MR6219: user32: Implement EVENT_OBJECT_STATECHANGE for BST_PUSHED.
by Esme Povirk (＠madewokherd) 06 Aug '24

06 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6219

3 2

[PATCH v2 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 06 Aug '24

06 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v2: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

3 3

[PATCH 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 06 Aug '24

06 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

3 3

[PATCH v5 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 06 Aug '24

06 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v5: comctl32/progress: Add states for progress bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

4 7

[PATCH 0/1] MR6217: include: Add DECLSPEC_CHPE_PATCHABLE definition.
by Jacek Caban (＠jacek) 06 Aug '24

06 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6217

3 2

[PATCH v4 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 06 Aug '24

06 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v4: comctl32/progress: Add states for progress bar. comctl32/tests: Add tests for progress bar states. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

4 5

[PATCH 0/4] MR6216: Implement httpapi HttpResponseSendEntityBody
by Tom Helander (＠thelande) 06 Aug '24

06 Aug '24

This merge request implements the `httpapi.dll` `HttpResponseSendEntityBody` function and associated tests. API documentation was written by me by paraphrasing/re-writing what I had read for the function from the MSDN documentation. I am adding this function to enable the remote API component of the Space Engineers Dedicated Server. Implementation notes: - I mainly copied the relevant portion of `HttpSendHttpResponse` for `HttpResponseSendEntityBody`. - I updated the `http_response` struct to add a field `response_flags` - This field tracks the flags passed in to `HttpSendHttpResponse` and `HttpResponseSendEntityBody`. - This was needed because the clean-up steps in `http.sys` need to be skipped when `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` is set. - I updated `HttpSendHttpResponse` to handle the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag by omitting the `Content-Length` header and setting the `response_flags` field in the `response` object passed to `http.sys`. - The `Content-Length` header is omitted by the Windows implementation and thus I omitted it here for conformance purposes. - I updated `http_send_response` in `http.sys` to skip the connection clean up steps if the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag was set. This works for both `HttpSendHttpResponse` and `HttpResponseSendEntityBody` as either could set the flag to continue to send more data. - It is not 100% clear to me what the cleanup steps are doing. In particular, I am uncertain what lines 1011-1016 and 1023-1027 are doing, but based on context it seemed appropriate to keep them with the other connection cleanup steps. For testing, I duplicated the existing `HttpSendHttpResponse` test but modified it to set the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag and then followed up with a call to `HttpResponseSendEntityBody` with new data. The validation ensures that data from both the initial response and follow up response are contained in the final response obtained via `recv()`. On Windows 11 this happens immediately without any delay, but in Wine I had to add a `Sleep(100)` to give enough time for the follow up response to be received in the socket buffer by the time the `recv()` call was made in the test. I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216

3 5

[PATCH v2 0/7] MR6212: mshtml: Use proper JS functions for constructors.
by Jacek Caban (＠jacek) 06 Aug '24

06 Aug '24

-- v2: mshtml: Add support for MutationObserver consturctor and prototype objects. mshtml: Use host object script bindings for Option constructor object. mshtml: Add support for option element prototype objects. mshtml: Use host constructor script bindings for XMLHttpRequest constructor object. mshtml: Use host constructor script bindings for Image constructor object. jscript: Introduce HostConstructor function type. https://gitlab.winehq.org/wine/wine/-/merge_requests/6212

3 8

[PATCH 0/1] MR6215: ntdll: Try to use page size from host_page_size() for macOS.
by Jactry Zeng (＠jactry) 06 Aug '24

06 Aug '24

For macOS on Apple Silion, includes Rosetta 2, page size is 16K by default. This fixes the incorrect ullAvailPageFile returned by GlobalMemoryStatusEx(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6215

3 2

[PATCH v4 0/1] MR6191: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux
by Haoran Wang (＠Low-power) 06 Aug '24

06 Aug '24

Tested using C&C Red Alert 2; selection of interface and network communication worked as expected. IPX traffic correctly sent to the selected interface only, as confirmed by **tcpdump(8)**. ![ra2-on-linux-with-multiple-ipx-interfaces](/uploads/7755db6a7b82a21050623d3ccd9ec37e/ra2-on-linux-with-multiple-ipx-interfaces.png) -- v4: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/6191

2 1

[PATCH v2 0/1] MR6191: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux
by Haoran Wang (＠Low-power) 06 Aug '24

06 Aug '24

Tested using C&C Red Alert 2; selection of interface and network communication worked as expected. IPX traffic correctly sent to the selected interface only, as confirmed by **tcpdump(8)**. ![ra2-on-linux-with-multiple-ipx-interfaces](/uploads/7755db6a7b82a21050623d3ccd9ec37e/ra2-on-linux-with-multiple-ipx-interfaces.png) -- v2: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/6191

2 2

[PATCH 0/5] MR6214: hidclass: Use a single device reading thread instead of one for each TLC.
by Rémi Bernon (＠rbernon) 06 Aug '24

06 Aug '24

Otherwise, with multi-TLC devices, concurrent PDO threads would steal reports from each other, which causes random timeouts in the tests. Fixes: c65d5b094825afdafba462a4050a490426f3cd51 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6214

2 5

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Rémi Bernon (＠rbernon) 06 Aug '24

06 Aug '24

I have opened https://gitlab.winehq.org/wine/wine/-/merge_requests/6213 which I believe should fix the issue in a simpler way. Note that it's not completely correct in any case, and there might be some unexpected behavior if applications rely on monitor display settings. We still allow different virtual desktop window sizes while the underlying virtual desktop size should always be the same as the monitor rectangles, which is normally (on Windows) the same across all the desktops of the interactive window station. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77860

1 0

[PATCH 0/1] MR6213: win32u: Force update the display cache when virtual desktop state changes.
by Rémi Bernon (＠rbernon) 06 Aug '24

06 Aug '24

This can happen when explorer creates a new virtual desktop, while being associated with the default non-virtual desktop. Explorer then fails to change the display settings of the virtual source in this case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56993 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6213

2 1

[PATCH 0/1] MR6191: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux
by Haoran Wang (＠Low-power) 06 Aug '24

06 Aug '24

Move implementation of these 2 options into ntdll, and add 2 ioctl codes for calling from ws2_32. Query configured IPX interfaces by reading /proc/net/ipx/interface of Linux procfs, enabling applications to iterate multiple IPX interfaces. This can be useful when a node have multiple IPX interfaces, and application need to receive/send packets from/to a non-primary IPX interface. Signed-off-by: WHR <whr(a)rivoreo.one> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6191

4 9

[PATCH 0/7] MR6212: mshtml: Use proper JS functions for constructors.
by Jacek Caban (＠jacek) 06 Aug '24

06 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6212

3 9

[PATCH 0/3] MR6210: kernel32: Implement Implement QueryIdleProcessorCycleTime[Ex]().
by Paul Gofman (＠gofman) 06 Aug '24

06 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6210

3 4

[PATCH 0/3] MR6209: d3d9/tests: Add comprehensive fog tests.
by Elizabeth Figura (＠zfigura) 06 Aug '24

06 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6209

3 4

[PATCH 0/8] MR6206: hidclass: Implement multiple TLC support.
by Rémi Bernon (＠rbernon) 05 Aug '24

05 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6206

4 10

Re: [PATCH v3 0/5] MR6148: include/codecapi.h: Add encoder defines. - approved
by Alexandre Julliard (＠julliard) 05 Aug '24

05 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6148

1 0

[PATCH 0/1] MR6201: wineps.drv: Fix EMR_SETPIXELV record playback.
by Piotr Caban (＠piotr) 05 Aug '24

05 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6201

4 3

Re: [PATCH v2 0/8] MR6206: hidclass: Implement multiple TLC support. - approved
by Alexandre Julliard (＠julliard) 05 Aug '24

05 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6206

1 0

Re: [PATCH v2 0/7] MR6204: mshtml: Add support for prototype chains and more prototype objects. - approved
by Alexandre Julliard (＠julliard) 05 Aug '24

05 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6204

1 0

Re: [PATCH v2 0/1] MR6201: wineps.drv: Fix EMR_SETPIXELV record playback. - approved
by Alexandre Julliard (＠julliard) 05 Aug '24

05 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6201

1 0

[PATCH 0/11] MR6207: include: Introduce new COM implementation helper macros.
by Rémi Bernon (＠rbernon) 05 Aug '24

05 Aug '24

I think it would be very nice to have something like that to reduce the burden of implementing COM interfaces. This shows for instance on the windows.gaming.input module a 30% LoC reduction (from ~6800 to ~4700), even though the module already had a boilerplate helper macros already. The MR introduces macros to automatically implement each IUnknown method, as well as all of them at once. It also includes a helper to implement IInspectable methods at once, as well as macros to forward both interface methods to a base interface or an outer object. Last, it provides higher-level macros to implement a main interface and any number of sub interfaces and generate IUnknown, forwarding and vtables for all of them at once. It uses widl to generate additional per-interface macros, for things like inheritance and vtable generation. The rest of the macros are otherwise shared in a Wine-specific header. The implementation is split to show individual macro being used, although they are later replaced by higher-level macros. The individual helpers are still useful in some corner cases where specific behavior needs to be implemented, or for aggregating classes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6207

3 12

2025

2024

2023

2022

wine-gitlab