- wine-gitlab - winehq.org

[PATCH v4 0/6] MR6042: d3d: Miscellaneous tests/fixes.
by Connor McAdams (＠cmcadams) 17 Jul '24

17 Jul '24

The first two patches here address an issue I encountered when using Wine's d3dx9 with DXVK in the game Command and Conquer 3. The game calls `D3DXLoadSurfaceFromMemory` on a multisampled render target. This ends up going through the `lock_surface()` helper in d3dx9, which eventually calls `UpdateSurface()` in `unlock_surface()` to copy the staging surface back to the multisampled render target. This succeeds on wined3d even though it shouldn't, and fails on DXVK like it should. The second two patches address an issue reported in Empires: Dawn of the Modern World, where the game expects a device reset to reset the scene state. -- v4: wined3d: Clear scene state on device state reset. d3d8/tests: Add a test for device reset after beginning a scene. d3d9/tests: Add a test for device reset after beginning a scene. ddraw/tests: Add tests for preserving d3d scene state during primary surface creation. d3d9: Return failure if a multisampled surface is passed to IDirect3DDevice9::UpdateSurface(). d3d9/tests: Add tests for IDirect3DDevice9::UpdateSurface() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6042

4 8

Re: [PATCH v2 0/2] MR6099: msado15: Report success in a few functions. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6099

1 0

Re: [PATCH v2 0/1] MR6109: win32u: Implement EVENT_OBJECT_STATECHANGE for WS_DISABLED. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6109

1 0

Re: [PATCH v2 0/1] MR6094: server: Mark the socket as cacheable when it is an accepted or accepted-into socket. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6094

1 0

Re: [PATCH v2 0/1] MR6101: mshtml: Add application/pdf MIME type. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6101

1 0

Re: [PATCH v2 0/6] MR6080: wined3d: Feed FFP shader constants through push constant buffers, part 3. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6080

1 0

Re: [PATCH v3 0/2] MR6026: winemac: Use the new surface shape helper to update window shape. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6026

1 0

Re: [PATCH v3 0/7] MR6036: win32u: Use the thread input and desktop shared memory for reading keyboard state. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6036

1 0

Re: [PATCH v2 0/1] MR6105: winex11: Reset empty window shape even without a window surface. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6105

1 0

Re: [PATCH v2 0/2] MR6106: winhttp test fixes - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6106

1 0

Re: [PATCH v2 0/1] MR6103: odbc32: Return success for handled attributes in SQLSetConnectAttrW. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6103

1 0

Re: [PATCH v3 0/1] MR6102: odbc32: Handle NULL attribute in SQLColAttributeW. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6102

1 0

Re: [PATCH v2 0/1] MR6055: ddraw/tests: Make sure the window is restored after some minimize tests. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6055

1 0

Re: [PATCH v2 0/2] MR6098: odbc32 fixes transact - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6098

1 0

Re: [PATCH v2 0/1] MR6104: light.msstyles: Use slightly darker color for GrayText to make text more readable. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6104

1 0

[PATCH 0/1] MR6109: win32u: Implement EVENT_OBJECT_STATECHANGE for WS_DISABLED.
by Esme Povirk (＠madewokherd) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6109

3 2

[PATCH v3 0/4] MR6089: setupapi: Fixes for get_source_info().
by Elizabeth Figura (＠zfigura) 17 Jul '24

17 Jul '24

-- v3: setupapi: Fix testing for a non-empty string in get_source_info(). setupapi/tests: Test installing an INF file with architecture-specific SourceDisks* sections. setupapi: Use SetupGetSourceInfo() in get_source_info(). setupapi: Use SetupGetSourceFileLocation() in get_source_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6089

2 4

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by theofficialgman (＠theofficialgman) 17 Jul '24

17 Jul '24

On Wed Jul 17 17:12:01 2024 +0000, Tim Clem wrote: > Filing a bug is probably the right thing to do. I don't know offhand who > would know best - I'm not very familiar with that area myself. In > ntdll/unix/virtual.c, the address space limit is hardcoded to > 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it > (see `get_host_addr_space_limit`). For the bug, it would be interesting > to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned. The issue I am having is when fully emulating x86_64 wine on arm64 using the likes of box64/fex/qemu. So the hardcode makes sense why the problem is happening. Thanks for the info, I'll look into using `get_host_addr_space_limit` for all architectures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76437

1 0

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by Tim Clem (＠tclem) 17 Jul '24

17 Jul '24

On Wed Jul 17 17:12:01 2024 +0000, theofficialgman wrote: > Thanks Tim. Should I file a bug for this then or are you aware of who > might be more knowledgeable about the allocation system and why its > attempting to allocate memory outside of address limit? Filing a bug is probably the right thing to do. I don't know offhand who would know best - I'm not very familiar with that area myself. In ntdll/unix/virtual.c, the address space limit is hardcoded to 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it (see `get_host_addr_space_limit`). For the bug, it would be interesting to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76436

1 0

[PATCH v2 0/1] MR6097: dxdiagn: Fill szHardwareId for sound render devices.
by Paul Gofman (＠gofman) 17 Jul '24

17 Jul '24

Somehow the field is not present for sound capture devices, at least on my Win11. Fixes Tom Clancy's Splinter Cell: Conviction not finding any sound devices and refusing to start. -- v2: dxdiagn: Fill szHardwareId for sound render devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/6097

2 2

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by theofficialgman (＠theofficialgman) 17 Jul '24

17 Jul '24

Thanks Tim. Should I file a bug for this then or are you aware of who might be more knowledgeable about the allocation system and why its attempting to allocate memory outside of address limit? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76427

1 0

[PATCH 0/4] MR6096: mshtml: event.cancelBubble and some ms* styles implementation.
by Gabriel Ivăncescu (＠insn) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6096

3 8

[PATCH 0/1] MR6101: mshtml: Add application/pdf MIME type.
by Daniel Lehman (＠dlehman25) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6101

3 2

[PATCH 0/6] MR6090: Cmd engine rewrite (part XXI)
by eric pouech (＠epo) 17 Jul '24

17 Jul '24

This is part XX1 of cmd engine rewrite. It covers: - tests & fixes for success/failure of changing current drive, - tests & fixes for success/failure when using pipes, - new implementation of CHOICE command. Notes: - CHOICE is not a builtin command in native cmd.exe, but I kept it builtin for simplicity, - CHOICE was (partially) implemented using syntax from MS-DOS days; it has been moved to use Windows' syntax. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6090

3 7

[PATCH 0/1] MR6094: server: Mark the socket as cacheable when it is an accepted or accepted-into socket.
by Jinoh Kang (＠iamahuman) 17 Jul '24

17 Jul '24

Should fix DJMAX RESPECT V. Fixes: 89f77a93a6c96896d90c943bc3e82139114cf58c Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56977 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6094

5 5

2025

2024

2023

2022

wine-gitlab