--
v7: user32/edit: Add some WM_ASKCBFORMATNAME tests.
user32/tests: Add tests for NULL strings with edit control GETTEXT message.
comctl32/tests: Add tests for NULL strings with edit control GETTEXT message.
user32: Fail on NULL string for edit control WM_GETTEXT message.
comctl32: Fail on NULL string for edit control WM_GETTEXT message.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6004
--
v6: user32/edit: Add some WM_ASKCBFORMATNAME tests.
user32/tests: Add tests for NULL strings with edit control GETTEXT message.
comctl32/tests: Add tests for NULL strings with edit control GETTEXT message.
user32: Fail on NULL string for edit control WM_GETTEXT message.
comctl32: Fail on NULL string for edit control WM_GETTEXT message.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6004
--
v5: user32/edit: Add some WM_ASKCBFORMATNAME tests.
comctl32/user32: Add tests for NULL strings with edit control GETTEXT message.
user32: Correctly handle NULL string in GETTEXT/CBFORMAT AtoW wrapper.
comctl32/user32: Fail on NULL string for edit control WM_GETTEXT message.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6004
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c:
> CoUninitialize();
> }
>
> +static void test_LVM_GETNEXTITEM(void)
Please add the tests first and put them in a separate commit. You can mark the tests that are failing on Wine with a todo_wine.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_76062
The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset.
The other is just a fix for when parameters are NULL when passed in (Same the the W version).
--
v3: odbc32: SQLError handle NULL handles
https://gitlab.winehq.org/wine/wine/-/merge_requests/6063
Wine renamed the "Application Data" directory to "AppData" in commit
4111801ab31 ("shell32: Use winvista+ AppData paths.", 2021-05-27), so we
can use it for the temp directory now without having to worry about
spaces in the path.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6071
Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it.
Before these patches, surface data for planar formats is not copied
correctly when the application uses a custom allocator-presenter and
allocates a surface of different size than the VMR9 source.
Patch 2/2 adds support for performing this copy correctly when the
source dimensions are less or equal than the rendering surface
dimensions.
---
I have some questions:
- Should I also make it work for when the dst is smaller than the src?
- If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope.
- Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6069
The first two patches here address an issue I encountered when using Wine's d3dx9 with DXVK in the game Command and Conquer 3. The game calls `D3DXLoadSurfaceFromMemory` on a multisampled render target. This ends up going through the `lock_surface()` helper in d3dx9, which eventually calls `UpdateSurface()` in `unlock_surface()` to copy the staging surface back to the multisampled render target. This succeeds on wined3d even though it shouldn't, and fails on DXVK like it should.
The second two patches address an issue reported in Empires: Dawn of the Modern World, where the game expects a device reset to reset the scene state.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6042
The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a
reviewer to clarify the MSC structs details)
--
v4: winedump: Initialize size variable in dump_dir_exceptions().
winedump: Use offsetof() for string position calculations.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5625
GCC 14.1 emits a bunch of warning when compiling (winedump & dbghelp).
This stems from some of the structures attempting to reflect file
layout (after serialisation), whereas the variable length of
some contiguous fields make it impossible (in C).
So use flexible array members for variable length arrays,
and use an FAM as well for packing the more complicated bits.
This keeps these data blocks as C structures for the fields
that can be directly mapped, and leave to the caller the
responsability of deserializing the rest.
This seem to be enough to get rid of these GCC warnings.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6064
Fixed rotation of angles < 90deg in bus_sdl.
Align logical max of angles to physical max defined in dinput (35900). Before, a polar angle of eg 90deg would end up in bus_sdl/bus_udev as 90.25deg.
--
v4: winebus.sys: Align logical max of angles to physical max defined in dinput
winebus.sys: Fix rotation for angles < 90deg
https://gitlab.winehq.org/wine/wine/-/merge_requests/6043
The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset.
The other is just a fix for when parameters are NULL when passed in (Same the the W version).
--
v2:
https://gitlab.winehq.org/wine/wine/-/merge_requests/6063