- wine-gitlab - winehq.org

[PATCH v8 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v8: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Hans Leidekker (＠hans) 09 Jul '24

09 Jul '24

In my tests GetUserNameEx(NameDisplay) returns ERROR_NONE_MAPPED on Windows. It seems that the Windows machine needs to be joined to a Windows domain for this call to return something sensible. Do you have an application that depends this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75538

1 0

[PATCH 0/1] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) 09 Jul '24

09 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

4 4

[PATCH v10 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v10: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

2 2

[PATCH 0/1] MR6024: ntoskrnl.exe: add a stub for KeQueryGroupAffinity
by Austin English (＠austin987) 09 Jul '24

09 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56948 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6024

2 1

[PATCH v7 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v7: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

[PATCH v6 0/2] MR5969: Draft: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v6: kernelbase: Ensure null termination in RegGetValue[AW]. windowscodecs: Use RegQueryValueExW in ComponentInfo_GetStringValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

2 2

[PATCH 0/6] MR5999: d3dx9: Miscellaneous fixes.
by Connor McAdams (＠cmcadams) 09 Jul '24

09 Jul '24

This MR contains patches with a few small fixes for things that have been found while working on the usual shared code patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5999

3 11

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Jul '24

08 Jul '24

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/mmdevapi/tests/render.c: > + NULL, (void**)&ac); > + ok(hr == S_OK, "Activation failed with %08lx\n", hr); > + if(hr != S_OK) > + return; > + > + hr = IAudioClient_GetMixFormat(ac, &pwfx); > + ok(hr == S_OK, "GetMixFormat failed: %08lx\n", hr); > + > + hr = IAudioClient_Initialize(ac, AUDCLNT_SHAREMODE_SHARED, 0, 5000000, > + 0, pwfx, NULL); > + ok(hr == S_OK, "Initialize failed: %08lx\n", hr); > + > + CoTaskMemFree(pwfx); > + > + /* contrary to what MSDN says this interface should be obtained via QueryInterface() */ > + hr = IAudioClient_GetService(ac, &IID_IAudioClockAdjustment, (void**)&aca); cracked the mystery, im pretty sure AUDCLNT_STREAMFLAGS_RATEADJUST is needed for GetService to work :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75515

1 0

Re: [PATCH v3 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6019

1 0

Re: [PATCH v2 0/1] MR6020: msv1_0: Add support for SECPKG_CRED_BOTH. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6020

1 0

Re: [PATCH v2 0/3] MR6016: mshtml: Refactor InvokeEx implementation. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6016

1 0

Re: [PATCH v3 0/3] MR5970: win32u: Use the thread message queue shared memory in peek_message. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5970

1 0

Re: [PATCH v2 0/1] MR6017: mf/tests: Remove static specifier on variables referencing other variables. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6017

1 0

Re: [PATCH v2 0/1] MR6018: winex11: Reset window shape whenever window surface is created. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6018

1 0

Re: [PATCH v2 0/7] MR6015: jscript: Refactor indexed properties handling. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6015

1 0

Re: [PATCH v2 0/1] MR6001: advapi32/tests: Drop security test workarounds for Windows <= 2000. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6001

1 0

Re: [PATCH v2 0/1] MR6008: advapi32/tests: Test RegGetValue[AW] null termination. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6008

1 0

Re: [PATCH v2 0/1] MR6013: msi: Avoid infinite recursion while processing the DrLocator table. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6013

1 0

Re: [PATCH v2 0/1] MR5619: win32u: Use FT_LOAD_PEDANTIC on first load try in freetype_get_glyph_outline(). - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5619

1 0

Re: [PATCH v2 0/7] MR6010: Cmd engine rewrite (part XVII) - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6010

1 0

[PATCH v2 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH.
by Dmitry Timoshkov (＠dmitry) 08 Jul '24

08 Jul '24

-- v2: kerberos: Add support for SECPKG_CRED_BOTH. https://gitlab.winehq.org/wine/wine/-/merge_requests/6019

4 4

[PATCH 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH.
by Dmitry Timoshkov (＠dmitry) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6019

4 6

[PATCH 0/1] MR6020: msv1_0: Add support for SECPKG_CRED_BOTH.
by Dmitry Timoshkov (＠dmitry) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6020

4 3

[PATCH v4 0/2] MR5976: Acquire filesystem labels from dbus
by Alfred Agrell (＠Alcaro) 08 Jul '24

08 Jul '24

-- v4: kernelbase: Delete now-inaccurate 'FS volume label not available' message. https://gitlab.winehq.org/wine/wine/-/merge_requests/5976

3 3

2025

2024

2023

2022

wine-gitlab