- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Loïc Rebmeister (＠Fox2Code) 29 Jun '24

29 Jun '24

Your pull request effectively make the code worse, as `{ L"Windows.Foundation.UniversalApiContract", 10, },` means `10` or lower. So `{ L"Windows.Foundation.UniversalApiContract", 7, },` was already included by `{ L"Windows.Foundation.UniversalApiContract", 10, },` But due to how `is_api_contract_present` work, it only take the first element with a name into consideration. This is a simplified pseudo code with comments of `is_api_contract_present` to show the loop stop at first name match: ```java boolean is_api_contract_present(String name,int version) { for (present_contract : present_contracts) // List though all entries if (present_contract.name == name)) // Check is name is equal return version <= present_contract.max_major; // Check if version is lower than max_major, and return return false; // No match found, return that we didn't found anything } ``` Note: the `return` keyword stop code execution, and return the value. (I'm assuming you didn't understood the code you sent there, as I'm pretty sure if you understood that code before sending it you wouldn't have opened this MR) Further more, `Windows.Foundation.UniversalApiContract` is a dotnet 5 feature. (Source: https://github.com/madewokherd/wine-mono/issues/151#issuecomment-1232824011) Wine (and Wine-mono) currently only support up to dotnet 4 on a clean install. If you want I can teach you code for free so you can actually read and understand the code before you are sending it to wine upstream. In the meantime I'll see what I can do to try to get the issue fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74750

1 0

[PATCH 0/3] MR5953: include: Add symbols for DirectXShaderCompiler project
by Biswapriyo Nath (＠Biswa96) 29 Jun '24

29 Jun '24

Required for https://github.com/microsoft/DirectXShaderCompiler.git -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5953

3 5

[PATCH v9 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 29 Jun '24

29 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v9: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

4 11

[PATCH 0/4] MR5908: misc: Use the correct interface for some COM calls.
by Elizabeth Figura (＠zfigura) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5908

5 9

Re: [PATCH v2 0/3] MR5950: msado15 command properties implementation. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5950

1 0

Re: [PATCH v3 0/9] MR5947: win32u: Factor layered surface attributes out of the drivers. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5947

1 0

Re: [PATCH v2 0/5] MR5949: Cmd engine rewrite (part XII) - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5949

1 0

Re: [PATCH v2 0/6] MR5948: jscript: Always free jsdisp_t in jsdisp_free. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5948

1 0

Re: [PATCH v3 0/6] MR5931: winegstreamer: Implement output type functions. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5931

1 0

Re: [PATCH v4 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion(). - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5816

1 0

Re: [PATCH v2 0/1] MR5945: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5945

1 0

[PATCH 0/1] MR5951: ntdll: Report the space completely outside of reserved areas as allocated on i386.
by Paul Gofman (＠gofman) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5951

2 2

[PATCH v31 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 28 Jun '24

28 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v31: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files.
by Connor McAdams (＠cmcadams) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5881

4 15

[PATCH v30 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 28 Jun '24

28 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v30: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH v29 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 28 Jun '24

28 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v29: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH 0/3] MR5950: msado15 command properties implementation.
by Alistair Leslie-Hughes (＠alesliehughes) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5950

2 3

[PATCH v2 0/9] MR5947: win32u: Factor layered surface attributes out of the drivers.
by Rémi Bernon (＠rbernon) 28 Jun '24

28 Jun '24

-- v2: winex11: Remove now unnecessary window surface BITMAPINFO. winewayland: Remove now unnecessary window surface BITMAPINFO. wineandroid: Remove now unnecessary window surface BITMAPINFO. winemac: Remove now unnecessary driver surface BITMAPINFO. win32u: Get rid of the unnecessary offscreen window surface struct. win32u: Introduce a new helper to get surface color info and bits. win32u: Pass BITMAPINFO and color bits to window surface flush. win32u: Introduce a new helper to update layered window surface attributes. win32u: Move layered surface attributes to the window_surface struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/5947

3 11

[PATCH 0/5] MR5949: Cmd engine rewrite (part XII)
by eric pouech (＠epo) 28 Jun '24

28 Jun '24

This part XII of cmd engine rewrite. This serie implements proper support for && and || command chaining operators: - implement proper precedence parsing - implement semantics for the operators - for this to work, we need to have expected success/failure from commands; this is supported here for external commands (and calling into a label or another BAT/CMD file), but support has to be added for all builtin commands - that's a big mess as behaviors is far from homogeneous among the builtins: + some builtin set coherent success/failure vs errorlevel information + some report success/failure, but only set errorlevel upon failure (keeping errorlevel from previous commands untouched), + some even report success (even in case of failure) yet set errorlevel in case of failure, - so the next series will now concentrate on testing success/failure and errorlevel for every builtin command (sigh) - for now, to help the transition phase, we can distinguish if a builtin properly reports success/failure; if a builtin with success/failure ability is used in a chaining operator, we implement the intented behavior of the chaining operator; otherwise, we keep old behavior (ie always execute LHS and RHS whatever the success/failure status). This shall be removed when all builtin commands report success/failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5949

2 5

[PATCH 0/6] MR5948: jscript: Always free jsdisp_t in jsdisp_free.
by Jacek Caban (＠jacek) 28 Jun '24

28 Jun '24

Instead of class-specific destructors. Also some other minor clean up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5948

2 6

[PATCH v2 0/6] MR5931: winegstreamer: Implement output type functions.
by Ziqing Hui (＠zhui) 28 Jun '24

28 Jun '24

-- v2: winegstreamer/video_encoder: Implement GetOutputCurrentType. winegstreamer/video_encoder: Implement SetOutputType. https://gitlab.winehq.org/wine/wine/-/merge_requests/5931

3 8

[PATCH 0/9] MR5947: win32u: Factor layered surface attributes out of the drivers.
by Rémi Bernon (＠rbernon) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5947

2 9

[PATCH v3 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion().
by Elizabeth Figura (＠zfigura) 28 Jun '24

28 Jun '24

This should reflect what we actually support, while still being a superset of what native drivers actually support. Native driver support varies, but, as the comments document, native drivers (at least as of windows 10) support only RGB -> RGB, YUV -> RGB, and BC -> RGB conversions. The actual formats supported are a more limited subset than exposed (despite that the video cards should be perfectly capable of supporting more conversions) but erring on the side of overreporting seems safer. -- v3: wined3d: Implement wined3d_check_device_format_conversion(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5816

3 2

[PATCH 0/6] MR5931: winegstreamer: Implement output type functions.
by Ziqing Hui (＠zhui) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5931

4 14

[PATCH 0/5] MR5946: Feed FFP shader constants through push constant buffers, part 2.
by Elizabeth Figura (＠zfigura) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5946

3 6

2025

2024

2023

2022

wine-gitlab