- wine-gitlab - winehq.org

[PATCH v6 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 27 Jun '24

27 Jun '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v6: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

3 5

[PATCH 0/1] MR5941: xcopy: Handle switch options concatenated with path.
by Piotr Caban (＠piotr) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5941

2 1

[PATCH 0/7] MR5930: win32u: Factor surface rect computation out of the drivers.
by Rémi Bernon (＠rbernon) 27 Jun '24

27 Jun '24

This clips surface rects which are larger than the virtual screen, keeping full window surfaces for one which are smaller. This makes sure that off-screen windows have valid pixels on overviews like macOS Exposé, or similarly, GNOME shell activities view. Supersedes both https://gitlab.winehq.org/wine/wine/-/merge_requests/5865 and https://gitlab.winehq.org/wine/wine/-/merge_requests/5878. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5930

3 8

Re: [PATCH v5 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Rémi Bernon (＠rbernon) 27 Jun '24

27 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c: > return true; > } > > +static ULONG popcount( ULONG val ) > +{ > +#if defined(__MINGW32__) > + return __builtin_popcount( val ); > +#else > + val -= val >> 1 & 0x55555555; > + val = (val & 0x33333333) + (val >> 2 & 0x33333333); > + return ((val + (val >> 4)) & 0x0f0f0f0f) * 0x01010101 >> 24; > +#endif > +} > + Well, now the __builtin_popcount path is never taken, because on the unix side it's not built with MinGW. There's a compiler check available already though. (Also mind the style change to match winegstreamer) ```suggestion:-10+0 static ULONG popcount(ULONG val) { #if HAVE___BUILTIN_POPCOUNT return __builtin_popcount(val); #else val -= val >> 1 & 0x55555555; val = (val & 0x33333333) + (val >> 2 & 0x33333333); return ((val + (val >> 4)) & 0x0f0f0f0f) * 0x01010101 >> 24; #endif } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923#note_74516

1 0

Re: [PATCH v5 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Rémi Bernon (＠rbernon) 27 Jun '24

27 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c: > return STATUS_UNSUCCESSFUL; > } > > + if (SUCCEEDED(NtQueryInformationProcess( GetCurrentProcess(), > + ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL ))) > + thread_count = popcount(process_mask); > + else > + thread_count = 0; ```suggestion:-4+0 if (!NtQueryInformationProcess(GetCurrentProcess(), ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL))) thread_count = popcount(process_mask); else thread_count = 0; ``` SUCCEEDED is for HRESULT, Nt API returns NTSTATUS and we often just check that it's 0. Also note the style fixes (no space in paren here, continuation indent is 8 spaces). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923#note_74517

1 0

[PATCH 0/1] MR5939: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5939

2 1

Re: [PATCH v5 0/6] MR5870: mmdevapi: Implement loopback capture with winepulse backend.
by Davide Beatrici (＠davidebeatrici) 27 Jun '24

27 Jun '24

On Thu Jun 27 01:41:40 2024 +0000, Davide Beatrici wrote: > Agreed. We may eventually want to make use of something like [clang-format](https://clang.llvm.org/docs/ClangFormat.html). https://gitlab.winehq.org/wine/wine/-/merge_requests/5938 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5870#note_74514

1 0

[PATCH 0/1] MR5938: Draft: Add clang-format configuration file
by Davide Beatrici (＠davidebeatrici) 27 Jun '24

27 Jun '24

I tried to follow https://wiki.winehq.org/Wine_Developer%27s_Guide/Coding_Practice as closely as possible. Known issues: - No break before brace for assignments. Upstream issue: https://github.com/llvm/llvm-project/issues/79054 - `ContinuationIndentWidth` affects everything. Instead, we want it to be 8 for function arguments and 4 for assignments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5938

2 1

Re: [PATCH v3 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Zhiyi Zhang (＠zhiyi) 27 Jun '24

27 Jun '24

> It fails on asserting return value of sending LVM_GETNEXTITEM message In that case, please also add a test checking the same thing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_74512

1 0

[PATCH v7 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 27 Jun '24

27 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v7: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

4 5

[PATCH 0/2] MR5937: Fix hotpatch prologue in GetProcAddress().
by Paul Gofman (＠gofman) 26 Jun '24

26 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5937

3 3

[PATCH v3 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 26 Jun '24

26 Jun '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v3: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

2 8

Re: [PATCH v2 0/1] MR5936: mscoree: Update Wine Mono to 9.2.0. - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5936

1 0

Re: [PATCH v4 0/7] MR5912: win32u: Create a shared memory object for message queue and read active hooks bitmap from it. - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5912

1 0

Re: [PATCH v2 0/5] MR5932: Cmd engine rewrite (part X) - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5932

1 0

Re: [PATCH v5 0/6] MR5870: mmdevapi: Implement loopback capture with winepulse backend. - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5870

1 0

Re: [PATCH v2 0/1] MR5928: msado15: Support interface ADOCommandConstruction in _Command - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5928

1 0

Re: [PATCH v3 0/2] MR5927: quartz: Implement IVMRWindowlessControl::GetNativeVideoSize(). - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5927

1 0

[PATCH 0/1] MR5936: mscoree: Update Wine Mono to 9.2.0.
by Esme Povirk (＠madewokherd) 26 Jun '24

26 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5936

3 2

Re: [PATCH v2 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Ilia Docin (＠IDocin) 26 Jun '24

26 Jun '24

On Wed Jun 26 07:26:50 2024 +0000, Zhiyi Zhang wrote: > This looks correct at first glance. Do you have an application affected > by this? It seems to me changing this only reduces some time and -1 will > be returned if it's the last item. Yes, I have. It fails on asserting return value of sending LVM_GETNEXTITEM message. I agree about aftereffect of this fix. Anyway, for me it doesn't make sense to handle ahead of time incorrect item (== infoPtr->nItemCount). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_74482

1 0

Re: [PATCH v5 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper
by Ilia Docin (＠IDocin) 26 Jun '24

26 Jun '24

On Wed Jun 26 07:15:20 2024 +0000, Zhiyi Zhang wrote: > Do you have a link to the software you used to demonstrate? No. It's a commercial software. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_74478

1 0

[PATCH v2 0/6] MR5926: ntdll: Always fill the 32-bit IOSB when performing I/O on overlapped handles.
by Elizabeth Figura (＠zfigura) 26 Jun '24

26 Jun '24

Previously it was assumed that synchronous I/O fills the 64-bit IOSB, and asynchronous I/O fills the 32-bit IOSB. As the ntdll:wow64 tests show, this is incorrect. I/O on an overlapped handle, whether it is synchronous or not, fills the 32-bit IOSB, and I/O on a non-overlapped handle always fills the 64-bit IOSB. The first half is important, since completion can be signaled before we even return from the initial I/O call [NtReadFile() etc.] Filling the IOSB after signaling completion is the cause of bug 56389. This patch series fixes that. The second discrepancy does not cause any bugs, as far as I can see, and is a bit harder to fix anyway. It is therefore not addressed by this patch series. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56389 -- v2: ntdll: Always fill the 32-bit iosb for overlapped handles, for regular read/write. ntdll: Always fill the 32-bit iosb for overlapped handles, in set_async_direct_result(). ntdll: Always fill the 32-bit iosb for overlapped handles, in file_complete_async(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5926

2 7

[PATCH 0/10] MR5934: ntdll: Improvements related to preferred UI languages
by Piotr Caban (＠piotr) 26 Jun '24

26 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5934

2 10

[PATCH v4 0/6] MR5870: mmdevapi: Implement loopback capture with winepulse backend.
by Paul Gofman (＠gofman) 26 Jun '24

26 Jun '24

-- v4: mmdevapi/tests: Add test for capturing render loopback. winepulse.drv: Implement pulse_get_loopback_capture_device(). winepulse.drv: Factor out wait_pa_operation_complete(). mmdevapi: Stub AUDCLNT_STREAMFLAGS_LOOPBACK support. mmdevapi: Adjust timing after main loop start in client_Initialize(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5870

4 9

[PATCH v3 0/1] MR5809: winecrt0, msvcrt: Implement static constructor support.
by Rémi Bernon (＠rbernon) 26 Jun '24

26 Jun '24

-- v3: winecrt0: Implement static constructors support. https://gitlab.winehq.org/wine/wine/-/merge_requests/5809

4 7

2025

2024

2023

2022

wine-gitlab