- wine-gitlab - winehq.org

[PATCH 0/1] MR8078: windows.ui: Fix a double free.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

The object reference is actually held by ref_weak. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8078

5 10

[PATCH 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020

3 45

[PATCH 0/2] MR8045: comctl32: Implement EVENT_OBJECT_VALUECHANGE for trackbars.
by Esme Povirk (＠madewokherd) 19 May '25

19 May '25

Unfortunately, this can't be properly tested because of todo's in the message sequence. The event does show up in response to TPM_SETPOS, at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8045

3 5

[PATCH 0/1] MR8081: opengl32: Move legacy extensions fixup from winex11.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8081

2 1

[PATCH 0/1] MR8080: winex11: Remove unnecessary mutable_pf member.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8080

2 1

[PATCH v2 0/1] MR8071: ucrtbase/tests: Avoid reading behind buffer in test_swprintf (ASan).
by Bernhard Übelacker (＠bernhardu) 19 May '25

19 May '25

The test `test_swprintf` creates an un-terminated buffer and calls `WideCharToMultiByte` without explicit srclen on it. This patch wraps the buffer into a struct providing a termination without modifying the test itself. <details> <summary>ASan output:</summary> ``` ================================================================= ==ucrtbase_test.exe==532==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ffac0 at pc 0x6ffffe845638 bp 0x7ffffe1ff030 sp 0x7ffffe1ff078 READ of size 24 at 0x7ffffe1ffac0 thread T0 #0 0x6ffffe845637 in wcslen C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/../sanitizer_common\sanitizer_common_interceptors.inc:7215:3 #1 0x6fffff7d1eff in lstrlenW .../wine/include/winbase.h:2574:5 #2 0x6fffff7d2a33 in WideCharToMultiByte .../wine/dlls/kernelbase/locale.c:7382:30 #3 0x000140016e6c in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:196:9 #4 0x000140015f3e in func_printf .../wine/dlls/ucrtbase/tests/printf.c:891:5 #5 0x00014002da0e in run_test .../wine/include/wine/test.h:765:5 #6 0x00014002d53a in main .../wine/include/wine/test.h:884:12 #7 0x00014002f005 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #8 0x6fffffc355be in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #9 0x6fffffdbbcc2 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004bcc2) Address 0x7ffffe1ffac0 is located in stack of thread T0 at offset 256 in frame #0 0x000140016b6f in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:176 This frame has 8 object(s): [32, 44) 'str_short' (line 177) [64, 80) 'str_justfit' (line 178) [96, 114) 'str_justfits' (line 179) [160, 182) 'str_muchlonger' (line 180) [224, 226) 'str_empty' (line 181) [240, 256) 'buffer' (line 184) [272, 280) 'narrow' (line 185) <== Memory access at offset 256 partially underflows this variable [304, 320) 'narrow_fmt' (line 185) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/winbase.h:2574:5 in lstrlenW Shadow bytes around the buggy address: 0x7ffffe1ff800: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 04 f2 f2 0x7ffffe1ffa00: 00 00 f2 f2 00 00 02 f2 f2 f2 f2 f2 00 00 06 f2 =>0x7ffffe1ffa80: f2 f2 f2 f2 02 f2 00 00[f2]f2 00 f2 f2 f2 00 00 0x7ffffe1ffb00: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f8 0x7ffffe1ffd00: f8 f8 f8 f8 f3 f3 f3 f3 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ``` </details> -- v2: ucrtbase/tests: Avoid reading behind buffer in test_swprintf (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/8071

3 4

[PATCH v2 0/2] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- v2: winex11: Serialize fullscreen/maximized and config changes. winex11: Trace more window change request serials. https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

2 2

[PATCH 0/2] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

2 2

[PATCH v6 0/1] MR8017: wined3d: Swap wined3d_resource.heap_pointer on swapchain present.
by Panayiotis Talianos (＠panintended) 19 May '25

19 May '25

wined3d_resource_free_sysmem() uses wined3d_resource.heap_pointer to deallocate wined3d_resource.heap_memory. Preserve pairing of heap_pointer/heap_memory to prevent deallocation of incorrect heap_memory. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57387 -- v6: wined3d: Swap wined3d_resource.heap_pointer on swapchain present. https://gitlab.winehq.org/wine/wine/-/merge_requests/8017

3 3

[PATCH 0/5] MR7973: wined3d: Move FFP extra states away from STATE_RENDER, part 4/4.
by Elizabeth Figura (＠zfigura) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7973

3 6

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 08:50:06 2025 +0000, Zhiyi Zhang wrote: > I will fix this. Thanks for spotting this. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078 should fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103801

1 0

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 08:23:31 2025 +0000, Nikolay Sivov wrote: > I don't think this works, see [1]. You're freeing the same thing using > two separate counters. My guess is that weak reference has to be a > separate object, main object would keep a regular reference to it, once > main thing is released it would clear itself from weak ref object. That > will be an indication to fail Resolve(). I doesn't seem necessary to > have multiple weak reference objects, that simplifies things. > [1] https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-05-06_wine-10.… I will fix this. Thanks for spotting this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103799

1 0

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Nikolay Sivov (＠nsivov) 19 May '25

19 May '25

Nikolay Sivov (@nsivov) commented about dlls/windows.ui/uisettings.c: > IUISettings3 IUISettings3_iface; > IUISettings4 IUISettings4_iface; > IUISettings5 IUISettings5_iface; > - LONG ref; > + IWeakReferenceSource IWeakReferenceSource_iface; > + IWeakReference IWeakReference_iface; > + LONG ref_strong; > + LONG ref_weak; > }; I don't think this works, see [1]. You're freeing the same thing using two separate counters. My guess is that weak reference has to be a separate object, main object would keep a regular reference to it, once main thing is released it would clear itself from weak ref object. That will be an indication to fail Resolve(). I doesn't seem necessary to have multiple weak reference objects, that simplifies things. [1] https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-05-06_wine-10.… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103796

1 0

Re: [PATCH v45 0/2] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 May '25

19 May '25

Latest changes pushed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103790

1 0

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 00:58:42 2025 +0000, Zhiyi Zhang wrote: > I will send a fix. Thanks for spotting this. https://gitlab.winehq.org/wine/wine/-/merge_requests/8074 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103774

1 0

[PATCH 0/1] MR8074: include: Avoid a C++ keyword.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8074

2 1

[PATCH 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) 19 May '25

19 May '25

1. For %fs/fsbase the patch follows the macOS logic with LDT descriptor registration and Linux with switching. One notable difference is that on 32->64 transition we set %fs to GSEL(GUFS32_SEL, SEL_UPL) before restoring fsbase, otherwise FreeBSD will just revert it by reloading the selector [at the first opportunity](https://github.com/freebsd/freebsd-src/blob/5673462af5330df207…. GSEL(GUFS32_SEL, SEL_UPL) is the default %fs value on FreeBSD and is special-cased to save/restore actual fsbase value to/from PCB. 2. I was told we could get rid of fsbase glitches in signal handlers by blocking signals with [sigfastblock(2)](https://man.freebsd.org/cgi/man.cgi?query=sigfastblock) between %fs reset to the default value and fsbase reset to pthread_teb. This is currently a part of internal API for libthr, which could be exposed as pthread_signal_block_np for Wine. I'm on the fence whether it's worth it. 3. I fully admit I have no idea what registers are worth preserving around fallback syscalls to sysarch(AMD64_SET_FSBASE) and whether it's appropriate to push those to stack. ("Kernel" stack should be fine, I assume?) They definitely clobber r8-r11. 4. For %ss see https://lkml.org/lkml/2015/4/24/216. We don't have a similar workaround in the kernel, so it goes into Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8073

2 2

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Sun May 18 07:29:08 2025 +0000, Biswapriyo Nath wrote: > This causes error in C++ > ``` > error: invalid parameter name: 'namespace' is a keyword > ``` I will send a fix. Thanks for spotting this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103770

1 0

[PATCH v3 0/1] MR8072: oledb32: Skip whitespaces around properties names and values in datainit_GetDataSource.
by Piotr Caban (＠piotr) 18 May '25

18 May '25

-- v3: oledb32: Remove leading whitespaces from property name in datainit_GetDataSource. https://gitlab.winehq.org/wine/wine/-/merge_requests/8072

2 1

[PATCH 0/1] MR8071: ucrtbase/tests: Avoid reading behind buffer in test_swprintf (ASan).
by Bernhard Übelacker (＠bernhardu) 18 May '25

18 May '25

The test `test_swprintf` creates an un-terminated buffer and calls `WideCharToMultiByte` without explicit srclen on it. This patch wraps the buffer into a struct providing a termination without modifying the test itself. <details> <summary>ASan output:</summary> ``` ================================================================= ==ucrtbase_test.exe==532==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ffac0 at pc 0x6ffffe845638 bp 0x7ffffe1ff030 sp 0x7ffffe1ff078 READ of size 24 at 0x7ffffe1ffac0 thread T0 #0 0x6ffffe845637 in wcslen C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/../sanitizer_common\sanitizer_common_interceptors.inc:7215:3 #1 0x6fffff7d1eff in lstrlenW .../wine/include/winbase.h:2574:5 #2 0x6fffff7d2a33 in WideCharToMultiByte .../wine/dlls/kernelbase/locale.c:7382:30 #3 0x000140016e6c in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:196:9 #4 0x000140015f3e in func_printf .../wine/dlls/ucrtbase/tests/printf.c:891:5 #5 0x00014002da0e in run_test .../wine/include/wine/test.h:765:5 #6 0x00014002d53a in main .../wine/include/wine/test.h:884:12 #7 0x00014002f005 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #8 0x6fffffc355be in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #9 0x6fffffdbbcc2 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004bcc2) Address 0x7ffffe1ffac0 is located in stack of thread T0 at offset 256 in frame #0 0x000140016b6f in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:176 This frame has 8 object(s): [32, 44) 'str_short' (line 177) [64, 80) 'str_justfit' (line 178) [96, 114) 'str_justfits' (line 179) [160, 182) 'str_muchlonger' (line 180) [224, 226) 'str_empty' (line 181) [240, 256) 'buffer' (line 184) [272, 280) 'narrow' (line 185) <== Memory access at offset 256 partially underflows this variable [304, 320) 'narrow_fmt' (line 185) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/winbase.h:2574:5 in lstrlenW Shadow bytes around the buggy address: 0x7ffffe1ff800: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 04 f2 f2 0x7ffffe1ffa00: 00 00 f2 f2 00 00 02 f2 f2 f2 f2 f2 00 00 06 f2 =>0x7ffffe1ffa80: f2 f2 f2 f2 02 f2 00 00[f2]f2 00 f2 f2 f2 00 00 0x7ffffe1ffb00: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f8 0x7ffffe1ffd00: f8 f8 f8 f8 f3 f3 f3 f3 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8071

3 2

[PATCH 0/1] MR8072: oledb32: Skip whitespaces around properties names and values in datainit_GetDataSource.
by Piotr Caban (＠piotr) 18 May '25

18 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8072

2 1

[PATCH 0/5] MR8070: msado15: Recordset ActiveConnection related changes.
by Piotr Caban (＠piotr) 18 May '25

18 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8070

2 5

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about include/consoleapi.h: > ULONG nLength; > ULONG nInitialChars; > ULONG dwCtrlWakeupMask; > - ULONG dwConsoleKeyState; this change (and the other ones using the correct field name) should be in a separate patch (inside the same merge request) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103751

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + > +static void set_cursor_visible(const HANDLE hOutput, const BOOL visible) > +{ > + CONSOLE_CURSOR_INFO cursorInfo; > + > + if (GetConsoleCursorInfo(hOutput, &cursorInfo)) { > + cursorInfo.bVisible = visible; > + SetConsoleCursorInfo(hOutput, &cursorInfo); > + } > +} > + > +static void build_search_string(WCHAR *inputBuffer, int len, SEARCH_CONTEXT *sc) > +{ > + int cc = 0, nn = 0; > + WCHAR *param = NULL, *last_param, *stripped_copy = NULL; > + WCHAR last_stripped_copy[MAX_PATH] = L"\0"; you likely want MAXSTRING here (native definitively works on strings longer than 260 chars) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103750

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + > +static void build_search_string(WCHAR *inputBuffer, int len, SEARCH_CONTEXT *sc) > +{ > + int cc = 0, nn = 0; > + WCHAR *param = NULL, *last_param, *stripped_copy = NULL; > + WCHAR last_stripped_copy[MAX_PATH] = L"\0"; > + BOOL need_wildcard = TRUE; > + > + sc->searchstr[0] = L'\0'; > + > + /* If inputBuffer ends in a space then the user hit tab beyond the last > + * parameter, so use that as the search pos (i.e. a wildcard search). > + * Otherwise, parse the buffer to find the last parameter in the buffer, > + * where tab was pressed. > + */ > + if (inputBuffer[len-1] == L' ') { len can be zero here (if \<tab\> is pressed at beg of line) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103749

1 0

2025

2024

2023

2022

wine-gitlab