- wine-gitlab - winehq.org

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + clear_console_characters(hOutput, maxLen - len, lastConsoleInfo.dwSize.X); /* width at time of last console update */ > + } > + set_cursor_visible(hOutput, TRUE); > + > + /* Remember current dimensions in case user resizes console window. */ > + GetConsoleScreenBufferInfo(hOutput, &lastConsoleInfo); > + > + inputControl.nLength = sizeof(inputControl); > + inputControl.nInitialChars = len; > + inputControl.dwCtrlWakeupMask = (1 << '\t'); > + inputControl.dwControlKeyState = 0; > + > + /* Allow room for NULL terminator. inputBufferLength is at least 1 due to check above. */ > + ret = ReadConsoleW(hInput, inputBuffer, inputBufferLength - 1, numRead, &inputControl); > + > + if (ret) { I'd rather do `if (!ret) break;` so that you gain an indentation level afterwards -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103748

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + sc.have_quotes = FALSE; > + sc.user_specified_quotes = FALSE; > + sc.search_pos = 0; > + sc.insert_pos = 0; > + > + build_search_string(inputBuffer, curPos, &sc); > + TRACE("***** New search: [%s]\n", wine_dbgstr_w(sc.searchstr)); > + > + sc.is_dir_search = is_directory_operation(inputBuffer); > + > + free_directory_entry_list(&sc); > + build_directory_entry_list(&sc); > + } > + > + if (sc.entry_count) { > + get_next_matching_directory_entry(&sc, (inputControl.dwControlKeyState & SHIFT_PRESSED) ? TRUE : FALSE); when starting a new iteration ,you start on second element (index 1) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103747

1 0

[PATCH v6 0/1] MR8051: timeout/tests: Move the ctrl-c tests below an intermediate process.
by Bernhard Übelacker (＠bernhardu) 18 May '25

18 May '25

Failing gitlab CI examples are: - [job #157583](https://gitlab.winehq.org/wine/wine/-/jobs/157583#L2282) - [job #157314](https://gitlab.winehq.org/wine/wine/-/jobs/157314#L1957) - [job #157131](https://gitlab.winehq.org/wine/wine/-/jobs/157131#L2052) - [job #157068](https://gitlab.winehq.org/wine/wine/-/jobs/157068#L1955) - [job #157032](https://gitlab.winehq.org/wine/wine/-/jobs/157032#L2150) - [job #156785](https://gitlab.winehq.org/wine/wine/-/jobs/156785#L2112) - [job #156713](https://gitlab.winehq.org/wine/wine/-/jobs/156713#L2048) - [job 156677#](https://gitlab.winehq.org/wine/wine/-/jobs/156677#L2030) So happens just a few times per day. The value -1073741510 in `timeout.exe:timeout:06b4 done (-1073741510) in 5s 177B` equals to 0xC000013A, STATUS_CONTROL_C_EXIT. Therefore the assumption the ctrl-c from the test reaches sometimes the parent process. -- v6: timeout/tests: Move the ctrl-c tests below an intermediate process. https://gitlab.winehq.org/wine/wine/-/merge_requests/8051

3 3

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Biswapriyo Nath (＠Biswa96) 18 May '25

18 May '25

Biswapriyo Nath (@Biswa96) commented about include/d3d11shader.h: > +#undef INTERFACE > + > +DEFINE_GUID(IID_ID3D11FunctionLinkingGraph, 0x54133220, 0x1ce8, 0x43d3, 0x82, 0x36, 0x98, 0x55, 0xc5, 0xce, 0xec, 0xff); > + > +#define INTERFACE ID3D11FunctionLinkingGraph > +DECLARE_INTERFACE_(ID3D11FunctionLinkingGraph, IUnknown) > +{ > + STDMETHOD(QueryInterface)(THIS_ REFIID iid, void **out) PURE; > + STDMETHOD_(ULONG, AddRef)(THIS) PURE; > + STDMETHOD_(ULONG, Release)(THIS) PURE; > + > + /* ID3D11FunctionLinkingGraph methods */ > + STDMETHOD(CreateModuleInstance)(THIS_ ID3D11ModuleInstance **instance, ID3DBlob **error) PURE; > + STDMETHOD(SetInputSignature)(THIS_ const D3D11_PARAMETER_DESC *parameter_desc, UINT parameter_count, ID3D11LinkingNode **input_node) PURE; > + STDMETHOD(SetOutputSignature)(THIS_ const D3D11_PARAMETER_DESC *parameter_desc, UINT parameter_count, ID3D11LinkingNode **output_node) PURE; > + STDMETHOD(CallFunction)(THIS_ LPCSTR namespace, ID3D11Module *module, LPCSTR function_name, ID3D11LinkingNode **call_node) PURE; This causes error in C++ ``` error: invalid parameter name: 'namespace' is a keyword ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103738

1 0

[PATCH v3 0/10] MR8047: Draft: dxcore: Implement IDXCoreAdapterList::GetAdapterCount().
by Mohamad Al-Jaf (＠maljaf) 18 May '25

18 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58133 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58192 -- v3: dxcore: Implement IDXCoreAdapter::GetProperty( HardwareID ). dxcore/tests: Add IDXCoreAdapter::GetProperty() tests. dxcore: Implement IDXCoreAdapterList::GetAdapter(). dxcore/tests: Add IDXCoreAdapterList::GetAdapter() tests. dxcore: Implement IDXCoreAdapterList::GetAdapterCount(). dxcore: Partially implement IDXCoreAdapterFactory::CreateAdapterList(). dxcore/tests: Add IDXCoreAdapterFactory::CreateAdapterList() tests. dxcore: Implement DXCoreCreateAdapterFactory(). dxcore/tests: Add DXCoreCreateAdapterFactory() tests. include: Add dxcore C interface macros. https://gitlab.winehq.org/wine/wine/-/merge_requests/8047

2 11

[PATCH 0/1] MR8069: gdiplus: Remove repeated points before widening paths.
by Esme Povirk (＠madewokherd) 17 May '25

17 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58203 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8069

2 1

[PATCH 0/1] MR7920: winecoreaudio: Fallback to pre-per-channel audio if the audio device does not support it
by Ada Ahmed (＠yretenai) 17 May '25

17 May '25

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

4 11

[PATCH 0/1] MR8031: winex11: Ensure initialized thread data in X11DRV_get_ic.
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 May '25

17 May '25

Intends to replace: https://gitlab.winehq.org/wine/wine-staging/-/blob/master/patches/winex11-i… This patch has been in proton for almost 2 years now, never realized the same code existed upstream, lol -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8031

3 4

[PATCH 0/3] MR8067: Fixes for compiler __try/__except support
by Jacek Caban (＠jacek) 17 May '25

17 May '25

This change allows building with compiler exception support enabled (`-DUSE_COMPILER_EXCEPTIONS`) on non-i386 targets. On i386, `_except_handler3` needs to be available. While we provide it as an import from the msvcrt DLLs, that's not sufficient for modules like kernel32. Making this work would likely require moving `_except_handler3` to `winecrt0`. In practice, this fixes the build with Clang, although the resulting binaries do not appear to be fully correct yet. Further investigation is needed, likely on the LLVM side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8067

3 4

Re: [PATCH v4 0/2] MR8006: windowscodecs/tests: Add some tests for multi-frame tiffs vs SUBFILETYPE tag.
by Nikolay Sivov (＠nsivov) 17 May '25

17 May '25

On Wed May 14 09:56:09 2025 +0000, Nikolay Sivov wrote: > Thank you. Hopefully !8040 helps. Looks like results are clean now, thanks again for letting me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8006#note_103716

1 0

Re: [PATCH v5 0/1] MR8017: wined3d: Swap wined3d_resource.heap_pointer on swapchain present. - approved
by Elizabeth Figura (＠zfigura) 17 May '25

17 May '25

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8017

1 0

[PATCH v2 0/6] MR8047: dxcore: Implement IDXCoreAdapterList::GetAdapterCount().
by Mohamad Al-Jaf (＠maljaf) 17 May '25

17 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58133 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58192 -- v2: dxcore: Implement IDXCoreAdapterList::GetAdapterCount(). dxcore: Partially implement IDXCoreAdapterFactory::CreateAdapterList(). dxcore/tests: Add IDXCoreAdapterFactory::CreateAdapterList() tests. dxcore: Implement DXCoreCreateAdapterFactory(). dxcore/tests: Add DXCoreCreateAdapterFactory() tests. include: Add dxcore C interface macros. https://gitlab.winehq.org/wine/wine/-/merge_requests/8047

5 11

[PATCH v3 0/1] MR8063: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller
by Lorenzo Ferrillo (＠llde) 16 May '25

16 May '25

Application using Delphi runtime with Virtual-TreeView module, like xEdit, pass a NULL IDropSource to SHDoDragDrop, prevnting the drag and drop to works at all, when used in Windos Vista and above compatiblity mode, while windows xp compatibility mode works (as it use a dfferent system). Documentation stated that Windows Vista and above will create an internal IDropSource in this case. Creating a dummy IDropSource with minimal functionality allow the drag and drop to works using the default cursor. In case of xEdit it won't show the cell that it's being dragged like on windows, a functionality that require a full implementation of IDropSource::GiveFeedback and DragSourceHelper2::InitializeFromBitmap. Solve the functional part of #54923 I'm unsure on how to write tests for this. -- v3: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller https://gitlab.winehq.org/wine/wine/-/merge_requests/8063

2 1

[PATCH v2 0/1] MR8063: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller
by Lorenzo Ferrillo (＠llde) 16 May '25

16 May '25

Application using Delphi runtime with Virtual-TreeView module, like xEdit, pass a NULL IDropSource to SHDoDragDrop, prevnting the drag and drop to works at all, when used in Windos Vista and above compatiblity mode, while windows xp compatibility mode works (as it use a dfferent system). Documentation stated that Windows Vista and above will create an internal IDropSource in this case. Creating a dummy IDropSource with minimal functionality allow the drag and drop to works using the default cursor. In case of xEdit it won't show the cell that it's being dragged like on windows, a functionality that require a full implementation of IDropSource::GiveFeedback and DragSourceHelper2::InitializeFromBitmap. Solve the functional part of #54923 I'm unsure on how to write tests for this. -- v2: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller https://gitlab.winehq.org/wine/wine/-/merge_requests/8063

2 2

[PATCH 0/1] MR8063: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller
by Lorenzo Ferrillo (＠llde) 16 May '25

16 May '25

Application using Delphi runtime with Virtual-TreeView module, like xEdit, pass a NULL IDropSource to SHDoDragDrop, prevnting the drag and drop to works at all, when used in Windos Vista and above compatiblity mode, while windows xp compatibility mode works (as it use a dfferent system). Documentation stated that Windows Vista and above will create an internal IDropSource in this case. Creating a dummy IDropSource with minimal functionality allow the drag and drop to works using the default cursor. In case of xEdit it won't show the cell that it's being dragged like on windows, a functionality that require a full implementation of IDropSource::GiveFeedback and DragSourceHelper2::InitializeFromBitmap. Solve the functional part of #54923 I'm unsure on how to write tests for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8063

3 24

Re: [PATCH v2 0/4] MR8065: msado15: Make Fields part of rowset structure. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8065

1 0

Re: [PATCH v2 0/1] MR8064: winevulkan: Update to VK spec version 1.4.315. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8064

1 0

Re: [PATCH v2 0/1] MR8062: winebus: Skip device stop if it wasn't started. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8062

1 0

Re: [PATCH v2 0/1] MR7962: ntdll: Also relocate entry point for builtin modules. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7962

1 0

Re: [PATCH v2 0/2] MR8057: server: Support removing port from completion job. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8057

1 0

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060

1 0

[PATCH 0/4] MR8065: msado15: Make Fields part of rowset structure.
by Piotr Caban (＠piotr) 16 May '25

16 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8065

2 4

[PATCH 0/1] MR8064: winevulkan: Update to VK spec version 1.4.315.
by Georg Lehmann (＠DadSchoorse) 16 May '25

16 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8064

2 1

[PATCH 0/4] MR8059: dxgi: Implement subresource surface support.
by Zhiyi Zhang (＠zhiyi) 16 May '25

16 May '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8059

3 5

[PATCH v4 0/2] MR8010: win32u: Provide more gpu device properties.
by Bernhard Kölbl (＠besentv) 16 May '25

16 May '25

-- v4: win32u: Provide more gpu device properties. setupapi/tests: Add display enum tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/8010

3 4

2025

2024

2023

2022

wine-gitlab