- wine-gitlab - winehq.org

Re: [PATCH v4 0/1] MR7926: dsound/tests: Allocate right amount of memory in test_secondary8 (ASan). - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7926

1 0

Re: [PATCH v2 0/1] MR7868: combase: Find correct apartment in ClientRpcChannelBuffer_SendReceive(). - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7868

1 0

[PATCH 0/1] MR7965: quartz: Clamp MediaSeeking_GetCurrentPosition to the stop position.
by Alex Henrie (＠alexhenrie) 05 May '25

05 May '25

test_graph_seeking sets the stop time to 6 seconds and then checks that the media has stopped at that exact point in time. That test failed 10 out of the last 67 times on test.winehq.org because IMediaSeeking_GetCurrentPosition returned a time that was 1 millisecond after the stop time. To make the test pass consistently, clamp the current time to the stop time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7965

4 4

[PATCH 0/1] MR7972: ntdll: Treat TokenElevationTypeDefault tokens in the admin group as elevated.
by Tim Clem (＠tclem) 05 May '25

05 May '25

When queried by NtQueryInformationToken(TokenElevation). --- As the test shows, a TokenElevation query is more complex than a check against the elevation type. GOG Galaxy's updater relies on this behavior when its service is launched with a TokenElevationTypeDefault token (which doesn't currently happen, but I have patches in the works for that). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7972

2 2

[PATCH v5 0/4] MR6874: windows.devices.enumeration: Add a basic implementation for DeviceInformationStatics::FindAllAsync().
by Vibhav Pant (＠vibhavp) 05 May '25

05 May '25

The basic `FindAllAsync()` method returns a collection of `DeviceInformation` objects representing all device interfaces on the system. This MR adds a basic implementation of this method, and the associated `IDeviceInformation` and `DeviceInformationCollection` objects it returns. For `IDeviceInformation`, this MR only implements the `Id()` method, which returns the symbolic link for the registered interface. A basic working `DeviceInformation` and `FindAll` implementations are needed to implement `DeviceWatcher`'s `Added`, `Removed` events, which in turn is required for basic device discovery in `Windows.Devices.Bluetooth`. -- v5: windows.devices.enumeration: Create IDeviceInformation objects from all present device interfaces. windows.devices.enumeration: Add a stubbed IDeviceInformation implementation for device interfaces. windows.devices.enumeration: Add a stubbed implementation for FindAllAsync() and DeviceInformationCollection. windows.devices.enumeration/tests: Add conformance tests for FindAllAsync(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6874

2 5

[PATCH v4 0/8] MR6874: windows.devices.enumeration: Add a basic implementation for DeviceInformationStatics::FindAllAsync().
by Vibhav Pant (＠vibhavp) 05 May '25

05 May '25

The basic `FindAllAsync()` method returns a collection of `DeviceInformation` objects representing all device interfaces on the system. This MR adds a basic implementation of this method, and the associated `IDeviceInformation` and `DeviceInformationCollection` objects it returns. For `IDeviceInformation`, this MR only implements the `Id()` method, which returns the symbolic link for the registered interface. -- v4: windows.devices.enumeration: Implement IIterable<IDeviceInformation *> for DeviceInformationCollection. windows.devices.enumeration: Implement IndexOf() and GetMany() for DeviceInformationCollection. windows.devices.enumeration: Create IDeviceInformation objects from all present device interfaces. windows.devices.enumeration: Add a stubbed IDeviceInformation implementation for device interfaces. windows.devices.enumeration: Add a stubbed implementation for FindAllAsync() and DeviceInformationCollection. windows.devices.enumeration/tests: Add conformance tests for IIterable and IIterator interfaces in DeviceInformationCollection. windows.devices.enumeration/tests: Add conformance tests for GetMany() and IndexOf() methods in DeviceInformationCollection. windows.devices.enumeration/tests: Add conformance tests for FindAllAsync(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6874

3 22

[PATCH 0/5] MR7971: netapi32: WOW64 related improvements.
by Piotr Caban (＠piotr) 05 May '25

05 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7971

2 5

[PATCH v3 0/4] MR7928: coremessaging: Partially implement CreateDispatcherQueueController().
by Mohamad Al-Jaf (＠maljaf) 05 May '25

05 May '25

Needed by Paint.NET installer. -- v3: coremessaging: Partially implement CreateDispatcherQueueController(). coremessaging/tests: Add CreateDispatcherQueueController() tests. coremessaging/tests: Add IDispatcherQueueControllerStatics::CreateOnDedicatedThread() tests. coremessaging: Add IDispatcherQueueControllerStatics stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/7928

3 7

[PATCH 0/2] MR7969: windows.ui: Implement IUISettings5 stub.
by Mohamad Al-Jaf (＠maljaf) 05 May '25

05 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56983 Also needed by ReplayBook. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7969

3 3

[PATCH 0/1] MR7966: odbc32: SQLColAttributesW accept field id SQL_COLUMN_NAME.
by Alistair Leslie-Hughes (＠alesliehughes) 05 May '25

05 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7966

3 2

[PATCH v4 0/2] MR7893: user32/tests: Test BeginPaint() clipbox of cropped window with CS_PARENTDC.
by Dmitry Timoshkov (＠dmitry) 05 May '25

05 May '25

Extracted from https://gitlab.winehq.org/wine/wine/-/merge_requests/5665. -- v4: user32/tests: Add a message test for listbox redrawing after LB_SETCOUNT. user32/tests: Test BeginPaint() clipbox of cropped window with CS_PARENTDC. https://gitlab.winehq.org/wine/wine/-/merge_requests/7893

3 3

[PATCH v4 0/4] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) 05 May '25

05 May '25

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v4: hidclass: Set Status for pending IRPs of removed devices to STATUS_DEVICE_NOT_CONNECTED. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex](). https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

4 27

[PATCH 0/1] MR7963: mfmediaengine/tests: Mark a refcount test in test_SetCurrentTime as flaky.
by Alex Henrie (＠alexhenrie) 05 May '25

05 May '25

This test failed on Linux 10 out of the last 67 times on test.winehq.org. There is a very similar test for the refcount after shutdown in test_GetSeekable which is already marked as flaky. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7963

3 3

[PATCH v2 0/2] MR7893: user32/tests: Test BeginPaint() clipbox of cropped window with CS_PARENTDC.
by Dmitry Timoshkov (＠dmitry) 05 May '25

05 May '25

Extracted from https://gitlab.winehq.org/wine/wine/-/merge_requests/5665. -- v2: user32/tests: Add a message test for listbox redrawing after LB_SETCOUNT. user32/tests: Test BeginPaint() clipbox of cropped window with CS_PARENTDC. https://gitlab.winehq.org/wine/wine/-/merge_requests/7893

4 6

[PATCH 0/4] MR7967: wineandroid, winemac, winewayland, winex11: Remove now unnecessary GL function loading.
by Rémi Bernon (＠rbernon) 05 May '25

05 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7967

2 4

[PATCH 0/1] MR7961: msvcrt: Fix buffer overflow in __STRINGTOLD_L
by Yuxuan Shui (＠yshui) 05 May '25

05 May '25

__STRINGTOLD_L expects a pointer to a `_LDOUBLE` as its first argument, which we internally declare as `MSVCRT__LDOUBLE`. Problem is, `_LDOUBLE` is 10 bytes long, whereas `MSVCRT__LDOUBLE` is 12 bytes long (ULONG * 3). Writing into the third ULONG is technically a buffer overflow. Declare `MSVCRT__LDOUBLE` instead as 2 ULONGs plus a USHORT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7961

5 4

[PATCH 0/1] MR7958: opcservices: Fix string comparison in opc_part_uri_get_rels_uri.
by Alex Henrie (＠alexhenrie) 05 May '25

05 May '25

This has to have been a mistake: It doesn't make sense to look at the first two-and-a-half characters of relsdirW. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7958

3 2

[PATCH v2 0/3] MR6408: odbc32: Handle odbcv2 for GetData
by Alistair Leslie-Hughes (＠alesliehughes) 05 May '25

05 May '25

-- v2: odbc32: SQLColAttributesW support ODBC v2.0 odbc32: SQLGetData support ODBC v2.0 odbc32: Record loaded driver SQL_ATTR_ODBC_VERSION https://gitlab.winehq.org/wine/wine/-/merge_requests/6408

2 3

[PATCH 0/3] MR7943: windowscodecs: Fix information strings for the Ico decoder.
by Nikolay Sivov (＠nsivov) 05 May '25

05 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7943

3 4

[PATCH v2 0/2] MR7942: windowscodecs/tests: Add a test for 24bpp TIFF with separate sample planes.
by Nikolay Sivov (＠nsivov) 05 May '25

05 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs/tiff: Add support for files with separate planes. https://gitlab.winehq.org/wine/wine/-/merge_requests/7942

3 3

[PATCH 0/3] MR7941: windowscodecs/tests: Use wide-char literals in tests.
by Nikolay Sivov (＠nsivov) 05 May '25

05 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7941

3 4

[PATCH 0/2] MR7893: user32/tests: Test BeginPaint() clipbox of cropped window with CS_PARENTDC.
by Dmitry Timoshkov (＠dmitry) 05 May '25

05 May '25

Extracted from https://gitlab.winehq.org/wine/wine/-/merge_requests/5665. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7893

4 4

Re: [PATCH v3 0/1] MR7824: winegstreamer: Handle the Stream Group Done event.
by Brendan McGrath (＠redmcg) 04 May '25

04 May '25

On Fri May 2 17:55:41 2025 +0000, Elizabeth Figura wrote: > > > I guess native is supposed to not block in that case > > > > That's a good point. If we have two streams call > `IMFMediaStream::RequestSample`, then we will process them in sequence > rather than in parallel. That is, one stream will have to wait for the > other to receive data (as we block all other streams once the source cs > is acquired in `source_async_commands_Invoke`). > > > > This MR will at least unblock a stream when there is no more data, but > Windows probably delivers data for the other stream immediately (i.e. it > can deliver data for one stream, even if the other was already waiting). > And I believe I recall seeing audio latency in Wine as a result of this. > From memory, it was a 4K video, so delivery of the video sample took a > while and as a result the audio fell behind. We should probably look to > lock the individual streams rather than the entire source when possible. > Hrm, I didn't think we had a locking problem, but if we do that should > be fixed, yeah. I'll have a think about how I can test this. I might be able to craft a file that'll delay one of the streams long enough, that whilst waiting for a sample, I can reliably request and receive a sample on the other. Thanks for the review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7824#note_102482

1 0

[PATCH 0/1] MR7932: mf: Restart transforms and sinks on seek.
by Brendan McGrath (＠redmcg) 04 May '25

04 May '25

This MR fixes seek in VRChat by copying the sequence of flushes/stop/starts that Windows does. The order on Windows is: 1. Stop sources; 2. Flush MFTs; 3. Start sources; 4. Request output down the chain of sink inputs; 6. Flush sinks; and 7. Start the clock This takes place whether we pause before we seek or seek without pause. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7932

3 3

[PATCH 0/1] MR7868: combase: Find correct apartment in ClientRpcChannelBuffer_SendReceive().
by Dmitry Timoshkov (＠dmitry) 04 May '25

04 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7868

3 5

2025

2024

2023

2022

wine-gitlab