- wine-gitlab - winehq.org

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Alexandre Julliard (＠julliard) 20 Aug '25

20 Aug '25

On Wed Aug 20 17:08:48 2025 +0000, Tres Finocchiaro wrote: > I've added a second flag for `HIGHENTROPYVA`. This new flag is longer > and breaks some styling. Any advice is greatly appreciated. I've > placed the style foopahs inline. That second flag doesn't seem necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113306

1 0

[PATCH v2 0/2] MR8801: ntdll: Support THREAD_CREATE_FLAGS_SKIP_THREAD_ATTACH flag.
by Billy Laws (＠bylaws) 20 Aug '25

20 Aug '25

This flag seems to have always been supported. Unlike BYPASS_PROCESS_FREEZE -- v2: ntdll: Support THREAD_CREATE_FLAGS_SKIP_THREAD_ATTACH flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/8801

3 4

[PATCH 0/2] MR8801: ntdll: Support THREAD_CREATE_FLAGS_SKIP_THREAD_ATTACH flag.
by Billy Laws (＠bylaws) 20 Aug '25

20 Aug '25

This flag seems to have always been supported. Unlike BYPASS_PROCESS_FREEZE -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8801

2 2

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) 20 Aug '25

20 Aug '25

I've added a second flag for `HIGHENTROPYVA`. This new flag is longer and breaks some styling. Any advice is greatly appreciated. I've placed the style foopahs inline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113299

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) 20 Aug '25

20 Aug '25

Tres Finocchiaro (@tresf) commented about tools/winebuild/main.c: > { "dll", 0, LONG_OPT_DLL }, > { "def", 0, LONG_OPT_DEF }, > { "disable-dynamicbase", 0, LONG_OPT_DISABLE_DYNAMICBASE }, > + { "disable-high-entropy-va", 0, LONG_OPT_DISABLE_HIGH_ENTROPY_VA }, I would appreciate any advice from the winehq team here on styling. Mimicking the existing format for section will touch many more lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113298

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) 20 Aug '25

20 Aug '25

Tres Finocchiaro (@tresf) commented about tools/winebuild/main.c: > " -d, --delay-lib=LIB Import the specified library in delayed mode\n" > " -D SYM Ignored for C flags compatibility\n" > " --disable-dynamicbase Disable 'ASLR' address space layout randomization (default: ASLR on)\n" > +" --disable-high-entropy-va Disable high-entropy 64-bit 'ASLR' (default: high-entropy on).\n" I would appreciate any advice from the winehq team here on styling. Mimicking the format this section for 80 chars will touch many more lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113297

1 0

[PATCH 0/2] MR8770: ntoskrnl: Add support for getting DEVPKEY_Device_BusReportedDeviceDesc from devices.
by Connor McAdams (＠cmcadams) 20 Aug '25

20 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8770

4 6

[PATCH v4 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) 20 Aug '25

20 Aug '25

Fix out-of-bound access by wcslen. Found by ASan. -- v4: mscoree: Add missing NUL terminator. https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

5 9

[PATCH v2 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) 20 Aug '25

20 Aug '25

Commit 518e394794160818ffe6826c874ff2f550c95bbb introduced new and important default behavior for PE binaries built using `winegcc`/`wineg++`/`winebuild`. * `/DYNAMICBASE` - Generates an executable image that can be randomly rebased at load time by using the address space layout randomization (ASLR) feature of Windows that was first available in Windows Vista. * `/HIGHENTROPYVA` - Randomized 64-bit virtual addresses make it more difficult for an attacker to guess the location of a particular memory region. ... however as identified in https://bugs.winehq.org/show_bug.cgi?id=58480, this new default behavior can severely impact applications that interact with binaries created for Windows XP and older. This is quite common for legacy audio plugins, such as VST2(TM) plugins. This MR keeps the new default "dynamicbase" and "highentropyva" flags by default, but mirrors the mingw/msys2 `--disable-dynamicbase` flag as explained here: https://www.msys2.org/news/#2021-01-31-aslr-enabled-by-default. MSVC also provides a similarly named flag [here](https://learn.microsoft.com/en-us/cpp/build/reference/dynamicbase). Downstream, the LMMS project has successfully deployed the mingw flag and the MSVC flag for our Windows builds. Our Linux builds use a custom wine-bridge and would benefit from the same. We've currently tested this MR downstream against a snapshot of master branch to passing results. Downstream PRs: * Linux: https://github.com/LMMS/lmms/pull/7987 * Windows: https://github.com/LMMS/lmms/pull/7976 -- v2: Spit up DYNAMICBASE and HIGHENTROPYVA https://gitlab.winehq.org/wine/wine/-/merge_requests/8786

2 2

[PATCH v2 0/4] MR8781: jscript: Misc array and toString fixes.
by Gabriel Ivăncescu (＠insn) 20 Aug '25

20 Aug '25

-- v2: jscript: Fix error value when passing non-string 'this' to String's toString. jscript: Fallback to Object's toString for Arrays when 'this' isn't an jscript: Return proper error when passing wrong type to Function.apply. jscript: Allow objects that expose "length" prop for Function.apply under https://gitlab.winehq.org/wine/wine/-/merge_requests/8781

3 8

[PATCH 0/5] MR8799: win32u, server: Misc atom / class name requests cleanup.
by Rémi Bernon (＠rbernon) 20 Aug '25

20 Aug '25

In preparation / instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/8486 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8799

2 5

[PATCH v3 0/3] MR8733: gameinput: Introduce new DLL.
by Rémi Bernon (＠rbernon) 20 Aug '25

20 Aug '25

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8338 The header cannot seem to be generated easily from an IDL, gameinput has some unfortunate versioning which reuses the same identifiers across versions, in an incompatible way and sometimes sharing only a subset of them (for instance enum values), and uses C++ namespaces to separate versions. The implementation needs to support every interface version at the same time, which is implemented by wrapping identifiers and adding version suffixes whenever it is included by the implementing code. The tests are also using that so we can tests multiple versions in the same file. -- v3: dinput/tests: Add some gameinput tests. gameinput: Introduce new DLL. include: Add gameinput.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/8733

3 8

Re: [PATCH v6 0/2] MR8635: oleaut32: Fix VarAnd string conversion length handling
by Maotong Zhang (＠xiaotong) 20 Aug '25

20 Aug '25

On Wed Aug 20 11:26:51 2025 +0000, Nikolay Sivov wrote: > I'm talking about changes to VarAnd implementation - what we need is a > least a helper that implements such type coercing with progressively > larger integer types. Or better using something from oleaut32 itself to > do such type conversion. It's most likely not limited to VarAnd(). Yes, you're right. We can write a helper function to handle type coercion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8635#note_113273

1 0

[PATCH 0/1] MR8089: include: Add missing extern "C++" to guiddef.h
by Alfred Agrell (＠Alcaro) 20 Aug '25

20 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8089

3 4

[PATCH 0/1] MR7951: Draft: test to see clean output
by Jeff Latimer (＠greyghoster) 20 Aug '25

20 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7951

3 2

Re: [PATCH v6 0/2] MR8635: oleaut32: Fix VarAnd string conversion length handling
by Maotong Zhang (＠xiaotong) 20 Aug '25

20 Aug '25

On Wed Aug 20 11:27:32 2025 +0000, Nikolay Sivov wrote: > Why do you need this new macro? Conduct VT_CY tests on both the left and right sides -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8635#note_113271

1 0

[PATCH v3 0/3] MR8614: Draft: wininet/internet: Fix parsing order of http times.
by Jacob Czekalla (＠JacobCzekalla) 20 Aug '25

20 Aug '25

Order of day or month and time or year needs to be considered. The year also needs to be adjusted correctly. -- v3: wininet/internet: Fix year parsing to include millennium. https://gitlab.winehq.org/wine/wine/-/merge_requests/8614

3 6

Re: [PATCH v6 0/2] MR8635: oleaut32: Fix VarAnd string conversion length handling
by Nikolay Sivov (＠nsivov) 20 Aug '25

20 Aug '25

Nikolay Sivov (@nsivov) commented about dlls/oleaut32/tests/vartest.c: > V_VT(&exp) = VT_##rvt; V_##rvt(&exp) = rval; \ > test_var_call2( __LINE__, pVarAnd, &left, &right, &exp ) > > -#define VARANDCY(vt1,val1,val2,rvt,rval) \ > +#define VARANDRCY(vt1,val1,val2,rvt,rval) \ > V_VT(&left) = VT_##vt1; V_##vt1(&left) = val1; \ > V_VT(&right) = VT_CY; V_CY(&right).int64 = val2; \ > V_VT(&exp) = VT_##rvt; V_##rvt(&exp) = rval; \ > test_var_call2( __LINE__, pVarAnd, &left, &right, &exp ) > > +#define VARANDLCY(val1,vt2,val2,rvt,rval) \ > + V_VT(&left) = VT_CY; V_CY(&left) .int64 = val1; \ > + V_VT(&right) = VT_##vt2; V_##vt2(&right) = val2; \ > + V_VT(&exp) = VT_##rvt; V_##rvt(&exp) = rval; \ > + test_var_call2( __LINE__, pVarAnd, &left, &right, &exp ) > + Why do you need this new macro? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8635#note_113261

1 0

Re: [PATCH v6 0/2] MR8635: oleaut32: Fix VarAnd string conversion length handling
by Nikolay Sivov (＠nsivov) 20 Aug '25

20 Aug '25

On Tue Aug 5 01:30:09 2025 +0000, Maotong Zhang wrote: > Hello, I'm not entirely sure which additional test cases are needed. > Could you please advise? Thanks! I'm talking about changes to VarAnd implementation - what we need is a least a helper that implements such type coercing with progressively larger integer types. Or better using something from oleaut32 itself to do such type conversion. It's most likely not limited to VarAnd(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8635#note_113260

1 0

[PATCH v2 0/1] MR8783: dwrite: Add fallback for Dingbats.
by Ziqing Hui (＠zhui) 20 Aug '25

20 Aug '25

-- v2: dwrite: Add fallback for Dingbats. https://gitlab.winehq.org/wine/wine/-/merge_requests/8783

3 3

[PATCH 0/2] MR8798: msi: Handle .NET assemblies in MSI_GetComponentPath().
by Hans Leidekker (＠hans) 20 Aug '25

20 Aug '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58577 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8798

2 2

[PATCH 0/5] MR8797: Implement GetProcessPriorityBoost/SetProcessPriorityBoost
by Marc-Aurel Zent (＠mzent) 20 Aug '25

20 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8797

2 5

[PATCH 0/1] MR8795: comdlg32: PRINTDLG_UpdatePrintDlgW() should update dmCopies field in DEVMODE.
by Dmitry Timoshkov (＠dmitry) 20 Aug '25

20 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8795

3 2

[PATCH v2 0/1] MR2362: gitlab: Build-Depend on libpcsclite-dev for winscard.
by Francois Gouget (＠fgouget) 20 Aug '25

20 Aug '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54656 -- v2: gitlab: Install libpcsclite-dev and pcscd for winscard. https://gitlab.winehq.org/wine/wine/-/merge_requests/2362

4 4

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Stian Low (＠stianlow) 20 Aug '25

20 Aug '25

Thanks for feedback @rbernon. I'll take a closer look to see if there are any other outstanding yabridge issues preventing merges. I'll also gather all the relevant patches considered tested by the bug comments vs all the other irrelevant wine-staging patches that were also included. Regardless whatever remaining broken state yabridge may still be in need of a fix, your yabridge new-wine10-embedding is in a far better and functioning state. If yabridge devs approve new-wine10-embedding for merge then that will be reflected here to attempt a merge of the relevant wine-staging changes into upstream which will be required by the yabridge merge approval. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_113254

1 0

2025

2024

2023

2022

wine-gitlab