- wine-gitlab - winehq.org

[PATCH 0/2] MR7942: windowscodecs/tests: Add a test for 24bpp TIFF with separate sample planes.
by Nikolay Sivov (＠nsivov) 30 Apr '25

30 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7942

2 2

Re: [PATCH v2 0/5] MR7933: win32u: Add procedure loading to generic OpenGL code. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7933

1 0

Re: [PATCH v2 0/1] MR7905: krnl386: Set carry flag for unimplemented DPMI 0800h call (Physical Address Mapping) - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7905

1 0

Re: [PATCH v2 0/4] MR7822: wined3d: Move FFP extra states away from STATE_RENDER, part 3/4. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7822

1 0

Re: [PATCH v2 0/4] MR7939: ntdll: Implement ProcessBasePriority class in NtSetInformationProcess. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7939

1 0

Re: [PATCH v4 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan). - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7925

1 0

Re: [PATCH v3 0/5] MR7910: windowscodecs/converter: Add 24bppBGR -> 128bppRGBAFloat conversion path. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7910

1 0

Re: [PATCH v2 0/1] MR7927: windowscodecs: Also initialize FlipRotator.bpp field. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7927

1 0

[PATCH 0/1] MR7824: winegstreamer: Handle the Stream Group Done event.
by Brendan McGrath (＠redmcg) 30 Apr '25

30 Apr '25

This event indicates that there will be no more data. Handling it like an EOS fixes a dead lock that occurs when a stream completes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7824

3 6

[PATCH v2 0/2] MR7934: mshtml: Validate builtin host functions in IE9+ using prototype_id rather than tid where possible.
by Gabriel Ivăncescu (＠insn) 30 Apr '25

30 Apr '25

-- v2: mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the object_id of the last object in the prototype chain that https://gitlab.winehq.org/wine/wine/-/merge_requests/7934

3 4

[PATCH 0/4] MR7822: wined3d: Move FFP extra states away from STATE_RENDER, part 3/4.
by Elizabeth Figura (＠zfigura) 30 Apr '25

30 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7822

3 5

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + { > + sock->addr.un.sun_family = WS_AF_UNIX; > + memcpy(sock->addr.un.sun_path, params->addr.sa_data, sizeof(sock->addr.un.sun_path)); > + sock->addr_len = sizeof(sock->addr.un); > + } > + else > + sock->addr_len = sockaddr_from_unix( &bind_addr, &sock->addr.addr, sizeof(sock->addr) ); > } > > update_addr_usage( sock, &bind_addr, v6only ); > > if (get_reply_max_size() >= sock->addr_len) > set_reply_data( &sock->addr, sock->addr_len ); > + > + if (sock->family == WS_AF_UNIX && *params->addr.sa_data) > + fchdir(server_dir_fd); here also -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102242

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > if (errno == EADDRINUSE && sock->reuseaddr) > errno = EACCES; > > - set_error( sock_get_ntstatus( errno ) ); > - return; > + /* Windows' AF_UNIX implementation has an edge case allowing for a socket to bind to > + * an empty path. Linux doesn't, so it throws EINVAL. We check for this situation > + * here and avoid early-exiting if it's the case. */ > + if (!(errno == EINVAL && sock->family == WS_AF_UNIX && !*params->addr.sa_data)) > + { > + set_error( sock_get_ntstatus( errno ) ); > + if (sock->family == WS_AF_UNIX && *params->addr.sa_data) > + fchdir(server_dir_fd); This should be changed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102241

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + if (!(unix_path = mem_alloc( unix_path_len + 1 ))) > + return; > + > + memcpy( unix_path, (char *)(&params->addr) + sizeof(struct WS_sockaddr_un), unix_path_len ); > + unix_path[unix_path_len] = '\0'; > + > + base_name = strrchr(unix_path, '/'); > + if (base_name) > + { > + if (base_name != unix_path) > + (++base_name)[-1] = '\0'; > + } > + else > + base_name = unix_path; > + > + if (chdir( unix_path ) == -1) chdir() is also used here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102240

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > return; > } > > + if (sock->family == WS_AF_UNIX && *addr->sa_data) > + fchdir(server_dir_fd); Here the working directory is also changed, which needs to be reviewed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102239

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + if (!(unix_path = mem_alloc( unix_path_len + 1 ))) > + return; > + > + memcpy( unix_path, (char *)(params + 1) + params->addr_len, unix_path_len ); > + unix_path[unix_path_len] = '\0'; > + > + base_name = strrchr(unix_path, '/'); > + if (base_name) > + { > + if (base_name != unix_path) > + (++base_name)[-1] = '\0'; > + } > + else > + base_name = unix_path; > + > + if (chdir( unix_path ) == -1) At https://gitlab.winehq.org/wine/wine/-/merge_requests/7519 it is pointed out that changing the working directory may not be a good idea, so it should be checked whether this can be avoided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102237

1 0

[PATCH v3 0/11] MR7869: Thread priority boosts (part 1)
by Marc-Aurel Zent (＠mzent) 30 Apr '25

30 Apr '25

This implements setting `ThreadPriorityBoost`, `ProcessPriorityBoost`, `ProcessBasePriority` and getting `ThreadPriorityBoost`, `ProcessPriorityBoost` NT info classes and adds tests where appropriate. The actual boosting mechanism will be in part 2 to keep the size of this MR manageable. -- v3: kernel32/tests: Add tests for GetProcessPriorityBoost/SetProcessPriorityBoost. kernelbase: Implement SetProcessPriorityBoost. kernelbase: Implement GetProcessPriorityBoost. ntdll: Implement ProcessPriorityBoost class in NtSetInformationProcess. ntdll: Implement ProcessPriorityBoost class in NtQueryInformationProcess. ntdll: Implement ThreadPriorityBoost class in NtSetInformationThread. ntdll: Properly implement ThreadPriorityBoost class in NtQueryInformationThread. ntdll/tests: Add tests for setting process base priority. ntdll: Implement ProcessBasePriority class in NtSetInformationProcess. https://gitlab.winehq.org/wine/wine/-/merge_requests/7869

3 14

[PATCH 0/4] MR7939: ntdll: Implement ProcessBasePriority class in NtSetInformationProcess.
by Marc-Aurel Zent (＠mzent) 30 Apr '25

30 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7939

2 4

[PATCH 0/1] MR7937: Draft: winewayland: Don't clip cursor coordinates to vscreen boundaries.
by Alexandros Frantzis (＠afrantzis) 30 Apr '25

30 Apr '25

Since the positions of win32 windows and their corresponding Wayland surfaces are not synchronized, there are cases where parts of a window are outside the vscreen boundaries, and thus inaccessible to input events, but still visible and accessible from a user (i.e., Wayland compositor) standpoint. Try to remedy this issue by instructing the Wine server to not clip the Wayland mouse event coordinates to vscreen boundaries. -- Relevant discussions: * https://gitlab.winehq.org/wine/wine/-/merge_requests/4014#note_47581 * https://gitlab.winehq.org/wine/wine/-/merge_requests/7919 @julliard @rbernon Do you think such an approach (or something along these lines) would have any future in upstream as (a possibly opt-in) workaround for the Wayland input issues? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7937

3 2

[PATCH 0/1] MR7919: winewayland.drv: Move windows to the top-left of the screen
by Julian Orth (＠mahkoh) 30 Apr '25

30 Apr '25

When opening the Cheat Engine [1] settings window, the window is spawned at around 400x400, making the right and bottom sides of the window inaccessible due to clipping. This commit moves the window to 0x0 to ensure that all window contents on the monitor are accessible. [1]: https://github.com/cheat-engine/cheat-engine Signed-off-by: Julian Orth <ju.orth(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7919

3 6

[PATCH v2 0/2] MR7780: win32u: Avoid uneeded (and sometimes harmful) RedrawWindow() calls in expose_window_surface().
by Paul Gofman (＠gofman) 30 Apr '25

30 Apr '25

-- v2: win32u: Only inflate dirty rect when dpi conversion is performed in expose_window_surface(). win32u: Don't redraw window in expose_window_surface() if window has surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/7780

3 4

[PATCH v4 0/5] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon (＠rbernon) 30 Apr '25

30 Apr '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v4: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

2 6

[PATCH v6 0/5] MR5068: win32u: Fix rendering of the rotated and scaled text.
by Dmitry Timoshkov (＠dmitry) 30 Apr '25

30 Apr '25

These patches make a test case attached to the bug https://bugs.winehq.org/show_bug.cgi?id=33190 work. -- v6: win32u: NtGdiExtTextOutW() should translate x,y from logical to device units at the last step. win32u: Fix device<->world width/height converters. win32u: Use slightly more readable names for DP/LP converters. win32u: Use correct helper for converting width to device units. gdi32/tests: Add some tests for rotated font metrics. https://gitlab.winehq.org/wine/wine/-/merge_requests/5068

4 12

[PATCH v27 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 30 Apr '25

30 Apr '25

Over the past several weeks I've been working on and off on this. I didn't track the hours but I'm sure that I've spent 80+ hours on the feature. I've tested and retested all known scenarios and it seems to be working as expected. -- v27: cmd: Implement tab completion for command line entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/7843

2 2

[PATCH v3 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan).
by Alex Henrie (＠alexhenrie) 30 Apr '25

30 Apr '25

test_logfont in dlls/gdi32/tests/font.c calls CreateFontIndirectA with a non-null-terminated font name and expects it to not crash. -- v3: gdi32: Limit source string length in logfont_AtoW (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/7925

2 1

2025

2024

2023

2022

wine-gitlab