Thanks for the update. FWIW I'm not aware of any wine-staging patch helping with yabridge, although it's possible I may be missing something. I believe there was a couple of remaining issues which is why the yabridge branch hasn't been merged but I haven't looked closely into them (anybody is welcome to have a try).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_113253
Yabridge bug has been updated with latest test results regarding this merge request patches applied with wine-staging patches against commit 75b9e1722d1 Release 10.13 on Debian 13: https://bugs.winehq.org/show_bug.cgi?id=58552
Confirming @rbernon contributions to yabridge fix the GUI offset mouse misalignment when built and run with latest wine-staging patches: https://github.com/robbert-vdh/yabridge/tree/new-wine10-embedding
Until relevant wine-staging patches are merged with upstream, yabridge new-wine10-embedding branch exists in a limbo state that complicates vanilla distro releases of yabridge because the relevant wine-staging patches are missing from vanilla wine distro releases.
If wine-patches are still pending per more user testing then updates to the bug report partly fulfill that dependency.
Yabridge equivalent bug report to WineHQ for ref: https://github.com/robbert-vdh/yabridge/issues/409
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_113250
MobaXTerm tries to ShellExecute "/bin/sh" when running under wine. This ability
to run unix executables on the host via unix paths was accidentally removed
in the attemp to align ShellExecute more closely with native, while fixing the
problem that sometimes wrong executable is started by ShellExecute (e.g. in
Motor Race Collection).
Related: a2548c8db3096963012939c82e340f6b867f3efd
Fixes: 85d029e3b01f6dd35a86cc07796af982d66e4a03
--
v3: shell32: Restore the ability of running unix executables via unix paths
https://gitlab.winehq.org/wine/wine/-/merge_requests/8794
Keyboard cues are disabled by default on newer versions of Windows. Some win32 common controls, e.g., button doesn't draw a focus rect when SystemParametersInfoW(SPI_GETKEYBOARDCUES) reports FALSE.
Drawing a focus rect when the button is really small creates an effect that makes the button look corrupted. On Windows, the focus rect is not drawn when keyboard cues are disabled, which is the default.
Other controls also have this behavior, so they're included as well. There are some exceptions, for example, SysMonthCal32 always draws a focus rect, even when keyboard cues are disabled.
--
v2:
https://gitlab.winehq.org/wine/wine/-/merge_requests/8763
Keyboard cues are disabled by default on newer versions of Windows. Some win32 common controls, e.g., button doesn't draw a focus rect when SystemParametersInfoW(SPI_GETKEYBOARDCUES) reports FALSE.
Drawing a focus rect when the button is really small creates an effect that makes the button look corrupted. On Windows, the focus rect is not drawn when keyboard cues are disabled, which is the default.
Other controls also have this behavior, so they're included as well. There are some exceptions, for example, SysMonthCal32 always draws a focus rect, even when keyboard cues are disabled.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8763
Follow-up of !2786, which appears to have been abandoned.
Depends on !8182, !8575, !8578
# Execute minimal test case
1. checkout wine into ~/src/wine
2. in dlls/ws2_32/tests/sock.c wrap all calls to test functions after `Init()` until `test_afunix()` with #if 0 ... #endif
3. build into ~/src/wine-build
4. run `(cd ~/src/wine-build; WINEPREFIX=~/src/wine/.wine ../wine/tools/runtest -q -P wine -T . -M ws2_32.dll -p dlls/ws2_32/tests/i386-windows/ws2_32_test.exe sock)`
# How to debug wineserver
Since `wineserver` runs in the background, simple calls to printf() will show nothing when the test case is executed. A workaround is to open a file and call fprintf() to write debug messages to this file, which can then be inspected.
--
v40: ws2_32: Add note in bind() for AF_UNIX sockets
ws2_32/tests: In tests for AF_UNIX sockets print actual directory used
ws2_32/tests: In AF_UNIX socket tests always print used path in case of errors
ws2_32/tests: Add test for AF_UNIX sockets
server: Fix getsockname() and accept() on AF_UNIX sockets.
server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket.
ws2_32: Add support for AF_UNIX sockets.
server: Allow for deletion of socket files.
https://gitlab.winehq.org/wine/wine/-/merge_requests/7650
--
v4: kernelbase: Implement QueueUserAPC2().
ntdll: Use NtContinueEx in KiUserApcDispatcher on x64.
ntdll: Implement QUEUE_USER_APC_CALLBACK_DATA_CONTEXT in NtQueueApcThreadEx2() on x64.
server: Do not allow queueing special APCs to wow64 threads.
ntdll: Pass user APC flags to call_user_apc_dispatcher().
ntdll: Validate reserve handle in NtQueueApcThreadEx2().
ntdll: Add semi-stub for NtQueueApcThreadEx2().
https://gitlab.winehq.org/wine/wine/-/merge_requests/8569
Commit 518e394794160818ffe6826c874ff2f550c95bbb introduced new and important default behavior for PE binaries built using `winegcc`/`wineg++`/`winebuild`.
* `/DYNAMICBASE` - Generates an executable image that can be randomly rebased at load time by using the address space layout randomization (ASLR) feature of Windows that was first available in Windows Vista.
* `/HIGHENTROPYVA` - Randomized 64-bit virtual addresses make it more difficult for an attacker to guess the location of a particular memory region.
... however as identified in https://bugs.winehq.org/show_bug.cgi?id=58480, this new default behavior can severely impact applications that interact with binaries created for Windows XP and older. This is quite common for legacy audio plugins, such as VST2(TM) plugins.
This MR keeps the new default "dynamicbase" and "highentropyva" flags by default, but mirrors the mingw/msys2 `--disable-dynamicbase` flag as explained here: https://www.msys2.org/news/#2021-01-31-aslr-enabled-by-default. MSVC also provides a similarly named flag [here](https://learn.microsoft.com/en-us/cpp/build/reference/dynamicbase).
Downstream, the LMMS project has successfully deployed the mingw flag and the MSVC flag for our Windows builds. Our Linux builds use a custom wine-bridge and would benefit from the same.
We've currently tested this MR downstream against a snapshot of master branch to passing results.
Downstream PRs:
* Linux: https://github.com/LMMS/lmms/pull/7987
* Windows: https://github.com/LMMS/lmms/pull/7976
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8786