- wine-gitlab - winehq.org

[PATCH 0/1] MR8278: dxgi: Do not print a FIXME for DXGI_PRESENT_ALLOW_TEARING.
by Elizabeth Figura (＠zfigura) 11 Jun '25

11 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8278

3 2

[PATCH v2 0/1] MR8277: d3d11: Implement CreateRasterizerState2().
by Elizabeth Figura (＠zfigura) 11 Jun '25

11 Jun '25

-- v2: d3d11: Implement CreateRasterizerState2(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8277

3 2

[PATCH 0/2] MR8286: win32u: Use a dedicated struct for window destroy entries.
by Rémi Bernon (＠rbernon) 11 Jun '25

11 Jun '25

So wIDmenu and userdata can be removed from the WND struct and read from shared memory, before the window handle gets destroyed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8286

2 2

[PATCH 0/5] MR8280: ir50_32: Various, part 1/2.
by Elizabeth Figura (＠zfigura) 11 Jun '25

11 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8280

3 6

[PATCH 0/2] MR8285: kernelbase: Support extended paths in GetFinalPathNameByHandleW
by Michael Stopa (＠stomy) 11 Jun '25

11 Jun '25

All unicode API functions are supposed to support paths longer than `MAX_PATH` if prepended with the extended-path prefix `\\?\`. As of writing this function in particular doesn't. This is causing problems with Unreal Engine shader preprocessing when running under Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8285

2 2

[PATCH v2 0/2] MR8272: kerberos: EncryptMessage() should fail if context doesn't support confidentiality.
by Dmitry Timoshkov (＠dmitry) 11 Jun '25

11 Jun '25

-- v2: kerberos: When requested confidentiality InitializeSecurityContext() should also add integrity. kerberos: EncryptMessage() should fail if context doesn't support confidentiality. https://gitlab.winehq.org/wine/wine/-/merge_requests/8272

3 3

[PATCH 0/1] MR8252: nsiproxy.sys: Fix size mismatch writing into ipstatlist.
by Yuxuan Shui (＠yshui) 11 Jun '25

11 Jun '25

Both of long and long long are 8 bytes on 64-bit unix, so this if does nothing and we will write 8 bytes into a 4-byte UINT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8252

3 2

[PATCH 0/3] MR8283: server: Get rid of set_window_info request flags.
by Rémi Bernon (＠rbernon) 11 Jun '25

11 Jun '25

Splitting get from set, and in preparation for moving these info to the shared memory. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8283

2 3

[PATCH 0/2] MR8272: kerberos: EncryptMessage() should fail if context doesn't support confidentiality.
by Dmitry Timoshkov (＠dmitry) 11 Jun '25

11 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8272

3 4

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Alexandre Julliard (＠julliard) 11 Jun '25

11 Jun '25

On Wed Jun 11 01:09:53 2025 +0000, Elizabeth Figura wrote: > But the patch is going to be edited before committing anyway, whether > the generated changes are included or not, so I don't see the issue? The generated files will be updated on commit, but if there's a conflict the MR won't apply cleanly. And in general I refrain from merging MRs that cause conflicts because that makes it too easy to screw something up. So not including generated files is not a requirement, but it increases the chances that the MR can go in smoothly. Of course it also depends on the file, conflicts are not very likely with `include/Makefile.in`, but are pretty much guaranteed with `ntsyscalls.h` or `server_protocol.h`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106208

1 0

[PATCH 0/1] MR8268: comdlg32/tests: Add broken to PrintDlg{A,W} tests.
by Bernhard Übelacker (＠bernhardu) 11 Jun '25

11 Jun '25

Followup to 2ca6741d57 and cd96c69876. [Test pattern page](https://test.winehq.org/data/patterns.html#comdlg32:printdlg) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=158591) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8268

2 3

[PATCH 0/1] MR8276: wbemprox: Pass current directory correctly to CreateProcessW() in process_create().
by Paul Gofman (＠gofman) 11 Jun '25

11 Jun '25

Now that is passed as environment block variable. Which generally works but not very well. Fixes environment variables being stripped of in games started by FunCom launcher. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8276

3 3

[PATCH 0/5] MR8254: msi: Fix installing 64 bit library from 32 bit installer if 32 bit version of it is loaded into installer.
by Paul Gofman (＠gofman) 11 Jun '25

11 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8254

3 12

[PATCH v3 0/2] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) 11 Jun '25

11 Jun '25

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- v3: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

2 2

[PATCH v4 0/3] MR8195: widl: Always use NdrClientCall2() for interpreted stubs.
by Nikolay Sivov (＠nsivov) 11 Jun '25

11 Jun '25

NdrClientCall() should only be used in 32-bit mode when Oi or Oic stub optimizations are used. Currently our interpreted mode targets Oicf mode and other levels are not supported. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: include: Add errlup.idl. widl: Do not write "const" modifiers for _PARAM_STRUCT fields. widl: Always use NdrClientCall2() for interpreted stubs. https://gitlab.winehq.org/wine/wine/-/merge_requests/8195

3 4

[PATCH v2 0/1] MR8242: libs/musl: Force built-in rint for i386.
by Daniel Lehman (＠dlehman25) 11 Jun '25

11 Jun '25

https://gitlab.winehq.org/wine/wine/-/merge_requests/7748#note_105461 huge thanks to @bernhardu for narrowing it down. does this work for you? -- v2: libs/musl: Base rounding constant on precision mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/8242

2 2

[PATCH v2 0/2] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) 11 Jun '25

11 Jun '25

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- v2: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer. winegstreamer: Signal eos on disconnect. https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

2 3

[PATCH 0/1] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) 11 Jun '25

11 Jun '25

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

2 1

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Elizabeth Figura (＠zfigura) 11 Jun '25

11 Jun '25

On Tue Jun 10 23:46:26 2025 +0000, Jinoh Kang wrote: > Thanks for your insight. I understand, but IMHO it's a good idea not to > include generated files since they introduce unnecessary merge conflicts. > For example, adding a new syscall results in about half of > `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, > and (2) include generated files will surely conflict each other. But the patch is going to be edited before committing anyway, whether the generated changes are included or not, so I don't see the issue? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106184

1 0

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Jinoh Kang (＠iamahuman) 10 Jun '25

10 Jun '25

On Tue Jun 10 18:39:40 2025 +0000, Elizabeth Figura wrote: > Where did this advice come from exactly? I've never heard Alexandre > request that people not include generated files, only that it's not > necessary, and I've seen plenty of patches accepted with generated > changes. As far as I can tell "it's not necessary" got somehow warped > into "you shouldn't" and then spread as common knowledge. Thanks for your insight. I understand, but IMHO it's a good idea not to include generated files since they introduce unnecessary merge conflicts. For example, adding a new syscall results in about half of `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, and (2) include generated files will surely conflict each other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106172

1 0

[PATCH 0/5] MR8281: amstream: More fallout from dynamic format change.
by Elizabeth Figura (＠zfigura) 10 Jun '25

10 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8281

2 5

[PATCH 0/1] MR8279: winewayland.drv: Respond to size hints when moving out of fullscreen
by Aven Bross (＠permutationlock) 10 Jun '25

10 Jun '25

Currently xdg_toplevel_config size hints are ignored if the config has state 0 to avoid spurrious re-sizing. However, if the window is currently configured with a non-zero state, e.g. it is in fullscreen, then such an event from the compositor indicates a switch to a floating window, in which case the size hint should be respected. Additionally, the check for whether the current size of a fullscreen window is compatible with the compositor requested size would always return true regardless of size. Reading the comments for `wayland_surface_config_is_compatible`, it seems that behavior is intended in the other places the function is used, so that call was replaced with a simple size comparison. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8279

2 1

[PATCH 0/1] MR8277: d3d11: Implement CreateRasterizerState2().
by Elizabeth Figura (＠zfigura) 10 Jun '25

10 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8277

2 1

Re: [PATCH v2 0/1] MR8271: kernel32/tests: Don't call pNtCompareObjects in Windows 8. - approved
by Alexandre Julliard (＠julliard) 10 Jun '25

10 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8271

1 0

Re: [PATCH v2 0/1] MR8269: comdlg32/tests: Remove tests in printer_properties_hook_proc for A and W versions. - approved
by Alexandre Julliard (＠julliard) 10 Jun '25

10 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8269

1 0

2025

2024

2023

2022

wine-gitlab