- wine-gitlab - winehq.org

[PATCH 0/1] MR7865: windows.media.mediacontrol: Fix a memory leak.
by Mohamad Al-Jaf (＠maljaf) 28 Apr '25

28 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7865

3 2

[PATCH v23 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 28 Apr '25

28 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v23: ws2_32/tests: Add test for AF_UNIX sockets server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH v2 0/1] MR7857: winewayland: Don't update constraints without wl_pointer.
by Attila Fidan (＠atticf) 28 Apr '25

28 Apr '25

If ClipCursor is called while the seat doesn't have a pointer and the call qualifies for locking the pointer, it would have tried to lock a null wl_pointer. For example, I'm launching a fullscreen application (which causes ClipCursor calls on startup) in a headless compositor before I launch my virtual keyboard/pointer client. While the pointer is deinitialized and there cannot be a focused hwnd, the cursor wl_surface will not be set, making it qualify for pointer locking. -- v2: winewayland: Require wl_pointer for pointer constraints. https://gitlab.winehq.org/wine/wine/-/merge_requests/7857

3 3

[PATCH 0/2] MR7924: windowscodecs/tiff: Remove unnecessary image data byte-swaping.
by Nikolay Sivov (＠nsivov) 28 Apr '25

28 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7924

4 4

[PATCH 0/1] MR7926: dsound/tests: Allocate right amount of memory in test_secondary8 (ASan).
by Alex Henrie (＠alexhenrie) 28 Apr '25

28 Apr '25

The wave format is passed to DirectSoundDevice_CreateSoundBuffer, which duplicates it including the 1 byte of extra data after the end of the struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7926

2 1

[PATCH 0/1] MR7917: windowscodecs/png: Fix byte-swapping mode usage in the encoder.
by Nikolay Sivov (＠nsivov) 28 Apr '25

28 Apr '25

The png_set_swap() explicitly checks for 16 bit depth, and bit_depth field is set by png_write_info(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7917

3 2

[PATCH 0/5] MR7910: windowscodecs/converter: Add 24bppBGR -> 128bppRGBAFloat conversion path.
by Nikolay Sivov (＠nsivov) 28 Apr '25

28 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7910

3 6

[PATCH 0/1] MR7923: shell32: Change type of KNOWNFOLDERID FOLDERID_UserProgramFiles from...
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

shell32: Change type of KNOWNFOLDERID FOLDERID_UserProgramFiles from CSIDL_Type_Disallowed to CSIDL_Type_User. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58169 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7923

2 1

[PATCH 0/1] MR7916: kernel32: Fixed MulDiv's inconsistencies with Windows.
by Shavit Yosef (＠shavitush) 27 Apr '25

27 Apr '25

`MulDiv` doesn't match the correct Windows behavior for the function, which actually differs in some edge cases for 32-bit and 64-bit. Test case: ```c MulDiv(1, 0x80000000, 0x80000000); // WINE - both 32-bit and 64-bit: 0 // Windows (32-bit/kernel32.dll): 2 // Windows (64-bit/kernelbase.dll): -1 ``` On Windows 32-bit, this would return 2. On 64-bit, it'd return -1. However, on WINE, this call would return 0 for both 32-bit and 64-bit. This discrepancy was previously abused by threat actors to detect if the application runs under WINE. --- On Windows, `MulDiv` has a different implementation for 32-bit (from `kernel32.dll`) and 64-bit (leveraged to `kernelbase.dll` from `kernel32.dll`). After adjusting the 64-bit code to be an exact replica of the original code from `kernelbase.dll`, it'd still return the incorrect value due to Microsoft's code having undefined behavior with negation. It could be avoided with `-O0` but I opted into rewriting it with the undefined behavior to be, well.. defined. To clarify, the original code from Microsoft has a bug (logically, at least). But WINE is supposed to have matching behavior so we can run Windows programs as intended. The 32-bit version of `MulDiv` in Windows has a more complicated bug; I've documented it in the code. --- This is my first contribution to WINE - I cannot find any `CONTRIBUTING.md` or similar file with guidelines so I did my best to follow the convention of other merge requests. I've added unit testing for `MulDiv` to ensure there won't be a regression in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7916

4 8

[PATCH v17 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). -- v17: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 3

[PATCH v2 0/1] MR7921: comdlg32/colordlg: Fix color picker cursor painting.
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56107 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: comdlg32/colordlg: Fix color picker cursor painting. https://gitlab.winehq.org/wine/wine/-/merge_requests/7921

2 1

[PATCH v16 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). -- v16: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. ws2_32/tests: Add tests for the Bluetooth namespace (NS_BTH) in WSALookupServiceBegin/Next. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 4

[PATCH 0/1] MR7921: comdlg32/colordlg: Fix color picker cursor painting.
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56107 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7921

2 1

[PATCH 0/1] MR7913: uiautomationcore: Fix BSTR buffer overrun (ASan).
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Length argument to SysAllocStringLen() should not exceed the length of the string argument. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7913

3 2

[PATCH v5 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v5: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. bluetoothapis: Implement BluetoothAuthenticateDeviceEx. winebth.sys: Implement IOCTL_WINEBTH_RADIO_START_AUTH. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 4

[PATCH v4 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v4: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 5

[PATCH 0/1] MR7664: ntdll: Add copies of two XDG env vars to the environment, and use those in...
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

ntdll: Add copies of two XDG env vars to the environment, and use those in winemenubuilder and shell32. To solve https://bugs.winehq.org/show_bug.cgi?id=49987 and https://bugs.winehq.org/show_bug.cgi?id=58023 we have to remove these two XDG variables from the environment. This is a proposal that adds copies with a different name and after this they can be removed. If this is not the right way to go I guess I will hear something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7664

2 3

[PATCH v2 0/1] MR7652: ntdll: Treat XDG_DATA_DIRS as special env variable.
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49987 GTK apps seem to use this to find path to schemas, like Meld: https://download.gnome.org/binaries/win32/meld/3.22/Meld-3.22.2-mingw.msi which doesn't start at all without this patch. More info in https://bugs.winehq.org/show_bug.cgi?id=49987. -- v2: ntdll: Treat XDG_DATA_DIRS as special env variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7652

3 6

[PATCH 0/1] MR7918: windows.ui/tests: Remove tests for exact color values.
by Nikolay Sivov (＠nsivov) 26 Apr '25

26 Apr '25

The tests are failing on Windows 11. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7918

2 1

[PATCH 0/1] MR7906: vwin32.vxd: Add support for VxDCall() 0x0010 and 0x002a services
by Pali Rohár (＠pali) 26 Apr '25

26 Apr '25

VxDCall service id 0x0010 provides int24 dispatch functionality and VxDCall service id 0x002a provides int41 dispatch functionality. All of these services together with existing service id 0x0029 (for int31/dpmi functionality) have same API, first VxDCall() argument is value for EAX register and second argument is value for ECX register. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7906

3 2

[PATCH 0/2] MR7915: shell32: Fix use-after-free at FolderItemVerbs creation (ASan).
by Nikolay Sivov (＠nsivov) 26 Apr '25

26 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7915

2 2

[PATCH 0/1] MR7914: gdiplus: Don't trace old values in GdipSetMatrixElements.
by Esme Povirk (＠madewokherd) 26 Apr '25

26 Apr '25

These are about to be overwritten, so they're not really meaningful at all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7914

2 1

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 17:30:57 2025 +0000, Joe Souza wrote: > I wasn't aware of WCMD_parameter. That is a good suggestion if it works > for what's needed here. FindFirstFileEx is an optimization for remote/network file systems, such that a round trip across the network is not performed for unwanted directory entries. Since Wine seems to support only file systems that are mounted by the host operating system and does not appear to have any direct knowledge of remote-mounted file systems, I can skip using the Ex function here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101956

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 17:30:01 2025 +0000, Joe Souza wrote: > In the latest changes I have already split out much code from > WCMD_ReadConsole into subfunctions. You're saying it's still too long? > I suppose that I could split out the code for the individual case > statements into separate handler functions, but the code to handle Tab > is the bulk of that function. I wasn't aware of WCMD_parameter. That is a good suggestion if it works for what's needed here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101955

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 15:12:31 2025 +0000, eric pouech wrote: > thanks > a couple of high level comments: > * I don't think having a separate source file just for \~400 LoC is > worth it > * WCMD_ReadConsole is way too big as a function and need to be split in > smaller pieces. > * you should also be using the command line parsing functions instead of > rewriting them (eg WCMD_parameter to loop against the various parameters) > from quick testing: > * when looping around files sometimes filename is inserted in quotes, > while it shouldn't. Native seems to insert quotes only when filename > contains specific characters (spaces...), but to also remove them if > next file doesn't contain any... > * using "cd c:\\Program Files"\<tab\>\<backspace\>\\\<tab\> doesn't > behave as native... native circles in the directory content, current MR > only adds a double quote > * got a crash when playing with MR (perhaps one of the buffer overflow > stated above, perhaps not) > * when the width of the console is smaller than the full line input (eg > spread at least on two lines), circling gives some strange result > (cursor and display when from bottom of screen buffer back to top, will > previous content not shifted) > likely the current appoach of just having a handle to findfirst/findnext > will not fit all the (long term) goals. at some point, we want to > support shift-tab which circles backwards in the matching files. and I > fail to see what using FindFirstFileEx brings as value, as you filter > against directory when needed (I'm not asking for supporting shift-tab > right now, but rather to put in place a structure were it wil fit simply > when we implement it) > support for cd/rmdir/ and friends should be added in a second patch > I didn't go further in the review given the amount a remarks and > problems stated above. I'll restart when they are solved > (will look in // to the ESC issue raised) In the latest changes I have already split out much code from WCMD_ReadConsole into subfunctions. You're saying it's still too long? I suppose that I could split out the code for the individual case statements into separate handler functions, but the code to handle Tab is the bulk of that function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101954

1 0

2025

2024

2023

2022

wine-gitlab