- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR7892: winewayland: Always check the role to determine whether a surface is a toplevel. - approved
by Alexandre Julliard (＠julliard) 24 Apr '25

24 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7892

1 0

Re: [PATCH v6 0/1] MR7781: combase: Add stub for RoOriginateErrorW. - approved
by Alexandre Julliard (＠julliard) 24 Apr '25

24 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

1 0

Re: [PATCH v3 0/1] MR7859: gdi32/tests: Remove one test for NtGdiMakeFontDir. - approved
by Alexandre Julliard (＠julliard) 24 Apr '25

24 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7859

1 0

Re: [PATCH v2 0/1] MR7891: winewayland: Support building with older EGL headers. - approved
by Alexandre Julliard (＠julliard) 24 Apr '25

24 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7891

1 0

Re: [PATCH v2 0/2] MR7890: msvcrt: Avoid dynamic allocation when storing locale name. - approved
by Alexandre Julliard (＠julliard) 24 Apr '25

24 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7890

1 0

[PATCH 0/1] MR7837: shell32/tests: Avoid hang in test_rename.
by Bernhard Übelacker (＠bernhardu) 24 Apr '25

24 Apr '25

Followup of 0eab97ffa8. Usually version checks have to be avoided, but this modifies a pre-existing version check to skip that single test just with Windows 7. [Test pattern page.](https://test.winehq.org/data/patterns.html#shell32:shlfileop) [Testbot run with this patch included.](https://testbot.winehq.org/JobDetails.pl?Key=157955) CC: @zhui -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7837

4 9

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 24 Apr '25

24 Apr '25

On Thu Apr 24 21:00:45 2025 +0000, Nikolay Sivov wrote: > Yes, if you resume from same position it will be assumed that source > produces sane time mark in the event. But there are a lot of assumptions > already, and it's relatively fragile on Windows in other aspects once > you start to go off default behavior. > Regarding multiple sources, as I recall it works in general, e.g. you > can have two completely separate video rendering branches (topoedit > could be used for testing), and it works reliably. Which one is correct > we can only test manually, if you return time+10 for one source and > time+20 another source and see which one reaches the sink clock state > method. What I haven't tried is using two separate source branches and > checking if same clock instance is used for both sinks. If it's doing > something mad and creates one clock per branch, next question would be > what happens to the junction nodes, like transforms with multiple inputs > where streams converging (there is an optional IMFClockConsumer thing > where you can obviously use only one clock). FYI - I just edited my comment above: https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101671 as I had missed a step. It calls `IMFMediaSource::Stop` before flushing the MFT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101828

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 24 Apr '25

24 Apr '25

On Thu Apr 24 20:50:29 2025 +0000, Brendan McGrath wrote: > I think Windows' approach has merit if we are requesting a new start > time, but for resumption I don't think it does. They don't perform any > of the flushing in this scenario. So if the source changes the position > significantly, then all the sinks and MFTs will have stale data. I guess > they just rely on the source not doing that on resumption. > But the other issue is, as you say, there will now be multiple sources > of truth. If we get different values from all the different streams, > which one is correct? Yes, if you resume from same position it will be assumed that source produces sane time mark in the event. But there are a lot of assumptions already, and it's relatively fragile on Windows in other aspects once you start to go off default behavior. Regarding multiple sources, as I recall it works in general, e.g. you can have two completely separate video rendering branches (topoedit could be used for testing), and it works reliably. Which one is correct we can only test manually, if you return time+10 for one source and time+20 another source and see which one reaches the sink clock state method. What I haven't tried is using two separate source branches and checking if same clock instance is used for both sinks. If it's doing something mad and creates one clock per branch, next question would be what happens to the junction nodes, like transforms with multiple inputs where streams converging (there is an optional IMFClockConsumer thing where you can obviously use only one clock). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101827

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 24 Apr '25

24 Apr '25

On Thu Apr 24 11:02:43 2025 +0000, Nikolay Sivov wrote: > > It was calling `OnClockStart`, but it turns out that was because I had > hard-coded the value in my `MESourceStarted` and `MEStreamStarted` > events. After changing these events to instead use `pvarStartPosition` > passed in `IMFMediaSource::Start`, I get: > > > > ``` > > 1330.024952|10088|source_mock_Start: format: > {00000000-0000-0000-0000-000000000000} (GUID_NULL) position: <EMPTY> > > 1330.025598|10088|clock_sink_OnClockRestart: system time 13300255028 > > ``` > > > > So sending those events with a hard-coded `VT_I8` value of zero caused > `OnClockStart` to be called, but now those events have a value of > `VT_EMPTY` and `OnClockRestart` is called. > I see, this is something we do differently. We are using original > session Start() timestamp when restarting the clock, and Windows > apparently is using whatever source reports. I think there is a value in > doing the same - the idea here I'm guessing is to adjust to the source > time, which could deviate both ways from the time client asked for. What > we'll need to figure out is which stamp we should actually be using for > the new clock position. You can have multiple sources with multiple > streams, so number of events with timestamps is potentially number of > streams across all sources + number of sources. I think Windows' approach has merit if we are requesting a new start time, but for resumption I don't think it does. They don't perform any of the flushing in this scenario. So if the source changes the position significantly, then all the sinks and MFTs will have stale data. I guess they just rely on the source not doing that on resumption. But the other issue is, as you say, there will now be multiple sources of truth. If we get different values from all the different streams, which one is correct? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101826

1 0

[PATCH v7 0/4] MR7779: mshtml: Misc constructor and prototype improvements.
by Gabriel Ivăncescu (＠insn) 24 Apr '25

24 Apr '25

-- v7: mshtml: Define "create" from XMLHttpRequest constructor as a jscript prop mshtml: Define the constructor's prototype on mshtml side. mshtml: Consolidate the functional constructors into a common struct mshtml: Rename struct constructor to stub_constructor. https://gitlab.winehq.org/wine/wine/-/merge_requests/7779

3 8

[PATCH v4 0/2] MR7771: win32u: Make font handle table dynamically growable.
by Brendan Shanks (＠bshanks) 24 Apr '25

24 Apr '25

This fixes "out of realized font handles" errors seen with Valve games like Half-Life 2 (which uses more than 1000 font handles). The new limit of 5000 is roughly inspired by the Windows limit, although there are differences. On Windows 11 I can call `CreateFont()` (and then `SetMapMode()`, `SelectObject()`, `SetTextAlign()` to realize the font) exactly 5000 times before it hits the handle limit. Under Wine, child fonts use handles as well, so the limit is usually hit before 5000 `CreateFont()` calls. But, there is caching so that `CreateFont()` calls with identical arguments do not count towards the limit. Ultimately the old limit of 256 was sufficient for almost all applications, and 5000 should be enough for all but the worst-behaved apps. -- v4: win32u: Raise realized font handle limit to 5000. https://gitlab.winehq.org/wine/wine/-/merge_requests/7771

2 3

[PATCH v22 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 24 Apr '25

24 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v22: ws2_32/tests: Add test for AF_UNIX sockets server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH 0/2] MR7892: winewayland: Always check the role to determine whether a surface is a toplevel.
by Alexandros Frantzis (＠afrantzis) 24 Apr '25

24 Apr '25

Since the role objects in the wayland_surface struct are part of a union, we first need to check whether the surface has the right role before checking the role objects themselves. Otherwise we risk using a subsurface as a toplevel or vice-versa. The second commit introduces a helper to deduplicate the toplevel checks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7892

2 2

[PATCH v5 0/1] MR7781: combase: Add stub for RoOriginateErrorW.
by Louis Lenders (＠xe) 24 Apr '25

24 Apr '25

This is called by UniGetUi (https://github.com/marticliment/UniGetUI/releases/tag/3.1.8). (After choosing 'Install for all users' --> 'perform portable installation' otherwise the installer runs into other (shellfolder) related bugs) -- v5: combase: Add stub for RoOriginateErrorW. https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

3 2

[PATCH 0/1] MR7879: dbghelp: Bail out when encountering managed symbols.
by Marc-Aurel Zent (＠mzent) 24 Apr '25

24 Apr '25

This avoids asserts later down the line and makes WineHQ Bug 34990 less problematic for now, until a full managed implementation can be done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7879

3 5

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 24 Apr '25

24 Apr '25

> It was calling `OnClockStart`, but it turns out that was because I had hard-coded the value in my `MESourceStarted` and `MEStreamStarted` events. After changing these events to instead use `pvarStartPosition` passed in `IMFMediaSource::Start`, I get: > > ``` > 1330.024952|10088|source_mock_Start: format: {00000000-0000-0000-0000-000000000000} (GUID_NULL) position: <EMPTY> > 1330.025598|10088|clock_sink_OnClockRestart: system time 13300255028 > ``` > > So sending those events with a hard-coded `VT_I8` value of zero caused `OnClockStart` to be called, but now those events have a value of `VT_EMPTY` and `OnClockRestart` is called. I see, this is something we do differently. We are using original session Start() timestamp when restarting the clock, and Windows apparently is using whatever source reports. I think there is a value in doing the same - the idea here I'm guessing is to adjust to the source time, which could deviate both ways from the time client asked for. What we'll need to figure out is which stamp we should actually be using for the new clock position. You can have multiple sources with multiple streams, so number of events with timestamps is potentially number of streams across all sources + number of sources. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101791

1 0

[PATCH 0/2] MR5285: AMD Radeon Vega 7 Renoir pci-ids
by Carlos Rodriguez (＠mrdeathjr28) 24 Apr '25

24 Apr '25

With this patch wine can recognize amd radeon vega 7 renoir (actually appears like radeon RX 5600) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5285

4 5

[PATCH v3 0/3] MR7771: win32u: Make font handle table dynamically growable.
by Brendan Shanks (＠bshanks) 24 Apr '25

24 Apr '25

This fixes "out of realized font handles" errors seen with Valve games like Half-Life 2 (which uses more than 1000 font handles). The new limit of 5000 is roughly inspired by the Windows limit, although there are differences. On Windows 11 I can call `CreateFont()` (and then `SetMapMode()`, `SelectObject()`, `SetTextAlign()` to realize the font) exactly 5000 times before it hits the handle limit. Under Wine, child fonts use handles as well, so the limit is usually hit before 5000 `CreateFont()` calls. But, there is caching so that `CreateFont()` calls with identical arguments do not count towards the limit. Ultimately the old limit of 256 was sufficient for almost all applications, and 5000 should be enough for all but the worst-behaved apps. -- v3: win32u: Make font handle table dynamically growable. win32u: Track free font handles through indices instead of pointers. win32u: Enter font_lock in NtGdiMakeFontDir. https://gitlab.winehq.org/wine/wine/-/merge_requests/7771

4 6

[PATCH v4 0/2] MR7781: combase: Add stub for RoOriginateErrorW.
by Louis Lenders (＠xe) 24 Apr '25

24 Apr '25

This is called by UniGetUi (https://github.com/marticliment/UniGetUI/releases/tag/3.1.8). (After choosing 'Install for all users' --> 'perform portable installation' otherwise the installer runs into other (shellfolder) related bugs) -- v4: v3: Only print pointer in FIXME. https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

2 2

[PATCH v2 0/1] MR7859: gdi32/tests: Remove one test for NtGdiMakeFontDir.
by Bernhard Übelacker (＠bernhardu) 24 Apr '25

24 Apr '25

The call to NtGdiMakeFontDir fails just below Windows 10-1607, therefore this test fails in Windows 10-1607 and above. Followup of 5a6a75a5ff. [Link to the pattern page.](https://test.winehq.org/data/patterns.html#gdi32:font) Edit: Outdated, was the first version of the patch: [A testbot run with this patch.](https://testbot.winehq.org/JobDetails.pl?Key=157999) -- v2: gdi32/tests: Remove one test for NtGdiMakeFontDir. https://gitlab.winehq.org/wine/wine/-/merge_requests/7859

3 4

[PATCH 0/1] MR7891: winewayland: Support building with older EGL headers.
by Alexandros Frantzis (＠afrantzis) 24 Apr '25

24 Apr '25

Support building on systems with older EGL headers, which may not include the EGL_EXT_present_opaque extension. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57941 -- Note that this MR doesn't change the runtime requirement for EGL_EXT_present_opaque. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7891

2 1

[PATCH v3 0/1] MR7781: combase: Add stub for RoOriginateErrorW.
by Louis Lenders (＠xe) 24 Apr '25

24 Apr '25

This is called by UniGetUi (https://github.com/marticliment/UniGetUI/releases/tag/3.1.8). (After choosing 'Install for all users' --> 'perform portable installation' otherwise the installer runs into other (shellfolder) related bugs) -- v3: combase: Add stub for RoOriginateErrorW. https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

4 3

[PATCH 0/2] MR7890: msvcrt: Avoid dynamic allocation when storing locale name.
by Piotr Caban (＠piotr) 24 Apr '25

24 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7890

2 2

[PATCH v5 0/2] MR7672: Draft: mfplat/tests: Add tests for Byte Stream Output.
by Brendan McGrath (＠redmcg) 24 Apr '25

24 Apr '25

This MR adds tests that examine the values of the samples output by the byte stream handlers. It is marked as draft as it is dependent on the fixes included within MR !7569. I've also renamed the tests as they previously exclusively tested the sample output timestamps. The tests now also look at the number of buffers included in a sample and total size of the buffers within a sample. -- v5: mfplat/tests: Add tests for MP3 Byte Stream Output. mfplat/tests: Add tests for Byte Stream Output. https://gitlab.winehq.org/wine/wine/-/merge_requests/7672

2 2

[PATCH v2 0/1] MR7669: Draft: ntdll/server: Make robust to spurious short writes
by Bernhard Übelacker (＠bernhardu) 24 Apr '25

24 Apr '25

Version 1 of the patch by Keno Fischer. -- v2: ntdll/server: Make robust to spurious short writes https://gitlab.winehq.org/wine/wine/-/merge_requests/7669

3 5

2025

2024

2023

2022

wine-gitlab