I tripped over this function while trying to run a game, so I thought I would have a go at it :-)
The implementation is very similar to what is done in `Local32Info16` already.
Regarding the place to put the function: I am not sure about the exact relationship between `kernel32` and `kernelbase`, but as most of the heap related functions are implemented in `kernelbase` I opted to add it to the latter. The tests reside in the `kernel32` directory though.
The tests are currently pretty basic as I was a bit hesitant to compare against hard coded sizes for reserved / committed memory (that could break if someone made changes to the heap implementation).
Also, I am not entirely sure about the semantics of the `cbMaxReserve` field. I opted to always set it to the same value as `cbReserved`, which seems *good enough™*.
Let me know if this needs improvement!
--
v4: kernelbase: Implement HeapSummary
https://gitlab.winehq.org/wine/wine/-/merge_requests/8237
For React Native. These help detect errors for React Native applications.
--
v3: combase: Add an error message when class is not found.
combase: Add RoReportUnhandledError() stub.
combase: Add RoGetErrorReportingFlags() stub.
combase: Add RoFailFastWithErrorContextInternal2() stub.
include: Add errhandlingapi.h.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8244
I tripped over this function while trying to run a game, so I thought I would have a go at it :-)
The implementation is very similar to what is done in `Local32Info16` already.
Regarding the place to put the function: I am not sure about the exact relationship between `kernel32` and `kernelbase`, but as most of the heap related functions are implemented in `kernelbase` I opted to add it to the latter. The tests reside in the `kernel32` directory though.
The tests are currently pretty basic as I was a bit hesitant to compare against hard coded sizes for reserved / committed memory (that could break if someone made changes to the heap implementation).
Also, I am not entirely sure about the semantics of the `cbMaxReserve` field. I opted to always set it to the same value as `cbReserved`, which seems *good enough™*.
Let me know if this needs improvement!
--
v3: kernelbase: Implement HeapSummary
https://gitlab.winehq.org/wine/wine/-/merge_requests/8237
Games built with recent versions of Unreal Engine (e.g. Backrooms Escape Together, Ratshaker, Abiotic Factor) refuse to start unless msvcp140_2 and vcruntime140_1 have version resources.
~~I took this opportunity to factor out the version numbers into their own include file so they'll be easier to change if we need to bump them in the future.~~
These version resources will likely stop MS redists from installing via winetricks, but we already bit that bullet with !6943, which added one to msvcp140.
--
v3: msvcp140_2: Add a version resource.
vcruntime140_1: Add a version resource.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8255
In native Windows, the COPY command will display the names of the files as they are copied. Wine should do the same. This change enables that.
--
v13: cmd: Allow '+' as delimiter for tab-completion, e.g. 'copy file+file2'.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8200