The code was not correct or very clear, and the tests were not testing what they intended to. I expanded the tests and I could add even more tests, but I was trying to stick to fixing the main problem.
Two of the new tests are to-do because Wine does not translate LDAP_OPT_ON to WLDAP32_OPT_ON in ldap_get_optionW. I haven't fixed that because to fix it properly, we would have to save the specific value that was passed to Wine's ldap_set_optionW and return that value from ldap_get_optionW instead of what was passed to OpenLDAP's ldap_set_option.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2558
First commit adds a "todo_wine" test, second commit fixes the behavior and marks the test as no longer "todo". It looks like the same logic is already implemented (and tested) for the EnumDevices method.
Commit message for the fix commit:
---
This solves an issue in ZUSI 3 settings for DirectInput devices. Delphi
defines the True value of the "C-compatible" LongBool type as -1, which
wine interpreted to mean DIENUM_STOP because it is != DIENUM_CONTINUE.
Change that logic so only an explicit DIENUM_STOP (= 0) return value
stops the enumeration of objects.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2560
On Wed Mar 1 08:51:53 2023 +0000, Zhiyi Zhang wrote:
> Make sure you pass the tests on the TestBots at
> https://testbot.winehq.org/Submit.pl first. If you have other tests
> failing only locally, you can comment them out for the time being.
I tried to add a test for this change, but it's too complex for me.
I tested my change with the project: https://github.com/ivellioscolin/NCALRPC_example
The project 'NCALRPC_example' using explicit binding handle, and the handle is always 0 in server functions.
I add some code in function 'RPCGet' in the file NCALRPC_example\Server\RPCServerImpl.cpp:
`
DWORD pid;
I_RpcBindingInqLocalClientPID(hBinding, &pid);
pData->outSize = pid;
`
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_28607
Add a new environment variable `WINEBOOT_HIDE_DIALOG` to disable configuration wait windows. Useful for wine wrappers that want to keep the UX seamless.
--
v6: Change `WINEHIDEWAIT` to `WINEBOOT_HIDE_DIALOG`
https://gitlab.winehq.org/wine/wine/-/merge_requests/2552
Add a new environment variable WINEHIDEWAIT to disable configuration wait windows. Useful for wine wrappers that want to keep the UX seamless.
--
v5: Add env variable to hide wait window
https://gitlab.winehq.org/wine/wine/-/merge_requests/2552