- wine-gitlab - winehq.org

[PATCH 0/1] MR2544: winedevice: Use the ntoskrnl channel.
by Zebediah Figura (＠zfigura) 31 Mar '23

31 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2544

2 1

[PATCH v17 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Mar '23

30 Mar '23

a hotfix for the recent release of Persona 5 Royal. -- v17: kernel32: Add semi-stub for RemoveDirectoryTransactedA/W(). kernel32: Add semi-stub for GetFileAttributesTransactedA/W(). kernel32: Add semi-stub for FindFirstFileTransactedA/W(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

2 6

[PATCH v16 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Mar '23

30 Mar '23

a hotfix for the recent release of Persona 5 Royal. -- v16: kernel32: Add semi-stub for RemoveDirectoryTransactedA/W(). kernel32: Add semi-stub for GetFileAttributesTransactedA/W(). kernel32: Add semi-stub for FindFirstFileTransactedA/W(). kernel32: Add semi-stub for DeleteFileTransactedA/W(). kernel32: Add semi-stub for CreateDirectoryTransactedA/W(). kernel32: Add semi-stub for CreateFileTransactedA/W(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

2 7

Re: [PATCH v15 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Mar '23

30 Mar '23

On Thu Mar 30 18:33:42 2023 +0000, Alexandre Julliard wrote: > Please don't use Hungarian notation, particularly when the other > parameters use the standard form. hungarian notation is the pus in front of MiniVersion if I am reading correctly? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1145#note_28475

1 0

[PATCH v2 0/1] MR2540: include: Define __has_attribute() if the compiler does not provide it.
by Zebediah Figura (＠zfigura) 30 Mar '23

30 Mar '23

Fixes: f4c3801495f4fe17a10e2f21339de3b511c78339 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54666 -- v2: include: Include corecrt.h in vadefs.h https://gitlab.winehq.org/wine/wine/-/merge_requests/2540

2 1

Re: [PATCH v3 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

1 0

Re: [PATCH v2 0/1] MR2538: include: Add DirectXAlphaMode enum. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2538

1 0

Re: [PATCH v2 0/1] MR2534: dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7 - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2534

1 0

Re: [PATCH v6 0/3] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

1 0

Re: [PATCH v4 0/11] MR2539: imm32: Introduce a default IME implementation. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

1 0

Re: [PATCH v2 0/1] MR2468: ntdll: Don't report user (PE) stack via pthread_attr_setstack(). - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2468

1 0

Re: [PATCH v2 0/2] MR2527: Avoid using the comma operator - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2527

1 0

Re: [PATCH v2 0/3] MR2536: services: Change running service state once its process dies. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2536

1 0

Re: [PATCH v7 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err. - approved
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

1 0

[PATCH v22 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) 30 Mar '23

30 Mar '23

Fixes bug [53826](https://bugs.winehq.org/show_bug.cgi?id=53826). -- v22: ntdll/tests: Increase margins in timer merging tests. ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Handle hidden file names inside get_file_info instead of after it. ntdll: Do not open-code hidden file handling in get_dir_data_entry. ntdll/tests: Add test for file attributes of files with names beginning with a dot. https://gitlab.winehq.org/wine/wine/-/merge_requests/1148

3 9

[PATCH v4 0/6] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) 30 Mar '23

30 Mar '23

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and supporting GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR leverages the win32u CURRENT_SETTINGS storage mechanism (which was previously used only in the null driver). Thanks! -- v4: winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Support GetCurrentDisplaySettings. win32u: Support setting the registry mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

3 7

[PATCH v5 0/6] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) 30 Mar '23

30 Mar '23

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and supporting GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR leverages the win32u CURRENT_SETTINGS storage mechanism (which was previously used only in the null driver). Thanks! -- v5: winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Support GetCurrentDisplaySettings. win32u: Support setting the registry mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

2 6

Re: [PATCH v15 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Alexandre Julliard (＠julliard) 30 Mar '23

30 Mar '23

Alexandre Julliard (@julliard) commented about dlls/kernel32/path.c: > return MoveFileWithProgressW(source, dest, progress, data, flags); > } > > +/************************************************************************* > + * CreateFileTransactedA (KERNEL32.@) > + */ > +HANDLE WINAPI DECLSPEC_HOTPATCH CreateFileTransactedA( LPCSTR name, DWORD access, DWORD sharing, > + LPSECURITY_ATTRIBUTES sa, DWORD creation, > + DWORD attributes, HANDLE template, > + HANDLE transaction, PUSHORT pusMiniVersion, > + PVOID pExtendedParameter ) > +{ Please don't use Hungarian notation, particularly when the other parameters use the standard form. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1145#note_28447

1 0

[PATCH 0/1] MR2540: include: Define __has_attribute() if the compiler does not provide it.
by Zebediah Figura (＠zfigura) 30 Mar '23

30 Mar '23

Fixes: f4c3801495f4fe17a10e2f21339de3b511c78339 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54666 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2540

3 2

[PATCH v3 0/6] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) 30 Mar '23

30 Mar '23

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and implementing GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own in the first commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR adds a shared memory region containing an authoritative version of the Wayland output information (see the "winewayland.drv: Implement GetCurrentDisplaySettings." commit for more details). Thanks! -- v3: winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Support GetCurrentDisplaySettings. win32u: Support setting the registry mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

2 7

[PATCH v3 0/11] MR2539: imm32: Introduce a default IME implementation.
by Rémi Bernon (＠rbernon) 30 Mar '23

30 Mar '23

-- v3: winemac: Use the default IME implementation for stubs. winex11: Use the default IME implementation for stubs. imm32: Return TRUE from ImmIsIME with any HKL. imm32: Add a default implementation for IME functions. imm32: Introduce new input_context_init helper. imm32: Select current IME on input contexts when needed. imm32: Send WM_IME_SELECT messages when IME is activated. imm32: Pass the HIMC to the IME UI window IMMGWL_IMC. win32u: Ignore some IME messages in default_window_proc. win32u: Ignore IME messages from IME UI windows in DefWindowProc. imm32/tests: Test DefWindowProc with IME UI messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

3 16

[PATCH v5 0/3] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) 30 Mar '23

30 Mar '23

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v5: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. wldap32: Return ~0u from ldap_modrdn* for any error. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

3 4

[PATCH v4 0/2] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) 30 Mar '23

30 Mar '23

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v4: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

2 3

[PATCH v2 0/5] MR2532: kernebase: Implement GetConsoleOriginalTitleA/W
by Hugh McMaster (＠hmc) 30 Mar '23

30 Mar '23

This series of patches implements GetConsoleOriginalTitleA/W(). We re-use the existing logic of GetConsoleTitle, as it is the same for GetConsoleOriginalTitle. -- v2: kernel32/tests: Test GetConsoleOriginalTitleA/W() with empty title kernelbase: Implement GetConsoleOriginalTitleA() kernelbase: Implement GetConsoleOriginalTitleW() conhost: Save original console title on initialization kernel32/tests: Check return length of GetConsoleOriginalTitleA/W() https://gitlab.winehq.org/wine/wine/-/merge_requests/2532

4 7

[PATCH 0/1] MR2468: ntdll: Don't report user (PE) stack via pthread_attr_setstack().
by Jinoh Kang (＠iamahuman) 30 Mar '23

30 Mar '23

Today, NtCreateThreadEx() passes to pthread_attr_setstack() an address range that spans both the user (PE) stack and the kernel (Unix) stack. pthread_attr_setstack() accepts an address range that will be used as the initial stack area for the thread created by pthread_create(). It is often assumed that the initial stack will be available for the entire duration of the thread's lifetime. This assumption, however, conflicts with how Win32 fibers operate. Fiber APIs allow the thread's initial stack to be freed before the thread exits, or kept alive beyond the point of thread's termination. This allows the lifetime of the thread's initial stack to be shorter or longer than the originating thread's lifetime. This is possible because each fiber has its own stack and context, and ConvertThreadToFiber() transfers the current thread's stack to a new fiber. This specifically causes problems in Glibc v2.31 and earlier. These Glibc versions have a bug where madvise(2) with the MADV_DONTNEED flag is called on the initial stack area on thread exit, even when the stack was user-supplied (via pthread_attr_setstack). Therefore, the kernel may zero out any portion of the initial stack at any time after the originating thread terminates, even if the stack no longer belongs to the current thread (either freed and reallocated, or owned by a fiber). This may ultimately lead to memory corruption. Fix this by only passing the syscall (kernel) portion of the stack to pthread_attr_setstack(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2468

3 2

2025

2024

2023

2022

wine-gitlab