- wine-gitlab - winehq.org

[PATCH v4 0/10] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) 09 Mar '23

09 Mar '23

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v4: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). vkd3d-shader/hlsl: Rename struct hlsl_reg_reservation fields. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

4 15

[PATCH 0/1] MR2358: gdi32: Improve EMR_CREATEDIBPATTERNBRUSHPT playback.
by Piotr Caban (＠piotr) 09 Mar '23

09 Mar '23

It makes the lbHatch data available after PlayEnhMetaFileRecord returns. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2358

3 2

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

To keep things consistent with the other WOW64 thunks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26528

1 0

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c: > > status = wow64_unmap_buffer( ptr, get_named_buffer_param( teb, params32->buffer, GL_BUFFER_MAP_LENGTH ), > get_named_buffer_param( teb, params32->buffer, GL_BUFFER_ACCESS_FLAGS ) ); > gl_unmap_named_buffer64( args ); ```suggestion:-7+0 struct glUnmapNamedBuffer_params params = { .teb = get_teb64(params32->teb), .buffer = params32->buffer, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_named_buffer_pointer( params.teb, params.buffer ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_MAP_LENGTH ), get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_named_buffer64( &params ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26527

1 0

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c: > } *params32 = args; > NTSTATUS status; > TEB *teb = get_teb64( params32->teb ); > + struct glUnmapBuffer_params params = { teb, params32->target, params32->ret }; > > if (!(ptr = get_buffer_pointer( teb, params32->target ))) return STATUS_SUCCESS; > > status = wow64_unmap_buffer( ptr, get_buffer_param( teb, params32->target, GL_BUFFER_MAP_LENGTH ), > get_buffer_param( teb, params32->target, GL_BUFFER_ACCESS_FLAGS ) ); > - gl_unmap_buffer64( args ); > + gl_unmap_buffer64( &params ); ```suggestion:-8+0 struct glUnmapBuffer_params params = { .teb = get_teb64(params32->teb), .target = params32->target, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_buffer_pointer( params.teb, params.target ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_buffer_param( params.teb, params.target, GL_BUFFER_MAP_LENGTH ), get_buffer_param( params.teb, params.target, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_buffer64( &params ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26526

1 0

[PATCH 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Fan WenJie (＠fanwenjie) 09 Mar '23

09 Mar '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359

2 1

Re: [PATCH v3 0/1] MR2346: winsqlite3: Add stub DLL.
by Jinoh Kang (＠iamahuman) 09 Mar '23

09 Mar '23

We should probably bundle `winsqlite3.dll` in the same manner we do for `wine-mono`, `wine-gecko`, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2346#note_26523

1 0

[PATCH 0/1] MR2357: windows.perception.stub/tests: Skip some tests when ISpatialSurfaceObserverStatics2 is not supported.
by Francois Gouget (＠fgouget) 09 Mar '23

09 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54649 --- This fixes the crash on Windows 10 1607. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2357

2 1

[PATCH v3 0/5] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

-- v3: win32u: Call NtUserActivateKeyboardLayout on focus change. winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

2 6

[PATCH v2 0/5] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

-- v2: win32u: Call NtUserActivateKeyboardLayout on focus change. winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

3 7

[PATCH v15 0/10] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 09 Mar '23

09 Mar '23

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v15: kernelbase: Restructure the create_key() loop. kernelbase: Add a fast path to create_key(). kernelbase: Move create_key() below open_key(). kernelbase: Factor opening a subkey out of open_key(). kernelbase: Always try to open the Wow6432Node in open_key(). kernelbase: Restructure the open_key() loop. kernelbase: Pass the key name to create_key(). kernelbase: Pass the root key to create_key(). kernelbase: Pass the key name to open_key(). kernelbase: Pass the root key to open_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

2 11

[PATCH 0/2] MR2356: regedit fixes
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

1. Allow export_key() to return TRUE. 2. Append '.reg' file extension if necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2356

2 2

Re: [PATCH v2 0/4] MR1899: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (process) - closed
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

This merge request was closed by Hugh McMaster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1899

1 0

[PATCH v2 0/3] MR1897: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (locale)
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

There are times when it is useful to test changes on the Windows XP and 2003 VMs, but the direct use of functions not on those platforms makes this impossible. -- v2: kernel32/tests: Call CompareStringEx via function address (locale.c) kernel32/tests: Call LCIDToLocaleName via function address (locale.c) kernel32/tests: Call LCMapStringEx via function address (locale.c) https://gitlab.winehq.org/wine/wine/-/merge_requests/1897

2 4

Re: [PATCH v2 0/2] MR1898: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (fiber) - closed
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

This merge request was closed by Hugh McMaster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1898

1 0

Re: [PATCH v2 0/7] MR1896: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (console) - closed
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

This merge request was closed by Hugh McMaster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1896

1 0

[PATCH 0/5] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

3 6

[PATCH v14 0/6] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 09 Mar '23

09 Mar '23

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v14: kernelbase: Restructure the create_key() loop. kernelbase: Add a fast path to create_key(). kernelbase: Move create_key() below open_key(). kernelbase: Factor opening a subkey out of open_key(). kernelbase: Always try to open the Wow6432Node in open_key(). kernelbase: Restructure the open_key() loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

3 10

[PATCH v3 0/7] MR1964: Draft: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger (＠stefan) 09 Mar '23

09 Mar '23

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v3: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi: Unlock the wined3d mutex after storing the new target. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

5 15

[PATCH 0/11] MR2354: imm32: Test and stub ImmLoadIME / ImmFreeLayout.
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

And begin cleanup of several functions in preparation for their implementation. This only reverse the control flow to use early return (and cleanup variable names and traces as it's touching entire functions anyway), so that later changes wrt IME loading / freeing would be simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2354

2 12

[PATCH v6 0/4] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 09 Mar '23

09 Mar '23

-- v6: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Make sure fps_d is not zero. winegstreamer: Add format field to wmv wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

4 11

[PATCH v5 0/1] MR2306: msado15: Implement _Recordset Open
by Alistair Leslie-Hughes (＠alesliehughes) 09 Mar '23

09 Mar '23

-- v5: msado15: Implement _Recordset Open https://gitlab.winehq.org/wine/wine/-/merge_requests/2306

2 1

[PATCH v2 0/1] MR2346: winsqlite3: Add stub DLL.
by Tareque Md Hanif (＠tmdh) 09 Mar '23

09 Mar '23

Required to run winget package manager. -- v2: winsqlite3: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2346

3 3

[PATCH v5 0/5] MR2296: Always use the user images for the D3D12 swapchain
by Giovanni Mascellani (＠giomasce) 08 Mar '23

08 Mar '23

-- v5: dxgi: Reset the back buffer index to zero on ResizeBuffers(). dxgi/tests: Test that ResizeBuffers() resets the back buffer index to zero. dxgi: Always assume that a D3D12 swapchain always uses user images. dxgi: Immediately error out when creating a D3D12 swapchain on a non-immediate queue. d3d12/tests: Test that D3D12 swapchains can only be created on direct command queues. https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

4 7

[PATCH v3 0/7] MR2336: mshtml: Assume navigation can happen during callbacks.
by Gabriel Ivăncescu (＠insn) 08 Mar '23

08 Mar '23

This should fix some rare crashes in e.g. FFXIV Launcher (requires Proton patches to have it working though). -- v3: mshtml: Use already available window local variable in refresh task. mshtml: Grab refs to windows upfront before sending pagehide events. mshtml: Hold ref to the frame element during readyState notifications. mshtml: Check if browser was detached during notifications while navigating. mshtml: Hold ref to outer window when navigating. mshtml: Hold ref to inner window when calling external code. mshtml: Hold ref to HTMLDocumentObj when calling external code. https://gitlab.winehq.org/wine/wine/-/merge_requests/2336

3 8

2025

2024

2023

2022

wine-gitlab