- wine-gitlab - winehq.org

[PATCH 0/2] MR2313: shlwapi/tests: Fix the date formatting tests when the locale does not match the code page.
by Francois Gouget (＠fgouget) 02 Mar '23

02 Mar '23

In particular, February dates contain an e-acute in French, the representation of which depends on the code page being used, which in SHFormatDateTimeA() is CP_ACP. Also there are only three months that triggered this bug in French: February, August and December. So also make sure to test this issue year round. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54149 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2313

2 2

[PATCH 0/1] MR2311: include: Add more Windows.Foundation.Numerics type declarations.
by Jacek Caban (＠jacek) 02 Mar '23

02 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2311

3 4

[PATCH 0/1] MR988: dmloader/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 02 Mar '23

02 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/988

3 6

[PATCH 0/1] MR1138: gitlab: Add winetest checksums to the build artifacts.
by Francois Gouget (＠fgouget) 02 Mar '23

02 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1138

3 5

[PATCH v3 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 02 Mar '23

02 Mar '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- v3: winewayland.drv: Introduce wayland_mutex. winewayland.drv: Initialize basic per-thread Wayland instance. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

3 9

[PATCH v2 0/5] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions
by Davide Beatrici (＠davidebeatrici) 02 Mar '23

02 Mar '23

The goal is to eventually move all interfaces from each driver's `mmdevdrv.c` into `mmdevapi`. -- v2: wine{alsa,coreaudio,oss,pulse}: Move test_connect handling into mmdevapi. winepulse: Move process_attach and process_detach handling into mmdevapi. mmdevapi: Query MemoryWineUnixFuncs virtual memory and store the resulting handle. wine{alsa,coreaudio,oss,pulse}: Return STATUS_NOT_IMPLEMENTED for unused unixlib functions. include: Add missing "winternl.h" include to unixlib.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

3 11

[PATCH v8 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 02 Mar '23

02 Mar '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v8: d3d9: Always draw only a single instance for non-indexed draws. https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

2 2

[PATCH v7 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 02 Mar '23

02 Mar '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v7: d3d9: Always draw only a single instance for non-indexed draws. d3d9/tests: Add test for non-indexed instancing drawing. https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

2 2

[PATCH v2 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 02 Mar '23

02 Mar '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- v2: winewayland.drv: Introduce wayland_mutex. winewayland.drv: Initialize basic per-thread Wayland instance. winewayland.drv: Add stub for per-thread data. winewayland.drv: Perform basic per-process Wayland initialization. winewayland.drv: Add initial unixlib stub. winewayland.drv: Add initial driver stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

3 16

Re: [PATCH v2 0/3] MR2304: widl: Add parameterized signatures for more basic types.
by Mohamad Al-Jaf (＠maljaf) 02 Mar '23

02 Mar '23

On Wed Mar 1 08:06:29 2023 +0000, Huw Davies wrote: > @rbernon, note that you should explicitly approve this as it contains > commits from another author. I see, yeah, I tried to add the correct strings to the types, but couldn't find anything on array. The others were pretty straightforward. Also, the build error was misleading and I think it'd be helpful to add the equivalent of `TRACE` in widl. The existing debug parameters were not helpful. Thanks for the link, good info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2304#note_25975

1 0

Re: [PATCH v7 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) 02 Mar '23

02 Mar '23

tests failing for unrelated reasons -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2044#note_25966

1 0

[PATCH v6 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 01 Mar '23

01 Mar '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v6: d3d9: Always draw only a single instance for non-indexed draws. d3d9/tests: Add test for not-indexed instancing drawing https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

3 9

[PATCH v2 0/2] MR2302: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile().
by w-flo (＠w-flo) 01 Mar '23

01 Mar '23

ZusiDisplay sometimes loads the same font file into two different PrivateFontCollections using two threads, so there is a race condition when the file is opened without the FILE_SHARE_READ sharing mode. The second call to GdipPrivateAddFontFile() might fail if the first one hasn't closed the file handle yet. -- v2: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile(). gdiplus/tests: Test for GdipPrivateAddFontFile() sharing violation. https://gitlab.winehq.org/wine/wine/-/merge_requests/2302

4 9

Re: [PATCH v2 0/5] MR2256: wined3d: move stubs out of state tables - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2256

1 0

Re: [PATCH v7 0/8] MR2098: mshtml: Implement synchronous XMLHttpRequests. - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2098

1 0

Re: [PATCH v3 0/2] MR2308: mfreadwrite/reader: Release device manager in source_reader_release. - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2308

1 0

Re: [PATCH v2 0/1] MR2307: dlls/dwrite: Pass correct font key when adding glyph to cache. - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2307

1 0

Re: [PATCH v5 0/1] MR2033: ntoskrnl: Add ExGetPreviousMode and test. - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2033

1 0

Re: [PATCH v5 0/1] MR2046: server: Annotate allocation functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2046

1 0

Re: [PATCH v2 0/3] MR2304: widl: Add parameterized signatures for more basic types. - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2304

1 0

[PATCH v2 0/3] MR2274: ntdll: Add source file and line to debug traces.
by Rémi Bernon (＠rbernon) 01 Mar '23

01 Mar '23

-- v2: ntdll: Add return address information in __wine_debug_context. ntdll: Add file and line information in __wine_debug_context. ntdll: Introduce struct __wine_debug_context for extensible debug info. https://gitlab.winehq.org/wine/wine/-/merge_requests/2274

3 7

[PATCH 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces.
by Connor McAdams (＠cmcadams) 01 Mar '23

01 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

3 11

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Paul Gofman (＠gofman) 01 Mar '23

01 Mar '23

Do you see any other way out of this? I mean specifically the case when an app sets GL pixel format itself on a window. I was thinking about whether it is possible to make setpixelformat quicker in winex11 instead and I don't see how. If keeping direct presentation it will require some X window reconfigure which is not going to be anywhere quick. Otherwise, it can be technically made to work like for GL child window redering (keeping composite redirected drawables for different pixel formats) but that requires essentially the same blitting on each present as done with wined3d backup context. The other different (but a bit complicated) way would be to: - count statistics of GL pixel format switches; - introduce switching back from backup context and switch between resetting pixel format or switching to backup context or back based on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25906

1 0

[PATCH 0/5] MR2256: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) 01 Mar '23

01 Mar '23

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2256

4 7

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Zebediah Figura (＠zfigura) 01 Mar '23

01 Mar '23

> It's probably worth pointing out that this has quite some potential for causing regressions in performance. swapchain_blit_gdi() is not fast, and ideally we'd work on reducing the number of cases where it's needed. The fundamental idea here is that setting and restoring the pixel format is even worse, since we always need to recreate the GLX drawable when we do that. And as far as I can tell, this patch doesn't force GDI blitting in any other circumstance. That said, what about Mac? I don't really know what's going on here; set_pixel_format() seems to be cheap, but I can't easily tell if that's because it really is cheap, or because setting the pixel format just doesn't work. Either way this patch is questionable as-is. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25904

1 0

2025

2024

2023

2022

wine-gitlab