- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR2291: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Jacek Caban (＠jacek) 27 Feb '23

27 Feb '23

The plan for those functions is to use syscall interface (not unixlib calls), see https://gitlab.winehq.org/jacek/wine/-/commits/wow/. We can't merge it yet because printer driver needs refactoring first (with current code, wineps.drv is a PE file that exposes GDI driver, so we still do some unixlib->PE calls in win32u). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2291#note_25557

1 0

[PATCH 0/3] MR2293: gdi32/tests: Fix the SetDeviceGammaRamp() tests on Windows 10 1909.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2293

3 4

[PATCH v11 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v11: winspool: Check dmSize in IsValidDevmodeWw https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

4 4

[PATCH v3 0/1] MR2288: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

Windows 11 uses a narrow non-breaking space instead of a plain one when formatting numbers. This is probably more correct and maybe Wine should switch too. But marking the old result as broken() would require unbundling expect_wstr() which would be bothersome. So this commit just accepts both. -- v3: kernel32/tests: Fix the French GetNumberFormatEx() test on Windows 11. https://gitlab.winehq.org/wine/wine/-/merge_requests/2288

2 3

[PATCH v2 0/1] MR2133: Draft: ntdll/tests: Minimize the stack size for test_tp_multi_wait().
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- v2: ntdll/tests: Minimize the stack size for test_tp_multi_wait(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2133

2 2

Re: [PATCH v4 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Henri Verbeet (＠hverbeet) 27 Feb '23

27 Feb '23

There are some minor style and formatting issues in this series that I'm going to ignore for the moment. The test either doesn't test the changes in patch 2/2, or it fails before that patch. The larger issue with this series though is that it doesn't seem quite ideal to potentially set and restore the stream source frequency on each DrawPrimitive()/DrawPrimitiveUP() call, because of the resulting state invalidation. It may be time to move the d3d9-style instance count handling out of wined3d and track that entirely in d3d9. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2282#note_25548

1 0

[PATCH v3 0/2] MR2213: Draft: Debug GitLab's kernel32:heap failures in test_GlobalMemoryStatus()
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- v3: DEBUG kernel32:heap: Trace the GlobalMemoryStatus() results for the GitLab CI failures. https://gitlab.winehq.org/wine/wine/-/merge_requests/2213

3 4

[PATCH 0/1] MR2281: nsi: Simplify and better document NsiAllocateAndGetTable().
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2281

3 3

[PATCH v10 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v10: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1

[PATCH v9 0/2] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v9: winspool: Check the alignment of dmSize in IsValidDevmodeW() winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

4 4

[PATCH v2 0/2] MR2268: oleaut32: Allocate a full pointer when unmarshalling byref arrays.
by Rémi Bernon (＠rbernon) 27 Feb '23

27 Feb '23

Instead of the 4 bytes array wire size returned by get_type_size, which will truncate the pointer on 64-bit. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54562 -- v2: oleaut32: Allocate a full pointer when unmarshalling byref arrays. oleaut32/tests: Test VARIANT_UserUnmarshal allocation sizes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2268

3 4

[PATCH 0/1] MR2291: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Fan WenJie (＠fanwenjie) 27 Feb '23

27 Feb '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> calling unix funcions from PE must via unix_call, Because must switch fs register vaule and other context on wow64 mode. Currently calling some unix functions of win32u via function pointers. The patch modify the way of calling unix functions of win32u by unix_call -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2291

2 1

Re: [PATCH v13 0/8] MR1628: ntdll: Implement Low Fragmentation Heap.
by Corey Hickey (＠bugfood) 27 Feb '23

27 Feb '23

Thank you for this. 27665f35e4da13bac1e4dd8948a65f484c9dadfa fixes a memory leak I was seeing in GTA San Andreas that had previously been introduced by 24432a24d5e922cbd824b0af8f7b0c66ff2b66e8. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1628#note_25506

1 0

[PATCH 0/1] MR2289: kernel32/tests: Fix the NtGetNlsSectionPtr() test on Windows 11.
by Francois Gouget (＠fgouget) 25 Feb '23

25 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2289

2 1

[PATCH v2 0/1] MR2288: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11.
by Francois Gouget (＠fgouget) 25 Feb '23

25 Feb '23

Windows 11 uses a narrow non-breaking space instead of a plain one when formatting numbers. This is probably more correct and maybe Wine should switch too. But marking the old result as broken() would require unbundling expect_wstr() which would be bothersome. So this commit just accepts both. -- v2: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11. https://gitlab.winehq.org/wine/wine/-/merge_requests/2288

2 2

[PATCH 0/1] MR2287: kernel32/tests: Fix the NLSVersion test on Windows 10 22H2.
by Francois Gouget (＠fgouget) 25 Feb '23

25 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2287

2 1

[PATCH 0/1] MR2286: shell32: Add Shell_GetCachedImageIndexA/W exports.
by Gijs Vermeulen (＠gverm) 25 Feb '23

25 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54581 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2286

2 1

[PATCH 0/6] MR2285: Enhancements to dbghelp/tests.
by eric pouech (＠epo) 25 Feb '23

25 Feb '23

This serie: - fixes a couple of tests failures on Windows 11 (Note: there are still other issues under Windows 11, mostly addressed by MR!2252) - introduce a couple of helpers to simplify current and yet to come test code - improves some existing tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2285

2 6

[PATCH v3 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 25 Feb '23

25 Feb '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v3: d3d9: Disable instancing for not-indexed drawing d3d9/tests: Add test for not-indexed instancing drawing https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

3 3

[PATCH v2 0/2] MR2279: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. (#54564)
by Jinoh Kang (＠iamahuman) 25 Feb '23

25 Feb '23

Introduce a temporary variable, `other_para`, so that we don't end up returning incorrect para (with stale run) inside the output cursor. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54564 -- v2: riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. riched20/tests: Test for word movement across paragraph boundary. https://gitlab.winehq.org/wine/wine/-/merge_requests/2279

2 4

[PATCH v3 0/4] MR2249: winscard: Add implementation of basic functionality.
by Konstantin Romanov (＠IncubusRK) 25 Feb '23

25 Feb '23

based on libpcsclite1 \ rework of [original code by Mounir IDRASSI](https://sourceforge.net/projects/scard4wine/) to use unixlib interface First step to resolve \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39113 \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37495 \ It will probably also require the implementation of scarddlg. In order for the tests to work fully in a virtual environment without the appropriate hardware, I suggest using the project https://github.com/Jakuje/virt_cacard Example for setting up a build server (It is supposed to be Debian): ``` apt-get install -y pcscd vsmartcard-vpcd libpcsclite1 libpcsclite-dev libcacard-dev libsofthsm2 libnss3-tools gnutls-bin opensc service pcscd restart git clone https://github.com/Jakuje/virt_cacard cd virt_cacard ./autogen.sh && ./configure && make ./setup-softhsm2.sh ``` "Insert" smartcard before runing tests: \ `cd /path/to/virt_cacard && SOFTHSM2_CONF=softhsm2.conf ./virt_cacard &` Partial test can be done if installed vsmartcard-vpcd (only test create/release context and list aviable card readers): \ ``` apt-get install -y pcscd vsmartcard-vpcd service pcscd restart ``` -- v3: winscard: fix discards 'const' qualifier https://gitlab.winehq.org/wine/wine/-/merge_requests/2249

5 15

[PATCH 0/1] MR2284: bcrypt: Remove unused fields from struct key_asymmetric32.
by Sven Baars (＠sbaars) 25 Feb '23

25 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2284

2 1

[PATCH v6 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v6: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 2

[PATCH v5 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v5: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 1

[PATCH v4 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 25 Feb '23

25 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v4: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 1

2025

2024

2023

2022

wine-gitlab