- wine-gitlab - winehq.org

[PATCH v10 0/8] MR84: vkd3d-shader/spirv: Merge all shader IR fork and join phases into a single phase.
by Conor McCarthy (＠cmccarthy) 17 Feb '23

17 Feb '23

Normalise the incoming vkd3d_shader_instruction IR to the shader model 6 pattern where only one patch constant function is emitted. This allows generation of a single patch constant function in SPIR-V. -- v10: vkd3d-shader/normalise: Insert hull shader control point input declarations if no control point phase is defined. vkd3d-shader/spirv: Delete an unnecessary call to spirv_compiler_get_register_id(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

4 15

[PATCH v13 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl (＠besentv) 17 Feb '23

17 Feb '23

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v13: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

3 7

[PATCH 0/5] MR2159: winegstreamer: Stride and RGB formats, part 2/2.
by Zebediah Figura (＠zfigura) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2159

5 11

[PATCH 0/2] MR2149: wineps: Use CRT functions for memory allocation on the process heap.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2149

4 6

[PATCH v5 0/6] MR1889: bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 17 Feb '23

17 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- v5: bluetoothapis: Add BluetoothUnregisterAuthentication stub. bluetoothapis: Add BluetoothRegisterForAuthenticationEx stub. include/bluetoothapis: Add BluetoothRegisterForAuthenticationEx prototype. irprops.cpl: Import implementations from bluetoothapis. bthprops.cpl: Import implementations from bluetoothapis. bthprops.cpl: Move implementations to bluetoothapis. https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

3 8

[PATCH v5 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 17 Feb '23

17 Feb '23

This is what it looks like: **v1** ![Screenshot_20230213_212244](/uploads/14156031c91d4da29fc49ed9831b599a/Screenshot_20230213_212244.png) **v2** ![winecfg](/uploads/f610908b8ed2fbece6ef09ee5bd4d13e/winecfg.png) -- v5: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

3 4

[PATCH v3 0/5] MR2177: win32u: Get monitor name from EDID when possible
by Paul Gofman (＠gofman) 17 Feb '23

17 Feb '23

There are two common ways I observe how games get monitor name to display: 1. Registry key under Enum/Display (also present in EnumDisplayDevicesA result for monitors). On Windows this key is derived from edid as 'Manufacturer ID' (3 letters) combined with "Manufacturer product code" (4 hex digits). We currently have 'Default_Display' there for all the displays; 2. DisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME). Windows sets friendlyNameFromEdid flag and returns a name from 'EDID Display Descriptor' with code 0xfc ("Display name"). As far as I could see by searching through the Windows registry this name doesn't seem to be explicitly present anywhere in registry (besides binary raw edid of course). The first patch removes name from the gdi driver's display structure. Now none of the drivers set anything genuine there. x11 and winemac always end up with "Generic Non-Pnp Monitor" string, wineandroid sets NULL there and "Generic Non-Pnp Monitor" is set in win32u in this case. That "Generic Non-Pnp Monitor" goes to "DeviceDesc" registry value. While our value doesn't match Windows string exactly, Windows also doesn't have any meaningful name under DeviceDesc (and contains "Generic Non-Pnp Monitor" as a part of it). So this patch is essentially a no-op currently. Going forward my idea is that we just want to have edid from drivers. If the raw one is not available we can generate fallback one ourselves based on the info about the monitor we might have from elsewhere in the drivers. My motivation is: - EDID is sometimes queried by apps directly, and it is better to provide a true one or a synthetic one with as much of accurate info as possible / reasonable; - There is more info in EDID, e. g., colorimetry for HDR support in d3d. As far as I can tell, there is no documented way to query HDR info on Windows besides dxgi interfaces (which in case on Wine are based on gdi drivers for such things and can hardly become a genine source of such info in Wine) and WinRT interface (for which I don't know where it takes the info on Windows but we probably don't want to make it a lower level source of such info in Wine). The alternative would be, instead of basing higher level win32u on EDID, parse EDID in drivers instead and add all the necessary info into gdi_monitor structure (instead of removing display name from there), but so far it seems less straightforward to me. -- v3: win32u: Get friendly monitor name from EDID in NtUserDisplayConfigGetDeviceInfo(). win32u: Return edidManufactureId and edidProductCodeId from NtUserDisplayConfigGetDeviceInfo(). win32u: Store EDID info in monitors cache. win32u: Use monitor ID from EDID when available. win32u: Remove monitor name from gdi driver monitor info. https://gitlab.winehq.org/wine/wine/-/merge_requests/2177

3 8

[PATCH v4 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 17 Feb '23

17 Feb '23

This is what it looks like: **v1** ![Screenshot_20230213_212244](/uploads/14156031c91d4da29fc49ed9831b599a/Screenshot_20230213_212244.png) **v2** ![winecfg](/uploads/f610908b8ed2fbece6ef09ee5bd4d13e/winecfg.png) -- v4: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

3 5

[PATCH v16 0/2] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 17 Feb '23

17 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v16: ddraw: Also Buffer D3DPT_POINTLIST ddraw: Add a local buffer in d3d_device7_DrawPrimitive() https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

2 2

[PATCH 0/1] MR2197: rpcrt4: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2197

4 10

[PATCH 0/1] MR2202: msxml3: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2202

3 4

[PATCH v2 0/1] MR2203: msado15: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- v2: msado15: Use the _recalloc function instead of reimplementing it. https://gitlab.winehq.org/wine/wine/-/merge_requests/2203

3 4

[PATCH 0/1] MR2201: oledb32: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2201

2 3

[PATCH v2 0/1] MR2199: wininet: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- v2: wininet: Use the _recalloc function instead of reimplementing it. https://gitlab.winehq.org/wine/wine/-/merge_requests/2199

2 3

[PATCH 0/1] MR2198: hhctrl: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2198

2 3

[PATCH 0/1] MR2223: msdasql: Use SQLColAttributesW to fetch statement attributes.
by Alistair Leslie-Hughes (＠alesliehughes) 17 Feb '23

17 Feb '23

We need to use the ODBC v1 function SQLColAttributesW, to ensure that we use the lowest verion available. This ODBC function internally will call SQLColAttribute or SQLColAttributesW depending on what the driver supports. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2223

2 1

[PATCH v2 0/2] MR2144: server: On macOS, fake debug registers when running under Rosetta.
by Brendan Shanks (＠bshanks) 17 Feb '23

17 Feb '23

This was preventing wow64 from working on Apple Silicon/Rosetta. Based on a patch by Tim Clem <tclem(a)codeweavers.com>. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54367 -- v2: ntdll: Add a WARN when setting debug registers fails under Rosetta. server: On macOS, fake debug registers when running under Rosetta. https://gitlab.winehq.org/wine/wine/-/merge_requests/2144

2 2

[PATCH 0/4] MR2189: winegstreamer: Fix raw aac handling
by Paul Gofman (＠gofman) 17 Feb '23

17 Feb '23

Fixes Gungrave G.o.r.e media playback and hang on start. I tested separately that setting an obviously invalid AudioSpecificConfig fails on Windows as well. On Windows stream attributes incompatible with AudioSpecificConfig (e. g., sample rate) also fails. We currently don't have such checks (and that will require fully parsing AudioSpecificConfig on our side), but since we don't have to choose between the parameters and only validate them I hope missing validation is not critical until we have something depending on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2189

6 8

[PATCH 0/1] MR2222: mfsrcsnk: Add missing DllGetClassObject() export.
by Zebediah Figura (＠zfigura) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2222

3 2

[PATCH 0/5] MR2192: Wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) 17 Feb '23

17 Feb '23

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2192

4 7

[PATCH v14 0/6] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 17 Feb '23

17 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v14: ddraw: Convert buffer API to use d3d_device struct https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

3 7

[PATCH v12 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl (＠besentv) 16 Feb '23

16 Feb '23

Second commit is to be removed. Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v12: windows.media.speech: Implement Vosk create and release functions in the unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

3 12

[PATCH 0/2] MR2215: winsock: Fix two connect() issues.
by Paul Gofman (＠gofman) 16 Feb '23

16 Feb '23

I was mainly after the issue fixed by the second patch but stomped on another one while testing that and that one looks even more unfortunate to me. 1. When connect() is used on blocking socket and fails for whatever reason, next connect() will make a new independent connection attempt (both on Windows and Unix). In non-blocking mode however (and Unix sockets are always in non-blocking mode in Wine) on Linux the next connect() will always return an error (unlike Windows which will make a new connect attempt if the previous one completed and failed). So in Wine now even for blocking socket connect() will fail if previous attempt failed and return WSAECONNABORTED. The error returned by Linux connect() will be ECONNABORTED if getsockopt(SO_ERROR) was called on the socket after connect completed with failure, and true connect() fail error if getsockopt wasn't called. 2. connect() on blocking socket times out after ~21sec on Windows and after ~130 sec on Linux. That is the case when peer doesn't actively reject connection but just never replies anything. That is, client sent SYN and never heard back. So much longer timeout leads to what is seen as hang on exit in one game, but probably more important that it affect much more in various apps provoking timeouts or huge delays not just on exit. I did not find a way to set connect() timeout for socket on Windows. That difference mostly corresponds to number of SYN send retries. That is 7 on Linux by default and 4 on Windows (the delay between attempts starts from 1s and is doubled on each next attempt). There is TCP_SYNCNT socket option (Linux specific now, unfortunately) which allows to set the number of retries. Setting that to 4 yields 32 sec timeout (vs 21 sec on Windows). The remaining difference is probably due to different amount of time waited after last SYN is sent. There is also TCP_USER_TIMEOUT parameter which allows to effectively set the delay exactly, but it might interfere with SO_KEEPALIVE somehow and I hope that 32 vs 21 is not that critical already as 130 vs 21 and probably we can avoid complicating the thing with it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2215

3 3

Re: [PATCH v3 0/1] MR2190: winspool: Initialize nt_ppd in add_printer_driver. - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2190

1 0

Re: [PATCH v4 0/1] MR2214: vbscript: fix compile issue with non hex after concat without space - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2214

1 0

2025

2024

2023

2022

wine-gitlab