- wine-gitlab - winehq.org

[PATCH 0/1] MR2143: vbscript: add missing stubs for GetLocale and SetLocale builtins
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

I ran into a script that was calling `SetLocale`. I didn't realize this was a built in function as it was missing in the `global_props` array and I couldn't find it defined in the script. After some research, I found it here: https://www.oreilly.com/library/view/vbscript-in-a/0596004885/re172.html This just adds the stubs for `GetLocale` and `SetLocale` so they can hopefully be implemented later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2143

3 2

[PATCH 0/1] MR2142: vbscript: fix compile when colon follows Else on new line
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

I ran into a script where someone placed a `:` on a new line after an `Else` but before another statement: ``` Else : VelCoef = LinearEnvelope(BallPos, VelocityIn, VelocityOut) if Enabled then aBall.Velx = aBall.Velx*VelCoef if Enabled then aBall.Vely = aBall.Vely*VelCoef end if ``` I confirmed that this is allowed and works. I've updated the grammar, and replaced `NL` with `StSep_opt` as it seems to cover all the bases. Fixes: https://bugs.winehq.org/show_bug.cgi?id=54234 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2142

3 2

[PATCH v2 0/1] MR2141: vbscript: Fix memory leak in owned safearray iterator
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

While running in XCode's profiler, I noticed memory leaks when safearrays were used in `For Each` statements. The following code would leak a safearray allocation: ``` For Each obj In vpDict.Keys : Debug.Print "Key" : Next ``` This following code does not leak: ``` Dim x x = vpDict.Keys For Each obj In x : Debug.Print "Key" : Next ``` Fixes: https://bugs.winehq.org/show_bug.cgi?id=54456 -- v2: vbscript: Fix memory leak in owned safearray iterator https://gitlab.winehq.org/wine/wine/-/merge_requests/2141

3 2

[PATCH v2 0/2] MR2151: ntdll: Look at CurrentMajor/MinorVersionNumber registry values before CurrentVersion.
by Hans Leidekker (＠hans) 09 Feb '23

09 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54463 -- v2: ntdll: Look at CurrentMajor/MinorVersionNumber registry values before CurrentVersion. ntdll: Initialize PEB version numbers with Windows 10 values. https://gitlab.winehq.org/wine/wine/-/merge_requests/2151

2 2

[PATCH 0/1] MR2152: dbghelp: Fix failing test on Windows 7.
by eric pouech (＠epo) 09 Feb '23

09 Feb '23

Using old versions of the module information structure. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54465 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2152

3 2

[PATCH 0/1] MR86: vkd3d-shader/hlsl: Support abs() for SM1.
by Nikolay Sivov (＠nsivov) 09 Feb '23

09 Feb '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/86

6 5

[PATCH v7 0/8] MR1628: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon (＠rbernon) 09 Feb '23

09 Feb '23

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v7: ntdll: Add a thread-specific category group cache. ntdll: Use atomics and lock-free list for category groups. ntdll: Implement Low Fragmentation Heap frontend. ntdll: Split heap_resize_block into heap_resize_(block|large) helpers. ntdll: Count allocations and automatically enable LFH. ntdll: Increase heap block tail_size capacity to 16 bits. ntdll: Implement HeapCompatibilityInformation. ntdll: Fix HeapWalk with empty uncommitted consecutive subheaps. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

3 36

[PATCH 0/1] MR2151: ntdll: Look at CurrentMajorVersionNumber/CurrentMinorVersionNumber registry values before CurrentVersion.
by Hans Leidekker (＠hans) 09 Feb '23

09 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54463 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2151

3 2

[PATCH 0/6] MR2146: winegstreamer: Add support for WMV DMO decoder.
by Ziqing Hui (＠zhui) 09 Feb '23

09 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2146

3 9

Re: [PATCH v2 0/4] MR2011: winegstreamer: Stride and RGB formats, part 1/2. - approved
by Nikolay Sivov (＠nsivov) 09 Feb '23

09 Feb '23

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2011

1 0

[PATCH v2 0/4] MR84: vkd3d-shader/spirv: Normalise inputs and outputs to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) 09 Feb '23

09 Feb '23

Multiple fork and join phases are eliminated. Signature elements are merged where required, and all input/output parameters are rewritten. -- v2: vkd3d-shader/trace: Trace the normalised instruction array after tracing the input. vkd3d-shader/spirv: Normalise signatures and input/output registers to the Shader Model 6 pattern. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

4 11

[PATCH 0/1] MR2150: include: Allow multiple definitions on GCC with DECLSPEC_SELECTANY.
by Alex Henrie (＠alexhenrie) 09 Feb '23

09 Feb '23

Needed to compile Tera Term. As far as I can tell, GCC has always supported `__attribute__((weak))`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2150

2 1

[PATCH v15 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 09 Feb '23

09 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v15: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

4 4

[PATCH 0/1] MR2147: ws2_32: Forbid passing zero buffers to WSARecv().
by Zebediah Figura (＠zfigura) 09 Feb '23

09 Feb '23

This may address bug 54074, but I'm not sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2147

3 2

[PATCH v14 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 09 Feb '23

09 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v14: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 3

Re: [PATCH v13 0/2] MR2100: ntdll: Do not send data to port 0.
by Zebediah Figura (＠zfigura) 09 Feb '23

09 Feb '23

> > but we could return it from the send_socket server request > > Where would I look into this I see the 'macro' call inside `sock_send`, but looking at `send_socket_reply` does not seem to have an protocol attached? It's automatically generated. You'd need to edit protocol.def and then run tools/make_requests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2100#note_23545

1 0

[PATCH v11 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 09 Feb '23

09 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v11: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 3

Re: [PATCH v13 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 09 Feb '23

09 Feb '23

> but we could return it from the send_socket server request Where would I look into this I see the 'macro' call inside `sock_send`, but looking at `send_socket_reply` does not seem to have an protocol attached? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2100#note_23543

1 0

[PATCH v3 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 08 Feb '23

08 Feb '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v3: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 4

[PATCH v10 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 08 Feb '23

08 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v10: ntdll: Do not send data to port 0. ws2_32/tests: Check if sending to port 0 succeeds. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 4

[PATCH v12 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 08 Feb '23

08 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v12: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 3

[PATCH 0/1] MR2141: vbscript: Fix memory leak in owned safearray iterator
by Jason Millard (＠jsm174) 08 Feb '23

08 Feb '23

While running in XCode's profiler, I noticed memory leaks when safearrays were used in `For Each` statements. The following code would leak a safearray allocation: ``` For Each obj In vpDict.Keys : Debug.Print "Key" : Next ``` This following code does not leak: ``` Dim x x = vpDict.Keys For Each obj In x : Debug.Print "Key" : Next ``` Fixes: https://bugs.winehq.org/show_bug.cgi?id=54456 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2141

2 1

Re: [PATCH v2 0/1] MR2128: ntdll/tests: Remove some Vista broken broken(<constant>) calls.
by Michael Stefaniuc (＠mstefani) 08 Feb '23

08 Feb '23

On Wed Feb 8 21:41:13 2023 +0000, Alex Henrie wrote: > I thought we still cared about XP and later (that's what the testbot > supports). Has that changed? WTB might support XP and Vista but those aren't part of the default test set. Nor are they shown on https://test.winehq.org/data/ . The winetest/dissect utility though doesn't marks them as prediluvian. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2128#note_23521

1 0

Re: [PATCH v2 0/1] MR2137: msi: Annotate memory allocation functions with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 08 Feb '23

08 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2137

1 0

Re: [PATCH v5 0/3] MR2130: Fix missing *out=NULL in (WMReader|unknown_inner)_QueryInterface - approved
by Alexandre Julliard (＠julliard) 08 Feb '23

08 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2130

1 0

2025

2024

2023

2022

wine-gitlab