- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR82: vkd3d: Fix checking for failure from SleepConditionVariableCS(). - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/82

1 0

Re: [PATCH v2 0/1] MR78: vkd3d: Initialize image aspect for NULL SRVs. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/78

1 0

[PATCH v2 0/1] MR2125: ntdll/tests: Fix broken broken(<constant>) calls.
by Michael Stefaniuc (＠mstefani) 07 Feb '23

07 Feb '23

-- v2: ntdll/tests: Fix broken broken(<constant>) calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2125

2 4

[PATCH 0/1] MR2053: wmc: Include config.h from lang.c
by Gerald Pfeifer (＠gerald) 07 Feb '23

07 Feb '23

tools.h uses HAVE_SYS_SYSCTL_H as an include guard which, like others set by configure, is defined in config.h. Make sure we pull that in or we never get to include sys/sysctl.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2053

3 3

Re: [PATCH v2 0/1] MR2124: dlls: fix whitespaces in WINE_*_DEBUG_CHANNEL declarations - closed
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2124

1 0

Re: [PATCH v2 0/1] MR2124: dlls: fix whitespaces in WINE_*_DEBUG_CHANNEL declarations
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

Please don't do that sort of thing. Whitespace-only changes should be avoided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2124#note_23323

1 0

[PATCH 0/1] MR2125: ntdll/tests: Fix broken broken(<constant>) calls.
by Michael Stefaniuc (＠mstefani) 07 Feb '23

07 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2125

3 2

[PATCH v2 0/11] MR2123: Wow64 support for wpcap.
by Hans Leidekker (＠hans) 07 Feb '23

07 Feb '23

-- v2: wpcap/tests: Initial tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2123

2 11

[PATCH 0/1] MR79: vkd3d-shader/hlsl: Handle saturate() for SM1.
by Nikolay Sivov (＠nsivov) 07 Feb '23

07 Feb '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/79

6 9

[PATCH v6 0/8] MR66: vkd3d-shader/hlsl: Broaden resources support v2 (PART 1).
by Francisco Casas (＠fcasas) 07 Feb '23

07 Feb '23

First part of v2 of !27, which aims to: * Allow allocation of variables of complex types that contain both numerics and objects across multiple register sets (regsets). * Support the tex2D and tex3D intrinsics, inferring generic samplers dimension from usage, writing sampler declarations, and writing sample instructions. * Support for arrays of resources for both SM1 and SM4 (not to be confused with the resource-arrays of SM 5.1, which can have non-constant indexes). * Support for resources declared within structs. * Support for synthetic combined samplers for SM1 and synthetic separated samplers for SM4, considering that they can be arrays or members of structs. * Imitate the way the native compiler assigns the register indexes of the resources on allocation, which proved to be the most difficult thing. * Support for object components within complex input parameters. * Small fixes to corner cases. This part consists on parsing the `tex2D()` and `tex3D()` intrinsics and beginning to support the allocation of variables across multiple regsets. The whole series, is on my [master6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6) branch. -- v6: vkd3d-shader/hlsl: Allocate register reservations in a separate pass. vkd3d-shader/hlsl: Respect object reservations even if the object is unused. vkd3d-shader/hlsl: Allocate objects according to register set. vkd3d-shader/hlsl: Keep an hlsl_reg for each register set in hlsl_ir_var. vkd3d-shader/hlsl: Store the type's register size for each register set. vkd3d-shader/hlsl: Parse the tex3D() intrinsic. vkd3d-shader/hlsl: Parse the tex2D() intrinsic. vkd3d-shader/hlsl: Avoid segfault on missing sampler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/66

4 15

[PATCH v3 0/2] MR2120: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications
by Evan Tang (＠etang-cw) 07 Feb '23

07 Feb '23

This seems to be relied on by some versions of [this Unreal Engine input plugin](https://www.unrealengine.com/marketplace/en-US/product/wm-input-man… Note: I'm not sure how to deal with `HID_USAGE_GENERIC_KEYPAD`, which (I think) would fall under `RIM_TYPEKEYBOARD`. Do we need to store extra info to differentiate these from `HID_USAGE_GENERIC_KEYBOARD` or is there something in the device info struct that can differentiate them? -- v3: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications https://gitlab.winehq.org/wine/wine/-/merge_requests/2120

4 5

[PATCH 0/1] MR1963: d3dcompiler_43/tests: Allow more imprecision in test_trig() for NVIDIA.
by Francois Gouget (＠fgouget) 07 Feb '23

07 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1963

3 2

[PATCH 0/9] MR2122: Draft: winex11: Support fixed X11 keycode to scancode conversion.
by Rémi Bernon (＠rbernon) 07 Feb '23

07 Feb '23

X11 keycodes are just Linux keycodes + 8 nowadays according to evdev or libinput drivers, and we can avoid innacurate reconstruction in the most common case. Opening this as a draft for now, to show where I'd like to go with https://gitlab.winehq.org/wine/wine/-/merge_requests/2062. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2122

3 10

[PATCH v8 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 07 Feb '23

07 Feb '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v8: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit on thread exit. ntdll: Return entry and suspend from server_init_process_done. ntdll: Create a pthread for the main thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

3 7

[PATCH v7 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 07 Feb '23

07 Feb '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v7: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit on thread exit. ntdll: Return entry and suspend from server_init_process_done. ntdll: Create a pthread for the main thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

4 9

[PATCH v3 0/6] MR77: hlsl: Fixes for function definition vs declaration.
by Zebediah Figura (＠zfigura) 07 Feb '23

07 Feb '23

-- v3: vkd3d-shader/hlsl: Add functions to the global list inside the func_prototype rule. vkd3d-shader/hlsl: Use the original hlsl_ir_function_decl struct rather than allocating a new one for each definition. vkd3d-shader/hlsl: Put synthetic variables into a dummy scope. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/77

4 10

[PATCH v2 0/5] MR81: vkd3d-shader/hlsl: Fixes for SM1 writemasks and swizzles.
by Francisco Casas (＠fcasas) 07 Feb '23

07 Feb '23

Because of the change introduced in f21693b2, SM1 scalars and vectors were not longer getting the correct writemask when they are allocated, so this is fixed. Also, the mapping of sm1 src register swizzles is moved outside `write_sm1_instruction()` since there are some instructions that don't do this, remarkably dp2add. This is fixed. Before the last patch we are writing the operation as: ``` dp2add r0.x, r1.x, r0.x, r2.x ``` and now it is: ``` dp2add r0.x, r1.xyxx, r0.xyxx, r2.x ``` dp2add now has its own function, `write_sm1_dp2add()`, since it seems to be the only instruction with this structure. Ideally we would be using the default swizzles for the first two src arguments: ``` dp2add r0.x, r1, r0, r2.x ``` since, according to native's documentation, these are supported for all sm < 4. But using default swizzles whenever is possible -- along with following the conversion of repeating the last component of the swizzle when fewer than 4 components are to be specified -- has a higher scope. Probably would involve modifying `hlsl_swizzle_from_writemask()` and `hlsl_map_swizzle()`. -- v2: vkd3d-shader/hlsl: Fix SM1 dp2add swizzles. vkd3d-shader/hlsl: Map SM1 src swizzles outside write_sm1_instruction(). vkd3d-shader/hlsl: Set writemasks correctly for SM1 scalar and vector types. vkd3d-shader/hlsl: Expect component count in allocate_register(). vkd3d-shader/hlsl: Rename 'component_count' arguments to 'reg_size'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/81

5 9

[PATCH 0/11] MR2123: Wow64 support for wpcap.
by Hans Leidekker (＠hans) 07 Feb '23

07 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2123

3 12

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes.
by Rémi Bernon (＠rbernon) 07 Feb '23

07 Feb '23

On Mon Feb 6 15:36:14 2023 +0000, Timo Zuccarello wrote: > Is there anything I can help with? I obviously have a bit of a personal > interest in having this "fixed" finally. Well if you feel like it, you can always have a look at the MR and review the changes. I also opened https://gitlab.winehq.org/wine/wine/-/merge_requests/2122 with the complete changes, if you want to give it a try, and confirm that it does the right thing for you as well. I've done a bit of testing but I don't often use any very fancy keyboard layout either. Then I suspect that what's expected here is actually a bit more wider testing, so probably I should try to get this into Wine Staging or Proton first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182#note_23264

1 0

[PATCH v6 0/7] MR1628: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon (＠rbernon) 07 Feb '23

07 Feb '23

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v6: ntdll: Add a thread-specific category group cache. ntdll: Use atomics and lock-free list for category groups. ntdll: Implement Low Fragmentation Heap frontend. ntdll: Count allocations and automatically enable LFH. ntdll: Increase heap block tail_size capacity to 16 bits. ntdll: Implement HeapCompatibilityInformation. ntdll: Fix HeapWalk with empty uncommitted consecutive subheaps. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

4 57

[PATCH 0/1] MR2111: nsiproxy: Avoid calling RtlInitUnicodeString on a static constant.
by Alex Henrie (＠alexhenrie) 07 Feb '23

07 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2111

3 2

[PATCH v2 0/1] MR2112: combase: Avoid calling RtlInitUnicodeString on a static constant.
by Alex Henrie (＠alexhenrie) 07 Feb '23

07 Feb '23

-- v2: combase: Avoid calling RtlInitUnicodeString on a static constant. https://gitlab.winehq.org/wine/wine/-/merge_requests/2112

3 2

[PATCH v3 0/5] MR2103: Draft: Add support for WinRT app dark mode
by Mohamad Al-Jaf (＠maljaf) 07 Feb '23

07 Feb '23

WinRT apps check if the Windows theme is set to dark mode through IUISettings3::GetColorValue(). An option needs to be added to Winecfg to enable dark mode support, which just sets the registry key AppsUseLightTheme to 0 for dark mode and 1 for light mode. It will have to be in a separate merge request. Also, not sure if a dark mode checkbox should be added or if dark mode should be automatically set based on the loaded theme in Wine. Though, for the latter there needs to be a property that returns the mode of the theme. Name alone might not be sufficient. -- v3: windows.ui/tests: Add IUISettings3::GetColorValue() tests. windows.ui: Implement IUISettings3::GetColorValue(). windows.ui: Add IUISettings3 stub interface. windows.ui: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2103

3 22

[PATCH v2 0/2] MR2120: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications
by Evan Tang (＠etang-cw) 07 Feb '23

07 Feb '23

This seems to be relied on by some versions of [this Unreal Engine input plugin](https://www.unrealengine.com/marketplace/en-US/product/wm-input-man… Note: I'm not sure how to deal with `HID_USAGE_GENERIC_KEYPAD`, which (I think) would fall under `RIM_TYPEKEYBOARD`. Do we need to store extra info to differentiate these from `HID_USAGE_GENERIC_KEYBOARD` or is there something in the device info struct that can differentiate them? -- v2: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications user32: Add tests for WM_INPUT_DEVICE_CHANGE messages https://gitlab.winehq.org/wine/wine/-/merge_requests/2120

4 7

[PATCH v5 0/6] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl (＠besentv) 07 Feb '23

07 Feb '23

Second commit is to be removed. Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v5: windows.media.speech: Implement Vosk create and release functions in the unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

4 20

2025

2024

2023

2022

wine-gitlab