- wine-gitlab - winehq.org

[PATCH 0/1] MR1859: winex11: Raise owned windows before setting input focus.
by Rémi Bernon (＠rbernon) 06 Feb '23

06 Feb '23

Installers based on InnoSetup use invisible window owning the main installer window. When focus is given to the installer window popup, window managers sometimes do not raise it as their owner is invisible and it stays below other windows unless they are minimized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49933 This is not a regression and it is arguably perhaps a window manager bug, but it is also extremely annoying for users as installer windows tend to disappear from the pager, as well as missing from the window selector and below all other windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1859

2 2

[PATCH 0/1] MR1498: ntdll: Use RTLD_NOLOAD to find already mapped modules.
by Rémi Bernon (＠rbernon) 06 Feb '23

06 Feb '23

This makes it possible to detect modules that weren't unmapped from dlclose, and that we should not fixup again. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49640 This usually happens with C++ winelibs, where some C++ symbols may be inlined into the winelib, then later resolved in preference over other symbol definitions when libstdc++ loads. This results in circular dependency between the winelib and libstdc++, making dlclose no-op. In this case, reloading the lib later and calling `map_so_dll` on it again will fixup the RVAs again, ending up with invalid addresses. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1498

4 6

Re: [PATCH v5 0/8] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 06 Feb '23

06 Feb '23

On Tue Oct 18 12:09:32 2022 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=125085 > Your paranoid android. > === debian11 (32 bit report) === > ddraw: > ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x1000. > ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x3000. > Report validation errors: > advapi32:security has no test summary line (early exit of the main process?) > advapi32:security has unaccounted for todo messages > kernel32:sync has no test summary line (early exit of the main process?) > === debian11 (build log) === > 01d0:err:winediag:d3d_device_create The application wants to create a > Direct3D device, but the current DirectDrawRenderer does not support this. > 01d0:err:winediag:d3d_device_create The application wants to create a > Direct3D device, but the current DirectDrawRenderer does not support this. > 01d0:err:winediag:d3d_device_create The application wants to create a > Direct3D device, but the current DirectDrawRenderer does not support this. > === debian11 (build log) === > Use of uninitialized value $Flaky in addition (+) at > /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489. > Use of uninitialized value $Flaky in addition (+) at > /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489. > Use of uninitialized value $Flaky in addition (+) at > /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489. > ``` I believe these failures should be fixed now, the `kernel32:sync` failure was coming from a thread terminated before it started. This should work fine now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1088#note_23056

1 0

Re: [PATCH v5 0/8] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 06 Feb '23

06 Feb '23

I've implemented the frame unwind, using `_Unwind_ForcedUnwind` when available, in addition to skipping `pthread_exit`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1088#note_23054

1 0

[PATCH v2 0/6] MR2102: Add a partially implemented ir50_32 winmm video decoder, and a stub generic video decoder in winegstreamer.
by Shaun Ren (＠shaunren) 06 Feb '23

06 Feb '23

-- v2: ir50_32: Implement open and close. winegstreamer: Add video_decoder stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2102

4 10

[PATCH v5 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 06 Feb '23

06 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v5: ntdll: Do not send data to port 0. tests: Added to check if sending port 0 succeeds https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 3

[PATCH 0/1] MR2110: msi: Handle memory allocation failure in get_link_file (cppcheck).
by Alex Henrie (＠alexhenrie) 06 Feb '23

06 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2110

3 2

[PATCH v6 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 06 Feb '23

06 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v6: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH v4 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 06 Feb '23

06 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v4: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH v3 0/2] MR2100: Draft: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 06 Feb '23

06 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v3: ntdll: Do not send data to port 0. tests: Added to check if sending port 0 succeeds https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH 0/2] MR2114: kernelbase: Fix performance of beatmap search in osu! Stable.
by Torge Matthies (＠tmatthies) 06 Feb '23

06 Feb '23

Commit 448e68ab5b937d168f5d091d8f65a7de534a9891 made searching for beatmaps in the in-game map list very slow, going from a few 100 ms to more than 10 seconds with my set of downloaded maps. The first commit in this MR fixes this problem, and the second commit potentially helps too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2114

2 2

[PATCH v2 0/1] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 06 Feb '23

06 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v2: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 5

[PATCH v2 0/5] MR2103: Draft: Add support for WinRT app darkmode
by Mohamad Al-Jaf (＠maljaf) 05 Feb '23

05 Feb '23

WinRT apps check if the Windows theme is set to dark mode through IUISettings3::GetColorValue(). An option needs to be added to Winecfg to enable dark mode support, which just sets the registry key AppsUseLightTheme to 0 for dark mode and 1 for light mode. It will have to be in a separate merge request. Also, not sure if a dark mode checkbox should be added or if dark mode should be automatically set based on the loaded theme in Wine. Though, for the latter there needs to be a property that returns the mode of the theme. Name alone might not be sufficient. Marking this as draft because I'm not sure what I'm doing wrong with the test. It's returning E_NOINTERFACE for IUISettings3. -- v2: windows.ui/tests: Add IUISettings3::GetColorValue() tests. windows.ui: Implement IUISettings3::GetColorValue(). windows.ui: Add IUISettings3 stub interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/2103

2 6

[PATCH 0/5] MR2103: Draft: Add support for WinRT app darkmode
by Mohamad Al-Jaf (＠maljaf) 05 Feb '23

05 Feb '23

WinRT apps check if the Windows theme is set to dark mode through IUISettings3::GetColorValue(). An option needs to be added to Winecfg to enable dark mode support, which just sets the registry key AppsUseLightTheme to 0 for dark mode and 1 for light mode. It will have to be in a separate merge request. Also, not sure if a dark mode checkbox should be added or if dark mode should be automatically set based on the loaded theme in Wine. Though, for the latter there needs to be a property that returns the mode of the theme. Name alone might not be sufficient. Marking this as draft because I'm not sure what I'm doing wrong with the test. It's returning E_NOINTERFACE for IUISettings3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2103

5 10

[PATCH 0/1] MR2113: odbccp32: Append DLL path when loading driver.
by Alistair Leslie-Hughes (＠alesliehughes) 05 Feb '23

05 Feb '23

For example, loading by full path, myodbc8a.dll causes a load failure since it dependencies libcrypto-1_1.dll, libssl-1_1.dll are in the DLL directory and not in the search path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2113

2 1

[PATCH v4 0/2] MR76: vkd3d-shader/hlsl: Support rsqrt() and distance() intrinsics.
by Nikolay Sivov (＠nsivov) 04 Feb '23

04 Feb '23

-- v4: vkd3d-shader/hlsl: Support distance() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/76

3 7

[PATCH 0/1] MR2112: combase: Avoid calling RtlInitUnicodeString on a constant.
by Alex Henrie (＠alexhenrie) 04 Feb '23

04 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2112

2 1

[PATCH 0/1] MR2109: setupapi: Fix memory leak on realloc failure in RetreiveFileSecurity.
by Alex Henrie (＠alexhenrie) 04 Feb '23

04 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2109

2 1

[PATCH v2 0/2] MR2108: wined3d: Destroy objects belonging to the current completed command buffer/fence.
by Zebediah Figura (＠zfigura) 04 Feb '23

04 Feb '23

-- v2: wined3d: Destroy objects belonging to wined3d_device_gl.completed_fence_id. https://gitlab.winehq.org/wine/wine/-/merge_requests/2108

3 3

[PATCH 0/2] MR2108: wined3d: Destroy objects belonging to the current completed command buffer/fence.
by Zebediah Figura (＠zfigura) 03 Feb '23

03 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2108

2 2

[PATCH 0/3] MR2107: dxgi: Implement IDXGIResource::GetUsage().
by Zebediah Figura (＠zfigura) 03 Feb '23

03 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2107

2 3

[PATCH 0/3] MR81: vkd3d-shader/hlsl: Fixes for SM1 writemasks and swizzles.
by Francisco Casas (＠fcasas) 03 Feb '23

03 Feb '23

Because of the change introduced in f21693b2, SM1 scalars and vectors were not longer getting the correct writemask when they are allocated, so this is fixed. Also, the mapping of sm1 src register swizzles is moved outside `write_sm1_instruction()` since there are some instructions that don't do this, remarkably dp2add. This is fixed. Before the last patch we are writing the operation as: ``` dp2add r0.x, r1.x, r0.x, r2.x ``` and now it is: ``` dp2add r0.x, r1.xyxx, r0.xyxx, r2.x ``` dp2add now has its own function, write_sm1_dp2add(), since it seems to be the only instruction with this structure. Ideally we would be using the default swizzles for the first two src arguments: ``` dp2add r0.x, r1, r0, r2.x ``` since, according to native's documentation, these are supported for all sm < 4. But using default swizzles whenever is possible -- along with following the conversion of repeating the last component of the swizzle when fewer than 4 components are to be specified -- has a higher scope. Probably would involve modifying `hlsl_swizzle_from_writemask()` and `hlsl_map_swizzle()`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/81

3 4

[PATCH 0/2] MR2099: tests: Actually test the return value of some function calls
by Michael Stefaniuc (＠mstefani) 03 Feb '23

03 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2099

5 6

[PATCH v4 0/1] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 03 Feb '23

03 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v4: ddraw: Add local buffer in d3d_device7_DrawPrimitive() https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

2 1

[PATCH v3 0/1] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 03 Feb '23

03 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v3: ddraw: Add local buffer in d3d_device7_DrawPrimitive() https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

2 1

2025

2024

2023

2022

wine-gitlab