- wine-gitlab - winehq.org

[PATCH 0/5] MR2087: More winedump improvement over PDB dumping.
by eric pouech (＠epo) 01 Feb '23

01 Feb '23

Continueing PDB support in winedump: - stricter size checks (to protect against bogus files) - more bits of PDB files dumped (ranges, sections, OMF details...) - keeping cleaning up some internal fields names -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2087

3 6

[PATCH v4 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Nikolay Sivov (＠nsivov) 01 Feb '23

01 Feb '23

-- v4: vkd3d-shader/hlsl: Support dot() for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74

2 2

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Broadly this feels fine to me. Other that the few little leftover issues, this should probably be split in at least three commits (one for writing DOT, one for lowering DOT and another one for writing DP2ADD). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22630

1 0

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c: > + break; > + > + default: > + vkd3d_unreachable(); > + } > + break; > + > + default: > + hlsl_fixme(ctx, &expr->node.loc, "SM1 %s dot expression.", dst_type_string->buffer); > + } > + break; > + > + case HLSL_OP3_DP2ADD: > + switch (dst_type->base_type) > + { > + case HLSL_TYPE_FLOAT: Same here, of course. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22628

1 0

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c: > write_sm1_unary_op(ctx, buffer, D3DSIO_FRC, &instr->reg, &arg1->reg, D3DSPSM_NONE); > break; > > + case HLSL_OP2_DOT: > + switch (dst_type->base_type) > + { > + case HLSL_TYPE_FLOAT: I think that SM1 basically only supports float, which is why all the other operations do not have this switch on the data type. I am not really confident on the details of this, but I guess that only float operations should arrive here anyway. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22624

1 0

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c: > struct hlsl_ir_expr *expr = hlsl_ir_expr(instr); > struct hlsl_ir_node *arg1 = expr->operands[0].node; > struct hlsl_ir_node *arg2 = expr->operands[1].node; > + struct hlsl_ir_node *arg3 = expr->operands[2].node; > + const struct hlsl_type *dst_type = expr->node.data_type; > + struct vkd3d_string_buffer *dst_type_string; > > assert(instr->reg.allocated); > > + if (!(dst_type_string = hlsl_type_to_string(ctx, dst_type))) This is never released. It should be passed to `hlsl_release_string_buffer()`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22620

1 0

[PATCH v2 0/7] MR2078: Fixes for debugging in new wow64 setup.
by eric pouech (＠epo) 01 Feb '23

01 Feb '23

This series brings some improvements for debugging support in the new wow64 environment: - detects and adapt to the new environement - fixes a couple of bugs appearing now - adds a couple of tests - extends winedbg to hide or display the modules when multiple machines are used in the same process -- v2: dbghelp: Identify a 32bit multi-arch wow64 debuggee as a live target. winedbg: Don't expose to gdb module which machine isn't the process' one. winedbg: Handle multi-machine process in command 'info share'. dbghelp: Filter on machine when searching for Wine system PE modules. dbghelp: Allow loading modules for different machines. dbghelp: Add tests about modules loading. dbghelp: Stop unwinding on potential 64bit frame for i386 cpu. https://gitlab.winehq.org/wine/wine/-/merge_requests/2078

2 8

[PATCH v2 0/6] MR2069: jscript/mshtml: Misc fixes and preparations.
by Gabriel Ivăncescu (＠insn) 01 Feb '23

01 Feb '23

Bunch of misc fixes and preparations for further improvements. The location changes are especially important later when we'll use outer windows everywhere we pass them to external callers (such as script engines, since inner windows are an implementation detail and all operations otherwise should go through the outer window "proxy"). -- v2: mshtml: Embed the HTMLLocation into the outer window. mshtml: Tie window.location to the outer window. mshtml: Return undefined from window.XMLHttpRequest for uninitialized jscript: Pass the correct ServiceProvider when invoking external prop. mshtml: Use Scrollbar_Auto as default for vertical scrollbars. include/mshtml: Add the other IHTMLEventObj* interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2069

3 8

[PATCH 0/1] MR2083: urlmon: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 01 Feb '23

01 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2083

3 2

[PATCH v3 0/4] MR2036: comctl32: Always use unicode messages for subclass procedures.
by Rémi Bernon (＠rbernon) 01 Feb '23

01 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43073 -- v3: comctl32: Skip restoring window proc if it has been modified. comctl32: Always use unicode messages for subclass procedures. https://gitlab.winehq.org/wine/wine/-/merge_requests/2036

4 8

[PATCH 0/1] MR2086: Warn that a libnss plugin may be missing if getaddrinfo() returns EBUSY.
by Francois Gouget (＠fgouget) 01 Feb '23

01 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2086

2 1

[PATCH v2 0/3] MR2080: winegstreamer: GetInputStatus for h264, aac and MF_SA_D3D11_AWARE for h264.
by Paul Gofman (＠gofman) 01 Feb '23

01 Feb '23

Needed for Gungrave G.O.R.E. (besides some bits in raw AAC handling). The game is fine with GetInputStatus always returning MFT_INPUT_STATUS_ACCEPT_DATA for both h264 and aac but I think it is better to be correct here. -- v2: winegstreamer: Set MF_SA_D3D11_AWARE attribute for h264 transform. winegstreamer: Implement _GetInputStatus() for aac decoder transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/2080

3 5

[PATCH v3 0/2] MR76: vkd3d-shader/hlsl: Support rsqrt() and distance() intrinsics.
by Nikolay Sivov (＠nsivov) 01 Feb '23

01 Feb '23

-- v3: vkd3d-shader/hlsl: Support distance() intrinsic. vkd3d-shader/hlsl: Support rsqrt() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/76

2 2

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about programs/rpcss/rpcss_main.c: > return S_OK; > } > > +/* Generates a new OXID suitable for use by an apartment. > + * Each call to this function returns a distinct OXID. > + * This function should not be invoked directly - use rpcss_get_new_apartment_oxid > + * instead. */ > +HRESULT __cdecl irpcss_get_new_apartment_oxid(handle_t h, OXID *oxid) > +{ > + HRESULT status; > + ULONG oxid_upper_bits; > + > + static LONG oxid_lower_bits; > + > + status = I_RpcBindingInqLocalClientPID(h, &oxid_upper_bits); > + ERR("Got client PID: %ld", oxid_upper_bits); This looks like it's left-over from debugging. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22593

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about programs/rpcss/rpcss_main.c: > } > > +/* Generates a new OXID suitable for use by an apartment. > + * Each call to this function returns a distinct OXID. > + * This function should not be invoked directly - use rpcss_get_new_apartment_oxid > + * instead. */ > +HRESULT __cdecl irpcss_get_new_apartment_oxid(handle_t h, OXID *oxid) > +{ > + HRESULT status; > + ULONG oxid_upper_bits; > + > + static LONG oxid_lower_bits; > + > + status = I_RpcBindingInqLocalClientPID(h, &oxid_upper_bits); > + ERR("Got client PID: %ld", oxid_upper_bits); > + if (status != S_OK) { Please put the opening brace on a new line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22594

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about dlls/combase/apartment.c: > > - if (apt->multi_threaded) > - { > - /* FIXME: should be randomly generated by in an RPC call to rpcss */ > - apt->oxid = ((OXID)GetCurrentProcessId() << 32) | 0xcafe; > - } > - else > - { > - /* FIXME: should be randomly generated by in an RPC call to rpcss */ > - apt->oxid = ((OXID)GetCurrentProcessId() << 32) | GetCurrentThreadId(); > - } > + /* Get a new OXID to use for this apartment. Note that re-creating > + * an apartment (by calling CoUninitialize and then CoInitializeEx) > + * will result in a new OXID. This ensures that we don't re-use a > + * proxy_manager` that refers to a dead apartment. */ > + rpcss_get_new_apartment_oxid(&apt->oxid); We would want to test for this failing (and probably clean up and return NULL). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22591

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about programs/rpcss/rpcss_main.c: > return S_OK; > } > > +/* Generates a new OXID suitable for use by an apartment. > + * Each call to this function returns a distinct OXID. > + * This function should not be invoked directly - use rpcss_get_new_apartment_oxid > + * instead. */ > +HRESULT __cdecl irpcss_get_new_apartment_oxid(handle_t h, OXID *oxid) > +{ > + HRESULT status; > + ULONG oxid_upper_bits; > + I think we can get rid of this blank line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22592

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Since the first commit just adds tests, could you change the commit msg prefix to `ole32/tests:` ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22590

1 0

[PATCH 0/1] MR2084: msi/tests: Avoid test failures when running with insufficient rights.
by Hans Leidekker (＠hans) 01 Feb '23

01 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51040 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2084

2 1

[PATCH v3 0/3] MR2077: Default to Windows 10.
by Hans Leidekker (＠hans) 01 Feb '23

01 Feb '23

-- v3: winecfg: Fix CurrentVersion registry string for Windows 10 and up. ntdll: Default to Windows 10. ntdll: Add Windows 11 version. https://gitlab.winehq.org/wine/wine/-/merge_requests/2077

2 4

[PATCH 0/7] MR2078: Fixes for debugging in new wow64 setup.
by eric pouech (＠epo) 01 Feb '23

01 Feb '23

This series brings some improvements for debugging support in the new wow64 environment: - detects and adapt to the new environement - fixes a couple of bugs appearing now - adds a couple of tests - extends winedbg to hide or display the modules when multiple machines are used in the same process -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2078

4 13

[PATCH 0/1] MR2082: opengl32/tests: Skip the wglCopyContext test on Nvidia on Windows.
by Alex Henrie (＠alexhenrie) 01 Feb '23

01 Feb '23

Fixes a testbot crash. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2082

3 3

Re: [PATCH v2 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Nikolay Sivov (＠nsivov) 01 Feb '23

01 Feb '23

Please take a look, I added both mul+add and dp2add paths. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22571

1 0

[PATCH v6 0/2] MR2045: d3d12core: Add stub DLL.
by Mohamad Al-Jaf (＠maljaf) 01 Feb '23

01 Feb '23

Forspoken checks for the existence of this DLL. -- v6: d3d12core: Add stub DLL. include/d3d12: Add DirectX 12 Agility SDK definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/2045

2 3

[PATCH 0/1] MR2081: Support relocatable fontconfig cache
by catsout (＠catsout) 01 Feb '23

01 Feb '23

For flatpak: ``` bind mount: /run/host/fonts <- /usr/share/fonts /run/host/user-fonts <- ~/.local/share/fonts /run/host/fonts-cache <- /usr/lib/fontconfig/cache /run/host/user-fonts-cache <- ~/.cache/fontconfig ``` For fontconfig: https://bugs.freedesktop.org/show_bug.cgi?id=101889 https://github.com/flatpak/flatpak/issues/589 It supports relocatable cache. ``` FcConfigGetFontDirs( config ) -> /run/host/user-fonts/test,... FcPatternGetString( pattern, FC_FILE, 0, &filename ) -> ~/.local/share/fonts/test/test.ttf ``` For wine: ``` FcPatternGetString -> unix_name -> add_unix_face( unix_name, ... ) ``` The valid file path for flatpak is `/run/host/user-fonts/test/test.ttf`. `~/.local/share/fonts/test/test.ttf` does not exist in flatpak sandbox. Add a check for this, and switch to right path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2081

2 1

2025

2024

2023

2022

wine-gitlab