- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > > if (riff.type == DMUS_FOURCC_SEGMENT_FORM) > hr = parse_segment_form(This, stream, &riff); > - else { > - FIXME("WAVE form loading not implemented\n"); > - hr = S_OK; > - } > + else Please check that the RIFF has the proper type and add an else for the error case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22346

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > return CONTAINING_RECORD(iface, IDirectMusicSegment8Impl, dmobj.IPersistStream_iface); > } > > +static HRESULT parse_wave_form(IDirectMusicSegment8Impl *This, IStream *stream, const struct chunk_entry *riff) > +{ > + HRESULT hr; > + struct chunk_entry chunk = {.parent = riff}; > + > + TRACE("Parsing segment wave in %p: %s\n", stream, debugstr_chunk(riff)); > + > + while ((hr = stream_next_chunk(stream, &chunk)) == S_OK) { > + switch (chunk.id) { > + case mmioFOURCC('f','m','t',' '): { > + if (FAILED(hr = stream_chunk_get_data(stream, &chunk, &This->wave_format, chunk.size))) Don't use the chunk.size there; use the sizeof the destination object, here sizeof(This->wave_format) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22347

1 0

[PATCH v5 0/3] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 30 Jan '23

30 Jan '23

-- v5: tests: Test entry point semantics on function declarations. tests: Add more tests for early return from the entry point. tests: Add some tests for early return from user-defined functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

2 3

[PATCH 0/1] MR2068: Draft: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 30 Jan '23

30 Jan '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 2

[PATCH 0/1] MR2067: wine32u: fix off-by-one bugs in MsgWaitForMultipleObjectsEx drivers
by Ivan Chikish (＠nekotekina) 30 Jan '23

30 Jan '23

When count = 0, returned value may become -1 which seems wrong in the case of successful process_events() call. Also MSDN suggests that `count` may be a valid return value in this case. When -1 is returned, it may cause SetLastError to -1 as well which is not a valid error code AFAIK. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54405 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2067

4 7

[PATCH v5 0/2] MR2051: include/msvcrt: Add noreturn attribute to _assert.
by Jinoh Kang (＠iamahuman) 30 Jan '23

30 Jan '23

This informs the compiler that no code will ever run after an assertion failure (unless NDEBUG is defined), which increases accuracy of compiler warnings and static analyses. -- v5: include/msvcrt: Add noreturn attribute to _assert. include: Add noreturn attribute to RtlRaiseStatus. https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

3 4

[PATCH 0/1] MR2066: gdi32/tests: Mark another D3DKMTCheckOcclusion() test as flaky.
by Hans Leidekker (＠hans) 30 Jan '23

30 Jan '23

It shows the same behavior as the one marked by commit 2d19baa6b576. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51313 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2066

3 2

[PATCH 0/2] MR2065: ws2_32/tests: Fix some test failures on Windows 11.
by Hans Leidekker (＠hans) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2065

2 2

[PATCH 0/7] MR2064: Implement kernelbase.EnumProcessModulesEx
by eric pouech (＠epo) 30 Jan '23

30 Jan '23

This series implements kernelbase.EnumProcessModulesEx(). This series: - implements EnumProcessModulesEx() - ensure it passes a bunch of new tests - fix GetModuleBaseName, GetModuleFileNameEx, GetModuleInformation() to cope with HMODULES returned from EnumProcessModulesEx(). Notes: as EnumProcessModules() doesn't return the same list as Windows on a Wow64 setup, and that there's no use of EnumProcessModulesEx() in Wine code, this first series will implement EnumProcessModulesEx() and if accepted, it will be followed by a second serie which, firstly, adapt all places in Wine code with bad expectations on EnumProcessModules(), and secondly reimlement EnumProcessModules() using EnumProcessModulesEx(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2064

2 7

[PATCH v2 0/1] MR2063: dinput/tests: Dynamically allocate async operation handlers.
by Rémi Bernon (＠rbernon) 30 Jan '23

30 Jan '23

Instead of passing them from the stack. The async operation is executed in a thread pool, which might Release its reference asynchronously and call a stale function pointer if it is sequenced after the stack invalidation. -- v2: dinput/tests: Dynamically allocate async operation handlers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2063

2 1

[PATCH v2 0/2] MR2055: win32u: Make more definitions hidden.
by Zebediah Figura (＠zfigura) 30 Jan '23

30 Jan '23

-- v2: win32u: Make set_visible_region() hidden. win32u: Make send_message_timeout() hidden. https://gitlab.winehq.org/wine/wine/-/merge_requests/2055

3 3

[PATCH 0/1] MR2059: combase: Generate apartment OXID in rpcss
by Aaron Hill (＠Aaron1011) 30 Jan '23

30 Jan '23

Currently, apartment OXIDs are generated using the process ID (and the thread ID for a single threaded-apartment). This means that if an apartment is destroyed and re-created (using `CoUninitialize` followed by `CoInitializeEx`), the newly created apartment will end up with the same OXID as the old apartment. However, testing shows that Windows will generate a *new* OXID when an apartment is created in the above manner. This patch uses `rpcss` to generate a new OXID. The current process id is combined with an incrementing counter stored in rpcss. This ensures that re-creating an apartment will not re-use an OXID. Additionally, this fixes an issue that caused the .NET 4.8 installer to become stuck during the downloading stage under Wine. The installer appears to perform the following actions: 1. Call `IBackgroundCopyJob_SetNotify` interface on a BITS job. This causes us to create a proxy (in the other process hosting 'qmgr') for the `IBackgroundCopyCallback` pointer passed as a parameter. 2. Trigger MTA apartment re-creation (in the process running the setup, *not* the process with the `IBackgroundCopyCallback` proxy) through `CoUninitialize` followed by `CoInitializeEx`. 3. Call `IBackgroundCopyJob_SetNotify` on a newly created job, but with the same `IBackgroundCopyCallback` pointer parameter. When we deserialize the pointer passed to `IBackgroundCopyJob_SetNotify`, we will end up re-using the same `proxy_manager` that we created for the previous `IBackgroundCopyCallback`. This is due to the fact that the OIDs happen to match (due to the fact that the .NET 4.8 setup appears to perform actions in the same order between the old and new apartments), and the apartment OXIDs match as explained above. above. As a result, we will use the old IPID when we send RPC packets using this `proxy_manager`. However, the new and old IPIDs will *never* match, since their generation process includes `RtlGenRandom`. This will cause a fault packet to be generated on the listening side of the RPC connection. By avoiding re-using OXIDs across re-created apartments, we ensure that the proxy side will never incorrectly re-use a stale `proxy_manager`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059

3 4

[PATCH 0/2] MR76: vkd3d-shader/hlsl: Support rsqrt() and distance() intrinsics.
by Nikolay Sivov (＠nsivov) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/76

3 7

[PATCH 0/1] MR2057: winepulse: Make mult_alaw_sample() and mult_ulaw_sample() hidden.
by Zebediah Figura (＠zfigura) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2057

3 2

[PATCH 0/5] MR2061: dinput: Move hook update to the input thread.
by Rémi Bernon (＠rbernon) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2061

2 5

[PATCH v3 0/1] MR2045: d3d12core: Add stub DLL.
by Mohamad Al-Jaf (＠maljaf) 30 Jan '23

30 Jan '23

Forspoken checks for the existence of this DLL. -- v3: d3d12core: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2045

3 12

[PATCH 0/1] MR2060: po: Update Tamil translation
by K.B.Dharun Krishna (＠kbdharun) 30 Jan '23

30 Jan '23

I updated Tamil translation. Over the next couple of weeks, I will send PRs to complete the translation fully. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2060

2 1

[PATCH v6 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Jan '23

30 Jan '23

according to MSDN they are implemented in the same way as a fast mutex. -- v6: ntoskrnl.exe: Implement KeReleaseGuardedMutex. https://gitlab.winehq.org/wine/wine/-/merge_requests/2044

3 3

[PATCH 0/2] MR2058: winex11: Make some definitions hidden.
by Zebediah Figura (＠zfigura) 29 Jan '23

29 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2058

2 2

[PATCH 0/3] MR2055: win32u: Make more definitions hidden.
by Zebediah Figura (＠zfigura) 29 Jan '23

29 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2055

4 5

[PATCH 0/5] MR2056: ntdll: Make some definitions static or hidden.
by Zebediah Figura (＠zfigura) 29 Jan '23

29 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2056

2 5

Re: [PATCH 0/1] MR112: Draft: Revert "dbghelp: Don't bother trying to initialize loader backend if we can't... - closed
by Jinoh Kang (＠iamahuman) 29 Jan '23

29 Jan '23

This merge request was closed by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/112

1 0

[PATCH v5 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 29 Jan '23

29 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v5: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

[PATCH v4 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 29 Jan '23

29 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v4: ntdll: Fix integer overflow in RtlUniform. ntdll/tests: Update test_RtlUniform to match Windows Vista or later. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 3

[PATCH 0/1] MR2050: include: Remove __WINE_MALLOC from functions that shouldn't have it.
by Alex Henrie (＠alexhenrie) 29 Jan '23

29 Jan '23

According to the GCC documentation,[1] `__attribute__((malloc))` may not be used on functions that return memory that contains one or more valid pointers. [1] https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2050

3 4

2025

2024

2023

2022

wine-gitlab