- wine-gitlab - winehq.org

[PATCH v2 0/5] MR47: hlsl: Function calls.
by Zebediah Figura (＠zfigura) 10 Jan '23

10 Jan '23

-- v2: vkd3d-shader/hlsl: Get rid of the "intrinsic" field of struct hlsl_ir_function. vkd3d-shader/hlsl: Forbid returning void expressions from void functions. vkd3d-shader/hlsl: Generate IR for user-defined function calls. vkd3d-shader/hlsl: Avoid assuming that expressions have at least one argument. tests: Test specifying a UAV address as an in/out parameter to a function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/47

3 9

[PATCH v5 0/3] MR1918: Draft: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments
by Santino Mazza (＠tati1454) 10 Jan '23

10 Jan '23

This functions should also work with document fragments, in wine they only return NULL. -- v5: mshtml: Implement HTMLDocument_get_body for document fragments. mshtml: Implement get_all for document fragments. mshtml/tests: Test for get_all and get_body in document fragments. https://gitlab.winehq.org/wine/wine/-/merge_requests/1918

3 4

[PATCH 0/1] MR1931: ntdll: Conform to Windows 11 behavior in RtlIpv6StringToAddress().
by Hans Leidekker (＠hans) 10 Jan '23

10 Jan '23

Also fixes test failures on Windows 11. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54045 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1931

3 2

[PATCH v8 0/1] MR1892: ntoskrnl.exe/tests: Add Driver Object Extension Tests.
by Etaash Mathamsetty (＠etaash.mathamsetty) 10 Jan '23

10 Jan '23

-- v8: ntoskrnl.exe/tests: Add Driver Object Extension Tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1892

2 1

[PATCH 0/1] MR56: vkd3d-shader/hlsl: Fix typo (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Jan '23

10 Jan '23

I assume this is a typo, right now it doesn't make sense. Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/56

6 7

[PATCH v4 0/6] MR53: vkd3d-shader/hlsl: transpose(), smoothstep(), and properly convert args of element-wise intrinsics.
by Francisco Casas (＠fcasas) 10 Jan '23

10 Jan '23

This patch series includes an implementation of the long-pending `transpose` intrinsic and the `smoothstep` intrinsic. While implementing `smoothstep` I realized that some intrinsics have different rules for the allowed data types than expressions: - Vectors and matrices at the same time are not allowed, regardless of their dimensions. Even if they have the same number of components. - Any combination of matrices is always allowed, even those when no matrix fits inside another, e.g.: `float2x3` is compatible with `float3x2`, resulting in `float2x2`. The common data type is the min on each dimension. This is the case for `max`, `pow`, `ldexp`, `clamp` and `smoothstep`; which suggest that it is the case for all intrinsics where the operation is applied element-wise. So this was corrected. A minor fix in `pow`'s type conversion is also included. -- v4: vkd3d-shader/hlsl: Use add_unary_arithmetic_expr() in intrinsic_pow(). vkd3d-shader/hlsl: Introduce elementwise_intrinsic_float_convert_args(). vkd3d-shader/hlsl: Convert elementwise intrinsics args to the proper common type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/53

4 8

[PATCH v3 0/9] MR50: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h. (v2) (PART 1/2)
by Francisco Casas (＠fcasas) 10 Jan '23

10 Jan '23

First part of v2 of !38, trying to follow the wide feedback provided. Following patches in: https://gitlab.winehq.org/fcasas/vkd3d/-/tree/documentation -- v3: vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_src. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ir_node. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ctx. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ir_var. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_struct_field. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_type. vkd3d-shader/hlsl: Rename hlsl_struct_field.modifiers to "storage_modifiers". vkd3d-shader/hlsl: Rename hlsl_ir_var.modifiers to "storage_modifiers". vkd3d-shader/hlsl: Rename HLSL_STORAGE_VOLATILE to HLSL_MODIFIER_VOLATILE. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/50

4 11

[PATCH 0/1] MR1906: wined3d: Clamp the bound buffer range to the buffer size.
by Stefan Dösinger (＠stefan) 10 Jan '23

10 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53671 --- Unless the application sets something, we use WINED3D_MAX_CONSTANT_BUFFER_SIZE * sizeof(vec4). https://registry.khronos.org/OpenGL-Refpages/gl4/html/glBindBufferRange.xht… says it is an error to set offset + size larger than the buffer size. I don't know why other drivers aren't rejecting our call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1906

4 3

[PATCH 0/1] MR1928: dwmapi: Fill qpcVBlank in DwmGetCompositionTimingInfo().
by Paul Gofman (＠gofman) 09 Jan '23

09 Jan '23

Since commit 182feddd4b02e83f3c69863bc2e6e63945eb2df1 DwmGetCompositionTimingInfo() returns success. Currently wine-gecko fails to display anything if prefix version is Win10. That is due to zero qpcVBlank field in DwmGetCompositionTimingInfo() output which is currently missing. Before the referenced commit it was handling the failure (see gfx/thebes/gfxWindowsPlatform.cpp:VBlankLoop() (line 2840 in the current wine-gecko snapshot from https://sourceforge.net/p/wine/wine-gecko/ci/master/tree/). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1928

2 1

Re: [PATCH v2 0/1] MR1926: winex11.drv: Obtain icon info for icons passed to fetch_icon_data(). - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1926

1 0

Re: [PATCH v5 0/4] MR1886: Fixing paste errors on edit control in Win10+. - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1886

1 0

Re: [PATCH v2 0/1] MR1922: win32u: Initialize the tracking_info for NtUserDrawScrollBar params. - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1922

1 0

Re: [PATCH v2 0/1] MR1920: iphlpapi: Handle errors from DnsQueryConfig(DnsConfigDnsServerList). - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1920

1 0

Re: [PATCH v2 0/1] MR1905: win32u: Introduce a get_display_depth() helper to retrieve emulated display depth. - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1905

1 0

Re: [PATCH v2 0/1] MR1923: faudio: Purge and clear notifcations on ShutDown - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1923

1 0

[PATCH v11 0/8] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 09 Jan '23

09 Jan '23

-- v11: windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech: Add a worker thread to the recognition session. windows.media.speech/tests: Test starting, stopping, pausing and resuming the recognition session. windows.media.speech/tests: Test the recognizer state. windows.media.speech: Return IAsyncAction from session_PauseAsync. windows.media.speech: Return IAsyncAction from session_StopAsync. windows.media.speech: Do not force calling convention on internal callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

4 22

[PATCH v11 0/7] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 09 Jan '23

09 Jan '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v11: fixup: address edit | limited known folder support comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

4 13

[PATCH v4 0/3] MR1918: Draft: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments
by Santino Mazza (＠tati1454) 09 Jan '23

09 Jan '23

This functions should also work with document fragments, in wine they only return NULL. -- v4: mshtml: Implement HTMLDocument_get_body for document fragments. https://gitlab.winehq.org/wine/wine/-/merge_requests/1918

5 13

[PATCH v2 0/2] MR1924: ntoskrnl.exe/tests: Add KeInitializeDpc tests.
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Jan '23

09 Jan '23

-- v2: ntoskrnl.exe/tests: Add KeInitializeDpc tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1924

2 2

[PATCH 0/1] MR1926: winex11.drv: Obtain icon info for icons passed to fetch_icon_data().
by Gabriel Ivăncescu (＠insn) 09 Jan '23

09 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1926

2 1

[PATCH v2 0/2] MR1917: [PATCH] shell32/tests: Workaround moving cursor to (0,0) coordinates.
by Gabriel Ivăncescu (＠insn) 09 Jan '23

09 Jan '23

-- v2: shell32/tests: Increase sleep time for autocomplete tests if necessary. shell32/tests: Workaround moving cursor to (0,0) coordinates. https://gitlab.winehq.org/wine/wine/-/merge_requests/1917

3 5

[PATCH 0/1] MR1922: win32u: Initialize the tracking_info for NtUserDrawScrollBar params.
by Gabriel Ivăncescu (＠insn) 09 Jan '23

09 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1922

3 2

[PATCH v4 0/4] MR1886: Fixing paste errors on edit control in Win10+.
by eric pouech (＠epo) 09 Jan '23

09 Jan '23

This series tries to fix WM_PASTE tests error on edit control (both user32 & comctl32). The test failures where systematic on a local Win10 for comctl32 (yet very rare on user32, perhaps one in 20 runs). Since the failures are not systematic, it ought to be a synchronisation / timing issue. Flushing the msg queue before starting the paste test cycle seems to fix the issue. - 0 occurence on comctl32 and user32 in 50 run (local VM) - 0 occurence on Testbot (comctl32) in 1 run. It's hard to be fully conclusive about bug resolution, but it's at least a step into the right direction. -- v4: comctl32/tests: Fix failing WM_PASTE tests for edit control on Win10+. comctl32/tests: Retry when opening the clipboard. user32/tests: Fix failing WM_PASTE tests for edit control on Win10+. user32/tests: Retry when opening the clipboard. https://gitlab.winehq.org/wine/wine/-/merge_requests/1886

3 5

[PATCH v3 0/3] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) 09 Jan '23

09 Jan '23

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- v3: vkd3d-shader/hlsl: Validate that referenced objects are uniform. tests: Test uninitialized object references. vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

3 6

[PATCH 0/1] MR1920: iphlpapi: Handle errors from DnsQueryConfig(DnsConfigDnsServerList).
by Hans Leidekker (＠hans) 09 Jan '23

09 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52557 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1920

3 2

2025

2024

2023

2022

wine-gitlab