- wine-gitlab - winehq.org

[PATCH 0/3] MR1876: d3d9/tests: Fix a few more test failures on Gitlab CI.
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1876

4 6

[PATCH 0/4] MR1877: user32: Clipboard overflow and underflow fixes
by Francois Gouget (＠fgouget) 22 Dec '22

22 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1877

2 5

[PATCH 0/2] MR1874: win32u: Honor CS_HREDRAW and CS_VREDRAW when resizing window. (#52903)
by Jinoh Kang (＠iamahuman) 21 Dec '22

21 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52903 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1874

3 3

[PATCH v3 0/1] MR1166: ntdll: don't claim to have not found a library that is in place
by Konstantin Kharlamov (＠Hi-Angel) 21 Dec '22

21 Dec '22

When `import_dll` function gets `STATUS_DLL_NOT_FOUND` from `load_dll()`, it has no way of distinguishing whether it's a dependency for the dll wasn't found, or the dll itself is missing. That results in confusing ERR messages, where a dll is found, but wine claims it isn't. Fix this by moving the print to the actual place that is aware of whether it's the parent or the child dll haven't been found. Log before: 0024:err:module:import_dll Library lib2.dll (which is needed by L"Z:\\tmp\\lib1.dll") not found 0024:err:module:import_dll Library lib1.dll (which is needed by L"Z:\\tmp\\a.exe") not found Log after: 0024:err:module:load_dll Library L"lib2.dll" (which is needed by L"Z:\\tmp\\foo\\lib1.dll") not found 0024:err:module:import_dll Loading library lib2.dll (which is needed by L"Z:\\tmp\\foo\\lib1.dll") failed (error c0000135). 0024:err:module:import_dll Loading library lib1.dll (which is needed by L"Z:\\tmp\\foo\\a.exe") failed (error c0000135). -------- While it's just about prints, but it costed me hours of wandering *(because if I know where to find the dependency dll, but I see that the main dll is also "not found" despite being "right there", I have to research the latter problem that looks more complicated. But given enough resources applied, it then turns out to be a faux)*. As a fun fact, I am apparently not the only one to have stumbled upon. Here's a screenshot of a `#english` chat where I asked about a commit title correctness. It's the last place where you'd expect to find someone familiar with WINE, and yet here's a person that had to deal with that exact error as well: ![Screenshot_20221026_023411](/uploads/55552d7c335ef5ce0b507f61adacbb00/Screenshot_20221026_023411.png) So, I think it's kinda serious problem. -- v3: ntdll: don't claim to have not found a library that is in place https://gitlab.winehq.org/wine/wine/-/merge_requests/1166

2 3

[PATCH 0/1] MR1879: ntdll/tests: Avoid testing the server pipe signaled state from the main thread.
by Zebediah Figura (＠zfigura) 21 Dec '22

21 Dec '22

Although the test has never been observed to fail on Windows, I think the failure is genuinely a race in the test. File handles (like events) are signaled in order to mark that an I/O operation has completed. In this case the I/O operation includes manipulating data on both ends of the pipe, and as part of that may signal the other end. Internally, however, the file handle must logically happen *after* all of this processing has taken place, not least because (given the Windows I/O architecture) it is the job of the I/O manager, not the IRP handler. Since the purpose of the test is probably just to check that the file handle will be signaled after a synchronous I/O operation has completed, we may as well check it from the client thread, after we know for sure that it has. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54078 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1879

2 2

[PATCH v2 0/1] MR1853: mf: Request more samples for MFT when needed.
by Shaun Ren (＠shaunren) 21 Dec '22

21 Dec '22

When an upstream node has not given enough samples to the transform, we need to request more samples from it to avoid stalling the pipeline. This fixes an issue where the intro audio of the game Airborne Kingdom stops playing after a few seconds. -- v2: mf: Request more samples for transforms when needed. https://gitlab.winehq.org/wine/wine/-/merge_requests/1853

2 1

Re: [PATCH v3 0/2] MR1828: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1828

1 0

Re: [PATCH v2 0/1] MR1868: Revert "qasf: Register ASF Reader filter media type." - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1868

1 0

Re: [PATCH v2 0/1] MR1872: wined3d: Do not explicitly check 3D depth/stencil capabilities in wined3d_check_device_format(). - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1872

1 0

Re: [PATCH v2 0/1] MR1873: kernel32/tests: Skip some console tests on w1064v1909. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1873

1 0

Re: [PATCH v2 0/2] MR1850: d3d9: Upload the relevant texture in d3d9_texture_gen_auto_mipmap(). - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1850

1 0

Re: [PATCH v2 0/1] MR1847: ddraw/tests: Release ddraw after device in test_texture_wrong_caps(). - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1847

1 0

Re: [PATCH v2 0/1] MR1871: shell32: Always set last error in Shell_NotifyIconW. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1871

1 0

Re: [PATCH v2 0/1] MR1870: urlmon/tests: Use gitlab.winehq.org host in can_do_https. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1870

1 0

Re: [PATCH v2 0/3] MR1869: dinput/tests: Add more force feedback envelope and duration tests. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1869

1 0

Re: [PATCH v3 0/2] MR1832: mfmediaengine: Pause the session in media_engine_Pause. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1832

1 0

Re: [PATCH v2 0/1] MR1866: mfplat/tests: Add MEDIASUBTYPE_RGB* and NV11 image size tests. - approved
by Alexandre Julliard (＠julliard) 21 Dec '22

21 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1866

1 0

[PATCH 0/1] MR1878: comctl32/listview: Draw border and background separately in WM_NCPAINT.
by Vladislav Timonin (＠vt) 21 Dec '22

21 Dec '22

Depending on the theme, if there was a header, the border ends up painted lower than it should be, and clipped by the header. 7-Zip file manager, the reason why the offset was added in 5f0dcf79185941c4faff35d1cc9c758160f3a27d in the first place, still renders correctly. Before: ![before](/uploads/8321f45c657469278b2787edfa147b20/before.png) After: ![after](/uploads/013241f4cd3b893c7f4073b6a9fe8119/after.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

2 1

[PATCH v2 0/2] MR1828: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB.
by Rémi Bernon (＠rbernon) 21 Dec '22

21 Dec '22

The check was dropped in e392e0ac2846edc25610723c19d6a796372017e1, leaving the dwFlags variable unused. I have no idea if it was indeed unnecessary or if it was dropped by mistake but either we need to keep the check, or we should remove the variable. -- v2: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB. opengl32/tests: Test wglChoosePixelFormatARB flags filters. https://gitlab.winehq.org/wine/wine/-/merge_requests/1828

3 3

[PATCH 0/1] MR1868: Revert "qasf: Register ASF Reader filter media type."
by Rémi Bernon (＠rbernon) 21 Dec '22

21 Dec '22

This reverts commit 4608e1e1257a377cd554a0e885368e3feb7d286f. The ASF Reader filter suffers from defects which are difficult to solve, and will require a better implementation of wmvcore in order to work correctly. In the meantime, revert the class registration so that the File Source filter is preferred instead. This will break games that tried to use the filter directly and which may have started to work correctly, but they are less frequent than the ones simply playing wmv videos with quartz. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53640 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53748 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54191 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1868

3 2

[PATCH 0/1] MR1872: wined3d: Do not explicitly check 3D depth/stencil capabilities in wined3d_check_device_format().
by Sven Baars (＠sbaars) 21 Dec '22

21 Dec '22

This reapplies the change from 67d0038e49323523b745c4a728069d8195273d23 that was reverted in 06b19322187e5ef8ffc06504c322ce9bcdaaa6ee, causing a regression. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53785 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1872

3 2

[PATCH 0/1] MR1873: kernel32/tests: Skip some console tests on w1064v1909.
by eric pouech (＠epo) 21 Dec '22

21 Dec '22

We get conhost.exe:tty failures on testbot: - not for version prior to w1064v1909 (these tests require pseudo-consoles, which are not implemented in these Windows version). - for w1064v1909 - not for W10 versions after w1064v1909. So, we assume that pseudo-console support is immature in this Windows version: skip all the remaining test at the first discrepancy point. I could have maintained a couple of unit tests for this Windows version, but decided not to: - it would make the code more complicated (*), - it doesn't bring value to Wine - it would be a pain to maintain. This patch fixes the (remaining) W10 part of bug below. Support for W11 will be handled in separate patch (and likely with properly integrating the results from W11, contrary to this patch). Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53465 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1873

2 1

[PATCH 0/2] MR1850: d3d9: Upload the relevant texture in d3d9_texture_gen_auto_mipmap().
by Zebediah Figura (＠zfigura) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1850

3 3

[PATCH 0/1] MR1847: ddraw/tests: Release ddraw after device in test_texture_wrong_caps().
by Paul Gofman (＠gofman) 21 Dec '22

21 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54049 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1847

4 3

[PATCH 0/1] MR1871: shell32: Always set last error in Shell_NotifyIconW.
by Jacek Caban (＠jacek) 21 Dec '22

21 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1871

2 1

2025

2024

2023

2022

wine-gitlab