- wine-gitlab - winehq.org

[PATCH 0/2] MR1858: win32u: Convert inter-process messages to Unicode.
by Jacek Caban (＠jacek) 20 Dec '22

20 Dec '22

It got lost in win32u conversion. In most cases, we may perform the conversion in user32, but trying to do that in inter-process would be weird. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1858

3 3

[PATCH v2 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- v2: winhttp: Only read server reply in send_request() if the whole request is available. https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

3 5

[PATCH 0/3] MR1854: httpapi: Allow passing NULL size to request reading functions.
by Zebediah Figura (＠zfigura) 20 Dec '22

20 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1854

2 3

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

Yes, this now builds -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769#note_19905

1 0

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769

1 0

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

On Tue Dec 20 02:41:21 2022 +0000, Alexandre Julliard wrote: > This should be superseded by f69c11117ee56cb664bd0ade1392c5553ff2af30. Yes, after that commit this now builds fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769#note_19904

1 0

Re: [PATCH v4 0/66] MR1849: winebus.sys: Declare a variable only when used - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

1 0

Re: [PATCH v2 0/0] MR1849: winebus.sys: Declare a variable only when used - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

1 0

[PATCH 0/1] MR1849: winebus.sys: Declare a variable only when used
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

udev_add_device declares a variable (product) even when it is not used on all platforms. Use the same condition for the declaration that already guards the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

2 4

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Zhiyi Zhang (＠zhiyi) 20 Dec '22

20 Dec '22

Zhiyi Zhang (@zhiyi) commented about include/pathcch.h: > HRESULT WINAPI PathCchStripPrefix(WCHAR *path, SIZE_T size); > HRESULT WINAPI PathCchStripToRoot(WCHAR *path, SIZE_T size); > BOOL WINAPI PathIsUNCEx(const WCHAR *path, const WCHAR **server); > + > +#ifdef __cplusplus > +} > +#endif Please add a new line here -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_19897

1 0

[PATCH 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

2 2

[PATCH 0/1] MR1848: wmc: Avoid uninitialized variable in init_argv0_dir
by Gerald Pfeifer (＠gerald) 19 Dec '22

19 Dec '22

init_argv0_dir has conditional code for different operating systems. In case of FreeBSD a variable remains uninitialized in the error case, yet is then used. Fix that by handling the error case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1848

2 1

Re: [PATCH v2 0/1] MR1845: winhttp: Check for NULL lpszAutoConfigUrl in WinHttpGetProxyForUrl(). - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1845

1 0

Re: [PATCH v3 0/3] MR1824: Remove broken from some color tests that can also fail on Linux. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

1 0

Re: [PATCH v3 0/5] MR1843: user32: Add more EnableMouseInPointer / GetPointerType / GetPointerInfo tests. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1843

1 0

Re: [PATCH v5 0/7] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

1 0

Re: [PATCH v2 0/1] MR1840: ntdll: Only compile get_current_teb() on linux. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1840

1 0

Re: [PATCH v2 0/1] MR1837: wined3d: Recognize AMD as a vendor string - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1837

1 0

Re: [PATCH v2 0/3] MR1836: DMusic: Implement the IDirectMusicSegment8_Clone() and semi-stub the IDirectMusicChordMap_ComposeSegmentFromTemplate() methods. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1836

1 0

Re: [PATCH v2 0/1] MR1835: po: Update Japanese translation. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1835

1 0

Re: [PATCH v2 0/1] MR1833: libs/wine: Only define exe_link when needed - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1833

1 0

Re: [PATCH v2 0/1] MR1831: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1831

1 0

[PATCH 0/1] MR1845: winhttp: Check for NULL lpszAutoConfigUrl in WinHttpGetProxyForUrl().
by Paul Gofman (＠gofman) 19 Dec '22

19 Dec '22

Fixes a regression introduced by cbfe940a1eaf5e158de3127b1265462bfbfb70af. Might be related to https://bugs.winehq.org/show_bug.cgi?id=54055, I don't yet have the confirmation but this is something probably worth fixing regardless. lpszAutoConfigUrl is used whenever WINHTTP_AUTOPROXY_CONFIG_URL is specified, regardless of WINHTTP_AUTOPROXY_AUTO_DETECT presence. Before cbfe940a1eaf5e158de3127b1265462bfbfb70af NULL lpszAutoConfigUrl went directly to GetAddrInfoW(). Now with the timeout it is relayed to aync name resolution thread and might be crashing in wcsdup(). It doesn't happen all the time as we might not be reaching download_script() at all due to prior WinHttpDetectAutoProxyConfigUrl() legitimate failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1845

3 2

[PATCH v2 0/3] MR1824: Remove broken from some color tests that can also fail on Linux.
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

They fail on the Gitlab CI. An alternative would be to mark them todo_wine but it's not clear that there's anything we want to do here. -- v2: d3d9/tests: Mark some of the depth bias tests as todo. d3d9/tests: Mark a zero-size pixel test as todo. d3d8/tests: Mark a zero-size pixel test as todo. https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

3 4

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

Please use your full name in the git commit info, so that it matches your Gitlab account. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_19862

1 0

2025

2024

2023

2022

wine-gitlab