- wine-gitlab - winehq.org

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 18 Dec '22

18 Dec '22

On Sun Dec 18 23:01:30 2022 +0000, Zebediah Figura wrote: > Hi Thomas, thanks for the patch! > We want the tests to "pass" after every commit, i.e. have no failures. > That may mean, in this case, introducing the tests marked as todo, and > then later removing those todos. Ok. Got it. Will do it soon -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19804

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Hi Thomas, thanks for the patch! We want the tests to "pass" after every commit, i.e. have no failures. That may mean, in this case, introducing the tests marked as todo, and then later removing those todos. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19803

1 0

[PATCH 0/4] MR1755: refcount return voiding
by Max Figura (＠maxfigura) 18 Dec '22

18 Dec '22

Setting the return type of various wined3d refcounting functions to void These patches modify: - wined3d_incref - wined3d_decref - wined3d_resource_incref - wined3d_resource_decref -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1755

4 9

[PATCH 0/3] MR1836: DMusic: Implement the IDirectMusicSegment8_Clone() and semi-stub the IDirectMusicChordMap_ComposeSegmentFromTemplate() methods.
by Michael Stefaniuc (＠mstefani) 18 Dec '22

18 Dec '22

Fixes https://bugs.winehq.org/show_bug.cgi?id=53941 Should be a fairly safe change as both methods were returning S_OK without touching the return pointer. Also Chicken Tournament is the first application in my collection that uses those methods. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1836

2 3

[PATCH 0/1] MR1835: po: Update Japanese translation.
by Akihiro Sagawa (＠sgwaki) 18 Dec '22

18 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1835

2 1

[PATCH 0/1] MR1834: include: Add recent DirectWrite API changes.
by Nikolay Sivov (＠nsivov) 17 Dec '22

17 Dec '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1834

2 1

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Sat Dec 17 10:41:32 2022 +0000, Etaash Mathamsetty wrote: > I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da > (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add > tests) into one commit I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19792

1 0

[PATCH 0/1] MR1833: libs/wine: Only define exe_link when needed
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

Revision 24b26f8bd6a49c855eec417a6585d44c9458e3ec changed FreeBSD (and DragonFly) not to use /proc any longer. Hence we also do not need the exe_link variable on those two platforms, either. Avoid declaring it there. (This avoids a compiler warning about an unused variable with GCC 12.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1833

2 1

[PATCH 0/1] MR1831: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

find_device_from_devnode was unnecessarily guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. Simply make find_device_from_devnode generally available. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1831

3 2

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Thu Dec 15 20:00:54 2022 +0000, Etaash Mathamsetty wrote: > you should mark them as todo in the code for the tests then I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19782

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Dec '22

17 Dec '22

I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add tests) into one commit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19781

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Alex Henrie (＠alexhenrie) 17 Dec '22

17 Dec '22

On Sat Dec 17 00:00:58 2022 +0000, Gerald Pfeifer wrote: > Any chance you can cherry pick > https://gitlab.winehq.org/wine/wine/-/commit/6ddda5b130481c89dae3750597452f… > ? > Git/Gitlab and me are not friends yet, and I already spent hours > (literally!) on this. :-( You've just got to learn how to use Git. One way to fix your branch: `git pull -ri https://gitlab.winehq.org/wine/wine.git master` Change all but the first commit to "squash", edit the commit message until it looks right, and then force-push. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810#note_19775

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

On Fri Dec 16 23:23:09 2022 +0000, Rémi Bernon wrote: > I don't have a strong opinion, although I tend to prefer having > variables declared in one place, especially for small functions like > this. In any case it's an unrelated and unnecessary change here. Any chance you can cherry pick https://gitlab.winehq.org/wine/wine/-/commit/6ddda5b130481c89dae3750597452f… ? Git/Gitlab and me are not friends yet, and I already spent hours (literally!) on this. :-( -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810#note_19774

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H - closed
by Gerald Pfeifer (＠gerald) 16 Dec '22

16 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810

1 0

[PATCH v3 0/1] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 16 Dec '22

16 Dec '22

find_device_from_devnode was guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. On the way reduce the scope of a variable (which makes sense per se and avoids introducing a compiler warning with this change). -- v3: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H https://gitlab.winehq.org/wine/wine/-/merge_requests/1810

3 4

Re: [PATCH 0/2] MR31: shell32: Only call HCR_GetFolderAttributes with simple pidls - closed
by Fabian Maurer (＠DarkShadow44) 16 Dec '22

16 Dec '22

This merge request was closed by Fabian Maurer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/31

1 0

Re: [PATCH 0/2] MR31: shell32: Only call HCR_GetFolderAttributes with simple pidls
by Fabian Maurer (＠DarkShadow44) 16 Dec '22

16 Dec '22

Obsolete now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/31#note_19768

1 0

Re: [PATCH v2 0/3] MR1830: Fixing some debugger tests when run on Windows. - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1830

1 0

Re: [PATCH v3 0/2] MR1829: user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode. - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1829

1 0

Re: [PATCH v2 0/3] MR1794: Improvements to ntdll.Rtl*ByteSwap(). - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1794

1 0

Re: [PATCH v3 0/3] MR1826: shell32: Add partial ControlPanel GetAttributesOf implementation. - approved
by Alexandre Julliard (＠julliard) 16 Dec '22

16 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1826

1 0

[PATCH v4 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) 16 Dec '22

16 Dec '22

-- v4: d3dx9: Partially implement D3DXFillCubeTextureTX(). d3dx9: Fix ARGB texture fills with negative component values. d3dx9/tests: Add a helper to compare filled cube textures. d3dx9: Partially implement D3DXFillTextureTX(). d3dx9: Create parameter evaluator for texture shaders. d3dx9/preshader: Set input table size for texture shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

2 6

[PATCH 0/1] MR1828: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB.
by Rémi Bernon (＠rbernon) 16 Dec '22

16 Dec '22

The check was dropped in e392e0ac2846edc25610723c19d6a796372017e1, leaving the dwFlags variable unused. I have no idea if it was indeed unnecessary or if it was dropped by mistake but either we need to keep the check, or we should remove the variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1828

3 3

[PATCH 0/3] MR1830: Fixing some debugger tests when run on Windows.
by eric pouech (＠epo) 16 Dec '22

16 Dec '22

Since test errors reported in MR!1823, I gave a spin at scheding some light on these errors. This series shall fix a couple of them, even there are still a couple standing (eg. https://testbot.winehq.org/JobDetails.pl?Key=127712). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1830

2 3

[PATCH v2 0/2] MR1829: user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode.
by Rémi Bernon (＠rbernon) 16 Dec '22

16 Dec '22

It looks like the behavior changes when only this test is run vs when it is run as part of the winetest suite. This is probably because ChangeDisplaySettingsExW only sends the message the first time it is called (since boot?). Having other tests run before it, one of them probably changed display settings already and we're not getting the message anymore. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53894 -- v2: user32/tests: Use %d to print last_bpp instead of %u. user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/1829

2 2

2025

2024

2023

2022

wine-gitlab