- wine-gitlab - winehq.org

[PATCH v2 0/5] MR1733: mshtml/jscript/vbscript: Implement SID_GetCaller and misc fixes.
by Gabriel Ivăncescu (＠insn) 09 Dec '22

09 Dec '22

-- v2: vbscript: Implement SID_GetCaller for QueryService. vbscript: Add a ServiceProvider stub. jscript: Implement SID_GetCaller for QueryService. mshtml: Set SCRIPTPROP_ABBREVIATE_GLOBALNAME_RESOLUTION properly. mshtml: Implement location props when there's no URI. https://gitlab.winehq.org/wine/wine/-/merge_requests/1733

2 5

[PATCH v5 0/2] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) 09 Dec '22

09 Dec '22

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index. -- v5: ntdll: TlsIndex should not actually contain tls indices winedbg: Don't expect TlsIndex to contain tls indices https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

3 4

[PATCH 0/5] MR1733: mshtml/jscript/vbscript: Implement SID_GetCaller and misc fixes.
by Gabriel Ivăncescu (＠insn) 09 Dec '22

09 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1733

4 9

[PATCH v3 0/10] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v3: ntdll: Tweak KeUserModeCallback to please Valgrind and GDB. ntdll: Introduce a new ntdll_dispatch_syscall helper. tools: Add suppressions from third party libraries. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

2 10

Re: [PATCH v2 0/8] MR1759: win32u: Move remaining focus.c functions from user32. - approved
by Huw Davies (＠huw) 09 Dec '22

09 Dec '22

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1759

1 0

[PATCH v2 0/1] MR1760: opengl32: Avoid calling functions that have not been queried yet.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

The glMapBuffer and al. functions are all duplicated between EXT/ARB and core functions, and we reduced code duplication by redirecting the EXT to the core functions. The internal function table is only filled as the functions are queried, and it causes crahes when games are using the EXT functions without querying the core function first. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53990 -- v2: opengl32: Avoid calling functions that have not been queried yet. https://gitlab.winehq.org/wine/wine/-/merge_requests/1760

2 2

[PATCH v3 0/10] MR1582: winhttp: Read server reply in send_request().
by Paul Gofman (＠gofman) 09 Dec '22

09 Dec '22

It turns out that WinHttpReceiveResponse() completes synchronously in async mode (unless recursive request for handling authorization or redirect is involved). Some apps depend on that and do not wait for WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE, calling WinHttpQueryHeaders() or WinHttpWebSocketCompleteUpgrade() right after calling WinHttpReceiveResponse, relying on that to finish synchronously. My initial out of tree testing shows that no network communication is performed during WinHttpReceiveResponse() call (when recursive request is not involved). I tested that by inserting a wait between WinHttpSendRequest and WinHttpReceiveResponse and disabling network connection during the wait. WinHttpReceiveResponse still succeeds on Windows. I think the above means that the actual response receiving from server is performed during WinHttpSendRequest. WinHttpReceiveResponse is not a complete no-op however. As shown by the existing tests the notifications related to receiving response are still delivered during WinHttpReceiveResponse (albeit in the same thread). Also WinHttpReceiveResponse affects request state: querying headers or upgrading to websocket without calling WinHttpReceiveResponse does not succeed. When redirect is involved, all the WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE, WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED and WINHTTP_CALLBACK_STATUS_REDIRECT notifications are delivered synchronously from the calling thread. Then, the new request send notifications and response receiving notifications are delivered from the new thread. An interesting case is when WinHttpReceiveResponse is called from SendRequest callbacks in async mode. If WinHttpReceiveResponse is called from WINHTTP_CALLBACK_STATUS_SENDING_REQUEST or WINHTTP_CALLBACK_STATUS_REQUEST_SENT (i. e., when request is not complete yet), calling WinHttpReceiveResponse() suddenly succeeds an shows the following message sequence (that is partially reflected in the tests I am adding): - calling WinHttpReceiveResponse from WINHTTP_CALLBACK_STATUS_SENDING_REQUEST (which is already called on the async thread on Win10, thread A). Win8 queues WINHTTP_CALLBACK_STATUS_SENDING_REQUEST synchronously and goes async a bit later. - WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE, thread A; - WinHttpReceiveResponse() returns to the caller WINHTTP_CALLBACK_STATUS_REQUEST_SENT callback; returning from user callback; - WINHTTP_CALLBACK_STATUS_REQUEST_SENT, thread A; - WINHTTP_CALLBACK_STATUS_SENDREQUEST_COMPLETE (another thread, although the sequence is probably synced; I am not implementing this part and calling this callback from the same thread A); - WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED in thread A; - WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE in thread A. So the receive_response() state RECEIVE_RESPONSE_SEND_INCOMPLETE is primarily needed to handle this case. -- v3: winhttp/tests: Test calling WinHttpReceiveResponse() recursively from various send callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1582

3 12

[PATCH 0/1] MR1760: opengl32: Avoid calling functions that have not been queried yet.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

The glMapBuffer and al. functions are all duplicated between EXT/ARB and core functions, and we reduced code duplication by redirecting the EXT to the core functions. The internal function table is only filled as the functions are queried, and it causes crahes when games are using the EXT functions without querying the core function first. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53990 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1760

2 1

[PATCH 0/8] MR1759: win32u: Move remaining focus.c functions from user32.
by Jacek Caban (＠jacek) 09 Dec '22

09 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1759

2 8

[PATCH v3 0/2] MR1321: Reject wic invalid formats
by Zhiyi Zhang (＠zhiyi) 09 Dec '22

09 Dec '22

These invalid formats are rejected when creating WIC render targets. Otherwise, Wine may create a WIC render target with an unsupported format and in turn, will make testing IsSupported() method difficult. -- v3: d2d1: Test creating WIC bitmap render targets. d2d1: Reject unsupported formats when creating WIC bitmap render targets. https://gitlab.winehq.org/wine/wine/-/merge_requests/1321

3 4

[PATCH v8 0/2] MR1046: MfMediaEngine invalid format handling.
by Bernhard Kölbl (＠besentv) 09 Dec '22

09 Dec '22

-- v8: mfmediaengine: Add a fallback when the set engine format cannot be used to init samplegrabber. mfmediaengine/tests: Test possible engine and output texture formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/1046

4 8

[PATCH 0/1] MR1758: comctl32: Switch back to internal allocation function.
by Nikolay Sivov (＠nsivov) 09 Dec '22

09 Dec '22

We are still using exported string functions internally, and that caused mismatches after recent incomplete switching to crt functions. There is also no evidence that crt functions are used at all there, so for now switch back to fix mismatching calls. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1758

2 1

[PATCH v2 0/1] MR1681: uxtheme: Avoid using lstrcmpiW.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

This is called a huge number of time every time the module is loaded. The function does a lot of things, which I believe aren't necessary for uxtheme string comparison. The impact on process startup is noticeable, and this saves ~1min on the Gitlab CI test run. Instead, convert strings to uppercase beforehand in a locale-independent way, and compare with wcscmp. -- v2: uxtheme: Use bsearch and CompareStringOrdinal in MSSTYLES_LookupProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/1681

3 3

[PATCH v3 0/1] MR1681: uxtheme: Avoid using lstrcmpiW.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

This is called a huge number of time every time the module is loaded. The function does a lot of things, which I believe aren't necessary for uxtheme string comparison. The impact on process startup is noticeable, and this saves ~1min on the Gitlab CI test run. Instead, convert strings to uppercase beforehand in a locale-independent way, and compare with wcscmp. -- v3: uxtheme: Use bsearch and CompareStringOrdinal in MSSTYLES_LookupProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/1681

2 2

[PATCH 0/5] MR1756: ntdll: Various performance improvements to hash_short_file_name.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

The function is called a lot, I believe something like this would improve its performance in general. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1756

2 5

[PATCH v5 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 09 Dec '22

09 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v5: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

4 12

[PATCH v4 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 09 Dec '22

09 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v4: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 9

[PATCH v3 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 09 Dec '22

09 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v3: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync. cryptowinrt: Import IAsyncOperation from windows.gaming.input. cryptowinrt: Stub IKeyCredentialManagerStatics interface. cryptowinrt: Add private.h file. cryptowinrt/tests: Add ICryptographicBufferStatics interface test. include: Add windows.security.credentials.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 13

[PATCH 0/1] MR1754: wsdapi: Annotate duplicate_(string|name) with __WINE_MALLOC.
by Alex Henrie (＠alexhenrie) 09 Dec '22

09 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1754

2 1

[PATCH 0/1] MR1753: wintrust: Annotate WINTRUST_Alloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 09 Dec '22

09 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1753

2 1

Re: [PATCH v13 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 09 Dec '22

09 Dec '22

Sorry for replying a bit late, I'm still working on this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1268#note_19265

1 0

[PATCH v2 0/2] MR1746: Draft: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Alex Henrie (＠alexhenrie) 09 Dec '22

09 Dec '22

-- v2: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them. setupapi: Handle NULL in string allocation functions and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1746

2 3

[PATCH v8 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 09 Dec '22

09 Dec '22

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v8: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. shell32: Fix error handling in SHBindToParent. shell32/tests: Test SHBindToParent last parameter behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 5

[PATCH v5 0/2] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc
by Brendan Shanks (＠bshanks) 09 Dec '22

09 Dec '22

-- v5: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _aligned_malloc functions. include/msvcrt: Add __WINE_(DEALLOC|MALLOC) attributes to _strdup and _wcsdup. https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

3 3

Re: [PATCH v3 0/4] MR1727: Enable long types in wined3d/texture.c - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1727

1 0

2025

2024

2023

2022

wine-gitlab