- wine-gitlab - winehq.org

[PATCH v31 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 24 Aug '24

24 Aug '24

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- v31: plugplay: Add support for DBT_DEVTYP_HANDLE device notifications. plugplay: Broadcast PnP events on a dedicated thread. plugplay: Separate deep-copying the received event into new_event. plugplay: Separate device broadcast event types into their own structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

2 4

[PATCH v2 0/1] MR6348: ntdll: Match the new ARM64 KiUserExceptionDispatcher stack layout.
by Billy Laws (＠bylaws) 24 Aug '24

24 Aug '24

This is used starting from around build 27686. -- v2: ntdll: Match the new ARM64 KiUserExceptionDispatcher stack layout. https://gitlab.winehq.org/wine/wine/-/merge_requests/6348

2 2

[PATCH v3 0/2] MR6225: Populate ARM64 ID register registry keys using the SMBIOS.
by Billy Laws (＠bylaws) 24 Aug '24

24 Aug '24

Takes advantage of linux's ID register emulation. The msr instruction is manually assembled to support older compilers and those that disallow reading e.g. SVE ID registers if unsupported by the target, even though they RAZ if unsupported. This defines a wine-specific SMBIOS table format ontop of the standard additional processor information block to pass ID registers to wineboot. The index of each table within the SMBIOS directly maps to the core it corresponds to and registers are passed using their numerical IDs to match Windows' registry format and avoid needing to map between names and IDs on both ends (the unix side needs to manually encode the msr's anyway). Question: would it be reasonable to add a wine/smbios.h header? I'm unsure if the duplication here is for a good reason. -- v3: wineboot: Populate ARM64 ID register registry keys using SMBIOS info. ntdll: Populate the SMBIOS with ARM64 ID register values. https://gitlab.winehq.org/wine/wine/-/merge_requests/6225

2 2

[PATCH 0/1] MR6348: ntdll: Match the new ARM64 KiUserExceptionDispatcher stack layout.
by Billy Laws (＠bylaws) 24 Aug '24

24 Aug '24

This is used starting from around build 27686. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6348

3 2

Re: [PATCH v6 0/1] MR6316: netapi32: Move some implementations to netutils. - approved
by Alexandre Julliard (＠julliard) 23 Aug '24

23 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6316

1 0

Re: [PATCH v5 0/1] MR6342: wscript: Implement Sleep - approved
by Alexandre Julliard (＠julliard) 23 Aug '24

23 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6342

1 0

Re: [PATCH v2 0/1] MR6345: kernel32: PowerCreateRequest return a valid handle - approved
by Alexandre Julliard (＠julliard) 23 Aug '24

23 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6345

1 0

Re: [PATCH v2 0/7] MR6344: user32: Introduce a generic KeUserDispatchCallback kernel callback. - approved
by Alexandre Julliard (＠julliard) 23 Aug '24

23 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6344

1 0

[PATCH v2 0/2] MR6225: Populate ARM64 ID register registry keys using the SMBIOS.
by Billy Laws (＠bylaws) 23 Aug '24

23 Aug '24

Takes advantage of linux's ID register emulation. The msr instruction is manually assembled to support older compilers and those that disallow reading e.g. SVE ID registers if unsupported by the target, even though they RAZ if unsupported. This defines a wine-specific SMBIOS table format ontop of the standard additional processor information block to pass ID registers to wineboot. The index of each table within the SMBIOS directly maps to the core it corresponds to and registers are passed using their numerical IDs to match Windows' registry format and avoid needing to map between names and IDs on both ends (the unix side needs to manually encode the msr's anyway). Question: would it be reasonable to add a wine/smbios.h header? I'm unsure if the duplication here is for a good reason. -- v2: wineboot: Populate ARM64 ID register registry keys using SMBIOS info. ntdll: Populate the SMBIOS with ARM64 ID register values. https://gitlab.winehq.org/wine/wine/-/merge_requests/6225

2 3

[PATCH v2 0/1] MR6347: advpack: DelNode support the ADN_DEL_IF_EMPTY flag
by Anders Kjersem (＠anders) 23 Aug '24

23 Aug '24

Fixes a bug where `rundll32.exe advpack.dll,DelNodeRunDLL32 "c:\test",1` is only supposed to delete "test" if the directory is empty. Also causes the [DelDirs Inf section](https://www.mdgx.com/INF_web/deldirs.htm) to work correctly. Notes: - I changed the code so it ignores the result of `SetFileAttributesW` because the user might not have FILE_WRITE_ATTRIBUTES even if they have DELETE rights. This seems to match Windows (XP NTFS). -- v2: advpack: DelNode support ADN_DEL_IF_EMPTY flag https://gitlab.winehq.org/wine/wine/-/merge_requests/6347

4 5

2025

2024

2023

2022

wine-gitlab